186369 2018-06-06 16:09:25 -0700 Add logging around internalError(const URL&) 2018-06-11 15:52:32 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin benjamin bfulgham cdumez cmarcelo commit-queue dbates ews-watchlist webkit-bug-importer oldest_to_newest 1430610 0 krollin 2018-06-06 16:09:25 -0700 There are times when we receive bug reports where the user says that they are simply shown a page saying an internal error occurred. To help understand the circumstances of that error, add some logging to internalError() in WebErrors.cpp. This logging logs at the Error level that internalError() was called and then logs a backtrace. 1430611 1 webkit-bug-importer 2018-06-06 16:09:48 -0700 <rdar://problem/40872046> 1430612 2 342090 krollin 2018-06-06 16:12:48 -0700 Created attachment 342090 Patch 1430623 3 342094 krollin 2018-06-06 16:46:25 -0700 Created attachment 342094 Fix build error 1432053 4 342094 bfulgham 2018-06-11 14:27:45 -0700 Comment on attachment 342094 Fix build error View in context: https://bugs.webkit.org/attachment.cgi?id=342094&action=review Looks good! I suggest the modern C++ loop. > Source/WTF/wtf/Assertions.cpp:556 > + for (int frameNumber = 1; frameNumber < stackTrace->size(); ++frameNumber) { Could this be a modern C++ loop? for (auto stackFrame : stackTrace->stack()) { ... 1432080 5 bfulgham 2018-06-11 15:25:40 -0700 (In reply to Brent Fulgham from comment #4) > Comment on attachment 342094 [details] > Fix build error > > View in context: > https://bugs.webkit.org/attachment.cgi?id=342094&action=review > > Looks good! I suggest the modern C++ loop. > > > Source/WTF/wtf/Assertions.cpp:556 > > + for (int frameNumber = 1; frameNumber < stackTrace->size(); ++frameNumber) { > > Could this be a modern C++ loop? > > for (auto stackFrame : stackTrace->stack()) { > ... I spoke with Keith in person, and realized that we need the index for logging. So never mind! 1432096 6 342094 commit-queue 2018-06-11 15:52:30 -0700 Comment on attachment 342094 Fix build error Clearing flags on attachment: 342094 Committed r232734: <https://trac.webkit.org/changeset/232734> 1432097 7 commit-queue 2018-06-11 15:52:32 -0700 All reviewed patches have been landed. Closing bug. 342090 2018-06-06 16:12:48 -0700 2018-06-06 16:46:24 -0700 Patch bug-186369-20180606161248.patch text/plain 5874 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDgxZDJjNTExMjVlNGViODkyOTAwZDcz OTBjMWNhM2NmMmJkODMzMTcuLmQ0MTc3NzVhZDEwZmJmZGUyY2ZmN2Y2NTExOGI3NTMzZjc0OGNm ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDYtMDYgIEtlaXRoIFJvbGxpbiAgPGtyb2xs aW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBsb2dnaW5nIGFyb3VuZCBpbnRlcm5hbEVycm9y KGNvbnN0IFVSTCYpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODYzNjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQwODcyMDQ2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSB0aW1lcyB3 aGVuIHdlIHJlY2VpdmUgYnVnIHJlcG9ydHMgd2hlcmUgdGhlIHVzZXIgc2F5cyB0aGF0CisgICAg ICAgIHRoZXkgYXJlIHNpbXBseSBzaG93biBhIHBhZ2Ugc2F5aW5nIGFuIGludGVybmFsIGVycm9y IG9jY3VycmVkLiBUbworICAgICAgICBoZWxwIHVuZGVyc3RhbmQgdGhlIGNpcmN1bXN0YW5jZXMg b2YgdGhhdCBlcnJvciwgYWRkIHNvbWUgbG9nZ2luZyB0bworICAgICAgICBpbnRlcm5hbEVycm9y KCkgaW4gV2ViRXJyb3JzLmNwcC4gVGhpcyBsb2dnaW5nIGxvZ3MgYXQgdGhlIEVycm9yIGxldmVs CisgICAgICAgIHRoYXQgaW50ZXJuYWxFcnJvcigpIHdhcyBjYWxsZWQgYW5kIHRoZW4gbG9ncyBh IGJhY2t0cmFjZS4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmNwcDoKKyAgICAgICAgKiB3 dGYvQXNzZXJ0aW9ucy5oOgorCiAyMDE4LTA1LTMxICBDb21taXQgUXVldWUgIDxjb21taXQtcXVl dWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjMyMjEy LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZwppbmRleCA3YTAxMWI4Mzc1MWNhZTY3YTVhNmIzNmUwYmYwZWE0NDM3Y2YxZDg1Li40 YTI5NmExMDNiNjY5OWIxZjU5ZDlhODkzOTQ5MGI3ZTQ1ZDU4YzM4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIwIEBACisyMDE4LTA2LTA2ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4K KworICAgICAgICBBZGQgbG9nZ2luZyBhcm91bmQgaW50ZXJuYWxFcnJvcihjb25zdCBVUkwmKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2MzY5Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDg3MjA0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBhcmUgdGltZXMgd2hlbiB3ZSByZWNlaXZl IGJ1ZyByZXBvcnRzIHdoZXJlIHRoZSB1c2VyIHNheXMgdGhhdAorICAgICAgICB0aGV5IGFyZSBz aW1wbHkgc2hvd24gYSBwYWdlIHNheWluZyBhbiBpbnRlcm5hbCBlcnJvciBvY2N1cnJlZC4gVG8K KyAgICAgICAgaGVscCB1bmRlcnN0YW5kIHRoZSBjaXJjdW1zdGFuY2VzIG9mIHRoYXQgZXJyb3Is IGFkZCBzb21lIGxvZ2dpbmcgdG8KKyAgICAgICAgaW50ZXJuYWxFcnJvcigpIGluIFdlYkVycm9y cy5jcHAuIFRoaXMgbG9nZ2luZyBsb2dzIGF0IHRoZSBFcnJvciBsZXZlbAorICAgICAgICB0aGF0 IGludGVybmFsRXJyb3IoKSB3YXMgY2FsbGVkIGFuZCB0aGVuIGxvZ3MgYSBiYWNrdHJhY2UuCisK KyAgICAgICAgKiBTaGFyZWQvV2ViRXJyb3JzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6aW50ZXJu YWxFcnJvcik6CisKIDIwMTgtMDYtMDQgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs ZS5jb20+CiAKICAgICAgICAgW1dlYktpdCBvbiB3YXRjaE9TXSBSZW1vdmUgYWxsIHVzZXMgb2Yg dGhlIEVYVFJBX1pPT01fTU9ERSBjb21waWxlciBmbGFnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L3d0Zi9Bc3NlcnRpb25zLmNwcCBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3BwCmluZGV4 IDY1NzNhMjA5YmMwYWYxMmMwMjA5YTI3ODUwZTEwMGUyNDI3MDk0NTguLjk1MjhiZjQ1NjViMWYz ZmFhM2U3OWY1ZWVmMzI0NDZlOGJhY2E3YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Fz c2VydGlvbnMuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3BwCkBAIC01NDcs NiArNTQ3LDI0IEBAIHZvaWQgV1RGSW5pdGlhbGl6ZUxvZ0NoYW5uZWxTdGF0ZXNGcm9tU3RyaW5n KFdURkxvZ0NoYW5uZWwqIGNoYW5uZWxzW10sIHNpemVfdCBjCiAgICAgfQogfQogCit2b2lkIFdU RlJlbGVhc2VMb2dTdGFja1RyYWNlKFdURkxvZ0NoYW5uZWwqIGNoYW5uZWwpCit7CisgICAgYXV0 byBzdGFja1RyYWNlID0gV1RGOjpTdGFja1RyYWNlOjpjYXB0dXJlU3RhY2tUcmFjZSgzMCwgMCk7 CisgICAgaWYgKHN0YWNrVHJhY2UgJiYgc3RhY2tUcmFjZS0+c3RhY2soKSkgeworICAgICAgICBh dXRvIHN0YWNrID0gc3RhY2tUcmFjZS0+c3RhY2soKTsKKyAgICAgICAgZm9yIChpbnQgZnJhbWVO dW1iZXIgPSAxOyBmcmFtZU51bWJlciA8IHN0YWNrVHJhY2UtPnNpemUoKTsgKytmcmFtZU51bWJl cikgeworICAgICAgICAgICAgYXV0byBzdGFja0ZyYW1lID0gc3RhY2tbZnJhbWVOdW1iZXJdOwor ICAgICAgICAgICAgYXV0byBkZW1hbmdsZWQgPSBXVEY6OlN0YWNrVHJhY2U6OmRlbWFuZ2xlKHN0 YWNrRnJhbWUpOworICAgICAgICAgICAgaWYgKGRlbWFuZ2xlZCAmJiBkZW1hbmdsZWQtPmRlbWFu Z2xlZE5hbWUoKSkKKyAgICAgICAgICAgICAgICBvc19sb2coY2hhbm5lbC0+b3NMb2dDaGFubmVs LCAiJS0zZCAlcCAle3B1YmxpY31zIiwgZnJhbWVOdW1iZXIsIHN0YWNrRnJhbWUsIGRlbWFuZ2xl ZC0+ZGVtYW5nbGVkTmFtZSgpKTsKKyAgICAgICAgICAgIGVsc2UgaWYgKGRlbWFuZ2xlZCAmJiBk ZW1hbmdsZWQtPm1hbmdsZWROYW1lKCkpCisgICAgICAgICAgICAgICAgb3NfbG9nKGNoYW5uZWwt Pm9zTG9nQ2hhbm5lbCwgIiUtM2QgJXAgJXtwdWJsaWN9cyIsIGZyYW1lTnVtYmVyLCBzdGFja0Zy YW1lLCBkZW1hbmdsZWQtPm1hbmdsZWROYW1lKCkpOworICAgICAgICAgICAgZWxzZQorICAgICAg ICAgICAgICAgIG9zX2xvZyhjaGFubmVsLT5vc0xvZ0NoYW5uZWwsICIlLTNkICVwIiwgZnJhbWVO dW1iZXIsIHN0YWNrRnJhbWUpOworICAgICAgICB9CisgICAgfQorfQorCiB9IC8vIGV4dGVybiAi QyIKIAogI2lmIE9TKERBUldJTikgJiYgKENQVShYODZfNjQpIHx8IENQVShBUk02NCkpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmggYi9Tb3VyY2UvV1RGL3d0Zi9Bc3Nl cnRpb25zLmgKaW5kZXggNzMxYTRlMWQ5YjFiMGQxNDI5N2I5OWU0OTdlNTllZjAwNTlhZjhhNS4u NzAwNTRiMWE5M2FmOGE5OWU2ODAyNTMyZGY5ZmIxMzBlNDdlZjVjNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMu aApAQCAtMjAwLDYgKzIwMCw3IEBAIFdURl9FWFBPUlRfUFJJVkFURSBib29sIFdURldpbGxMb2dX aXRoTGV2ZWwoV1RGTG9nQ2hhbm5lbCosIFdURkxvZ0xldmVsKTsKIFdURl9FWFBPUlRfUFJJVkFU RSB2b2lkIFdURkdldEJhY2t0cmFjZSh2b2lkKiogc3RhY2ssIGludCogc2l6ZSk7CiBXVEZfRVhQ T1JUX1BSSVZBVEUgdm9pZCBXVEZSZXBvcnRCYWNrdHJhY2Uodm9pZCk7CiBXVEZfRVhQT1JUX1BS SVZBVEUgdm9pZCBXVEZQcmludEJhY2t0cmFjZSh2b2lkKiogc3RhY2ssIGludCBzaXplKTsKK1dU Rl9FWFBPUlRfUFJJVkFURSB2b2lkIFdURlJlbGVhc2VMb2dTdGFja1RyYWNlKFdURkxvZ0NoYW5u ZWwqKTsKIAogV1RGX0VYUE9SVF9QUklWQVRFIGJvb2wgV1RGSXNEZWJ1Z2dlckF0dGFjaGVkKHZv aWQpOwogCkBAIC00NTksNiArNDYwLDggQEAgV1RGX0VYUE9SVF9QUklWQVRFIE5PX1JFVFVSTl9E VUVfVE9fQ1JBU0ggdm9pZCBXVEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0aW9uKHYKIAogI2Rl ZmluZSBSRUxFQVNFX0xPR19XSVRIX0xFVkVMKGNoYW5uZWwsIGxldmVsLCAuLi4pICgodm9pZCkw KQogI2RlZmluZSBSRUxFQVNFX0xPR19XSVRIX0xFVkVMX0lGKGlzQWxsb3dlZCwgY2hhbm5lbCwg bGV2ZWwsIC4uLikgZG8geyBpZiAoaXNBbGxvd2VkKSBSRUxFQVNFX0xPR19XSVRIX0xFVkVMKGNo YW5uZWwsIGxldmVsLCBfX1ZBX0FSR1NfXyk7IH0gd2hpbGUgKDApCisKKyNkZWZpbmUgUkVMRUFT RV9MT0dfU1RBQ0tUUkFDRShjaGFubmVsKSAoKHZvaWQpMCkKICNlbHNlCiAjZGVmaW5lIFJFTEVB U0VfTE9HKGNoYW5uZWwsIC4uLikgb3NfbG9nKExPR19DSEFOTkVMKGNoYW5uZWwpLm9zTG9nQ2hh bm5lbCwgX19WQV9BUkdTX18pCiAjZGVmaW5lIFJFTEVBU0VfTE9HX0VSUk9SKGNoYW5uZWwsIC4u Likgb3NfbG9nX2Vycm9yKExPR19DSEFOTkVMKGNoYW5uZWwpLm9zTG9nQ2hhbm5lbCwgX19WQV9B UkdTX18pCkBAIC00NzgsNiArNDgxLDggQEAgV1RGX0VYUE9SVF9QUklWQVRFIE5PX1JFVFVSTl9E VUVfVE9fQ1JBU0ggdm9pZCBXVEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0aW9uKHYKICAgICBp ZiAoKGlzQWxsb3dlZCkgJiYgTE9HX0NIQU5ORUwoY2hhbm5lbCkubGV2ZWwgPj0gKGxvZ0xldmVs KSkgXAogICAgICAgICBvc19sb2coTE9HX0NIQU5ORUwoY2hhbm5lbCkub3NMb2dDaGFubmVsLCBf X1ZBX0FSR1NfXyk7IFwKIH0gd2hpbGUgKDApCisKKyNkZWZpbmUgUkVMRUFTRV9MT0dfU1RBQ0tU UkFDRShjaGFubmVsKSBXVEZSZWxlYXNlTG9nU3RhY2tUcmFjZSgmTE9HX0NIQU5ORUwoY2hhbm5l bCkpCiAjZW5kaWYKIAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJFcnJv cnMuY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViRXJyb3JzLmNwcAppbmRleCBlMjJmM2Jk NTBlMDY0YzI4MjZmNWVmODRlMWI5NzllM2E1MTg3YWY1Li44ZjE1Y2QzMGM1YzU2OWIyOTdkMTBm ZmQ0OGM3MmRjY2E4NzkxYmRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJF cnJvcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYkVycm9ycy5jcHAKQEAgLTI5 LDYgKzI5LDcgQEAKICNpbmNsdWRlICJXZWJFcnJvcnMuaCIKIAogI2luY2x1ZGUgIkFQSUVycm9y LmgiCisjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgPFdlYkNvcmUvTG9jYWxpemVkU3Ry aW5ncy5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VSZXF1ZXN0Lmg+CiAjaW5jbHVkZSA8 V2ViQ29yZS9SZXNvdXJjZVJlc3BvbnNlLmg+CkBAIC03NSw2ICs3Niw5IEBAIFJlc291cmNlRXJy b3IgcGx1Z2luV2lsbEhhbmRsZUxvYWRFcnJvcihjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNw b25zZSkKIAogUmVzb3VyY2VFcnJvciBpbnRlcm5hbEVycm9yKGNvbnN0IFVSTCYgdXJsKQogewor ICAgIFJFTEVBU0VfTE9HX0VSUk9SKExvYWRpbmcsICJJbnRlcm5hbCBlcnJvciBjYWxsZWQiKTsK KyAgICBSRUxFQVNFX0xPR19TVEFDS1RSQUNFKExvYWRpbmcpOworCiAgICAgcmV0dXJuIFJlc291 cmNlRXJyb3IoQVBJOjpFcnJvcjo6d2ViS2l0RXJyb3JEb21haW4oKSwgQVBJOjpFcnJvcjo6R2Vu ZXJhbDo6SW50ZXJuYWwsIHVybCwgV0VCX1VJX1NUUklORygiV2ViS2l0IGVuY291bnRlcmVkIGFu IGludGVybmFsIGVycm9yIiwgIldlYktpdEVycm9ySW50ZXJuYWwgZGVzY3JpcHRpb24iKSk7CiB9 CiAK 342094 2018-06-06 16:46:25 -0700 2018-06-11 15:52:30 -0700 Fix build error bug-186369-20180606164624.patch text/plain 5944 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDgxZDJjNTExMjVlNGViODkyOTAwZDcz OTBjMWNhM2NmMmJkODMzMTcuLmQ0MTc3NzVhZDEwZmJmZGUyY2ZmN2Y2NTExOGI3NTMzZjc0OGNm ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDYtMDYgIEtlaXRoIFJvbGxpbiAgPGtyb2xs aW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBsb2dnaW5nIGFyb3VuZCBpbnRlcm5hbEVycm9y KGNvbnN0IFVSTCYpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODYzNjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQwODcyMDQ2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSB0aW1lcyB3 aGVuIHdlIHJlY2VpdmUgYnVnIHJlcG9ydHMgd2hlcmUgdGhlIHVzZXIgc2F5cyB0aGF0CisgICAg ICAgIHRoZXkgYXJlIHNpbXBseSBzaG93biBhIHBhZ2Ugc2F5aW5nIGFuIGludGVybmFsIGVycm9y IG9jY3VycmVkLiBUbworICAgICAgICBoZWxwIHVuZGVyc3RhbmQgdGhlIGNpcmN1bXN0YW5jZXMg b2YgdGhhdCBlcnJvciwgYWRkIHNvbWUgbG9nZ2luZyB0bworICAgICAgICBpbnRlcm5hbEVycm9y KCkgaW4gV2ViRXJyb3JzLmNwcC4gVGhpcyBsb2dnaW5nIGxvZ3MgYXQgdGhlIEVycm9yIGxldmVs CisgICAgICAgIHRoYXQgaW50ZXJuYWxFcnJvcigpIHdhcyBjYWxsZWQgYW5kIHRoZW4gbG9ncyBh IGJhY2t0cmFjZS4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmNwcDoKKyAgICAgICAgKiB3 dGYvQXNzZXJ0aW9ucy5oOgorCiAyMDE4LTA1LTMxICBDb21taXQgUXVldWUgIDxjb21taXQtcXVl dWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjMyMjEy LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZwppbmRleCA3YTAxMWI4Mzc1MWNhZTY3YTVhNmIzNmUwYmYwZWE0NDM3Y2YxZDg1Li40 YTI5NmExMDNiNjY5OWIxZjU5ZDlhODkzOTQ5MGI3ZTQ1ZDU4YzM4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwz ICsxLDIwIEBACisyMDE4LTA2LTA2ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4K KworICAgICAgICBBZGQgbG9nZ2luZyBhcm91bmQgaW50ZXJuYWxFcnJvcihjb25zdCBVUkwmKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2MzY5Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDg3MjA0Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBhcmUgdGltZXMgd2hlbiB3ZSByZWNlaXZl IGJ1ZyByZXBvcnRzIHdoZXJlIHRoZSB1c2VyIHNheXMgdGhhdAorICAgICAgICB0aGV5IGFyZSBz aW1wbHkgc2hvd24gYSBwYWdlIHNheWluZyBhbiBpbnRlcm5hbCBlcnJvciBvY2N1cnJlZC4gVG8K KyAgICAgICAgaGVscCB1bmRlcnN0YW5kIHRoZSBjaXJjdW1zdGFuY2VzIG9mIHRoYXQgZXJyb3Is IGFkZCBzb21lIGxvZ2dpbmcgdG8KKyAgICAgICAgaW50ZXJuYWxFcnJvcigpIGluIFdlYkVycm9y cy5jcHAuIFRoaXMgbG9nZ2luZyBsb2dzIGF0IHRoZSBFcnJvciBsZXZlbAorICAgICAgICB0aGF0 IGludGVybmFsRXJyb3IoKSB3YXMgY2FsbGVkIGFuZCB0aGVuIGxvZ3MgYSBiYWNrdHJhY2UuCisK KyAgICAgICAgKiBTaGFyZWQvV2ViRXJyb3JzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6aW50ZXJu YWxFcnJvcik6CisKIDIwMTgtMDYtMDQgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs ZS5jb20+CiAKICAgICAgICAgW1dlYktpdCBvbiB3YXRjaE9TXSBSZW1vdmUgYWxsIHVzZXMgb2Yg dGhlIEVYVFJBX1pPT01fTU9ERSBjb21waWxlciBmbGFnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L3d0Zi9Bc3NlcnRpb25zLmNwcCBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3BwCmluZGV4 IDY1NzNhMjA5YmMwYWYxMmMwMjA5YTI3ODUwZTEwMGUyNDI3MDk0NTguLjEzYjcwOTMxNTBlZTY1 NTFlNDZkZWRhN2FlMjY1ZmVlZDcwMGQzOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Fz c2VydGlvbnMuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3BwCkBAIC01NDcs NiArNTQ3LDI2IEBAIHZvaWQgV1RGSW5pdGlhbGl6ZUxvZ0NoYW5uZWxTdGF0ZXNGcm9tU3RyaW5n KFdURkxvZ0NoYW5uZWwqIGNoYW5uZWxzW10sIHNpemVfdCBjCiAgICAgfQogfQogCisjaWYgIVJF TEVBU0VfTE9HX0RJU0FCTEVECit2b2lkIFdURlJlbGVhc2VMb2dTdGFja1RyYWNlKFdURkxvZ0No YW5uZWwqIGNoYW5uZWwpCit7CisgICAgYXV0byBzdGFja1RyYWNlID0gV1RGOjpTdGFja1RyYWNl OjpjYXB0dXJlU3RhY2tUcmFjZSgzMCwgMCk7CisgICAgaWYgKHN0YWNrVHJhY2UgJiYgc3RhY2tU cmFjZS0+c3RhY2soKSkgeworICAgICAgICBhdXRvIHN0YWNrID0gc3RhY2tUcmFjZS0+c3RhY2so KTsKKyAgICAgICAgZm9yIChpbnQgZnJhbWVOdW1iZXIgPSAxOyBmcmFtZU51bWJlciA8IHN0YWNr VHJhY2UtPnNpemUoKTsgKytmcmFtZU51bWJlcikgeworICAgICAgICAgICAgYXV0byBzdGFja0Zy YW1lID0gc3RhY2tbZnJhbWVOdW1iZXJdOworICAgICAgICAgICAgYXV0byBkZW1hbmdsZWQgPSBX VEY6OlN0YWNrVHJhY2U6OmRlbWFuZ2xlKHN0YWNrRnJhbWUpOworICAgICAgICAgICAgaWYgKGRl bWFuZ2xlZCAmJiBkZW1hbmdsZWQtPmRlbWFuZ2xlZE5hbWUoKSkKKyAgICAgICAgICAgICAgICBv c19sb2coY2hhbm5lbC0+b3NMb2dDaGFubmVsLCAiJS0zZCAlcCAle3B1YmxpY31zIiwgZnJhbWVO dW1iZXIsIHN0YWNrRnJhbWUsIGRlbWFuZ2xlZC0+ZGVtYW5nbGVkTmFtZSgpKTsKKyAgICAgICAg ICAgIGVsc2UgaWYgKGRlbWFuZ2xlZCAmJiBkZW1hbmdsZWQtPm1hbmdsZWROYW1lKCkpCisgICAg ICAgICAgICAgICAgb3NfbG9nKGNoYW5uZWwtPm9zTG9nQ2hhbm5lbCwgIiUtM2QgJXAgJXtwdWJs aWN9cyIsIGZyYW1lTnVtYmVyLCBzdGFja0ZyYW1lLCBkZW1hbmdsZWQtPm1hbmdsZWROYW1lKCkp OworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIG9zX2xvZyhjaGFubmVsLT5vc0xv Z0NoYW5uZWwsICIlLTNkICVwIiwgZnJhbWVOdW1iZXIsIHN0YWNrRnJhbWUpOworICAgICAgICB9 CisgICAgfQorfQorI2VuZGlmCisKIH0gLy8gZXh0ZXJuICJDIgogCiAjaWYgT1MoREFSV0lOKSAm JiAoQ1BVKFg4Nl82NCkgfHwgQ1BVKEFSTTY0KSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3Rm L0Fzc2VydGlvbnMuaCBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAppbmRleCA3MzFhNGUx ZDliMWIwZDE0Mjk3Yjk5ZTQ5N2U1OWVmMDA1OWFmOGE1Li41ZTA2ZWFhNmU2MTk5YTIyOTE4MTM2 OGUwZTcwZWNhYTdkYmQ0ZjU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25z LmgKKysrIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCkBAIC0yMDAsNiArMjAwLDkgQEAg V1RGX0VYUE9SVF9QUklWQVRFIGJvb2wgV1RGV2lsbExvZ1dpdGhMZXZlbChXVEZMb2dDaGFubmVs KiwgV1RGTG9nTGV2ZWwpOwogV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGR2V0QmFja3RyYWNl KHZvaWQqKiBzdGFjaywgaW50KiBzaXplKTsKIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIFdURlJl cG9ydEJhY2t0cmFjZSh2b2lkKTsKIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIFdURlByaW50QmFj a3RyYWNlKHZvaWQqKiBzdGFjaywgaW50IHNpemUpOworI2lmICFSRUxFQVNFX0xPR19ESVNBQkxF RAorV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGUmVsZWFzZUxvZ1N0YWNrVHJhY2UoV1RGTG9n Q2hhbm5lbCopOworI2VuZGlmCiAKIFdURl9FWFBPUlRfUFJJVkFURSBib29sIFdURklzRGVidWdn ZXJBdHRhY2hlZCh2b2lkKTsKIApAQCAtNDU5LDYgKzQ2Miw4IEBAIFdURl9FWFBPUlRfUFJJVkFU RSBOT19SRVRVUk5fRFVFX1RPX0NSQVNIIHZvaWQgV1RGQ3Jhc2hXaXRoU2VjdXJpdHlJbXBsaWNh dGlvbih2CiAKICNkZWZpbmUgUkVMRUFTRV9MT0dfV0lUSF9MRVZFTChjaGFubmVsLCBsZXZlbCwg Li4uKSAoKHZvaWQpMCkKICNkZWZpbmUgUkVMRUFTRV9MT0dfV0lUSF9MRVZFTF9JRihpc0FsbG93 ZWQsIGNoYW5uZWwsIGxldmVsLCAuLi4pIGRvIHsgaWYgKGlzQWxsb3dlZCkgUkVMRUFTRV9MT0df V0lUSF9MRVZFTChjaGFubmVsLCBsZXZlbCwgX19WQV9BUkdTX18pOyB9IHdoaWxlICgwKQorCisj ZGVmaW5lIFJFTEVBU0VfTE9HX1NUQUNLVFJBQ0UoY2hhbm5lbCkgKCh2b2lkKTApCiAjZWxzZQog I2RlZmluZSBSRUxFQVNFX0xPRyhjaGFubmVsLCAuLi4pIG9zX2xvZyhMT0dfQ0hBTk5FTChjaGFu bmVsKS5vc0xvZ0NoYW5uZWwsIF9fVkFfQVJHU19fKQogI2RlZmluZSBSRUxFQVNFX0xPR19FUlJP UihjaGFubmVsLCAuLi4pIG9zX2xvZ19lcnJvcihMT0dfQ0hBTk5FTChjaGFubmVsKS5vc0xvZ0No YW5uZWwsIF9fVkFfQVJHU19fKQpAQCAtNDc4LDYgKzQ4Myw4IEBAIFdURl9FWFBPUlRfUFJJVkFU RSBOT19SRVRVUk5fRFVFX1RPX0NSQVNIIHZvaWQgV1RGQ3Jhc2hXaXRoU2VjdXJpdHlJbXBsaWNh dGlvbih2CiAgICAgaWYgKChpc0FsbG93ZWQpICYmIExPR19DSEFOTkVMKGNoYW5uZWwpLmxldmVs ID49IChsb2dMZXZlbCkpIFwKICAgICAgICAgb3NfbG9nKExPR19DSEFOTkVMKGNoYW5uZWwpLm9z TG9nQ2hhbm5lbCwgX19WQV9BUkdTX18pOyBcCiB9IHdoaWxlICgwKQorCisjZGVmaW5lIFJFTEVB U0VfTE9HX1NUQUNLVFJBQ0UoY2hhbm5lbCkgV1RGUmVsZWFzZUxvZ1N0YWNrVHJhY2UoJkxPR19D SEFOTkVMKGNoYW5uZWwpKQogI2VuZGlmCiAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9T aGFyZWQvV2ViRXJyb3JzLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYkVycm9ycy5jcHAK aW5kZXggZTIyZjNiZDUwZTA2NGMyODI2ZjVlZjg0ZTFiOTc5ZTNhNTE4N2FmNS4uOGYxNWNkMzBj NWM1NjliMjk3ZDEwZmZkNDhjNzJkY2NhODc5MWJkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9TaGFyZWQvV2ViRXJyb3JzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJFcnJv cnMuY3BwCkBAIC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAiV2ViRXJyb3JzLmgiCiAKICNpbmNs dWRlICJBUElFcnJvci5oIgorI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRlIDxXZWJDb3Jl L0xvY2FsaXplZFN0cmluZ3MuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlUmVxdWVzdC5o PgogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VSZXNwb25zZS5oPgpAQCAtNzUsNiArNzYsOSBA QCBSZXNvdXJjZUVycm9yIHBsdWdpbldpbGxIYW5kbGVMb2FkRXJyb3IoY29uc3QgUmVzb3VyY2VS ZXNwb25zZSYgcmVzcG9uc2UpCiAKIFJlc291cmNlRXJyb3IgaW50ZXJuYWxFcnJvcihjb25zdCBV UkwmIHVybCkKIHsKKyAgICBSRUxFQVNFX0xPR19FUlJPUihMb2FkaW5nLCAiSW50ZXJuYWwgZXJy b3IgY2FsbGVkIik7CisgICAgUkVMRUFTRV9MT0dfU1RBQ0tUUkFDRShMb2FkaW5nKTsKKwogICAg IHJldHVybiBSZXNvdXJjZUVycm9yKEFQSTo6RXJyb3I6OndlYktpdEVycm9yRG9tYWluKCksIEFQ STo6RXJyb3I6OkdlbmVyYWw6OkludGVybmFsLCB1cmwsIFdFQl9VSV9TVFJJTkcoIldlYktpdCBl bmNvdW50ZXJlZCBhbiBpbnRlcm5hbCBlcnJvciIsICJXZWJLaXRFcnJvckludGVybmFsIGRlc2Ny aXB0aW9uIikpOwogfQogCg==