186367 2018-06-06 15:51:34 -0700 Display links are sometimes not notifying WebCore when fired. 2018-06-06 17:37:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue jer.noble simon.fraser webkit-bug-importer oldest_to_newest 1430605 0 pvollan 2018-06-06 15:51:34 -0700 This can lead to display links not being destroyed, causing performance problems. 1430617 1 pvollan 2018-06-06 16:26:59 -0700 <rdar://problem/40439109> 1430618 2 342092 pvollan 2018-06-06 16:27:39 -0700 Created attachment 342092 Patch 1430626 3 342092 bfulgham 2018-06-06 16:46:57 -0700 Comment on attachment 342092 Patch This looks reasonable. It makes sense to only fire the display link for active monitors. 1430636 4 342092 pvollan 2018-06-06 17:10:24 -0700 Comment on attachment 342092 Patch Thanks for reviewing! 1430643 5 342092 commit-queue 2018-06-06 17:37:53 -0700 Comment on attachment 342092 Patch Clearing flags on attachment: 342092 Committed r232563: <https://trac.webkit.org/changeset/232563> 1430644 6 commit-queue 2018-06-06 17:37:54 -0700 All reviewed patches have been landed. Closing bug. 342092 2018-06-06 16:27:39 -0700 2018-06-06 17:37:53 -0700 Patch bug-186367-20180606162738.patch text/plain 2356 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjU0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE4LTA2LTA2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBEaXNwbGF5IGxpbmtzIGFy ZSBzb21ldGltZXMgbm90IG5vdGlmeWluZyBXZWJDb3JlIHdoZW4gZmlyZWQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODYzNjcKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzQwNDM5MTA5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdoZW4gdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyBpcyByZWNlaXZpbmcg YW4gSVBDIG1lc3NhZ2Ugbm90aWZ5aW5nIGFib3V0IGEgc2NyZWVuIHVwZGF0ZSwgYWxsIGRpc3Bs YXkgcmVmcmVzaCBtb25pdG9ycworICAgICAgICBhcmUgbm90aWZpZWQgYnkgdGhlIG1hbmFnZXIg aW4gRGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlcjo6ZGlzcGxheVdhc1VwZGF0ZWQoKS4gVGhl IG1hbmFnZXIgY2hlY2tzIHRoYXQgdGhlIG1vbml0b3IKKyAgICAgICAgaXMgc2NoZWR1bGVkIGJl Zm9yZSBub3RpZnlpbmcuIFRoaXMgaXMgYSBwcm9ibGVtLCBzaW5jZSB0aGUgc2NoZWR1bGVkIGZs YWcgaXMgYWx3YXlzIHNldCB0byBmYWxzZSBpbiB0aGUKKyAgICAgICAgRGlzcGxheVJlZnJlc2hN b25pdG9yOjpkaXNwbGF5RGlkUmVmcmVzaCgpIG1ldGhvZCwgd2hlbiB0aGUgbW9uaXRvciBpcyBm aXJzdCBub3RpZmllZCBhYm91dCBhIHNjcmVlbiB1cGRhdGUuIFRoaXMgY2FuCisgICAgICAgIGxl YWQgdG8gZGlzcGxheSBsaW5rcyBydW5uaW5nIHdpdGhvdXQgbm90aWZ5aW5nIHRoZSBtb25pdG9y cywgY2F1c2luZyBleHRyYSBDUFUgdXNhZ2UuIEl0IGNhbiBhbHNvIHByZXZlbnQgdGhlbSBmcm9t CisgICAgICAgIGJlaW5nIGRlbGV0ZWQsIHNpbmNlIHRoZSBtb25pdG9ycyBhcmUgbm90IG5vdGlm aWVkLiBJbnN0ZWFkLCB3ZSBjYW4gY2hlY2sgdGhhdCB0aGUgZGlzcGxheSByZWZyZXNoIG1vbml0 b3IgaXMgYWN0aXZlCisgICAgICAgIGJlZm9yZSBub3RpZnlpbmcgaXQuIFRoaXMgbWF0Y2hlcyB0 aGUgb3JpZ2luYWwgZGlzcGxheSBsaW5rIGltcGxlbWVudGF0aW9uIHVzZWQgd2hlbiB0aGUgV2Vi Q29udGVudCBwcm9jZXNzIGhhcworICAgICAgICBXaW5kb3dTZXJ2ZXIgYWNjZXNzLCB3aGVyZSB0 aGUgbW9uaXRvcnMgYXJlIGFsd2F5cyBub3RpZmllZC4KKworICAgICAgICBObyBuZXcgdGVzdHMs IHNpbmNlIEkgaGF2ZSBub3QgYmVlbiBhYmxlIHRvIHJlcHJvZHVjZSB0aGlzIGluIGEgdGVzdCBj YXNlIHlldC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9u aXRvck1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheVJlZnJlc2hNb25pdG9y TWFuYWdlcjo6ZGlzcGxheVdhc1VwZGF0ZWQpOgorCiAyMDE4LTA2LTA2ICBKZXIgTm9ibGUgIDxq ZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZ2lvbnMgb3V0c2lkZSBvZiB0aGUgZnVs bHNjcmVlbiB3aW5kb3cgYXJlIGV4cG9zZWQgZHVyaW5nIHpvb20gb3BlcmF0aW9ucwpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9yTWFu YWdlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv RGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlci5jcHAJKHJldmlzaW9uIDIzMjU0MykKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFn ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjgsNyArMTI4LDcgQEAgdm9pZCBEaXNwbGF5UmVm cmVzaE1vbml0b3JNYW5hZ2VyOjp3aW5kbwogdm9pZCBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5h Z2VyOjpkaXNwbGF5V2FzVXBkYXRlZCgpCiB7CiAgICAgZm9yIChhdXRvIG1vbml0b3IgOiBtX21v bml0b3JzKSB7Ci0gICAgICAgIGlmIChtb25pdG9yLT5pc1NjaGVkdWxlZCgpKQorICAgICAgICBp ZiAobW9uaXRvci0+aXNBY3RpdmUoKSkKICAgICAgICAgICAgIG1vbml0b3ItPmRpc3BsYXlMaW5r RmlyZWQoKTsKICAgICB9CiB9Cg==