186351 2018-06-06 09:19:35 -0700 ArityFixup should adjust SP first on 32-bit platforms too 2018-06-06 19:44:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 guijemont webkit-unassigned commit-queue ews-watchlist guijemont keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1430462 0 guijemont 2018-06-06 09:19:35 -0700 We see the same problem as in bug 167239 on linux x86 (32-bits). The same solution (adjusting sp first) seems to fix it. 1430468 1 342052 guijemont 2018-06-06 09:27:02 -0700 Created attachment 342052 Patch The patch. Seems to fix the issue in my tests. I also added the untag/tag calls though I'm not entirely sure how they work or if we want them on 32-bit too. 1430671 2 342052 ysuzuki 2018-06-06 19:16:53 -0700 Comment on attachment 342052 Patch r=me 1430678 3 342052 commit-queue 2018-06-06 19:43:36 -0700 Comment on attachment 342052 Patch Clearing flags on attachment: 342052 Committed r232568: <https://trac.webkit.org/changeset/232568> 1430679 4 commit-queue 2018-06-06 19:43:37 -0700 All reviewed patches have been landed. Closing bug. 1430680 5 webkit-bug-importer 2018-06-06 19:44:19 -0700 <rdar://problem/40878480> 342052 2018-06-06 09:27:02 -0700 2018-06-06 19:43:36 -0700 Patch bug-186351-20180606182701.patch text/plain 3399 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NjE0ODY4ZmUzNWQwYTQ1ODFkZGUzNTI5MWM4ZDdhNDkzNGM4MDQ0Li4yZTY4ZDQ3Y2VlZDBhZDA2 YTBmMTE5YzRjZGEyYjc3MDRlMjQ2ZDgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0wNi0wNiAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgQXJpdHlGaXh1cCBzaG91bGQgYWRqdXN0IFNQIGZpcnN0IG9uIDMy LWJpdCBwbGF0Zm9ybXMgdG9vCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODYzNTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGppdC9UaHVua0dlbmVyYXRvcnMuY3BwOgorICAgICAgICAoSlNDOjphcml0 eUZpeHVwR2VuZXJhdG9yKToKKwogMjAxOC0wNi0wNSAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFt QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGp1c3QgY29tcGlsZSBhbmQgcnVudGltZSBmbGFncyB0 byBtYXRjaCBzaGlwcGFibGUgc3RhdGUgb2YgZmVhdHVyZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcAppbmRleCBlZTM1YTAyY2Y4NThkOGUwY2M2ODlm NzM3ZDdiZGQ1YmRjNzA4MDg3Li5kZDVkODMwNTFlYzU3ODBhYjBiNjE4NmFjY2EwZGEzMDk2MTkx ZDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9y cy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3Bw CkBAIC01MDAsNyArNTAwLDcgQEAgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmPEpJVFRodW5rUHRyVGFn PiBhcml0eUZpeHVwR2VuZXJhdG9yKFZNKiB2bSkKIAogICAgIC8vIEFkanVzdCBjYWxsIGZyYW1l IHJlZ2lzdGVyIGFuZCBzdGFjayBwb2ludGVyIHRvIGFjY291bnQgZm9yIG1pc3NpbmcgYXJncy4K ICAgICAvLyBXZSBuZWVkIHRvIGNoYW5nZSB0aGUgc3RhY2sgcG9pbnRlciBmaXJzdCBiZWZvcmUg cGVyZm9ybWluZyBjb3B5L2ZpbGwgbG9vcHMuCi0gICAgLy8gVGhpcyBzdGFjayBzcGFjZSBiZWxv dyB0aGUgc3RhY2sgcG9pbnRlciBpcyBjb25zaWRlcmVkIHVuc2VkIGJ5IE9TLiBUaGVyZWZvcmUs CisgICAgLy8gVGhpcyBzdGFjayBzcGFjZSBiZWxvdyB0aGUgc3RhY2sgcG9pbnRlciBpcyBjb25z aWRlcmVkIHVudXNlZCBieSBPUy4gVGhlcmVmb3JlLAogICAgIC8vIE9TIG1heSBjb3JydXB0IHRo aXMgc3BhY2Ugd2hlbiBjb25zdHJ1Y3RpbmcgYSBzaWduYWwgc3RhY2suCiAgICAgaml0Lm1vdmUo SlNJbnRlcmZhY2VKSVQ6OmFyZ3VtZW50R1BSMCwgZXh0cmFUZW1wKTsKICAgICBqaXQubHNoaWZ0 NjQoSlNJbnRlcmZhY2VKSVQ6OlRydXN0ZWRJbW0zMigzKSwgZXh0cmFUZW1wKTsKQEAgLTU2NCw2 ICs1NjQsMTcgQEAgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmPEpJVFRodW5rUHRyVGFnPiBhcml0eUZp eHVwR2VuZXJhdG9yKFZNKiB2bSkKIAogICAgIGppdC5uZWczMihKU0ludGVyZmFjZUpJVDo6YXJn dW1lbnRHUFIwKTsKIAorICAgIC8vIEFkanVzdCBjYWxsIGZyYW1lIHJlZ2lzdGVyIGFuZCBzdGFj ayBwb2ludGVyIHRvIGFjY291bnQgZm9yIG1pc3NpbmcgYXJncy4KKyAgICAvLyBXZSBuZWVkIHRv IGNoYW5nZSB0aGUgc3RhY2sgcG9pbnRlciBmaXJzdCBiZWZvcmUgcGVyZm9ybWluZyBjb3B5L2Zp bGwgbG9vcHMuCisgICAgLy8gVGhpcyBzdGFjayBzcGFjZSBiZWxvdyB0aGUgc3RhY2sgcG9pbnRl ciBpcyBjb25zaWRlcmVkIHVudXNlZCBieSBPUy4gVGhlcmVmb3JlLAorICAgIC8vIE9TIG1heSBj b3JydXB0IHRoaXMgc3BhY2Ugd2hlbiBjb25zdHJ1Y3RpbmcgYSBzaWduYWwgc3RhY2suCisgICAg aml0Lm1vdmUoSlNJbnRlcmZhY2VKSVQ6OmFyZ3VtZW50R1BSMCwgSlNJbnRlcmZhY2VKSVQ6OnJl Z1Q1KTsKKyAgICBqaXQubHNoaWZ0MzIoSlNJbnRlcmZhY2VKSVQ6OlRydXN0ZWRJbW0zMigzKSwg SlNJbnRlcmZhY2VKSVQ6OnJlZ1Q1KTsKKyAgICBqaXQuYWRkUHRyKEpTSW50ZXJmYWNlSklUOjpy ZWdUNSwgSlNJbnRlcmZhY2VKSVQ6OmNhbGxGcmFtZVJlZ2lzdGVyKTsKKyAgICBqaXQudW50YWdS ZXR1cm5BZGRyZXNzKCk7CisgICAgaml0LmFkZFB0cihKU0ludGVyZmFjZUpJVDo6cmVnVDUsIEpT SW50ZXJmYWNlSklUOjpzdGFja1BvaW50ZXJSZWdpc3Rlcik7CisgICAgaml0LnRhZ1JldHVybkFk ZHJlc3MoKTsKKwogICAgIC8vIE1vdmUgY3VycmVudCBmcmFtZSBkb3duIGFyZ3VtZW50R1BSMCBu dW1iZXIgb2Ygc2xvdHMKICAgICBKU0ludGVyZmFjZUpJVDo6TGFiZWwgY29weUxvb3Aoaml0Lmxh YmVsKCkpOwogICAgIGppdC5sb2FkMzIoTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3MoSlNJbnRlcmZh Y2VKSVQ6OnJlZ1QzLCBQYXlsb2FkT2Zmc2V0KSwgSlNJbnRlcmZhY2VKSVQ6OnJlZ1Q1KTsKQEAg LTU4NCwxMiArNTk1LDYgQEAgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmPEpJVFRodW5rUHRyVGFnPiBh cml0eUZpeHVwR2VuZXJhdG9yKFZNKiB2bSkKICAgICBqaXQuYWRkUHRyKEpTSW50ZXJmYWNlSklU OjpUcnVzdGVkSW1tMzIoOCksIEpTSW50ZXJmYWNlSklUOjpyZWdUMyk7CiAgICAgaml0LmJyYW5j aEFkZDMyKE1hY3JvQXNzZW1ibGVyOjpOb25aZXJvLCBKU0ludGVyZmFjZUpJVDo6VHJ1c3RlZElt bTMyKDEpLCBKU0ludGVyZmFjZUpJVDo6YXJndW1lbnRHUFIyKS5saW5rVG8oZmlsbFVuZGVmaW5l ZExvb3AsICZqaXQpOwogCi0gICAgLy8gQWRqdXN0IGNhbGwgZnJhbWUgcmVnaXN0ZXIgYW5kIHN0 YWNrIHBvaW50ZXIgdG8gYWNjb3VudCBmb3IgbWlzc2luZyBhcmdzCi0gICAgaml0Lm1vdmUoSlNJ bnRlcmZhY2VKSVQ6OmFyZ3VtZW50R1BSMCwgSlNJbnRlcmZhY2VKSVQ6OnJlZ1Q1KTsKLSAgICBq aXQubHNoaWZ0MzIoSlNJbnRlcmZhY2VKSVQ6OlRydXN0ZWRJbW0zMigzKSwgSlNJbnRlcmZhY2VK SVQ6OnJlZ1Q1KTsKLSAgICBqaXQuYWRkUHRyKEpTSW50ZXJmYWNlSklUOjpyZWdUNSwgSlNJbnRl cmZhY2VKSVQ6OmNhbGxGcmFtZVJlZ2lzdGVyKTsKLSAgICBqaXQuYWRkUHRyKEpTSW50ZXJmYWNl SklUOjpyZWdUNSwgSlNJbnRlcmZhY2VKSVQ6OnN0YWNrUG9pbnRlclJlZ2lzdGVyKTsKLQogICAg IGRvbmUubGluaygmaml0KTsKIAogIyAgaWYgQ1BVKFg4NikK