186350 2018-06-06 08:26:05 -0700 Wrong NSVisualEffectMaterial used for exit full screen overlay in dark mode 2018-06-06 09:42:12 -0700 1 1 1 Unclassified WebKit Media WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy andersca commit-queue megan_gardner thorton webkit-bug-importer oldest_to_newest 1430438 0 timothy 2018-06-06 08:26:05 -0700 The material is used. It needs to be one of the new semantic materials to work in dark mode. 1430439 1 timothy 2018-06-06 08:26:14 -0700 <rdar://problem/39135535> 1430441 2 342047 timothy 2018-06-06 08:28:39 -0700 Created attachment 342047 Patch 1430443 3 342048 timothy 2018-06-06 08:36:40 -0700 Created attachment 342048 Patch 1430476 4 342048 commit-queue 2018-06-06 09:42:11 -0700 Comment on attachment 342048 Patch Clearing flags on attachment: 342048 Committed r232546: <https://trac.webkit.org/changeset/232546> 1430477 5 commit-queue 2018-06-06 09:42:12 -0700 All reviewed patches have been landed. Closing bug. 342047 2018-06-06 08:28:39 -0700 2018-06-06 08:36:38 -0700 Patch bug-186350-20180606082838.patch text/plain 2091 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGUwYzk4M2JmNjg1MmNk ODMyMjRiYzViNjI2Njc3ZjU2YWI0ZWQ0NS4uMTUwNzVhMjgyY2ZkNjA4NjBkNzc4MzliZGRhNjVk MDFmNjVkYmMwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA2LTA2ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBXcm9uZyBOU1Zpc3Vh bEVmZmVjdE1hdGVyaWFsIHVzZWQgZm9yIGV4aXQgZnVsbCBzY3JlZW4gb3ZlcmxheSBpbiBkYXJr IG1vZGUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NjM1MAorICAgICAgICByZGFyOi8vcHJvYmxlbS8zOTEzNTUzNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1dlYkNvcmVG dWxsU2NyZWVuUGxhY2Vob2xkZXJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJDb3JlRnVsbFNjcmVl blBsYWNlaG9sZGVyVmlldyBpbml0V2l0aEZyYW1lOl0pOgorICAgICAgICBVc2UgdGhlIE5TVmlz dWFsRWZmZWN0TWF0ZXJpYWxGdWxsU2NyZWVuVUkgb24gbWFjT1MgMTAuMTQgYW5kIGRvbid0Cisg ICAgICAgIHNldCBhbiBleHBsaWNpdCBOU0FwcGVhcmFuY2UuCisKIDIwMTgtMDYtMDUgIFRpbW90 aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFuIHVwIExvY2Fs RGVmYXVsdFN5c3RlbUFwcGVhcmFuY2UgYW5kIHByZWZlcnMtZGFyay1pbnRlcmZhY2UgbWVkaWEg cXVlcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVs bFNjcmVlblBsYWNlaG9sZGVyVmlldy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9X ZWJDb3JlRnVsbFNjcmVlblBsYWNlaG9sZGVyVmlldy5tbQppbmRleCBiMWZhZWI1MzViN2Q5MThk ZTM2MThjMDBhMjBhMTIzOTk2MDdjMjg4Li5kNjUzOTJlMTI0NGNlNjQ1YTI2NDVjNzEwMjQ3Y2Ix OWJjYTgzODI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29y ZUZ1bGxTY3JlZW5QbGFjZWhvbGRlclZpZXcubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuUGxhY2Vob2xkZXJWaWV3Lm1tCkBAIC01NSw5ICs1NSwx NSBAQCAtIChpZClpbml0V2l0aEZyYW1lOihOU1JlY3QpZnJhbWVSZWN0CiAgICAgX2VmZmVjdFZp ZXcuZ2V0KCkuYXV0b3Jlc2l6aW5nTWFzayA9IE5TVmlld1dpZHRoU2l6YWJsZSB8IE5TVmlld0hl aWdodFNpemFibGU7CiAgICAgX2VmZmVjdFZpZXcuZ2V0KCkuYmxlbmRpbmdNb2RlID0gTlNWaXN1 YWxFZmZlY3RCbGVuZGluZ01vZGVXaXRoaW5XaW5kb3c7CiAgICAgX2VmZmVjdFZpZXcuZ2V0KCku aGlkZGVuID0gWUVTOwotICAgIF9lZmZlY3RWaWV3LmdldCgpLm1hdGVyaWFsID0gTlNWaXN1YWxF ZmZlY3RNYXRlcmlhbExpZ2h0OwogICAgIF9lZmZlY3RWaWV3LmdldCgpLnN0YXRlID0gTlNWaXN1 YWxFZmZlY3RTdGF0ZUFjdGl2ZTsKKworI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTAxNDAwCisgICAgX2VmZmVjdFZpZXcuZ2V0KCkubWF0ZXJpYWwgPSBOU1Zpc3VhbEVm ZmVjdE1hdGVyaWFsRnVsbFNjcmVlblVJOworI2Vsc2UKKyAgICBfZWZmZWN0Vmlldy5nZXQoKS5t YXRlcmlhbCA9IE5TVmlzdWFsRWZmZWN0TWF0ZXJpYWxMaWdodDsKICAgICBfZWZmZWN0Vmlldy5n ZXQoKS5hcHBlYXJhbmNlID0gW05TQXBwZWFyYW5jZSBhcHBlYXJhbmNlTmFtZWQ6TlNBcHBlYXJh bmNlTmFtZVZpYnJhbnRMaWdodF07CisjZW5kaWYKKwogICAgIFtzZWxmIGFkZFN1YnZpZXc6X2Vm ZmVjdFZpZXcuZ2V0KCldOwogCiAgICAgX2V4aXRXYXJuaW5nID0gYWRvcHROUyhbW05TVGV4dEZp ZWxkIGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TWmVyb1JlY3RdKTsK 342048 2018-06-06 08:36:40 -0700 2018-06-06 09:42:11 -0700 Patch bug-186350-20180606083639.patch text/plain 2086 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGUwYzk4M2JmNjg1MmNk ODMyMjRiYzViNjI2Njc3ZjU2YWI0ZWQ0NS4uMTUwNzVhMjgyY2ZkNjA4NjBkNzc4MzliZGRhNjVk MDFmNjVkYmMwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA2LTA2ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBXcm9uZyBOU1Zpc3Vh bEVmZmVjdE1hdGVyaWFsIHVzZWQgZm9yIGV4aXQgZnVsbCBzY3JlZW4gb3ZlcmxheSBpbiBkYXJr IG1vZGUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NjM1MAorICAgICAgICByZGFyOi8vcHJvYmxlbS8zOTEzNTUzNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1dlYkNvcmVG dWxsU2NyZWVuUGxhY2Vob2xkZXJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJDb3JlRnVsbFNjcmVl blBsYWNlaG9sZGVyVmlldyBpbml0V2l0aEZyYW1lOl0pOgorICAgICAgICBVc2UgdGhlIE5TVmlz dWFsRWZmZWN0TWF0ZXJpYWxGdWxsU2NyZWVuVUkgb24gbWFjT1MgMTAuMTQgYW5kIGRvbid0Cisg ICAgICAgIHNldCBhbiBleHBsaWNpdCBOU0FwcGVhcmFuY2UuCisKIDIwMTgtMDYtMDUgIFRpbW90 aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFuIHVwIExvY2Fs RGVmYXVsdFN5c3RlbUFwcGVhcmFuY2UgYW5kIHByZWZlcnMtZGFyay1pbnRlcmZhY2UgbWVkaWEg cXVlcnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlRnVs bFNjcmVlblBsYWNlaG9sZGVyVmlldy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9X ZWJDb3JlRnVsbFNjcmVlblBsYWNlaG9sZGVyVmlldy5tbQppbmRleCBiMWZhZWI1MzViN2Q5MThk ZTM2MThjMDBhMjBhMTIzOTk2MDdjMjg4Li43NjBmNThlZTI5MDMxMDAwYzFmNDExNjcwZTA0YzQw NTI5MWE2ZTk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29y ZUZ1bGxTY3JlZW5QbGFjZWhvbGRlclZpZXcubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1dlYkNvcmVGdWxsU2NyZWVuUGxhY2Vob2xkZXJWaWV3Lm1tCkBAIC01NSw5ICs1NSwx NSBAQCAtIChpZClpbml0V2l0aEZyYW1lOihOU1JlY3QpZnJhbWVSZWN0CiAgICAgX2VmZmVjdFZp ZXcuZ2V0KCkuYXV0b3Jlc2l6aW5nTWFzayA9IE5TVmlld1dpZHRoU2l6YWJsZSB8IE5TVmlld0hl aWdodFNpemFibGU7CiAgICAgX2VmZmVjdFZpZXcuZ2V0KCkuYmxlbmRpbmdNb2RlID0gTlNWaXN1 YWxFZmZlY3RCbGVuZGluZ01vZGVXaXRoaW5XaW5kb3c7CiAgICAgX2VmZmVjdFZpZXcuZ2V0KCku aGlkZGVuID0gWUVTOwotICAgIF9lZmZlY3RWaWV3LmdldCgpLm1hdGVyaWFsID0gTlNWaXN1YWxF ZmZlY3RNYXRlcmlhbExpZ2h0OwogICAgIF9lZmZlY3RWaWV3LmdldCgpLnN0YXRlID0gTlNWaXN1 YWxFZmZlY3RTdGF0ZUFjdGl2ZTsKKworI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTAxNDAwCisgICAgX2VmZmVjdFZpZXcuZ2V0KCkubWF0ZXJpYWwgPSBOU1Zpc3VhbEVm ZmVjdE1hdGVyaWFsUG9wb3ZlcjsKKyNlbHNlCisgICAgX2VmZmVjdFZpZXcuZ2V0KCkubWF0ZXJp YWwgPSBOU1Zpc3VhbEVmZmVjdE1hdGVyaWFsTGlnaHQ7CiAgICAgX2VmZmVjdFZpZXcuZ2V0KCku YXBwZWFyYW5jZSA9IFtOU0FwcGVhcmFuY2UgYXBwZWFyYW5jZU5hbWVkOk5TQXBwZWFyYW5jZU5h bWVWaWJyYW50TGlnaHRdOworI2VuZGlmCisKICAgICBbc2VsZiBhZGRTdWJ2aWV3Ol9lZmZlY3RW aWV3LmdldCgpXTsKIAogICAgIF9leGl0V2FybmluZyA9IGFkb3B0TlMoW1tOU1RleHRGaWVsZCBh bGxvY10gaW5pdFdpdGhGcmFtZTpOU1plcm9SZWN0XSk7Cg==