186348 2018-06-06 06:31:52 -0700 Use the default label for snapshotted plug-ins if no mime-type is available 2018-06-06 11:24:46 -0700 1 1 1 Unclassified WebKit Plug-ins Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts cdumez commit-queue dino esprehn+autocc ews-watchlist gyuyoung.kim jonlee rniwa webkit-bug-importer oldest_to_newest 1430415 0 graouts 2018-06-06 06:31:52 -0700 We currently crash in titleText() or subtitleText() in HTMLPlugInImageElement.cpp if there is no mime-type specified. 1430416 1 graouts 2018-06-06 06:32:10 -0700 <rdar://problem/38278978> 1430417 2 342045 graouts 2018-06-06 06:34:20 -0700 Created attachment 342045 Patch 1430489 3 342045 ap 2018-06-06 10:16:52 -0700 Comment on attachment 342045 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342045&action=review > Source/WebCore/ChangeLog:8 > + In case the mime-type is not available, use the default labels otherwise we'd crash trying to look up the empty string in the HashMap. Is it feasible to have a test for this? 1430519 4 jonlee 2018-06-06 11:09:56 -0700 To answer ap's question, there is a test, but it hits RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(isSafeToUpdateStyleOrLayout(*this)) in Document::updateLayout() See rdar://40849498. 1430530 5 342045 commit-queue 2018-06-06 11:24:44 -0700 Comment on attachment 342045 Patch Clearing flags on attachment: 342045 Committed r232551: <https://trac.webkit.org/changeset/232551> 1430531 6 commit-queue 2018-06-06 11:24:46 -0700 All reviewed patches have been landed. Closing bug. 342045 2018-06-06 06:34:20 -0700 2018-06-06 11:24:44 -0700 Patch bug-186348-20180606153418.patch text/plain 2304 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWZkZWI1ZTA1YThlNmMy MWM3ZWM0NTFlMmU3ZjE3MTFlOGI5ZjgxMS4uN2U1ZDBlZWNhOWIwMDA5ZGY3MzkyNzVkMzNmM2Y0 YTU3YjI1YTM4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA2LTA2ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIHRoZSBkZWZhdWx0 IGxhYmVsIGZvciBzbmFwc2hvdHRlZCBwbHVnLWlucyBpZiBubyBtaW1lLXR5cGUgaXMgYXZhaWxh YmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODYz NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBj YXNlIHRoZSBtaW1lLXR5cGUgaXMgbm90IGF2YWlsYWJsZSwgdXNlIHRoZSBkZWZhdWx0IGxhYmVs cyBvdGhlcndpc2Ugd2UnZCBjcmFzaCB0cnlpbmcgdG8gbG9vayB1cCB0aGUgZW1wdHkgc3RyaW5n IGluIHRoZSBIYXNoTWFwLgorCisgICAgICAgICogaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRpdGxlVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpz dWJ0aXRsZVRleHQpOgorCiAyMDE4LTA2LTA1ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBs ZS5jb20+CiAKICAgICAgICAgW1dlYiBBbmltYXRpb25zXSBPbmx5IGV4cG9zZSBDU1NBbmltYXRp b24gYW5kIENTU1RyYW5zaXRpb24gaWYgdGhlIFdlYkFuaW1hdGlvbnNDU1NJbnRlZ3JhdGlvbiBy dW50aW1lIGZsYWcgaXMgZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJ bkltYWdlRWxlbWVudC5jcHAKaW5kZXggNTY3NWViOTdiNjhiN2QxMDg2MTNlNWNjNTU1ZDU1MmQy OWJjODk1YS4uMTM2MjU5YTViOTk3NDZlNzcwNDU1ODcyNWRlNzJiMzg1MDM0YzdmZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCkBAIC03Miw2 ICs3Miw5IEBAIHN0YXRpYyBjb25zdCBTZWNvbmRzIHJlbW92ZVNuYXBzaG90VGltZXJEZWxheSB7 IDE1MDBfbXMgfTsKIAogc3RhdGljIGNvbnN0IFN0cmluZyB0aXRsZVRleHQoUGFnZSYgcGFnZSwg Y29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKIHsKKyAgICBpZiAobWltZVR5cGUuaXNFbXB0eSgpKQor ICAgICAgICByZXR1cm4gc25hcHNob3R0ZWRQbHVnSW5MYWJlbFRpdGxlKCk7CisKICAgICAvLyBG SVhNRTogSXQncyBub3QgY29uc2lzdGVudCB0byBnZXQgYSBzdHJpbmcgZnJvbSB0aGUgcGFnZSdz IGNocm9tZSBjbGllbnQsIGJ1dCB0aGVuIGNhY2hlIGl0IGdsb2JhbGx5LgogICAgIC8vIElmIGl0 J3MgZ2xvYmFsLCBpdCBzaG91bGQgY29tZSBmcm9tIGVsc2V3aGVyZS4gSWYgaXQncyBwZXItcGFn ZSB0aGVuIGl0IHNob3VsZCBiZSBjYWNoZWQgcGVyIHBhZ2UuCiAgICAgc3RhdGljIE5ldmVyRGVz dHJveWVkPEhhc2hNYXA8U3RyaW5nLCBTdHJpbmc+PiBtaW1lVHlwZVRvTGFiZWxUaXRsZU1hcDsK QEAgLTg1LDYgKzg4LDkgQEAgc3RhdGljIGNvbnN0IFN0cmluZyB0aXRsZVRleHQoUGFnZSYgcGFn ZSwgY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKIAogc3RhdGljIGNvbnN0IFN0cmluZyBzdWJ0aXRs ZVRleHQoUGFnZSYgcGFnZSwgY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKIHsKKyAgICBpZiAobWlt ZVR5cGUuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gc25hcHNob3R0ZWRQbHVnSW5MYWJlbFN1 YnRpdGxlKCk7CisKICAgICAvLyBGSVhNRTogSXQncyBub3QgY29uc2lzdGVudCB0byBnZXQgYSBz dHJpbmcgZnJvbSB0aGUgcGFnZSdzIGNocm9tZSBjbGllbnQsIGJ1dCB0aGVuIGNhY2hlIGl0IGds b2JhbGx5LgogICAgIC8vIElmIGl0J3MgZ2xvYmFsLCBpdCBzaG91bGQgY29tZSBmcm9tIGVsc2V3 aGVyZS4gSWYgaXQncyBwZXItcGFnZSB0aGVuIGl0IHNob3VsZCBiZSBjYWNoZWQgcGVyIHBhZ2Uu CiAgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPEhhc2hNYXA8U3RyaW5nLCBTdHJpbmc+PiBtaW1l VHlwZVRvTGFiZWxTdWJ0aXRsZU1hcDsK