186334 2018-06-05 19:55:48 -0700 [LFC] Add margin computation for floating, no-replaced elements. 2018-06-06 08:26:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1430333 0 zalan 2018-06-05 19:55:48 -0700 If 'margin-left', or 'margin-right' are computed as 'auto', their used value is '0' 1430334 1 342024 zalan 2018-06-05 19:59:29 -0700 Created attachment 342024 Patch 1430436 2 342024 commit-queue 2018-06-06 08:25:44 -0700 Comment on attachment 342024 Patch Clearing flags on attachment: 342024 Committed r232540: <https://trac.webkit.org/changeset/232540> 1430437 3 commit-queue 2018-06-06 08:25:45 -0700 All reviewed patches have been landed. Closing bug. 1430440 4 webkit-bug-importer 2018-06-06 08:26:23 -0700 <rdar://problem/40852253> 342024 2018-06-05 19:59:29 -0700 2018-06-06 08:25:44 -0700 Patch bug-186334-20180605195928.patch text/plain 2877 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGUwYzk4M2JmNjg1MmNk ODMyMjRiYzViNjI2Njc3ZjU2YWI0ZWQ0NS4uNmJjYmFkMTg5NjMxMTU3NjUyOTUxMzMzZjA0NTYx NWUzZWNmZjYzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA2LTA1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gQWRkIG1hcmdpbiBj b21wdXRhdGlvbiBmb3IgZmxvYXRpbmcsIG5vLXJlcGxhY2VkIGVsZW1lbnRzLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2MzM0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgJ21hcmdpbi1sZWZ0Jywg b3IgJ21hcmdpbi1yaWdodCcgYXJlIGNvbXB1dGVkIGFzICdhdXRvJywgdGhlaXIgdXNlZCB2YWx1 ZSBpcyAnMCcuCisKKyAgICAgICAgKiBsYXlvdXQvRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRy eTo6ZmxvYXRpbmdOb25SZXBsYWNlZFdpZHRoQW5kTWFyZ2luKToKKwogMjAxOC0wNi0wNSAgVGlt b3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgTG9j YWxEZWZhdWx0U3lzdGVtQXBwZWFyYW5jZSBhbmQgcHJlZmVycy1kYXJrLWludGVyZmFjZSBtZWRp YSBxdWVyeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zvcm1hdHRpbmdDb250 ZXh0R2VvbWV0cnkuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zvcm1hdHRpbmdDb250ZXh0 R2VvbWV0cnkuY3BwCmluZGV4IDFhMjZmZWY5Y2Y4NzkwNTYxYTg0M2Q3YjFjMzBiMzIwM2Q0ZjYy OTguLmY3OGVlYjZmNWRmODViMjZiODQzYTZiODE2OTk1MzljZmUwNDg0ZDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHAKQEAg LTIyMCwxMSArMjIwLDI2IEBAIEZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeTo6V2lkdGhBbmRN YXJnaW4gRm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5OjpmbG9hdGluCiB7CiAgICAgQVNTRVJU KGxheW91dEJveC5pc0Zsb2F0aW5nUG9zaXRpb25lZCgpICYmICFsYXlvdXRCb3gucmVwbGFjZWQo KSk7CiAgICAgLy8gMTAuMy41IEZsb2F0aW5nLCBub24tcmVwbGFjZWQgZWxlbWVudHMKKyAgICAv LworICAgIC8vIDEuIElmICdtYXJnaW4tbGVmdCcsIG9yICdtYXJnaW4tcmlnaHQnIGFyZSBjb21w dXRlZCBhcyAnYXV0bycsIHRoZWlyIHVzZWQgdmFsdWUgaXMgJzAnLgorICAgIC8vIDIuIElmICd3 aWR0aCcgaXMgY29tcHV0ZWQgYXMgJ2F1dG8nLCB0aGUgdXNlZCB2YWx1ZSBpcyB0aGUgInNocmlu ay10by1maXQiIHdpZHRoLgorICAgIGF1dG8mIHN0eWxlID0gbGF5b3V0Qm94LnN0eWxlKCk7Cisg ICAgYXV0byB3aWR0aCA9IHN0eWxlLmxvZ2ljYWxXaWR0aCgpOworICAgIExheW91dFVuaXQgY29t cHV0ZWRNYXJnaW5MZWZ0VmFsdWU7CisgICAgTGF5b3V0VW5pdCBjb21wdXRlZE1hcmdpblJpZ2h0 VmFsdWU7CisKKyAgICB7CisgICAgICAgIGF1dG8gbWFyZ2luTGVmdCA9IHN0eWxlLm1hcmdpbkxl ZnQoKTsKKyAgICAgICAgYXV0byBtYXJnaW5SaWdodCA9IHN0eWxlLm1hcmdpblJpZ2h0KCk7Cisg ICAgICAgIGF1dG8gY29udGFpbmluZ0Jsb2NrV2lkdGggPSBsYXlvdXRDb250ZXh0LmRpc3BsYXlC b3hGb3JMYXlvdXRCb3goKmxheW91dEJveC5jb250YWluaW5nQmxvY2soKSktPndpZHRoKCk7Cisg ICAgICAgIC8vICMxCisgICAgICAgIGNvbXB1dGVkTWFyZ2luTGVmdFZhbHVlID0gbWFyZ2luTGVm dC5pc0F1dG8oKSA/IExheW91dFVuaXQoMCkgOiB2YWx1ZUZvckxlbmd0aChtYXJnaW5MZWZ0LCBj b250YWluaW5nQmxvY2tXaWR0aCk7CisgICAgICAgIGNvbXB1dGVkTWFyZ2luUmlnaHRWYWx1ZSA9 IG1hcmdpblJpZ2h0LmlzQXV0bygpID8gTGF5b3V0VW5pdCgwKSA6IHZhbHVlRm9yTGVuZ3RoKG1h cmdpblJpZ2h0LCBjb250YWluaW5nQmxvY2tXaWR0aCk7CisgICAgfQogCi0gICAgLy8gSWYgJ3dp ZHRoJyBpcyBjb21wdXRlZCBhcyAnYXV0bycsIHRoZSB1c2VkIHZhbHVlIGlzIHRoZSAic2hyaW5r LXRvLWZpdCIgd2lkdGguCi0gICAgYXV0byB3aWR0aCA9IGxheW91dEJveC5zdHlsZSgpLmxvZ2lj YWxXaWR0aCgpOworICAgIC8vICMyCiAgICAgYXV0byBjb21wdXRlZFdpZHRoVmFsdWUgPSB3aWR0 aC5pc0F1dG8oKSA/IHNocmlua1RvRml0V2lkdGgobGF5b3V0Q29udGV4dCwgbGF5b3V0Qm94KSA6 IExheW91dFVuaXQod2lkdGgudmFsdWUoKSk7Ci0gICAgcmV0dXJuIEZvcm1hdHRpbmdDb250ZXh0 OjpHZW9tZXRyeTo6V2lkdGhBbmRNYXJnaW4geyBjb21wdXRlZFdpZHRoVmFsdWUsIHsgfSB9Owor ICAgIHJldHVybiBGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6OldpZHRoQW5kTWFyZ2luIHsg Y29tcHV0ZWRXaWR0aFZhbHVlLCB7IGNvbXB1dGVkTWFyZ2luTGVmdFZhbHVlLCBjb21wdXRlZE1h cmdpblJpZ2h0VmFsdWUgfSB9OwogfQogCiBMYXlvdXRVbml0IEZvcm1hdHRpbmdDb250ZXh0OjpH ZW9tZXRyeTo6ZmxvYXRpbmdSZXBsYWNlZEhlaWdodChMYXlvdXRDb250ZXh0JiBsYXlvdXRDb250 ZXh0LCBjb25zdCBCb3gmIGxheW91dEJveCkK