186328 2018-06-05 16:44:18 -0700 Set the AVAssetResourceLoaderRequest's contentType to AVStreamingKeyDeliveryContentKeyType in the case of a FPS key request. 2018-06-06 09:10:55 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1430279 0 jer.noble 2018-06-05 16:44:18 -0700 Set the AVAssetResourceLoaderRequest's contentType to AVStreamingKeyDeliveryContentKeyType in the case of a FPS key request. 1430280 1 webkit-bug-importer 2018-06-05 16:44:53 -0700 <rdar://problem/40829228> 1430281 2 342006 jer.noble 2018-06-05 16:47:11 -0700 Created attachment 342006 Patch 1430343 3 342006 eric.carlson 2018-06-05 20:50:20 -0700 Comment on attachment 342006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342006&action=review r=me once the bots are happy. > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2492 > + infoRequest.contentType = AVStreamingKeyDeliveryContentKeyType; Is this string available in every version is the OS we support? 1430344 4 342006 jer.noble 2018-06-05 20:55:39 -0700 Comment on attachment 342006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342006&action=review >> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2492 >> + infoRequest.contentType = AVStreamingKeyDeliveryContentKeyType; > > Is this string available in every version is the OS we support? This is wrapped in a ENABLE(ENCRYPTED_MEDIA) check, which is only enabled on platforms which will deliver this string. 1430349 5 342029 jer.noble 2018-06-05 21:23:10 -0700 Created attachment 342029 Patch for landing 1430457 6 342029 commit-queue 2018-06-06 09:10:53 -0700 Comment on attachment 342029 Patch for landing Clearing flags on attachment: 342029 Committed r232542: <https://trac.webkit.org/changeset/232542> 1430458 7 commit-queue 2018-06-06 09:10:55 -0700 All reviewed patches have been landed. Closing bug. 342006 2018-06-05 16:47:11 -0700 2018-06-05 21:23:04 -0700 Patch bug-186328-20180605164710.patch text/plain 3080 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWI1NzJmM2ZlOTMxYjA2 ODAzODM1MzIxMTcwYmIwZDdkODhkMjYyMC4uMGQzMjA0NGQyMWIxNzljY2VkZjRmMzAxZjMwNzRj MTRjYTZiNzZiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA2LTA1ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFNldCB0aGUgQVZBc3NldFJl c291cmNlTG9hZGVyUmVxdWVzdCdzIGNvbnRlbnRUeXBlIHRvIEFWU3RyZWFtaW5nS2V5RGVsaXZl cnlDb250ZW50S2V5VHlwZSBpbiB0aGUgY2FzZSBvZiBhIEZQUyBrZXkgcmVxdWVzdC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjMyOAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNDA4MjkyMjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2Jq Yy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tOgorICAgICAgICAoV2ViQ29y ZTo6TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6YXR0ZW1wdFRvRGVjcnlwdFdp dGhJbnN0YW5jZSk6CisKIDIwMTgtMDYtMDUgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAoMjMxODE3KTogVmlkZW9zIHBlcm1hbmVudGx5IGJs YW5rIG91dCBhZnRlciBzd2l0Y2hpbmcgb3V0IG9mIGEgdGFiIGFuZCBiYWNrIGluCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9N ZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3Vu ZGF0aW9uT2JqQy5tbQppbmRleCAwNDJjMGEzMGMxNDY0YjI0NWFkOTY0MmY3OTBlYzBiMWE2M2Fm Yjg2Li4zZTYzNjllYjQwMDkyYzcwY2I4ZmMyYjQ4YWVkNTU5YzVjOWM0NTA3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRp YVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91 bmRhdGlvbk9iakMubW0KQEAgLTE4MCw2ICsxODAsNyBAQCBTT0ZUX0xJTktfUE9JTlRFUihBVkZv dW5kYXRpb24sIEFWVVJMQXNzZXRSZWZlcmVuY2VSZXN0cmljdGlvbnNLZXksIE5TU3RyaW5nICop CiBTT0ZUX0xJTktfUE9JTlRFUihBVkZvdW5kYXRpb24sIEFWTGF5ZXJWaWRlb0dyYXZpdHlSZXNp emVBc3BlY3QsIE5TU3RyaW5nICopCiBTT0ZUX0xJTktfUE9JTlRFUihBVkZvdW5kYXRpb24sIEFW TGF5ZXJWaWRlb0dyYXZpdHlSZXNpemVBc3BlY3RGaWxsLCBOU1N0cmluZyAqKQogU09GVF9MSU5L X1BPSU5URVIoQVZGb3VuZGF0aW9uLCBBVkxheWVyVmlkZW9HcmF2aXR5UmVzaXplLCBOU1N0cmlu ZyAqKQorU09GVF9MSU5LX1BPSU5URVIoQVZGb3VuZGF0aW9uLCBBVlN0cmVhbWluZ0tleURlbGl2 ZXJ5Q29udGVudEtleVR5cGUsIE5TU3RyaW5nICopCiAKIFNPRlRfTElOS19QT0lOVEVSX09QVElP TkFMKEFWRm91bmRhdGlvbiwgQVZVUkxBc3NldENsaWVudEJ1bmRsZUlkZW50aWZpZXJLZXksIE5T U3RyaW5nICopCiBTT0ZUX0xJTktfUE9JTlRFUl9PUFRJT05BTChBVkZvdW5kYXRpb24sIEFWVVJM QXNzZXRSZXF1aXJlc0N1c3RvbVVSTExvYWRpbmdLZXksIE5TU3RyaW5nICopCkBAIC0yMTQsNiAr MjE1LDcgQEAgU09GVF9MSU5LX1BPSU5URVJfT1BUSU9OQUwoQVZGb3VuZGF0aW9uLCBBVlVSTEFz c2V0VXNlQ2xpZW50VVJMTG9hZGluZ0V4Y2x1c2l2ZWwKICNkZWZpbmUgQVZMYXllclZpZGVvR3Jh dml0eVJlc2l6ZUFzcGVjdCBnZXRBVkxheWVyVmlkZW9HcmF2aXR5UmVzaXplQXNwZWN0KCkKICNk ZWZpbmUgQVZMYXllclZpZGVvR3Jhdml0eVJlc2l6ZUFzcGVjdEZpbGwgZ2V0QVZMYXllclZpZGVv R3Jhdml0eVJlc2l6ZUFzcGVjdEZpbGwoKQogI2RlZmluZSBBVkxheWVyVmlkZW9HcmF2aXR5UmVz aXplIGdldEFWTGF5ZXJWaWRlb0dyYXZpdHlSZXNpemUoKQorI2RlZmluZSBBVlN0cmVhbWluZ0tl eURlbGl2ZXJ5Q29udGVudEtleVR5cGUgZ2V0QVZTdHJlYW1pbmdLZXlEZWxpdmVyeUNvbnRlbnRL ZXlUeXBlKCkKIAogI2lmIEhBVkUoQVZGT1VOREFUSU9OX01FRElBX1NFTEVDVElPTl9HUk9VUCkK IHR5cGVkZWYgQVZNZWRpYVNlbGVjdGlvbkdyb3VwIEFWTWVkaWFTZWxlY3Rpb25Hcm91cFR5cGU7 CkBAIC0yNDg1LDggKzI0ODcsMTEgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRp b25PYmpDOjpjZG1JbnN0YW5jZURldGFjaGVkKENETUluc3RhbmNlJiBpbnN0YW4KIHZvaWQgTWVk aWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6YXR0ZW1wdFRvRGVjcnlwdFdpdGhJbnN0 YW5jZShDRE1JbnN0YW5jZSYpCiB7CiAgICAgYXV0byBrZXlVUklUb1JlcXVlc3RNYXAgPSBXVEZN b3ZlKG1fa2V5VVJJVG9SZXF1ZXN0TWFwKTsKLSAgICBmb3IgKGF1dG8mIHJlcXVlc3QgOiBrZXlV UklUb1JlcXVlc3RNYXAudmFsdWVzKCkpCisgICAgZm9yIChhdXRvJiByZXF1ZXN0IDoga2V5VVJJ VG9SZXF1ZXN0TWFwLnZhbHVlcygpKSB7CisgICAgICAgIGlmIChhdXRvICppbmZvUmVxdWVzdCA9 IHJlcXVlc3QuZ2V0KCkuY29udGVudEluZm9ybWF0aW9uUmVxdWVzdCkKKyAgICAgICAgICAgIGlu Zm9SZXF1ZXN0LmNvbnRlbnRUeXBlID0gQVZTdHJlYW1pbmdLZXlEZWxpdmVyeUNvbnRlbnRLZXlU eXBlOwogICAgICAgICBbcmVxdWVzdCBmaW5pc2hMb2FkaW5nXTsKKyAgICB9CiB9CiAjZW5kaWYK IAo= 342029 2018-06-05 21:23:10 -0700 2018-06-06 09:10:53 -0700 Patch for landing bug-186328-20180605212309.patch text/plain 3077 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDY4OWNkNGIyYzMwMTZm NGFjMTFmZmU3NzVjMzg1ZTQ1MTdmZjg2ZS4uYmE1NDE5NjEzMDFjNGQ4ZWQ3NDdiMTEzZjgxYzcz NjBkMjk2YzcyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA2LTA1ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFNldCB0aGUgQVZBc3NldFJl c291cmNlTG9hZGVyUmVxdWVzdCdzIGNvbnRlbnRUeXBlIHRvIEFWU3RyZWFtaW5nS2V5RGVsaXZl cnlDb250ZW50S2V5VHlwZSBpbiB0aGUgY2FzZSBvZiBhIEZQUyBrZXkgcmVxdWVzdC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjMyOAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNDA4MjkyMjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBD YXJsc29uLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMv TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6 Ok1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OmF0dGVtcHRUb0RlY3J5cHRXaXRo SW5zdGFuY2UpOgorCiAyMDE4LTA2LTA1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+ CiAKICAgICAgICAgW0xGQ10gQWRkIG1pc3NpbmcgbWFyZ2lucyBmb3IgaW5mbG93LCBub24gcmVw bGFjZWQgYmxvY2sgYW5kIHJlcGxhY2VkIGlubGluZSBlbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5 ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9i akMubW0KaW5kZXggNGYxNWVjMjg5ZjI4OWU1NzU3MmExNmFjODZkNmYxZWM2Y2FjYjk0OC4uOWFj MDVjMjJjZTUzMGQ1MGZkZDg5NmE4M2YyYzMzM2VlZWZkMDUzNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQ cml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25P YmpDLm1tCkBAIC0xODAsNiArMTgwLDcgQEAgU09GVF9MSU5LX0NPTlNUQU5UKEFWRm91bmRhdGlv biwgQVZVUkxBc3NldFJlZmVyZW5jZVJlc3RyaWN0aW9uc0tleSwgTlNTdHJpbmcgKikKIFNPRlRf TElOS19DT05TVEFOVChBVkZvdW5kYXRpb24sIEFWTGF5ZXJWaWRlb0dyYXZpdHlSZXNpemVBc3Bl Y3QsIE5TU3RyaW5nICopCiBTT0ZUX0xJTktfQ09OU1RBTlQoQVZGb3VuZGF0aW9uLCBBVkxheWVy VmlkZW9HcmF2aXR5UmVzaXplQXNwZWN0RmlsbCwgTlNTdHJpbmcgKikKIFNPRlRfTElOS19DT05T VEFOVChBVkZvdW5kYXRpb24sIEFWTGF5ZXJWaWRlb0dyYXZpdHlSZXNpemUsIE5TU3RyaW5nICop CitTT0ZUX0xJTktfQ09OU1RBTlQoQVZGb3VuZGF0aW9uLCBBVlN0cmVhbWluZ0tleURlbGl2ZXJ5 Q29udGVudEtleVR5cGUsIE5TU3RyaW5nICopCiAKIFNPRlRfTElOS19QT0lOVEVSX09QVElPTkFM KEFWRm91bmRhdGlvbiwgQVZVUkxBc3NldENsaWVudEJ1bmRsZUlkZW50aWZpZXJLZXksIE5TU3Ry aW5nICopCiBTT0ZUX0xJTktfUE9JTlRFUl9PUFRJT05BTChBVkZvdW5kYXRpb24sIEFWVVJMQXNz ZXRSZXF1aXJlc0N1c3RvbVVSTExvYWRpbmdLZXksIE5TU3RyaW5nICopCkBAIC0yMTQsNiArMjE1 LDcgQEAgU09GVF9MSU5LX1BPSU5URVJfT1BUSU9OQUwoQVZGb3VuZGF0aW9uLCBBVlVSTEFzc2V0 VXNlQ2xpZW50VVJMTG9hZGluZ0V4Y2x1c2l2ZWwKICNkZWZpbmUgQVZMYXllclZpZGVvR3Jhdml0 eVJlc2l6ZUFzcGVjdCBnZXRBVkxheWVyVmlkZW9HcmF2aXR5UmVzaXplQXNwZWN0KCkKICNkZWZp bmUgQVZMYXllclZpZGVvR3Jhdml0eVJlc2l6ZUFzcGVjdEZpbGwgZ2V0QVZMYXllclZpZGVvR3Jh dml0eVJlc2l6ZUFzcGVjdEZpbGwoKQogI2RlZmluZSBBVkxheWVyVmlkZW9HcmF2aXR5UmVzaXpl IGdldEFWTGF5ZXJWaWRlb0dyYXZpdHlSZXNpemUoKQorI2RlZmluZSBBVlN0cmVhbWluZ0tleURl bGl2ZXJ5Q29udGVudEtleVR5cGUgZ2V0QVZTdHJlYW1pbmdLZXlEZWxpdmVyeUNvbnRlbnRLZXlU eXBlKCkKIAogI2lmIEhBVkUoQVZGT1VOREFUSU9OX01FRElBX1NFTEVDVElPTl9HUk9VUCkKIHR5 cGVkZWYgQVZNZWRpYVNlbGVjdGlvbkdyb3VwIEFWTWVkaWFTZWxlY3Rpb25Hcm91cFR5cGU7CkBA IC0yNDc0LDggKzI0NzYsMTEgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25P YmpDOjpjZG1JbnN0YW5jZURldGFjaGVkKENETUluc3RhbmNlJiBpbnN0YW4KIHZvaWQgTWVkaWFQ bGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6YXR0ZW1wdFRvRGVjcnlwdFdpdGhJbnN0YW5j ZShDRE1JbnN0YW5jZSYpCiB7CiAgICAgYXV0byBrZXlVUklUb1JlcXVlc3RNYXAgPSBXVEZNb3Zl KG1fa2V5VVJJVG9SZXF1ZXN0TWFwKTsKLSAgICBmb3IgKGF1dG8mIHJlcXVlc3QgOiBrZXlVUklU b1JlcXVlc3RNYXAudmFsdWVzKCkpCisgICAgZm9yIChhdXRvJiByZXF1ZXN0IDoga2V5VVJJVG9S ZXF1ZXN0TWFwLnZhbHVlcygpKSB7CisgICAgICAgIGlmIChhdXRvICppbmZvUmVxdWVzdCA9IHJl cXVlc3QuZ2V0KCkuY29udGVudEluZm9ybWF0aW9uUmVxdWVzdCkKKyAgICAgICAgICAgIGluZm9S ZXF1ZXN0LmNvbnRlbnRUeXBlID0gQVZTdHJlYW1pbmdLZXlEZWxpdmVyeUNvbnRlbnRLZXlUeXBl OwogICAgICAgICBbcmVxdWVzdCBmaW5pc2hMb2FkaW5nXTsKKyAgICB9CiB9CiAjZW5kaWYKIAo=