186320 2018-06-05 13:40:03 -0700 attenuationFactor should be in range [0,1] 2018-06-06 09:36:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue jer.noble jonlee webkit-bug-importer oldest_to_newest 1430204 0 jeremyj-wk 2018-06-05 13:40:03 -0700 attenuationFactor should be in range [0,1] 1430205 1 jeremyj-wk 2018-06-05 13:40:48 -0700 rdar://problem/40821456 1430212 2 341992 jeremyj-wk 2018-06-05 13:57:10 -0700 Created attachment 341992 Patch 1430226 3 341992 jonlee 2018-06-05 14:26:37 -0700 Comment on attachment 341992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341992&action=review > Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:81 > + return std::max(std::min(normalizedTimeDelta * m_weight, 1.0), 0.0); So the weight factor is incorrect when you pass some threshold, but with the clamping, how long must I wait in order for the old influence to be at 0, and basically we start from scratch? Before, the old influence would end up having a negative impact. 1430456 4 341992 jer.noble 2018-06-06 09:06:38 -0700 Comment on attachment 341992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341992&action=review >> Source/WebKit/UIProcess/ios/fullscreen/FullscreenTouchSecheuristic.cpp:81 >> + return std::max(std::min(normalizedTimeDelta * m_weight, 1.0), 0.0); > > So the weight factor is incorrect when you pass some threshold, but with the clamping, how long must I wait in order for the old influence to be at 0, and basically we start from scratch? Before, the old influence would end up having a negative impact. We set the ramp down speed to 1_s and the weight to 0.1, so it would take 10 seconds until the old influence had negative impact under the old code. 1430474 5 341992 commit-queue 2018-06-06 09:36:18 -0700 Comment on attachment 341992 Patch Clearing flags on attachment: 341992 Committed r232545: <https://trac.webkit.org/changeset/232545> 1430475 6 commit-queue 2018-06-06 09:36:20 -0700 All reviewed patches have been landed. Closing bug. 341992 2018-06-05 13:57:10 -0700 2018-06-06 09:36:18 -0700 Patch bug-186320-20180605135709.patch text/plain 1614 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxOTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNhYmJkMTU4ODhlZTIyN2Nk MmMyNjdmZjgzOWJjM2UxZWRlZTZiZWEuLjZmZmI5YTY1M2M4MGViYTYwNGEzZTJhYzk4NTU5Yzli Y2RmN2UyZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDYtMDUgIEplcmVteSBK b25lcyAgPGplcmVteWpAYXBwbGUuY29tPgorCisgICAgICAgIGF0dGVudWF0aW9uRmFjdG9yIHNo b3VsZCBiZSBpbiByYW5nZSBbMCwxXQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg2MzIwCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzQwODIxNDU2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgYXR0ZW51 YXRpb25GYWN0b3IgaXMgb3V0c2lkZSBvZiB0aGlzIHJhbmdlIGl0IGNhbiBjYXVzZSBmYWxzZSBw b3NpdGl2ZXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vRnVsbHNjcmVl blRvdWNoU2VjaGV1cmlzdGljLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RnVsbHNjcmVlblRvdWNo U2VjaGV1cmlzdGljOjphdHRlbnVhdGlvbkZhY3Rvcik6CisKIDIwMTgtMDUtMTggIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBBZGQgbWlzc2luZyBudWxs YWJpbGl0eSBhbm5vdGF0aW9ucyB0byBfV0tBdXRvbWF0aW9uU2Vzc2lvbkRlbGVnYXRlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9GdWxsc2NyZWVu VG91Y2hTZWNoZXVyaXN0aWMuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Z1bGxz Y3JlZW4vRnVsbHNjcmVlblRvdWNoU2VjaGV1cmlzdGljLmNwcAppbmRleCA5ZTkwNzAxMTU4YWUy MTJjZDZhYzc3OGIwM2NkZDVhNzFlZTMzM2E4Li5kMGNmN2E5ZjNhYTE3ZWExN2NhNWQ4OWVmNDVi Y2Q4OWQ3YzJjY2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVs bHNjcmVlbi9GdWxsc2NyZWVuVG91Y2hTZWNoZXVyaXN0aWMuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL0Z1bGxzY3JlZW5Ub3VjaFNlY2hldXJpc3RpYy5j cHAKQEAgLTc4LDcgKzc4LDcgQEAgZG91YmxlIEZ1bGxzY3JlZW5Ub3VjaFNlY2hldXJpc3RpYzo6 ZGlzdGFuY2VTY29yZShjb25zdCBDR1BvaW50JiBuZXh0TG9jYXRpb24sIGMKIGRvdWJsZSBGdWxs c2NyZWVuVG91Y2hTZWNoZXVyaXN0aWM6OmF0dGVudWF0aW9uRmFjdG9yKFNlY29uZHMgZGVsdGEp CiB7CiAgICAgZG91YmxlIG5vcm1hbGl6ZWRUaW1lRGVsdGEgPSBkZWx0YSAvIG1fcmFtcERvd25T cGVlZDsKLSAgICByZXR1cm4gbm9ybWFsaXplZFRpbWVEZWx0YSAqIG1fd2VpZ2h0OworICAgIHJl dHVybiBzdGQ6Om1heChzdGQ6Om1pbihub3JtYWxpemVkVGltZURlbHRhICogbV93ZWlnaHQsIDEu MCksIDAuMCk7CiB9CiAKIH0K