186317 2018-06-05 13:11:29 -0700 Web Inspector: Tab picker is briefly visible when TabBar initially shown 2018-06-05 15:41:06 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1430190 0 mattbaker 2018-06-05 13:11:29 -0700 Summary: Tab picker is briefly visible when TabBar initially shown. It is hidden during first view layout, which causes a barely perceptible jerk in the TabBar. Steps to Reproduce: 1. Open Inspector in undocked mode 2. Ensure tab picker (>>) is not visible (close tabs as needed) 3. Hide Inspector 4. Show Inspector => TabBar adds picker button, immediately hides it 1430191 1 341986 mattbaker 2018-06-05 13:13:04 -0700 Created attachment 341986 Patch 1430192 2 webkit-bug-importer 2018-06-05 13:13:30 -0700 <rdar://problem/40820269> 1430244 3 341986 joepeck 2018-06-05 15:13:46 -0700 Comment on attachment 341986 Patch rs=me 1430255 4 341986 commit-queue 2018-06-05 15:41:05 -0700 Comment on attachment 341986 Patch Clearing flags on attachment: 341986 Committed r232524: <https://trac.webkit.org/changeset/232524> 1430256 5 commit-queue 2018-06-05 15:41:06 -0700 All reviewed patches have been landed. Closing bug. 341986 2018-06-05 13:13:04 -0700 2018-06-05 15:41:05 -0700 Patch bug-186317-20180605131304.patch text/plain 1632 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 YmNiNzkzYzk1YWRhY2I1NTlmMzM0YmM4ODkxZWZlMWE4Y2RkN2U1Li5kNzliZjg2MTRmY2Y5NDQ0 M2U2YThmNGNlNWU0Nzk5YzA5YWViMDk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0wNi0wNSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGFiIHBpY2tlciBpcyBicmllZmx5IHZpc2libGUg d2hlbiBUYWJCYXIgaW5pdGlhbGx5IHNob3duCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODYzMTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFyLmpzOgorICAg ICAgICAoV0kuVGFiQmFyKTogUGlja2VyIHNob3VsZCBiZSBpbml0aWFsbHkgaGlkZGVuLgorCiAy MDE4LTA2LTA0ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBDYW5ub3QgY29weSBhIGxpbmsgYWRkcmVzcyBpbiBFbGVtZW50cyB0YWIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Rh YkJhci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJh ci5qcwppbmRleCA0OGU3YzlmYTk1Nzc4ZGEwMDA2MTM4OWEzMGNkZGM1NWE4M2QzNDRiLi45Y2Rk MGE1NWM3MGZlZGRhZmEyZTZhMDZhYTNlZmI5MWM0YTkzNDFlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJCYXIuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFyLmpzCkBAIC00Nyw3ICs0 Nyw3IEBAIFdJLlRhYkJhciA9IGNsYXNzIFRhYkJhciBleHRlbmRzIFdJLlZpZXcKICAgICAgICAg fQogCiAgICAgICAgIHRoaXMuX3RhYlBpY2tlclRhYkJhckl0ZW0gPSBuZXcgV0kuUGlubmVkVGFi QmFySXRlbSgiSW1hZ2VzL1RhYlBpY2tlci5zdmciLCBXSS5VSVN0cmluZygiU2hvdyBoaWRkZW4g dGFicyIpKTsKLSAgICAgICAgdGhpcy5fdGFiUGlja2VyVGFiQmFySXRlbS5lbGVtZW50LmNsYXNz TGlzdC5hZGQoInRhYi1waWNrZXIiKTsKKyAgICAgICAgdGhpcy5fdGFiUGlja2VyVGFiQmFySXRl bS5lbGVtZW50LmNsYXNzTGlzdC5hZGQoInRhYi1waWNrZXIiLCAiaGlkZGVuIik7CiAgICAgICAg IHRoaXMuX3RhYlBpY2tlclRhYkJhckl0ZW0uZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJjb250 ZXh0bWVudSIsIHRoaXMuX2hhbmRsZVRhYlBpY2tlclRhYkNvbnRleHRNZW51LmJpbmQodGhpcykp OwogICAgICAgICB0aGlzLmFkZFRhYkJhckl0ZW0odGhpcy5fdGFiUGlja2VyVGFiQmFySXRlbSwg e3N1cHByZXNzQW5pbWF0aW9uczogdHJ1ZX0pOwogICAgIH0K