186311 2018-06-05 11:10:28 -0700 Web Inspector: Text in "Add New Class" is auto-capitalized 2018-06-05 12:07:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1430144 0 nvasilyev 2018-06-05 11:10:28 -0700 Steps to Reproduce: 1. Open inspector 2. Toggle "Classes" 3. Focus "Add New Class" input 4. Type a lowercase string ("btn") 5. Notice that it auto-capitalizes Expected Results: It would behave like an IDE and not auto-correct or capitalize. Actual Results: It auto-corrects, respects text shortcuts, and silently fails when inputting multiple classes after hitting `space`. <rdar://problem/40705141> 1430146 1 341979 nvasilyev 2018-06-05 11:16:37 -0700 Created attachment 341979 Patch 1430151 2 341979 mattbaker 2018-06-05 11:32:09 -0700 Comment on attachment 341979 Patch rs=me 1430165 3 341979 commit-queue 2018-06-05 12:07:18 -0700 Comment on attachment 341979 Patch Clearing flags on attachment: 341979 Committed r232518: <https://trac.webkit.org/changeset/232518> 1430166 4 commit-queue 2018-06-05 12:07:19 -0700 All reviewed patches have been landed. Closing bug. 341979 2018-06-05 11:16:37 -0700 2018-06-05 12:07:18 -0700 Patch patch.txt text/plain 1752 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDViY2I3OTNjOTVhLi5iYTViMmM1NDcxZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDYtMDUgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogVGV4dCBpbiAiQWRkIE5ldyBDbGFzcyIgaW4gYXV0by1jYXBpdGFsaXplcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2MzExCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGlzYWJsZSBzcGVsbGNoZWNr IHRvIHByZXZlbnQgYXV0by1jYXBpdGFsaXphdGlvbi4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdJ LkdlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLmluaXRpYWxMYXlvdXQp OgorCiAyMDE4LTA2LTA0ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBDYW5ub3QgY29weSBhIGxpbmsgYWRkcmVzcyBpbiBFbGVtZW50 cyB0YWIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0dlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVs LmpzCmluZGV4IGM4YjQ0ZGEzNmY1Li40MDk4N2JiODc3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGVi YXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzCkBAIC0xOTQsNiArMTk0LDcgQEAg V0kuR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIEdlbmVyYWxTdHlsZURl dGFpbHNTaWRlYmFyUGFuZWwgZXh0ZW4KICAgICAgICAgdGhpcy5fYWRkQ2xhc3NDb250YWluZXIu YWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCB0aGlzLl9hZGRDbGFzc0NvbnRhaW5lckNsaWNrZWQu YmluZCh0aGlzKSk7CiAKICAgICAgICAgdGhpcy5fYWRkQ2xhc3NJbnB1dCA9IHRoaXMuX2FkZENs YXNzQ29udGFpbmVyLmNyZWF0ZUNoaWxkKCJpbnB1dCIsICJjbGFzcy1uYW1lLWlucHV0Iik7Cisg ICAgICAgIHRoaXMuX2FkZENsYXNzSW5wdXQuc3BlbGxjaGVjayA9IGZhbHNlOwogICAgICAgICB0 aGlzLl9hZGRDbGFzc0lucHV0LnNldEF0dHJpYnV0ZSgicGxhY2Vob2xkZXIiLCBXSS5VSVN0cmlu ZygiQWRkIE5ldyBDbGFzcyIpKTsKICAgICAgICAgdGhpcy5fYWRkQ2xhc3NJbnB1dC5hZGRFdmVu dExpc3RlbmVyKCJrZXlwcmVzcyIsIHRoaXMuX2FkZENsYXNzSW5wdXRLZXlQcmVzc2VkLmJpbmQo dGhpcykpOwogICAgICAgICB0aGlzLl9hZGRDbGFzc0lucHV0LmFkZEV2ZW50TGlzdGVuZXIoImJs dXIiLCB0aGlzLl9hZGRDbGFzc0lucHV0Qmx1ci5iaW5kKHRoaXMpKTsK