186303 2018-06-04 23:23:41 -0700 [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies aren't flushed to file 2018-06-05 15:09:55 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen beidson cdumez commit-queue ggaren lforschler ryanhaddad sihui_liu webkit-bug-importer oldest_to_newest 1430051 0 sihui_liu 2018-06-04 23:23:41 -0700 Here is the failure output now: TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool /Volumes/Data/slave/ios-simulator-11-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:471 Value of: message.UTF8String Actual: "SessionCookieName=CookieValue" Expected: "PersistentCookieName=CookieValue; SessionCookieName=CookieValue" https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20%28Tests%29/builds/5348/steps/run-api-tests/logs/stdio 1430052 1 sihui_liu 2018-06-04 23:24:23 -0700 <rdar://problem/40468716> 1430053 2 341956 sihui_liu 2018-06-04 23:31:41 -0700 Created attachment 341956 Patch 1430235 3 341956 ggaren 2018-06-05 14:43:38 -0700 Comment on attachment 341956 Patch r=me 1430240 4 341956 commit-queue 2018-06-05 15:09:53 -0700 Comment on attachment 341956 Patch Clearing flags on attachment: 341956 Committed r232522: <https://trac.webkit.org/changeset/232522> 1430241 5 commit-queue 2018-06-05 15:09:55 -0700 All reviewed patches have been landed. Closing bug. 341956 2018-06-04 23:31:41 -0700 2018-06-05 15:09:53 -0700 Patch bug-186303-20180604233140.patch text/plain 3871 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIzZGU1ZGQ3MDk5MTRlZGU0 NWJjMTUzZWU1M2RiNmVkZWYzM2YwM2MuLjRiMjRhMTdlZGJkOGI1YzY0OGU0YTE4OWU4ZTE4ODNj NzA5YjYwNTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDYtMDQgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gVGVzdFdlYktpdEFQSS5X ZWJLaXQuV0tIVFRQQ29va2llU3RvcmVXaXRob3V0UHJvY2Vzc1Bvb2wgZmFpbHMgYmVjYXVzZSBj b29raWVzIGFyZW4ndCBmbHVzaGVkIHRvIGZpbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjMwMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDA0 Njg3MTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbWF0dGVyIHRoZXJlIGlzIGFuIG9ic2VydmVyIG9yIG5vdCwgY29va2llcyBpbiBVSSBwcm9j ZXNzIHNob3VsZCBhbHdheXMgYmUgZmx1c2hlZCB0byAKKyAgICAgICAgZmlsZSB3aGVuIG5ldyBw cm9jZXNzIHBvb2wgaXMgY3JlYXRlZCwgc3VjaCB0aGF0IGNvb2tpZXMgY3JlYXRlZCB2aWEgQVBJ IGNhbiBiZSBzeW5jZWQgdG8KKyAgICAgICAgbmV0d29yayBwcm9jZXNzLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9BUElIVFRQQ29va2llU3RvcmUuY3BwOgorICAgICAgICAoQVBJOjpIVFRQ Q29va2llU3RvcmU6OkhUVFBDb29raWVTdG9yZSk6CisgICAgICAgIChBUEk6OkhUVFBDb29raWVT dG9yZTo6cmVnaXN0ZXJPYnNlcnZlcik6CisgICAgICAgIChBUEk6OkhUVFBDb29raWVTdG9yZTo6 Y29va2llTWFuYWdlckRlc3Ryb3llZCk6CisgICAgICAgIChBUEk6OkhUVFBDb29raWVTdG9yZTo6 cmVnaXN0ZXJGb3JOZXdQcm9jZXNzUG9vbE5vdGlmaWNhdGlvbnMpOgorCiAyMDE4LTA1LTMwICBZ dXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtKU0NdIFBh c3MgVk0mIHBhcmFtZXRlciBhcyBtdWNoIGFzIHBvc3NpYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJSFRUUENvb2tpZVN0b3JlLmNwcCBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9BUElIVFRQQ29va2llU3RvcmUuY3BwCmluZGV4IGVkNWQ3Mzg1OTY0 ZGI4MDcyNjM0M2I3NjczYmEwY2U1YTkxYWZlZTYuLmFkOTIxNTc5MzkyNWI4YWZjMzE5MzM0OGJl YjFjNjI1ZDFmMGY2Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9B UElIVFRQQ29va2llU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9B UElIVFRQQ29va2llU3RvcmUuY3BwCkBAIC00MCw2ICs0MCw4IEBAIG5hbWVzcGFjZSBBUEkgewog SFRUUENvb2tpZVN0b3JlOjpIVFRQQ29va2llU3RvcmUoV2Vic2l0ZURhdGFTdG9yZSYgd2Vic2l0 ZURhdGFTdG9yZSkKICAgICA6IG1fb3duaW5nRGF0YVN0b3JlKHdlYnNpdGVEYXRhU3RvcmUud2Vi c2l0ZURhdGFTdG9yZSgpKQogeworICAgIGlmICghbV9vd25pbmdEYXRhU3RvcmUtPnByb2Nlc3NQ b29sRm9yQ29va2llU3RvcmFnZU9wZXJhdGlvbnMoKSkKKyAgICAgICAgcmVnaXN0ZXJGb3JOZXdQ cm9jZXNzUG9vbE5vdGlmaWNhdGlvbnMoKTsKIH0KIAogSFRUUENvb2tpZVN0b3JlOjp+SFRUUENv b2tpZVN0b3JlKCkKQEAgLTE1MSw3ICsxNTMsNiBAQCB2b2lkIEhUVFBDb29raWVTdG9yZTo6cmVn aXN0ZXJPYnNlcnZlcihPYnNlcnZlciYgb2JzZXJ2ZXIpCiAgICAgYXV0byogcG9vbCA9IG1fb3du aW5nRGF0YVN0b3JlLT5wcm9jZXNzUG9vbEZvckNvb2tpZVN0b3JhZ2VPcGVyYXRpb25zKCk7CiAK ICAgICBpZiAoIXBvb2wpIHsKLSAgICAgICAgcmVnaXN0ZXJGb3JOZXdQcm9jZXNzUG9vbE5vdGlm aWNhdGlvbnMoKTsKICAgICAgICAgQVNTRVJUKCFtX29ic2VydmluZ1VJUHJvY2Vzc0Nvb2tpZXMp OwogCiAgICAgICAgIC8vIExpc3RlbiBmb3IgY29va2llIG5vdGlmaWNhdGlvbnMgaW4gdGhlIFVJ UHJvY2VzcyBpbiB0aGUgbWVhbnRpbWUuCkBAIC0yMDMsMTAgKzIwNCw4IEBAIHZvaWQgSFRUUENv b2tpZVN0b3JlOjpjb29raWVNYW5hZ2VyRGVzdHJveWVkKCkKIAogICAgIGF1dG8qIHBvb2wgPSBt X293bmluZ0RhdGFTdG9yZS0+cHJvY2Vzc1Bvb2xGb3JDb29raWVTdG9yYWdlT3BlcmF0aW9ucygp OwogCi0gICAgaWYgKCFwb29sKSB7Ci0gICAgICAgIHJlZ2lzdGVyRm9yTmV3UHJvY2Vzc1Bvb2xO b3RpZmljYXRpb25zKCk7CisgICAgaWYgKCFwb29sKQogICAgICAgICByZXR1cm47Ci0gICAgfQog CiAgICAgbV9vYnNlcnZlZENvb2tpZU1hbmFnZXJQcm94eSA9IHBvb2wtPnN1cHBsZW1lbnQ8V2Vi S2l0OjpXZWJDb29raWVNYW5hZ2VyUHJveHk+KCk7CiAgICAgbV9vYnNlcnZlZENvb2tpZU1hbmFn ZXJQcm94eS0+cmVnaXN0ZXJPYnNlcnZlcihtX293bmluZ0RhdGFTdG9yZS0+c2Vzc2lvbklEKCks ICptX2Nvb2tpZU1hbmFnZXJQcm94eU9ic2VydmVyKTsKQEAgLTIxNyw4ICsyMTYsNiBAQCB2b2lk IEhUVFBDb29raWVTdG9yZTo6cmVnaXN0ZXJGb3JOZXdQcm9jZXNzUG9vbE5vdGlmaWNhdGlvbnMo KQogICAgIEFTU0VSVCghbV9wcm9jZXNzUG9vbENyZWF0aW9uTGlzdGVuZXJJZGVudGlmaWVyKTsK IAogICAgIG1fcHJvY2Vzc1Bvb2xDcmVhdGlvbkxpc3RlbmVySWRlbnRpZmllciA9IFdlYlByb2Nl c3NQb29sOjpyZWdpc3RlclByb2Nlc3NQb29sQ3JlYXRpb25MaXN0ZW5lcihbdGhpc10oV2ViUHJv Y2Vzc1Bvb2wmIG5ld1Byb2Nlc3NQb29sKSB7Ci0gICAgICAgIEFTU0VSVChtX2Nvb2tpZU1hbmFn ZXJQcm94eU9ic2VydmVyKTsKLQogICAgICAgICBpZiAoIW1fb3duaW5nRGF0YVN0b3JlLT5pc0Fz c29jaWF0ZWRQcm9jZXNzUG9vbChuZXdQcm9jZXNzUG9vbCkpCiAgICAgICAgICAgICByZXR1cm47 CiAKQEAgLTIyNyw5ICsyMjQsMTAgQEAgdm9pZCBIVFRQQ29va2llU3RvcmU6OnJlZ2lzdGVyRm9y TmV3UHJvY2Vzc1Bvb2xOb3RpZmljYXRpb25zKCkKICAgICAgICAgV2ViQ29yZTo6TmV0d29ya1N0 b3JhZ2VTZXNzaW9uOjpkZWZhdWx0U3RvcmFnZVNlc3Npb24oKS5mbHVzaENvb2tpZVN0b3JlKCk7 CiAgICAgICAgIG5ld1Byb2Nlc3NQb29sLmVuc3VyZU5ldHdvcmtQcm9jZXNzKCk7CiAKLQotICAg ICAgICBtX29ic2VydmVkQ29va2llTWFuYWdlclByb3h5ID0gbmV3UHJvY2Vzc1Bvb2wuc3VwcGxl bWVudDxXZWJLaXQ6OldlYkNvb2tpZU1hbmFnZXJQcm94eT4oKTsKLSAgICAgICAgbV9vYnNlcnZl ZENvb2tpZU1hbmFnZXJQcm94eS0+cmVnaXN0ZXJPYnNlcnZlcihtX293bmluZ0RhdGFTdG9yZS0+ c2Vzc2lvbklEKCksICptX2Nvb2tpZU1hbmFnZXJQcm94eU9ic2VydmVyKTsKKyAgICAgICAgaWYg KG1fY29va2llTWFuYWdlclByb3h5T2JzZXJ2ZXIpIHsKKyAgICAgICAgICAgIG1fb2JzZXJ2ZWRD b29raWVNYW5hZ2VyUHJveHkgPSBuZXdQcm9jZXNzUG9vbC5zdXBwbGVtZW50PFdlYktpdDo6V2Vi Q29va2llTWFuYWdlclByb3h5PigpOworICAgICAgICAgICAgbV9vYnNlcnZlZENvb2tpZU1hbmFn ZXJQcm94eS0+cmVnaXN0ZXJPYnNlcnZlcihtX293bmluZ0RhdGFTdG9yZS0+c2Vzc2lvbklEKCks ICptX2Nvb2tpZU1hbmFnZXJQcm94eU9ic2VydmVyKTsKKyAgICAgICAgfQogICAgICAgICB1bnJl Z2lzdGVyRm9yTmV3UHJvY2Vzc1Bvb2xOb3RpZmljYXRpb25zKCk7CiAgICAgfSk7CiB9Cg==