186290 2018-06-04 16:18:30 -0700 Typo in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() 2018-06-04 21:05:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aakash_jain ap ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1429953 0 dbates 2018-06-04 16:18:30 -0700 Although the usefulness of the code in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() is questionable we should fix a typo when calling this mocked function with argument since. 1429954 1 341934 dbates 2018-06-04 16:19:54 -0700 Created attachment 341934 Patch 1430012 2 dbates 2018-06-04 21:04:52 -0700 Committed r232498: <https://trac.webkit.org/changeset/232498> 1430013 3 webkit-bug-importer 2018-06-04 21:05:18 -0700 <rdar://problem/40793226> 341934 2018-06-04 16:19:54 -0700 2018-06-04 16:26:13 -0700 Patch bug-186290-20180604161925.patch text/plain 1756 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyNDgzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmZjNGYzN2E5MTMzOGU0YjdjMTdlMGVmZTU3N2Y4YzY4 ZTM3YTk0Yi4uODQxYzMwZDhkZDFkMzNkZGFkM2ZiOTc0YmYyNTRhY2RhYWZjZjViYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE4LTA2LTA0ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBUeXBvIGluIE1vY2tCdWd6aWxsYVF1ZXJpZXMuZmV0Y2hfYXR0YWNobWVudF9pZHNfZnJv bV9yZXZpZXdfcXVldWUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg2MjkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWx0aG91Z2ggdGhlIHVzZWZ1bG5lc3Mgb2YgdGhlIGNvZGUgaW4gTW9ja0J1Z3pp bGxhUXVlcmllcy5mZXRjaF9hdHRhY2htZW50X2lkc19mcm9tX3Jldmlld19xdWV1ZSgpIGlzCisg ICAgICAgIHF1ZXN0aW9uYWJsZSB3ZSBzaG91bGQgZml4IGEgdHlwbyB3aGVuIGNhbGxpbmcgdGhp cyBtb2NrZWQgZnVuY3Rpb24gd2l0aCBhcmd1bWVudCBzaW5jZS4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYV9tb2NrLnB5OgorICAgICAg ICAoTW9ja0J1Z3ppbGxhUXVlcmllcy5mZXRjaF9hdHRhY2htZW50X2lkc19mcm9tX3Jldmlld19x dWV1ZSk6CisKIDIwMTgtMDYtMDQgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+ CiAKICAgICAgICAgQWRkIE1vamF2ZSBzdXBwb3J0IHRvIFdlYktpdCB0b29scwpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhX21v Y2sucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemls bGFfbW9jay5weQppbmRleCBmZDg4OWNkY2RmN2FiNWM5YzIwMDk4MTYwNGNkYzcwNGU0YjAyMGM1 Li5kMTE3ZmY4ZTNmOGI2YjFkMWE1MWM0MzEyM2MwYTViYTMwMjZhOTdkIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGFfbW9jay5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemls bGFfbW9jay5weQpAQCAtMjk3LDcgKzI5Nyw3IEBAIGNsYXNzIE1vY2tCdWd6aWxsYVF1ZXJpZXMo b2JqZWN0KToKICAgICAgICAgdW5yZXZpZXdlZF9wYXRjaGVzID0gc3VtKFtidWcudW5yZXZpZXdl ZF9wYXRjaGVzKCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgYnVnIGlu IHNlbGYuX2FsbF9idWdzKCldLCBbXSkKICAgICAgICAgaWYgc2luY2U6Ci0gICAgICAgICAgICB1 bnJldmlld2VkX3BhY3RoZXMgPSBbcGF0Y2ggZm9yIHBhdGNoIGluIHVucmV2aWV3ZWRfcGF0Y2hl cworICAgICAgICAgICAgdW5yZXZpZXdlZF9wYXRjaGVzID0gW3BhdGNoIGZvciBwYXRjaCBpbiB1 bnJldmlld2VkX3BhdGNoZXMKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBpZiBwYXRjaC5hdHRhY2hfZGF0ZSgpID49IHNpbmNlXQogICAgICAgICByZXR1cm4gbWFwKGxh bWJkYSBwYXRjaDogcGF0Y2guaWQoKSwgdW5yZXZpZXdlZF9wYXRjaGVzKQogCg==