186289 2018-06-04 16:07:02 -0700 AR Badging on transparent thumbnail images makes the glyph look really dark 2018-06-04 17:09:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino andersca webkit-bug-importer oldest_to_newest 1429947 0 dino 2018-06-04 16:07:02 -0700 AR Badging on transparent thumbnail images makes the glyph look really dark 1429958 1 dino 2018-06-04 16:37:19 -0700 <rdar://problem/40627111> 1429961 2 341936 dino 2018-06-04 16:40:16 -0700 Created attachment 341936 Patch 1429962 3 341936 andersca 2018-06-04 16:42:35 -0700 Comment on attachment 341936 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341936&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:1874 > + // Clip out the circle to only show the shadow Please add a period to the end of the sentence. > Source/WebCore/rendering/RenderThemeIOS.mm:1876 > + CGRect imageRect = static_cast<CGRect>(rect); Can this be CGRect imageRect { rect }; ? 1429972 4 341936 dino 2018-06-04 17:09:13 -0700 Comment on attachment 341936 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341936&action=review >> Source/WebCore/rendering/RenderThemeIOS.mm:1876 >> + CGRect imageRect = static_cast<CGRect>(rect); > > Can this be CGRect imageRect { rect }; ? I didn't even need this. I can just autocast from IntRect. 1429973 5 dino 2018-06-04 17:09:30 -0700 Committed r232487: <https://trac.webkit.org/changeset/232487> 341936 2018-06-04 16:40:16 -0700 2018-06-04 16:42:35 -0700 Patch bug-186289-20180605094015.patch text/plain 6875 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDI2MzE5OGUzNWIxOGJi ZTY2NjE5MGQwNzUyYjY5YTNmZTVkY2QxMy4uYzI5NGU0MmY5NTk4MTI3ZjU1NzMwMjdmNTk3ZTJh MDcyOTdiMWMxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA2LTA0ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBBUiBCYWRnaW5nIG9uIHRyYW5z cGFyZW50IHRodW1ibmFpbCBpbWFnZXMgbWFrZXMgdGhlIGdseXBoIGxvb2sgcmVhbGx5IGRhcmsK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjI4OQor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDA2MjcxMTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xpcCBvdXQgdGhlIHNoYXBlIGZvciB0aGUgZHJv cCBzaGFkb3csIHNvIHRoYXQgaXQgaXNuJ3QgdmlzaWJsZSBpZgorICAgICAgICB0aGVyZSBpcyB0 cmFuc3BhcmVudCBwaXhlbCBkYXRhIG9uIHRvcCBvZiBpdC4KKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJUaGVtZUlPUy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lSU9TOjpw YWludFN5c3RlbVByZXZpZXdCYWRnZSk6CisKIDIwMTgtMDUtMzEgIERlYW4gSmFja3NvbiAgPGRp bm9AYXBwbGUuY29tPgogCiAgICAgICAgIERvbid0IHBhaW50IHRoZSBTeXN0ZW0gUHJldmlldyBi YWRnZSBpZiB0aGUgaW1hZ2UgaXNuJ3QgZnVsbHkgZGVjb2RlZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1tIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1tCmluZGV4IDJlZmJkMGM1ZGJlMDE0MDZmYWFlM2Y2ODZj ZjVhOTIxYTQwYzhkNWMuLjY0MGE2ZjM1OTUxNDJhMDUwZGI1NWJjYjVjYzdiYWVlZjI0Zjc3Yzcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW0KQEAgLTE4NzEs OCArMTg3MSwxNiBAQCB2b2lkIFJlbmRlclRoZW1lSU9TOjpwYWludFN5c3RlbVByZXZpZXdCYWRn ZShJbWFnZSYgaW1hZ2UsIGNvbnN0IFBhaW50SW5mbyYgcGFpbgogICAgIENHQ29udGV4dFNldEZp bGxDb2xvcldpdGhDb2xvcihjdHgsIGNpcmNsZUNvbG9yLmdldCgpKTsKICAgICBDR0NvbnRleHRT ZXRTaGFkb3dXaXRoQ29sb3IoY3R4LCBDR1NpemVaZXJvLCAxNiwgc2hhZG93Q29sb3IuZ2V0KCkp OwogCisgICAgLy8gQ2xpcCBvdXQgdGhlIGNpcmNsZSB0byBvbmx5IHNob3cgdGhlIHNoYWRvdwor ICAgIENHQ29udGV4dEJlZ2luUGF0aChjdHgpOworICAgIENHUmVjdCBpbWFnZVJlY3QgPSBzdGF0 aWNfY2FzdDxDR1JlY3Q+KHJlY3QpOworICAgIENHQ29udGV4dEFkZFJlY3QoY3R4LCBpbWFnZVJl Y3QpOworICAgIENHQ29udGV4dEFkZFBhdGgoY3R4LCBjaXJjbGUuZ2V0KCkpOworICAgIENHQ29u dGV4dENsb3NlUGF0aChjdHgpOworICAgIENHQ29udGV4dEVPQ2xpcChjdHgpOworCiAgICAgLy8g RHJhdyBhIHNsaWdodGx5IHNtYWxsZXIgY2lyY2xlIHdpdGggYSBzaGFkb3csIG90aGVyd2lzZSB3 ZSdsbCBzZWUgYSBmcmluZ2Ugb2YgdGhlIHNvbGlkCi0gICAgLy8gYmxhY2sgY2lyY2xlIGFyb3Vu ZCB0aGUgZWRnZXMgb2YgdGhlIGNsaXBlZCBwYXRoIGJlbG93LgorICAgIC8vIGJsYWNrIGNpcmNs ZSBhcm91bmQgdGhlIGVkZ2VzIG9mIHRoZSBjbGlwcGVkIHBhdGggYmVsb3cuCiAgICAgQ0dDb250 ZXh0QmVnaW5QYXRoKGN0eCk7CiAgICAgQ0dSZWN0IHNsaWdodGx5U21hbGxlckFic29sdXRlQmFk Z2VSZWN0ID0gQ0dSZWN0TWFrZShhYnNvbHV0ZUJhZGdlUmVjdC5vcmlnaW4ueCArIDAuNSwgYWJz b2x1dGVCYWRnZVJlY3Qub3JpZ2luLnkgKyAwLjUsIGJhZGdlRGltZW5zaW9uIC0gMSwgYmFkZ2VE aW1lbnNpb24gLSAxKTsKICAgICBSZXRhaW5QdHI8Q0dQYXRoUmVmPiBzbGlnaHRseVNtYWxsZXJD aXJjbGUgPSBhZG9wdENGKENHUGF0aENyZWF0ZVdpdGhSb3VuZGVkUmVjdChzbGlnaHRseVNtYWxs ZXJBYnNvbHV0ZUJhZGdlUmVjdCwgc2xpZ2h0bHlTbWFsbGVyQWJzb2x1dGVCYWRnZVJlY3Quc2l6 ZS53aWR0aCAvIDIsIHNsaWdodGx5U21hbGxlckFic29sdXRlQmFkZ2VSZWN0LnNpemUuaGVpZ2h0 IC8gMiwgbnVsbHB0cikpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDM3Njg5MzIyNzU1OWYyOTY2YzAzYmQxYjNjNGI5NjZh OTc1OTc0MTguLjI5YThiNWE2NjAzYjNjYzdlZjdmNDFlMGQyZGE1OTZhNTBlYjIwYmEgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNiBAQAorMjAxOC0wNi0wNCAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5j b20+CisKKyAgICAgICAgQVIgQmFkZ2luZyBvbiB0cmFuc3BhcmVudCB0aHVtYm5haWwgaW1hZ2Vz IG1ha2VzIHRoZSBnbHlwaCBsb29rIHJlYWxseSBkYXJrCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODYyODkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzQwNjI3MTExPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFVwZGF0ZSB0aGUgdGVzdCB0byBleGVyY2lzZSBtb3JlIGJhY2tncm91bmQgY29sb3JzLiBJ bmNsdWRlIHRoZSByZXN1bHRzIGZvciB0aGUgQVIgYmFkZ2UuCisKKyAgICAgICAgKiBzeXN0ZW0t cHJldmlldy9iYWRnZS1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBzeXN0ZW0tcHJl dmlldy9iYWRnZS5odG1sOgorCiAyMDE4LTA1LTI5ICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9A YXBwbGUuY29tPgogCiAgICAgICAgIERvbid0IGFzc2VydCBvbiBtX2FjdGlvbnNTdGFydCB3aGVu IHNldHRpbmcgYWN0aW9ucyBvbiBERkEgbm9kZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N5 c3RlbS1wcmV2aWV3L2JhZGdlLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9zeXN0ZW0tcHJl dmlldy9iYWRnZS1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQ0NTRhNzEyNjU1NWMwMTY1OGUw MzA5ODY0NWQzNGY4Yzg1OGVhZDQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zeXN0 ZW0tcHJldmlldy9iYWRnZS1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsNTUgQEAKKzwhRE9DVFlQ RSBodG1sPgorPG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9IndpZHRoPWRldmljZS13aWR0 aCI+Cis8c3R5bGU+CisgICAgYSB7CisgICAgICAgIC13ZWJraXQtY2xpcC1wYXRoOiBwYXRoKCJN IDgyIDE0IEwgODQgMTQgTCA4NCAxNiBMIDgyIDE2IHoiKTsKKyAgICAgICAgdGV4dC1kZWNvcmF0 aW9uOiBub25lOworICAgIH0KKyAgICBpbWcgeworICAgICAgICB3aWR0aDogMTAwcHg7CisgICAg ICAgIGhlaWdodDogMTAwcHg7CisgICAgfQorPC9zdHlsZT4KKzxzY3JpcHQ+Cit3aW5kb3cuYWRk RXZlbnRMaXN0ZW5lcigibG9hZCIsICgpID0+IHsKKyAgICBjb25zdCBjYW52YXMgPSBkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCJjYW52YXMiKTsKKyAgICBjYW52YXMud2lkdGggPSAxMDsKKyAgICBj YW52YXMuaGVpZ2h0ID0gMTA7CisgICAgY29uc3QgY3R4ID0gY2FudmFzLmdldENvbnRleHQoIjJk Iik7CisgICAgY29uc3QgaW1hZ2VzID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgiaW1nIik7 CisgICAgaW1hZ2VzLmZvckVhY2goaW1hZ2UgPT4geworICAgICAgICBjdHguY2xlYXJSZWN0KDAs IDAsIDEwLCAxMCk7CisgICAgICAgIGNvbnN0IGNvbG9yID0gaW1hZ2UuZ2V0QXR0cmlidXRlKCJk YXRhLWNvbG9yIik7CisgICAgICAgIGN0eC5maWxsU3R5bGUgPSBjb2xvcjsKKyAgICAgICAgY3R4 LmZpbGxSZWN0KDAsIDAsIDEwLCAxMCk7CisgICAgICAgIGltYWdlLnNyYyA9IGNhbnZhcy50b0Rh dGFVUkwoKTsKKyAgICB9KTsKK30sIGZhbHNlKTsKKzwvc2NyaXB0PgorPGEgaHJlZj0iLyI+Cisg ICAgPGltZyBkYXRhLWNvbG9yPSJyZ2IoMjU1LCA1NywgNTcpIj4KKzwvYT4KKzxhIGhyZWY9Ii8i PgorICAgIDxpbWcgZGF0YS1jb2xvcj0icmdiKDgwLCAxNjksIDc5KSI+Cis8L2E+Cis8YSBocmVm PSIvIj4KKyAgICA8aW1nIGRhdGEtY29sb3I9InJnYigxMDIsIDEwMiwgMjU1KSI+Cis8L2E+Cis8 YSBocmVmPSIvIj4KKyAgICA8aW1nIGRhdGEtY29sb3I9InJnYigwLCAyNTUsIDI1NSkiPgorPC9h PgorPGEgaHJlZj0iLyI+CisgICAgPGltZyBkYXRhLWNvbG9yPSJyZ2IoMTU2LCAxNTYsIDE1Niki PgorPC9hPgorPGEgaHJlZj0iLyI+CisgICAgPGltZyBkYXRhLWNvbG9yPSJyZ2IoMjU1LCAxNzYs IDEwNSkiPgorPC9hPgorPGEgaHJlZj0iLyI+CisgICAgPGltZyBkYXRhLWNvbG9yPSJ3aGl0ZSI+ Cis8L2E+Cis8YSBocmVmPSIvIj4KKyAgICA8aW1nIGRhdGEtY29sb3I9InJnYigxMTgsIDExOCwg MTE4KSI+Cis8L2E+Cis8YSBocmVmPSIvIj4KKyAgICA8aW1nIGRhdGEtY29sb3I9InJnYmEoMCwg MCwgMCwgMC4wKSI+Cis8L2E+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zeXN0ZW0tcHJldmll dy9iYWRnZS5odG1sIGIvTGF5b3V0VGVzdHMvc3lzdGVtLXByZXZpZXcvYmFkZ2UuaHRtbAppbmRl eCBiMWMzOGQyNTcwYTU1NDY1NDc3ZTg5YzBiODllN2YwODE4OGQxZWZkLi5lMTYyMGMwNzg0YjVi ODVkNjU2ZjZhZDk1MzEyOGI1NTY5ZTQ0NWUzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zeXN0 ZW0tcHJldmlldy9iYWRnZS5odG1sCisrKyBiL0xheW91dFRlc3RzL3N5c3RlbS1wcmV2aWV3L2Jh ZGdlLmh0bWwKQEAgLTEsNyArMSw5IEBACiA8IURPQ1RZUEUgaHRtbD4KKzxtZXRhIG5hbWU9InZp ZXdwb3J0IiBjb250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgiPgogPHN0eWxlPgogICAgIGEgewot ICAgICAgICAtd2Via2l0LWNsaXAtcGF0aDogcGF0aCgiTSA4MiAxNCBMIDg2IDE0IEwgODYgMTgg TCA4MiAxOCB6Iik7CisgICAgICAgIC13ZWJraXQtY2xpcC1wYXRoOiBwYXRoKCJNIDgyIDE0IEwg ODQgMTQgTCA4NCAxNiBMIDgyIDE2IHoiKTsKKyAgICAgICAgdGV4dC1kZWNvcmF0aW9uOiBub25l OwogICAgIH0KICAgICBpbWcgewogICAgICAgICB3aWR0aDogMTAwcHg7CkBAIC0xMCwxNCArMTIs NDQgQEAKIDwvc3R5bGU+CiA8c2NyaXB0Pgogd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQi LCAoKSA9PiB7Ci0gICAgaWYgKCF3aW5kb3cuaW50ZXJuYWxzKQotICAgICAgICByZXR1cm47Ci0K LSAgICBjb25zdCBsaW5rID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigiYSIpOwotICAgIGxpbmsu cmVsID0gaW50ZXJuYWxzLnN5c3RlbVByZXZpZXdSZWxUeXBlKCk7CisgICAgY29uc3QgY2FudmFz ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiY2FudmFzIik7CisgICAgY2FudmFzLndpZHRoID0g MTA7CisgICAgY2FudmFzLmhlaWdodCA9IDEwOworICAgIGNvbnN0IGN0eCA9IGNhbnZhcy5nZXRD b250ZXh0KCIyZCIpOworICAgIGNvbnN0IGltYWdlcyA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JB bGwoImltZyIpOworICAgIGltYWdlcy5mb3JFYWNoKGltYWdlID0+IHsKKyAgICAgICAgY3R4LmNs ZWFyUmVjdCgwLCAwLCAxMCwgMTApOworICAgICAgICBjb25zdCBjb2xvciA9IGltYWdlLmdldEF0 dHJpYnV0ZSgiZGF0YS1jb2xvciIpOworICAgICAgICBjdHguZmlsbFN0eWxlID0gY29sb3I7Cisg ICAgICAgIGN0eC5maWxsUmVjdCgwLCAwLCAxMCwgMTApOworICAgICAgICBpbWFnZS5zcmMgPSBj YW52YXMudG9EYXRhVVJMKCk7CisgICAgfSk7CiB9LCBmYWxzZSk7CiA8L3NjcmlwdD4KLTxwPlRo aXMgdGVzdCBvbmx5IHdvcmtzIGluIFdLVFIgb3IgRFJULjwvcD4KLTxhIGhyZWY9Ii8iPgotICAg IDxpbWcgc3JjPSJkYXRhOmltYWdlL3BuZztiYXNlNjQsaVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FB QUFFQUFBQUJBUU1BQUFBbDIxYktBQUFBQmxCTVZFVUFBUDhBQUFCN1lyOCtBQUFBRUVsRVFWUjRu R0pnQlFBQUFQLy9Bd0FBQndBR3pIS3JKZ0FBQUFCSlJVNUVya0pnZ2c9PSI+Cis8YSBocmVmPSIv IiByZWw9ImFyIj4KKyAgICA8aW1nIGRhdGEtY29sb3I9InJlZCI+Cis8L2E+Cis8YSBocmVmPSIv IiByZWw9ImFyIj4KKyAgICA8aW1nIGRhdGEtY29sb3I9ImdyZWVuIj4KKzwvYT4KKzxhIGhyZWY9 Ii8iIHJlbD0iYXIiPgorICAgIDxpbWcgZGF0YS1jb2xvcj0iYmx1ZSI+Cis8L2E+Cis8YSBocmVm PSIvIiByZWw9ImFyIj4KKyAgICA8aW1nIGRhdGEtY29sb3I9ImN5YW4iPgorPC9hPgorPGEgaHJl Zj0iLyIgcmVsPSJhciI+CisgICAgPGltZyBkYXRhLWNvbG9yPSIjNzc3Nzc3Ij4KKzwvYT4KKzxh IGhyZWY9Ii8iIHJlbD0iYXIiPgorICAgIDxpbWcgZGF0YS1jb2xvcj0icmdiYSgyNTUsIDEyOCwg MCwgMC41KSI+Cis8L2E+Cis8YSBocmVmPSIvIiByZWw9ImFyIj4KKyAgICA8aW1nIGRhdGEtY29s b3I9IndoaXRlIj4KKzwvYT4KKzxhIGhyZWY9Ii8iIHJlbD0iYXIiPgorICAgIDxpbWcgZGF0YS1j b2xvcj0iYmxhY2siPgorPC9hPgorPGEgaHJlZj0iLyIgcmVsPSJhciI+CisgICAgPGltZyBkYXRh LWNvbG9yPSJyZ2JhKDAsIDAsIDAsIDAuMCkiPgogPC9hPgo=