186277 2018-06-04 12:42:50 -0700 JSLock should clear last exception when releasing the lock 2018-06-11 18:58:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam simon.fraser webkit-bug-importer oldest_to_newest 1429864 0 keith_miller 2018-06-04 12:42:50 -0700 JSLock should clear last exception when releasing the lock 1429865 1 341909 keith_miller 2018-06-04 12:44:18 -0700 Created attachment 341909 Patch 1429877 2 341909 mark.lam 2018-06-04 13:25:50 -0700 Comment on attachment 341909 Patch r=me 1429878 3 341909 mark.lam 2018-06-04 13:27:01 -0700 Comment on attachment 341909 Patch Wait a minute. What happens when we have a ReleaseAllLocks situation and want to GrabAllLocks again later? 1429879 4 mark.lam 2018-06-04 13:29:29 -0700 (In reply to Mark Lam from comment #3) > Comment on attachment 341909 [details] > Patch > > Wait a minute. What happens when we have a ReleaseAllLocks situation and > want to GrabAllLocks again later? How about clearing lastException on unlocking JSLock only when vm.topCallFrame is null? 1429897 5 keith_miller 2018-06-04 14:16:07 -0700 (In reply to Mark Lam from comment #3) > Comment on attachment 341909 [details] > Patch > > Wait a minute. What happens when we have a ReleaseAllLocks situation and > want to GrabAllLocks again later? DropAllLocks doesn't call willReleaseLock()... So it will have the some behavior it has now. willReleaseLock is only called from JSLock::unlock and only if the lock count is going to go to zero. 1429906 6 341919 keith_miller 2018-06-04 14:37:42 -0700 Created attachment 341919 Patch 1429907 7 keith_miller 2018-06-04 14:39:02 -0700 Nvm, you're right, we should only drop the last exception if we don't have a top call frame. 1429910 8 keith_miller 2018-06-04 14:45:54 -0700 *** Bug 186221 has been marked as a duplicate of this bug. *** 1429911 9 341919 mark.lam 2018-06-04 14:46:40 -0700 Comment on attachment 341919 Patch r=me 1429915 10 keith_miller 2018-06-04 14:51:15 -0700 Committed r232482: <https://trac.webkit.org/changeset/232482> 1429917 11 webkit-bug-importer 2018-06-04 14:52:21 -0700 <rdar://problem/40782080> 1432170 12 341919 saam 2018-06-11 18:58:38 -0700 Comment on attachment 341919 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341919&action=review > Source/JavaScriptCore/runtime/JSLock.cpp:203 > + if (!vm->topCallFrame) > + vm->clearLastException(); Don't we really just want this in ~VMEntryScope? Don't we drop locks and regrab them in interesting places. I feel like you're guarding against this with "!vm->topCallFrame", but that's exactly what ~VMEntryScope gives you. 341909 2018-06-04 12:44:18 -0700 2018-06-04 14:37:41 -0700 Patch bug-186277-20180604124417.patch text/plain 1394 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NTUxNDU5ZTFhNjRlMzJmYTc0YjdkZmJhYzMxNzQxZjMyNTQ5MDQ4Li4xYzQ2YmU1MzNhMDY5ZDQ1 MjMzZjllODdhN2Y0ZDQxNGFiMjU3Mjc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wNi0wNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBKU0xvY2sgc2hvdWxkIGNsZWFyIGxhc3QgZXhjZXB0aW9uIHdoZW4g cmVsZWFzaW5nIHRoZSBsb2NrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODYyNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJZiB3ZSBkb24ndCBjbGVhciB0aGUgbGFzdCBleGNlcHRpb24gd2UgZXNzZW50 aWFsbHkgbGVhayB0aGUKKyAgICAgICAgb2JqZWN0IGFuZCBldmVyeXRoaW5nIHJlZmVyZW5jZWQg YnkgaXQgdW50aWwgYW5vdGhlciBleGNlcHRpb24gaXMKKyAgICAgICAgdGhyb3duLgorCisgICAg ICAgICogcnVudGltZS9KU0xvY2suY3BwOgorICAgICAgICAoSlNDOjpKU0xvY2s6OndpbGxSZWxl YXNlTG9jayk6CisKIDIwMTgtMDUtMzAgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFp bC5jb20+CiAKICAgICAgICAgW0pTQ10gUGFzcyBWTSYgcGFyYW1ldGVyIGFzIG11Y2ggYXMgcG9z c2libGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTTG9jay5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0xvY2suY3BwCmluZGV4IGRmYjc1 YTdkMDFmYzI2NWRiODBhNzZiYmUzODhiMGYwYWQ3YTZkY2EuLmZhMDEzNDlhYzVjNTllYWRiZjBk MmQ1MDM3MzY3NjEyM2NkZTc1ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTTG9jay5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNM b2NrLmNwcApAQCAtMTk5LDYgKzE5OSw4IEBAIHZvaWQgSlNMb2NrOjp3aWxsUmVsZWFzZUxvY2so KQogICAgIGlmICh2bSkgewogICAgICAgICB2bS0+ZHJhaW5NaWNyb3Rhc2tzKCk7CiAKKyAgICAg ICAgdm0tPmNsZWFyTGFzdEV4Y2VwdGlvbigpOworCiAgICAgICAgIHZtLT5oZWFwLnJlbGVhc2VE ZWxheWVkUmVsZWFzZWRPYmplY3RzKCk7CiAgICAgICAgIHZtLT5zZXRTdGFja1BvaW50ZXJBdFZN RW50cnkobnVsbHB0cik7CiAgICAgICAgIAo= 341919 2018-06-04 14:37:42 -0700 2018-06-04 14:46:40 -0700 Patch bug-186277-20180604143742.patch text/plain 1430 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NTUxNDU5ZTFhNjRlMzJmYTc0YjdkZmJhYzMxNzQxZjMyNTQ5MDQ4Li4xYzQ2YmU1MzNhMDY5ZDQ1 MjMzZjllODdhN2Y0ZDQxNGFiMjU3Mjc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wNi0wNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBKU0xvY2sgc2hvdWxkIGNsZWFyIGxhc3QgZXhjZXB0aW9uIHdoZW4g cmVsZWFzaW5nIHRoZSBsb2NrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODYyNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJZiB3ZSBkb24ndCBjbGVhciB0aGUgbGFzdCBleGNlcHRpb24gd2UgZXNzZW50 aWFsbHkgbGVhayB0aGUKKyAgICAgICAgb2JqZWN0IGFuZCBldmVyeXRoaW5nIHJlZmVyZW5jZWQg YnkgaXQgdW50aWwgYW5vdGhlciBleGNlcHRpb24gaXMKKyAgICAgICAgdGhyb3duLgorCisgICAg ICAgICogcnVudGltZS9KU0xvY2suY3BwOgorICAgICAgICAoSlNDOjpKU0xvY2s6OndpbGxSZWxl YXNlTG9jayk6CisKIDIwMTgtMDUtMzAgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFp bC5jb20+CiAKICAgICAgICAgW0pTQ10gUGFzcyBWTSYgcGFyYW1ldGVyIGFzIG11Y2ggYXMgcG9z c2libGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTTG9jay5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0xvY2suY3BwCmluZGV4IGRmYjc1 YTdkMDFmYzI2NWRiODBhNzZiYmUzODhiMGYwYWQ3YTZkY2EuLjUxZDE4NzBmYTJjZTZkYTk1NTM5 NGY4ODQwMzA3MzVkZTY3MjhhNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTTG9jay5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNM b2NrLmNwcApAQCAtMTk5LDYgKzE5OSw5IEBAIHZvaWQgSlNMb2NrOjp3aWxsUmVsZWFzZUxvY2so KQogICAgIGlmICh2bSkgewogICAgICAgICB2bS0+ZHJhaW5NaWNyb3Rhc2tzKCk7CiAKKyAgICAg ICAgaWYgKCF2bS0+dG9wQ2FsbEZyYW1lKQorICAgICAgICAgICAgdm0tPmNsZWFyTGFzdEV4Y2Vw dGlvbigpOworCiAgICAgICAgIHZtLT5oZWFwLnJlbGVhc2VEZWxheWVkUmVsZWFzZWRPYmplY3Rz KCk7CiAgICAgICAgIHZtLT5zZXRTdGFja1BvaW50ZXJBdFZNRW50cnkobnVsbHB0cik7CiAgICAg ICAgIAo=