186264 2018-06-04 03:36:39 -0700 [WPE] WebDriver: stop making mandatory to provide a browser path if wpe:browserOptions is present in capabilities 2018-06-04 22:40:20 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180012 InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg webkit-bug-importer zan oldest_to_newest 1429793 0 cgarcia 2018-06-04 03:36:39 -0700 We fixed this in GTK, but in WPE see bug #180012. 1429794 1 341899 cgarcia 2018-06-04 03:40:18 -0700 Created attachment 341899 Patch 1430039 2 cgarcia 2018-06-04 22:39:07 -0700 Committed r232504: <https://trac.webkit.org/changeset/232504> 1430041 3 webkit-bug-importer 2018-06-04 22:40:20 -0700 <rdar://problem/40795244> 341899 2018-06-04 03:40:18 -0700 2018-06-04 04:05:42 -0700 Patch wpe-wd-capabilities.diff text/plain 2829 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggMmYyOTUzMzlmYmYuLjJiZTVkNWYzNDMxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA2LTA0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBXZWJEcml2ZXI6IHN0b3AgbWFraW5n IG1hbmRhdG9yeSB0byBwcm92aWRlIGEgYnJvd3NlciBwYXRoIGlmIHdlYmtpdGd0azpicm93c2Vy T3B0aW9ucyBpcyBwcmVzZW50IGluIGNhcGFiaWxpdGllcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2MjY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXZlcnl0aGluZyBzaG91bGQgYmUgb3B0aW9uYWwu IERvIG5vdCBjb25zaWRlciBpbnZhbGlkIHRvIG5vdCBwcm92aWRlIGEgYnJvd3NlciBiaW5hcnkg d2hlbiB3cGU6YnJvd3Nlck9wdGlvbnMKKyAgICAgICAgaXMgcHJlc2VudC4KKworICAgICAgICAq IHdwZS9XZWJEcml2ZXJTZXJ2aWNlV1BFLmNwcDoKKyAgICAgICAgKFdlYkRyaXZlcjo6V2ViRHJp dmVyU2VydmljZTo6cGxhdGZvcm1QYXJzZUNhcGFiaWxpdGllcyBjb25zdCk6CisKIDIwMTgtMDUt MjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFdlYkRyaXZlcjogaW1wbGVtZW50IG1heGltaXplLCBtaW5pbWl6ZSBhbmQgZnVsbHNjcmVlbiB3 aW5kb3cgY29tbWFuZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvd3BlL1dlYkRyaXZl clNlcnZpY2VXUEUuY3BwIGIvU291cmNlL1dlYkRyaXZlci93cGUvV2ViRHJpdmVyU2VydmljZVdQ RS5jcHAKaW5kZXggNTIzZThlNzcyNmEuLjBhYWFjM2RmZmEwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViRHJpdmVyL3dwZS9XZWJEcml2ZXJTZXJ2aWNlV1BFLmNwcAorKysgYi9Tb3VyY2UvV2ViRHJp dmVyL3dwZS9XZWJEcml2ZXJTZXJ2aWNlV1BFLmNwcApAQCAtODEsMjIgKzgxLDIxIEBAIGJvb2wg V2ViRHJpdmVyU2VydmljZTo6cGxhdGZvcm1NYXRjaENhcGFiaWxpdHkoY29uc3QgU3RyaW5nJiwg Y29uc3QgUmVmUHRyPEpTT046CiAKIHZvaWQgV2ViRHJpdmVyU2VydmljZTo6cGxhdGZvcm1QYXJz ZUNhcGFiaWxpdGllcyhjb25zdCBKU09OOjpPYmplY3QmIG1hdGNoZWRDYXBhYmlsaXRpZXMsIENh cGFiaWxpdGllcyYgY2FwYWJpbGl0aWVzKSBjb25zdAogeworICAgIGNhcGFiaWxpdGllcy5icm93 c2VyQmluYXJ5ID0gU3RyaW5nKCJkeXoiKTsKKyAgICBjYXBhYmlsaXRpZXMuYnJvd3NlckFyZ3Vt ZW50cyA9IFZlY3RvcjxTdHJpbmc+IHsgQVNDSUlMaXRlcmFsKCItLWF1dG9tYXRpb24iKSB9Owor CiAgICAgUmVmUHRyPEpTT046Ok9iamVjdD4gYnJvd3Nlck9wdGlvbnM7Ci0gICAgaWYgKCFtYXRj aGVkQ2FwYWJpbGl0aWVzLmdldE9iamVjdChBU0NJSUxpdGVyYWwoIndwZTpicm93c2VyT3B0aW9u cyIpLCBicm93c2VyT3B0aW9ucykpIHsKLSAgICAgICAgY2FwYWJpbGl0aWVzLmJyb3dzZXJCaW5h cnkgPSBTdHJpbmcoImR5eiIpOwotICAgICAgICBjYXBhYmlsaXRpZXMuYnJvd3NlckFyZ3VtZW50 cyA9IFZlY3RvcjxTdHJpbmc+IHsgQVNDSUlMaXRlcmFsKCItLWF1dG9tYXRpb24iKSB9OworICAg IGlmICghbWF0Y2hlZENhcGFiaWxpdGllcy5nZXRPYmplY3QoQVNDSUlMaXRlcmFsKCJ3cGU6YnJv d3Nlck9wdGlvbnMiKSwgYnJvd3Nlck9wdGlvbnMpKQogICAgICAgICByZXR1cm47Ci0gICAgfQog CiAgICAgU3RyaW5nIGJyb3dzZXJCaW5hcnk7Ci0gICAgYnJvd3Nlck9wdGlvbnMtPmdldFN0cmlu ZyhBU0NJSUxpdGVyYWwoImJpbmFyeSIpLCBicm93c2VyQmluYXJ5KTsKLSAgICBBU1NFUlQoIWJy b3dzZXJCaW5hcnkuaXNOdWxsKCkpOwotICAgIGNhcGFiaWxpdGllcy5icm93c2VyQmluYXJ5ID0g YnJvd3NlckJpbmFyeTsKKyAgICBpZiAoYnJvd3Nlck9wdGlvbnMtPmdldFN0cmluZyhBU0NJSUxp dGVyYWwoImJpbmFyeSIpLCBicm93c2VyQmluYXJ5KSkKKyAgICAgICAgY2FwYWJpbGl0aWVzLmJy b3dzZXJCaW5hcnkgPSBicm93c2VyQmluYXJ5OwogCi0gICAgY2FwYWJpbGl0aWVzLmJyb3dzZXJB cmd1bWVudHMgPSBWZWN0b3I8U3RyaW5nPigpOwogICAgIFJlZlB0cjxKU09OOjpBcnJheT4gYnJv d3NlckFyZ3VtZW50czsKLSAgICBpZiAoYnJvd3Nlck9wdGlvbnMtPmdldEFycmF5KEFTQ0lJTGl0 ZXJhbCgiYXJncyIpLCBicm93c2VyQXJndW1lbnRzKSkgeworICAgIGlmIChicm93c2VyT3B0aW9u cy0+Z2V0QXJyYXkoQVNDSUlMaXRlcmFsKCJhcmdzIiksIGJyb3dzZXJBcmd1bWVudHMpICYmIGJy b3dzZXJBcmd1bWVudHMtPmxlbmd0aCgpKSB7CiAgICAgICAgIHVuc2lnbmVkIGJyb3dzZXJBcmd1 bWVudHNMZW5ndGggPSBicm93c2VyQXJndW1lbnRzLT5sZW5ndGgoKTsKKyAgICAgICAgY2FwYWJp bGl0aWVzLmJyb3dzZXJBcmd1bWVudHMgPSBWZWN0b3I8U3RyaW5nPigpOwogICAgICAgICBjYXBh YmlsaXRpZXMuYnJvd3NlckFyZ3VtZW50cy0+cmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShicm93c2Vy QXJndW1lbnRzTGVuZ3RoKTsKICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGJyb3dz ZXJBcmd1bWVudHNMZW5ndGg7ICsraSkgewogICAgICAgICAgICAgUmVmUHRyPEpTT046OlZhbHVl PiB2YWx1ZSA9IGJyb3dzZXJBcmd1bWVudHMtPmdldChpKTsK