186237 2018-06-02 10:31:09 -0700 FunctionRareData::m_objectAllocationProfileWatchpoint is racy 2018-06-07 14:02:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 164904 1 fpizlo fpizlo ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1429572 0 fpizlo 2018-06-02 10:31:09 -0700 We initialize it blind and let it go into auto-watch mode once the DFG adds a watchpoint, but that means that we never notice that it fired if it fires between when the DFG decides to watch it and when it actually adds the watchpoint. 1429573 1 341847 fpizlo 2018-06-02 10:34:05 -0700 Created attachment 341847 the patch 1431012 2 fpizlo 2018-06-07 14:01:34 -0700 Landed in https://trac.webkit.org/changeset/232598/webkit 1431013 3 webkit-bug-importer 2018-06-07 14:02:24 -0700 <rdar://problem/40909445> 341847 2018-06-02 10:34:05 -0700 2018-06-02 11:56:05 -0700 the patch blah.patch text/plain 3616 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMyNDM5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBA CisyMDE4LTA2LTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RnVuY3Rpb25SYXJlRGF0YTo6bV9vYmplY3RBbGxvY2F0aW9uUHJvZmlsZVdhdGNocG9pbnQgaXMg cmFjeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2 MjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug aW5pdGlhbGl6ZSBpdCBibGluZCBhbmQgbGV0IGl0IGdvIGludG8gYXV0by13YXRjaCBtb2RlIG9u Y2UgdGhlIERGRyBhZGRzIGEgd2F0Y2hwb2ludCwgYnV0CisgICAgICAgIHRoYXQgbWVhbnMgdGhh dCB3ZSBuZXZlciBub3RpY2UgdGhhdCBpdCBmaXJlZCBpZiBpdCBmaXJlcyBiZXR3ZWVuIHdoZW4g dGhlIERGRyBkZWNpZGVzIHRvCisgICAgICAgIHdhdGNoIGl0IGFuZCB3aGVuIGl0IGFjdHVhbGx5 IGFkZHMgdGhlIHdhdGNocG9pbnQuCisgICAgICAgIAorICAgICAgICBNb3N0IHdhdGNocG9pbnRz IGFyZSBpbml0aWFsaXplZCB3YXRjaGVkIGZvciB0aGlzIHB1cnBvc2UuIFRoaXMgb25lIGhhZCBh IHNvbWV3aGF0IGdvb2QKKyAgICAgICAgcmVhc29uIGZvciBiZWluZyBpbml0aWFsaXplZCBibGlu ZDogdGhhdCdzIGhvdyB3ZSBrbmV3IHRvIGlnbm9yZSBjaGFuZ2VzIHRvIHRoZSBwcm90b3R5cGUK KyAgICAgICAgYmVmb3JlIHRoZSBmaXJzdCBhbGxvY2F0aW9uLiBIb3dldmVyLCB0aGF0IGZ1bmN0 aW9uYWxpdHkgYWxzbyBhcm9zZSBvdXQgb2YgdGhlIGZhY3QgdGhhdCB0aGUKKyAgICAgICAgcmFy ZSBkYXRhIGlzIGNyZWF0ZWQgbGF6aWx5IGFuZCB1c3VhbGx5IHdvbid0IGV4aXN0IHVudGlsIHRo ZSBmaXJzdCBhbGxvY2F0aW9uLgorICAgICAgICAKKyAgICAgICAgVGhlIGZpeCBoZXJlIGlzIHRv IG1ha2UgdGhlIHdhdGNocG9pbnQgZ28gaW50byB3YXRjaGVkIG1vZGUgYXMgc29vbiBhcyB3ZSBp bml0aWFsaXplIHRoZQorICAgICAgICBvYmplY3QgYWxsb2NhdGlvbiBwcm9maWxlLgorICAgICAg ICAKKyAgICAgICAgSXQncyBoYXJkIHRvIHJlcHJvIHRoaXMgcmFjZSwgaG93ZXZlciBpdCBzdGFy dGVkIGNhdXNpbmcgc3B1cmlvdXMgdGVzdCBmYWlsdXJlcyBmb3IgbWUgYWZ0ZXIKKyAgICAgICAg YnVnIDE2NDkwNC4KKworICAgICAgICAqIHJ1bnRpbWUvRnVuY3Rpb25SYXJlRGF0YS5jcHA6Cisg ICAgICAgIChKU0M6OkZ1bmN0aW9uUmFyZURhdGE6OkZ1bmN0aW9uUmFyZURhdGEpOgorICAgICAg ICAoSlNDOjpGdW5jdGlvblJhcmVEYXRhOjppbml0aWFsaXplT2JqZWN0QWxsb2NhdGlvblByb2Zp bGUpOgorCiAyMDE4LTA2LTAyICBDYWlvIExpbWEgIDx0aWNhaW9saW1hQGdtYWlsLmNvbT4KIAog ICAgICAgICBbRVNOZXh0XVtCaWdJbnRdIEltcGxlbWVudCBzdXBwb3J0IGZvciBhZGRpdGlvbiBv cGVyYXRpb25zCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9GdW5jdGlvblJh cmVEYXRhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9G dW5jdGlvblJhcmVEYXRhLmNwcAkocmV2aXNpb24gMjMyMjI3KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvRnVuY3Rpb25SYXJlRGF0YS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY0 LDE0ICs2NCw4IEBAIEZ1bmN0aW9uUmFyZURhdGE6OkZ1bmN0aW9uUmFyZURhdGEoVk0mIHYKICAg ICA6IEJhc2Uodm0sIHZtLmZ1bmN0aW9uUmFyZURhdGFTdHJ1Y3R1cmUuZ2V0KCkpCiAgICAgLCBt X29iamVjdEFsbG9jYXRpb25Qcm9maWxlKCkKICAgICAvLyBXZSBpbml0aWFsaXplIGJsaW5kIHNv IHRoYXQgY2hhbmdlcyB0byB0aGUgcHJvdG90eXBlIGFmdGVyIGZ1bmN0aW9uIGNyZWF0aW9uIGJ1 dCBiZWZvcmUKLSAgICAvLyB0aGUgb3B0aW1pemVyIGtpY2tzIGluIGRvbid0IGRpc2FibGUgb3B0 aW1pemF0aW9ucy4gT25jZSB0aGUgb3B0aW1pemVyIGtpY2tzIGluLCB0aGUKLSAgICAvLyB3YXRj aHBvaW50IHdpbGwgc3RhcnQgd2F0Y2hpbmcgYW5kIGFueSBjaGFuZ2VzIHdpbGwgYm90aCBmb3Jj ZSBkZW9wdGltaXphdGlvbiBhbmQgZGlzYWJsZQotICAgIC8vIGZ1dHVyZSBhdHRlbXB0cyB0byBv cHRpbWl6ZS4gVGhpcyBpcyBuZWNlc3NhcnkgYmVjYXVzZSB3ZSBhcmUgZ3VhcmFudGVlZCB0aGF0 IHRoZQotICAgIC8vIGFsbG9jYXRpb24gcHJvZmlsZSBpcyBjaGFuZ2VkIGV4YWN0bHkgb25jZSBw cmlvciB0byBvcHRpbWl6YXRpb25zIGtpY2tpbmcgaW4uIFdlIGNvdWxkIGJlCi0gICAgLy8gc21h cnRlciBhbmQgY291bnQgdGhlIG51bWJlciBvZiB0aW1lcyB0aGUgcHJvdG90eXBlIGlzIGNsb2Ji ZXJlZCBhbmQgb25seSBvcHRpbWl6ZSBpZiBpdAotICAgIC8vIHdhcyBjbG9iYmVyZWQgZXhhY3Rs eSBvbmNlLCBidXQgdGhhdCBzZWVtcyBsaWtlIG92ZXJraWxsLiBJbiBhbG1vc3QgYWxsIGNhc2Vz IGl0IHdpbGwgYmUKLSAgICAvLyBjbG9iYmVyZWQgb25jZSwgYW5kIGlmIGl0J3MgY2xvYmJlcmVk IG1vcmUgdGhhbiBvbmNlLCB0aGF0IHdpbGwgcHJvYmFibHkgb25seSBvY2N1cgotICAgIC8vIGJl Zm9yZSB3ZSBzdGFydGVkIG9wdGltaXppbmcsIGFueXdheS4KKyAgICAvLyB0aGUgZmlyc3QgYWxs b2NhdGlvbiBkb24ndCBkaXNhYmxlIG9wdGltaXphdGlvbnMuIFRoaXMgaXNuJ3Qgc3VwZXIgaW1w b3J0YW50LCBzaW5jZSB0aGUKKyAgICAvLyBmdW5jdGlvbiBpcyB1bmxpa2VseSB0byBhbGxvY2F0 ZSBhIHJhcmUgZGF0YSB1bnRpbCB0aGUgZmlyc3QgYWxsb2NhdGlvbiBhbnl3YXkuCiAgICAgLCBt X29iamVjdEFsbG9jYXRpb25Qcm9maWxlV2F0Y2hwb2ludChDbGVhcldhdGNocG9pbnQpCiB7CiB9 CkBAIC04Miw2ICs3Niw5IEBAIEZ1bmN0aW9uUmFyZURhdGE6On5GdW5jdGlvblJhcmVEYXRhKCkK IAogdm9pZCBGdW5jdGlvblJhcmVEYXRhOjppbml0aWFsaXplT2JqZWN0QWxsb2NhdGlvblByb2Zp bGUoVk0mIHZtLCBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU09iamVjdCogcHJvdG90 eXBlLCBzaXplX3QgaW5saW5lQ2FwYWNpdHksIEpTRnVuY3Rpb24qIGNvbnN0cnVjdG9yKQogewor ICAgIGlmIChtX29iamVjdEFsbG9jYXRpb25Qcm9maWxlV2F0Y2hwb2ludC5pc1N0aWxsVmFsaWQo KSkKKyAgICAgICAgbV9vYmplY3RBbGxvY2F0aW9uUHJvZmlsZVdhdGNocG9pbnQuc3RhcnRXYXRj aGluZygpOworICAgIAogICAgIG1fb2JqZWN0QWxsb2NhdGlvblByb2ZpbGUuaW5pdGlhbGl6ZVBy b2ZpbGUodm0sIGdsb2JhbE9iamVjdCwgdGhpcywgcHJvdG90eXBlLCBpbmxpbmVDYXBhY2l0eSwg Y29uc3RydWN0b3IsIHRoaXMpOwogfQogCg==