18620 2008-04-19 03:22:50 -0700 Long hang under TextIterator::advance() when loading http://www.lsvd.de/ 2008-11-13 13:05:38 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://www.lsvd.de NeedsReduction P1 Normal --- 1 hoagie webkit-unassigned ap hoagie justin.garcia mihnea mitz oldest_to_newest 78251 0 hoagie 2008-04-19 03:22:50 -0700 As soon as I click into the SEARCH (Suchen) field on the Website www.lsvd.de the Browser hangs it self up and is not responding anylonger. When I do the same with the regular Safari Browser I can work on the website with no problems. I have sent the system report to Apple and would have pasted into this text field but it was too long. 78399 1 ap 2008-04-21 07:55:07 -0700 With a local debug build, I got a temporary freeze (for ~30 seconds) when opening the page, but not when clicking in the search field. 98309 2 eric 2008-11-11 11:02:17 -0800 I can confirm ap's findings. I don't see a hang when clicking the search field, but I do see one on load: 0.0% 99.8% Safari 0xb2776 [unknown] 0.0% 99.8% AppKit NSApplicationMain 0.0% 99.8% AppKit -[NSApplication run] 0.0% 99.8% Safari 0x7ae0 [105B] 0.0% 99.8% AppKit -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 0.0% 99.8% AppKit _DPSNextEvent 0.0% 99.8% HIToolbox BlockUntilNextEventMatchingListInMode 0.0% 99.8% HIToolbox ReceiveNextEventCommon 0.0% 99.8% HIToolbox RunCurrentEventLoopInMode 0.0% 99.8% CoreFoundation CFRunLoopRunInMode 0.0% 99.8% CoreFoundation CFRunLoopRunSpecific 0.0% 99.8% Foundation __NSFireTimer 0.0% 99.8% Safari 0x100840 [169B] 0.0% 99.8% Safari 0x26d90 [264B] 0.0% 99.8% Safari 0x27154 [unknown] 0.0% 99.8% Safari 0x27480 [421B] 0.0% 99.8% WebKit -[WebHTMLView(WebDocumentPrivateProtocols) string] 0.0% 99.8% WebKit -[WebFrame(WebInternal) _stringForRange:] 0.0% 99.8% WebCore WebCore::plainTextToMallocAllocatedBuffer(WebCore::Range const*, unsigned int&) 0.0% 99.8% WebCore WebCore::TextIterator::TextIterator(WebCore::Range const*, bool, bool) 0.0% 99.8% WebCore WebCore::TextIterator::advance() 0.0% 99.8% WebCore WebCore::TextIterator::handleNonTextNode() 0.0% 99.8% WebCore WebCore::TextIterator::representNodeOffsetZero() 0.0% 99.8% WebCore WebCore::TextIterator::shouldRepresentNodeOffsetZero() 0.0% 76.0% WebCore WebCore::inSameLine(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&) 0.0% 76.0% WebCore WebCore::startOfLine(WebCore::VisiblePosition const&) 0.0% 76.0% WebCore _ZN7WebCoreL20startPositionForLineERKNS_15VisiblePositionE 0.0% 76.0% WebCore _ZN7WebCoreL36positionAvoidingFirstPositionInTableERKNS_15VisiblePositionE 0.0% 76.0% WebCore WebCore::VisiblePosition::previous(bool) const 3.4% 75.4% WebCore WebCore::previousVisuallyDistinctCandidate(WebCore::Position const&) 6.5% 31.2% WebCore WebCore::Position::previous(WebCore::EUsingComposedCharacters) const I'm not sure why Safari's asking for the text content of the page at load, but the TextIterator seems to have some trouble iterating through this large page. :) 98448 3 justin.garcia 2008-11-12 00:31:41 -0800 (In reply to comment #2) > I'm not sure why Safari's asking for the text content of the page at load, but > the TextIterator seems to have some trouble iterating through this large page. I believe it's for indexing. I'll take a look at this... 98462 4 25094 justin.garcia 2008-11-12 03:35:15 -0800 Created attachment 25094 patch 98480 5 25094 darin 2008-11-12 10:02:40 -0800 Comment on attachment 25094 patch r=me Could you add a test case? 98638 6 justin.garcia 2008-11-13 13:04:29 -0800 (In reply to comment #5) > (From update of attachment 25094 [review]) > r=me > > Could you add a test case? Not currently. There's no way to create a test that makes an explicit call to plainText or to a function that calls plainText with the kind of Range necessary to invoke this code. Filed: https://bugs.webkit.org/show_bug.cgi?id=22236 98639 7 justin.garcia 2008-11-13 13:05:38 -0800 http://trac.webkit.org/changeset/38376 25094 2008-11-12 03:35:15 -0800 2008-11-12 10:02:40 -0800 patch textiterator.txt text/plain 3476 justin.garcia SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4MzMz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDgtMTEt MTIgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2MjAKKyAgICAgICAgTG9uZyBoYW5nIHVuZGVyIFRleHRJ dGVyYXRvcjo6YWR2YW5jZSgpIHdoZW4gbG9hZGluZyBodHRwOi8vd3d3LmxzdmQuZGUvCisgICAg ICAgIAorICAgICAgICBBIGh1Z2Ugc2VjdGlvbiBhdCB0aGUgYmVnaW5uaW5nIG9mIHRoaXMgZG9j dW1lbnQgaXMgaW52aXNpYmxlLiAgQXMgd2UgaXRlcmF0ZSB0aHJvdWdoIGl0LAorICAgICAgICB3 ZSBjcmVhdGUgVmlzaWJsZVBvc2l0aW9ucyB1bm5lY2Vzc2FyaWx5LgorCisgICAgICAgICogZWRp dGluZy9UZXh0SXRlcmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dEl0ZXJhdG9yOjpz aG91bGRSZXByZXNlbnROb2RlT2Zmc2V0WmVybyk6IERvbid0IHByb2NlZWQgdG8gVmlzaWJsZVBv c2l0aW9uIAorICAgICAgICBjcmVhdGlvbiBpZiBtX25vZGUgaXMgdW5yZW5kZXJlZCBvciBpbnZp c2libGUuICBUaGUgYW5zd2VycyB3b3VsZG4ndCBoYXZlIG11Y2ggbWVhbmluZyAKKyAgICAgICAg YW5kIHdvdWxkIGJlIHdhc3RlZnVsLiAgQWxzbyBmaXhlZCBzb21lIGNvbW1lbnRzIHRvIHJlZmxl Y3QgdGhlIGZhY3QgdGhhdCB0aGlzIGZ1bmN0aW9uCisgICAgICAgIGlzbid0IHNwZWNpZmljYWxs eSBhYm91dCBlbWl0dGluZyBhIG5ld2xpbmUuCisKIDIwMDgtMTEtMTAgIFRvciBBcm5lIFZlc3Ri w7ggIDx0YXZlc3Rib0B0cm9sbHRlY2guY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9u IEhhdXNtYW5uLgpJbmRleDogZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGVkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcAkocmV2aXNpb24gMzgzMTgpCisrKyBlZGl0aW5nL1Rl eHRJdGVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzMiw2ICs1MzIsNyBAQAogICAgIHJl dHVybiBmYWxzZTsKIH0KIAorLy8gV2hldGhlciBvciBub3Qgd2Ugc2hvdWxkIGVtaXQgYSBjaGFy YWN0ZXIgYXMgd2UgZW50ZXIgbV9ub2RlIChpZiBpdCdzIGEgY29udGFpbmVyKSBvciBhcyB3ZSBo aXQgaXQgKGlmIGl0J3MgYXRvbWljKS4KIGJvb2wgVGV4dEl0ZXJhdG9yOjpzaG91bGRSZXByZXNl bnROb2RlT2Zmc2V0WmVybygpCiB7CiAgICAgaWYgKG1fZW1pdENoYXJhY3RlcnNCZXR3ZWVuQWxs VmlzaWJsZVBvc2l0aW9ucyAmJiBtX25vZGUtPnJlbmRlcmVyKCkgJiYgbV9ub2RlLT5yZW5kZXJl cigpLT5pc1RhYmxlKCkpCkBAIC01NTQsMjMgKzU1NSwyOSBAQAogICAgIC8vIGlzIHdoZXRoZXIg dGhlIGlubGluZSB2cyBibG9jayBmbG93IGNoYW5nZWQgc2luY2UgdGhlIHByZXZpb3VzIHZpc2li bGUgZWxlbWVudC4KICAgICAvLyBJIHRoaW5rIHdlJ3JlIGFscmVhZHkgaW4gYSBzcGVjaWFsIGVu b3VnaCBjYXNlIHRoYXQgdGhhdCB3b24ndCBiZSBuZWVkZWQsIHRoby4KIAotICAgIC8vIElmIHdl IGFyZSBhdCB0aGUgc3RhcnQsIG9idmlvdXNseSBubyBuZXdsaW5lIGlzIG5lZWRlZC4KKyAgICAv LyBObyBjaGFyYWN0ZXIgbmVlZGVkIGlmIHRoaXMgaXMgdGhlIGZpcnN0IG5vZGUgaW4gdGhlIHJh bmdlLgogICAgIGlmIChtX25vZGUgPT0gbV9zdGFydENvbnRhaW5lcikKICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIAotICAgIC8vIElmIHdlIGFyZSBvdXRzaWRlIHRoZSBzdGFydCBjb250YWlu ZXIncyBzdWJ0cmVlLCBhc3N1bWUgd2UgbmVlZCBhIG5ld2xpbmUuCisgICAgLy8gSWYgd2UgYXJl IG91dHNpZGUgdGhlIHN0YXJ0IGNvbnRhaW5lcidzIHN1YnRyZWUsIGFzc3VtZSB3ZSBuZWVkIHRv IGVtaXQuCiAgICAgLy8gRklYTUU6IG1fc3RhcnRDb250YWluZXIgY291bGQgYmUgYW4gaW5saW5l IGJsb2NrCiAgICAgaWYgKCFtX25vZGUtPmlzRGVzY2VuZGFudE9mKG1fc3RhcnRDb250YWluZXIp KQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIC8vIElmIHdlIHN0YXJ0ZWQgYXMgbV9zdGFy dENvbnRhaW5lciBvZmZzZXQgMCBhbmQgdGhlIGN1cnJlbnQgbm9kZSBpcyBhIGRlc2NlbmRhbnQg b2YKICAgICAvLyB0aGUgc3RhcnQgY29udGFpbmVyLCB3ZSBhbHJlYWR5IGhhZCBlbm91Z2ggY29u dGV4dCB0byBjb3JyZWN0bHkgZGVjaWRlIHdoZXRoZXIgdG8KLSAgICAvLyBlbWl0IGEgbmV3bGlu ZSBhZnRlciBhIHByZWNlZGluZyBibG9jay4gV2UgY2hvc2Ugbm90IHRvIGVtaXQgKG1faGF2ZUVt aXR0ZWQgaXMgZmFsc2UpLAorICAgIC8vIGVtaXQgYWZ0ZXIgYSBwcmVjZWRpbmcgYmxvY2suIFdl IGNob3NlIG5vdCB0byBlbWl0IChtX2hhdmVFbWl0dGVkIGlzIGZhbHNlKSwKICAgICAvLyBzbyBk b24ndCBzZWNvbmQgZ3Vlc3MgdGhhdCBub3cuCiAgICAgLy8gTk9URTogSXMgdGhpcyByZWFsbHkg Y29ycmVjdCB3aGVuIG1fbm9kZSBpcyBub3QgYSBsZWZ0bW9zdCBkZXNjZW5kYW50PyBQcm9iYWJs eQogICAgIC8vIGltbWF0ZXJpYWwgc2luY2Ugd2UgbGlrZWx5IHdvdWxkIGhhdmUgYWxyZWFkeSBl bWl0dGVkIHNvbWV0aGluZyBieSBub3cuCiAgICAgaWYgKG1fc3RhcnRPZmZzZXQgPT0gMCkKICAg ICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAKKyAgICAvLyBJZiB0aGlzIG5vZGUgaXMgdW5y ZW5kZXJlZCBvciBpbnZpc2libGUgdGhlIFZpc2libGVQb3NpdGlvbiBjaGVja3MgYmVsb3cgd29u J3QgaGF2ZSBtdWNoIG1lYW5pbmcuCisgICAgLy8gQWRkaXRpb25hbGx5LCBpZiB0aGUgcmFuZ2Ug d2UgYXJlIGl0ZXJhdGluZyBvdmVyIGNvbnRhaW5zIGh1Z2Ugc2VjdGlvbnMgb2YgdW5yZW5kZXJl ZCBjb250ZW50LCAKKyAgICAvLyB3ZSB3b3VsZCBjcmVhdGUgVmlzaWJsZVBvc2l0aW9ucyBvbiBl dmVyeSBjYWxsIHRvIHRoaXMgZnVuY3Rpb24gd2l0aG91dCB0aGlzIGNoZWNrLgorICAgIGlmICgh bV9ub2RlLT5yZW5kZXJlcigpIHx8IG1fbm9kZS0+cmVuZGVyZXIoKS0+c3R5bGUoKS0+dmlzaWJp bGl0eSgpICE9IFZJU0lCTEUpCisgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKICAgICAvLyBU aGUgY3VyclBvcy5pc05vdE51bGwoKSBjaGVjayBpcyBuZWVkZWQgYmVjYXVzZSBwb3NpdGlvbnMg aW4gbm9uLWh0bWwgY29udGVudAogICAgIC8vIChsaWtlIHN2ZykgZG8gbm90IGhhdmUgdmlzaWJs ZSBwb3NpdGlvbnMsIGFuZCB3ZSBkb24ndCB3YW50IHRvIGVtaXQgZm9yIHRoZW0gZWl0aGVyLgo=