186197 2018-06-01 09:24:58 -0700 REGRESSION (r231456): Colloquy is broken 2018-06-01 16:09:21 -0700 1 1 1 Unclassified WebKit Frames Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=11388 InRadar, Regression P1 Normal --- 11388 1 mitz cdumez ajuma beidson cdumez commit-queue esprehn+autocc ews-watchlist ggaren gyuyoung.kim simon.fraser timothy webkit-bug-importer oldest_to_newest 1429243 0 mitz 2018-06-01 09:24:58 -0700 <rdar://problem/40722960> https://trac.webkit.org/r231456, the fix for bug 11388, broke the macOS Colloquy app. It is failing to populate the transcript tabs with any content or even finish creating all of its UI. 1429374 1 341790 cdumez 2018-06-01 15:06:07 -0700 Created attachment 341790 Patch 1429392 2 timothy 2018-06-01 15:36:42 -0700 Thanks for fixing this! 1429404 3 341790 commit-queue 2018-06-01 16:09:20 -0700 Comment on attachment 341790 Patch Clearing flags on attachment: 341790 Committed r232424: <https://trac.webkit.org/changeset/232424> 1429405 4 commit-queue 2018-06-01 16:09:21 -0700 All reviewed patches have been landed. Closing bug. 341790 2018-06-01 15:06:07 -0700 2018-06-01 16:09:20 -0700 Patch bug-186197-20180601150606.patch text/plain 4529 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNiYjMxZDNmN2FlMGI3 OTQ2NTYwNzNlZjE5ZGRmZDc5YWNjOTEyNy4uZDM3MmQxMzQ4YWQ4ZWZkYjFiNTI1MWVlNzgxZWVm YjQxYjkwZmVkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA2LTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIzMTQ1 Nik6IENvbGxvcXV5IGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg2MTk3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDcyMjk2MD4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXN0b3Jl IHByZS1yMjMxNDU2IGJlaGF2aW9yIGZvciBDb2xsb3F1eSBhcHAgc28gdGhhdCBpdCB3b3JrcyBh Z2Fpbi4KKworICAgICAgICAqIGh0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTEZyYW1lRWxlbWVudEJhc2U6Om9wZW5VUkwpOgorICAgICAgICAqIHBh Z2UvU2V0dGluZ3MueWFtbDoKKwogMjAxOC0wNi0wMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIFJlZ3Jlc3Npb24ocjIzMDU2Nyk6IFVuYWJsZSB0byBsb2cgaW50 byB0d2l0dGVyLmNvbSBpbiBwcml2YXRlIHNlc3Npb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VM b2cKaW5kZXggMjFkZTRjMGVlMmQ0NTY1ZjI5MzA3MjU1MDMwYjE1MDk5NjNlMDY4Ny4uMjdhMDY5 OWZhMzlhMjA2NDM5NjY1MzUwMmI3YzFiYzQxYmQ4MzAyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0No YW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA2LTAxICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIzMTQ1Nik6IENvbGxvcXV5IGlz IGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTg2MTk3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDcyMjk2MD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXN0b3JlIHByZS1yMjMxNDU2IGJl aGF2aW9yIGZvciBDb2xsb3F1eSBhcHAgc28gdGhhdCBpdCB3b3JrcyBhZ2Fpbi4KKworICAgICAg ICAqIFdlYlZpZXcvV2ViVmlldy5tbToKKyAgICAgICAgKC1bV2ViVmlldyBfbmVlZHNGcmFtZU5h bWVGYWxsYmFja1RvSWRRdWlya10pOgorICAgICAgICAoLVtXZWJWaWV3IF9wcmVmZXJlbmNlc0No YW5nZWQ6XSk6CisKIDIwMTgtMDUtMzAgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFp bC5jb20+CiAKICAgICAgICAgW0pTQ10gUGFzcyBWTSYgcGFyYW1ldGVyIGFzIG11Y2ggYXMgcG9z c2libGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJh c2UuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHAKaW5k ZXggMDkxYjM1YTY3YjQyZjY0MGQ5N2EwZWExNmMwZjdkZjUyYjU0NGU0Ni4uZjEyMmRlZWEzNzNm MDk5OWQ5NTk4MzI5YWYyY2IxOGIwZDM1M2YyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MRnJhbWVFbGVtZW50QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MRnJhbWVFbGVtZW50QmFzZS5jcHAKQEAgLTk2LDcgKzk2LDExIEBAIHZvaWQgSFRNTEZyYW1l RWxlbWVudEJhc2U6Om9wZW5VUkwoTG9ja0hpc3RvcnkgbG9ja0hpc3RvcnksIExvY2tCYWNrRm9y d2FyZExpc3QKICAgICBpZiAoIXBhcmVudEZyYW1lKQogICAgICAgICByZXR1cm47CiAKLSAgICBw YXJlbnRGcmFtZS0+bG9hZGVyKCkuc3ViZnJhbWVMb2FkZXIoKS5yZXF1ZXN0RnJhbWUoKnRoaXMs IG1fVVJMLCBnZXROYW1lQXR0cmlidXRlKCksIGxvY2tIaXN0b3J5LCBsb2NrQmFja0ZvcndhcmRM aXN0KTsKKyAgICBTdHJpbmcgZnJhbWVOYW1lID0gZ2V0TmFtZUF0dHJpYnV0ZSgpOworICAgIGlm IChmcmFtZU5hbWUuaXNOdWxsKCkgJiYgVU5MSUtFTFkoZG9jdW1lbnQoKS5zZXR0aW5ncygpLm5l ZWRzRnJhbWVOYW1lRmFsbGJhY2tUb0lkUXVpcmsoKSkpCisgICAgICAgIGZyYW1lTmFtZSA9IGdl dElkQXR0cmlidXRlKCk7CisKKyAgICBwYXJlbnRGcmFtZS0+bG9hZGVyKCkuc3ViZnJhbWVMb2Fk ZXIoKS5yZXF1ZXN0RnJhbWUoKnRoaXMsIG1fVVJMLCBmcmFtZU5hbWUsIGxvY2tIaXN0b3J5LCBs b2NrQmFja0ZvcndhcmRMaXN0KTsKIH0KIAogdm9pZCBIVE1MRnJhbWVFbGVtZW50QmFzZTo6cGFy c2VBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29uc3QgQXRvbWljU3RyaW5n JiB2YWx1ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MueWFtbCBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MueWFtbAppbmRleCBmZjc3MGQxYWNlN2JkZTdj YWE0NDZkZjA5N2FhODU0Mjk2ZjNkYTNkLi40Yjc0NjVmY2QwYjYxNzJiYjk5NTMyMDY0N2NiZGY0 YzNlZDhmMDNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLnlhbWwK KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy55YW1sCkBAIC0xMDUsNiArMTA1LDgg QEAgYWxsb3dDcm9zc09yaWdpblN1YnJlc291cmNlc1RvQXNrRm9yQ3JlZGVudGlhbHM6CiAgIGlu aXRpYWw6IGZhbHNlCiBuZWVkc1N0b3JhZ2VBY2Nlc3NGcm9tRmlsZVVSTHNRdWlyazoKICAgaW5p dGlhbDogdHJ1ZQorbmVlZHNGcmFtZU5hbWVGYWxsYmFja1RvSWRRdWlyazoKKyAgaW5pdGlhbDog ZmFsc2UKIHVzZUFub255bW91c01vZGVXaGVuRmV0Y2hpbmdNYXNrSW1hZ2VzOgogICBpbml0aWFs OiB0cnVlCiBqYXZhU2NyaXB0Q2FuT3BlbldpbmRvd3NBdXRvbWF0aWNhbGx5OgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tIGIvU291cmNlL1dl YktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCmluZGV4IGI0MDIwZDlhZGJmODY3ZTZh NTJjYTQxOWNlYjY1OGQzMWU2NmVmNGEuLjNiNjBhMGI0YzUwYWU4OTM2NjkyMDQwMTgzYjI5Mzcx ODg2ZWYwZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2Vi Vmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXcubW0K QEAgLTI3MDQsNiArMjcwNCwxMiBAQCAtIChCT09MKV9uZWVkc0xpbmtFbGVtZW50VGV4dENTU1F1 aXJrCiAgICAgcmV0dXJuIG5lZWRzUXVpcms7CiB9CiAKKy0gKEJPT0wpX25lZWRzRnJhbWVOYW1l RmFsbGJhY2tUb0lkUXVpcmsKK3sKKyAgICBzdGF0aWMgQk9PTCBuZWVkc1F1aXJrID0gX0NGQXBw VmVyc2lvbkNoZWNrTGVzc1RoYW4oQ0ZTVFIoImluZm8uY29sbG9xdXkiKSwgLTEsIDIuNSk7Cisg ICAgcmV0dXJuIG5lZWRzUXVpcms7Cit9CisKIC0gKEJPT0wpX25lZWRzSXNMb2FkaW5nSW5BUElT ZW5zZVF1aXJrCiB7CiAgICAgc3RhdGljIEJPT0wgbmVlZHNRdWlyayA9IF9DRkFwcFZlcnNpb25D aGVja0xlc3NUaGFuKENGU1RSKCJjb20uYXBwbGUuaUFkUHJvZHVjZXIiKSwgLTEsIDIuMSk7CkBA IC0zMDA0LDYgKzMwMTAsNyBAQCAtICh2b2lkKV9wcmVmZXJlbmNlc0NoYW5nZWQ6KFdlYlByZWZl cmVuY2VzICopcHJlZmVyZW5jZXMKIAogICAgIHNldHRpbmdzLnNldE5lZWRzQWRvYmVGcmFtZVJl bG9hZGluZ1F1aXJrKFtzZWxmIF9uZWVkc0Fkb2JlRnJhbWVSZWxvYWRpbmdRdWlya10pOwogICAg IHNldHRpbmdzLnNldFRyZWF0c0FueVRleHRDU1NMaW5rQXNTdHlsZXNoZWV0KFtzZWxmIF9uZWVk c0xpbmtFbGVtZW50VGV4dENTU1F1aXJrXSk7CisgICAgc2V0dGluZ3Muc2V0TmVlZHNGcmFtZU5h bWVGYWxsYmFja1RvSWRRdWlyayhbc2VsZiBfbmVlZHNGcmFtZU5hbWVGYWxsYmFja1RvSWRRdWly a10pOwogICAgIHNldHRpbmdzLnNldE5lZWRzS2V5Ym9hcmRFdmVudERpc2FtYmlndWF0aW9uUXVp cmtzKFtzZWxmIF9uZWVkc0tleWJvYXJkRXZlbnREaXNhbWJpZ3VhdGlvblF1aXJrc10pOwogICAg IHNldHRpbmdzLnNldEVuZm9yY2VDU1NNSU1FVHlwZUluTm9RdWlya3NNb2RlKCFfQ0ZBcHBWZXJz aW9uQ2hlY2tMZXNzVGhhbihDRlNUUigiY29tLmFwcGxlLmlXZWIiKSwgLTEsIDIuMSkpOwogICAg IHNldHRpbmdzLnNldE5lZWRzSXNMb2FkaW5nSW5BUElTZW5zZVF1aXJrKFtzZWxmIF9uZWVkc0lz TG9hZGluZ0luQVBJU2Vuc2VRdWlya10pOwo=