186150 2018-05-31 10:33:22 -0700 Don't attempt to extend sandbox when running tests with mock media devices 2018-05-31 12:13:42 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 185526 1 bfulgham bfulgham ap bfulgham commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1428889 0 bfulgham 2018-05-31 10:33:22 -0700 Various WebKit media tests can fail when TCC prompts are displayed when WebKitTestRunner attempts to create sandbox extensions for media capture devices. When running our test infrastructure, we use Mock devices, which do not need these extensions, and should not be creating any prompts. This patch revises the media capture device logic to avoid extending the sandbox for mock test devices. 1428895 1 341672 bfulgham 2018-05-31 10:41:06 -0700 Created attachment 341672 Patch 1428897 2 bfulgham 2018-05-31 10:49:06 -0700 <rdar://problem/40690875> 1428898 3 341673 bfulgham 2018-05-31 10:49:45 -0700 Created attachment 341673 Patch for landing 1428956 4 341673 commit-queue 2018-05-31 12:13:41 -0700 Comment on attachment 341673 Patch for landing Clearing flags on attachment: 341673 Committed r232360: <https://trac.webkit.org/changeset/232360> 1428957 5 commit-queue 2018-05-31 12:13:42 -0700 All reviewed patches have been landed. Closing bug. 341672 2018-05-31 10:41:06 -0700 2018-05-31 10:49:43 -0700 Patch bug-186150-20180531104104.patch text/plain 2235 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIzZGU1ZGQ3MDk5MTRlZGU0 NWJjMTUzZWU1M2RiNmVkZWYzM2YwM2MuLmJiYjMyNTI1MTA1ODZjMDZkMTk5YTM4YzM5ODQ3YzU5 NWNkZGQyODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDUtMzEgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgYXR0ZW1wdCB0byBl eHRlbmQgc2FuZGJveCB3aGVuIHJ1bm5pbmcgdGVzdHMgd2l0aCBtb2NrIG1lZGlhIGRldmljZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjE1MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkIGF0 dGVtcHRpbmcgdG8gaXNzdWUgYSBzYW5kYm94IGV4dGVuc2lvbiB0byBhY3R1YWwgbWVkaWEgZGV2 aWNlcyB3aGVuCisgICAgICAgIHJ1bm5pbmcgd2l0aCBNb2NrIGNhcHR1cmUgZGV2aWNlcy4KKwor ICAgICAgICBBbHNvIGhhbmRsZSB0aGUgJ2RlbnlOZXh0UmVxdWVzdCcgdGVzdCBzdGF0ZSBvdXRz aWRlIG9mIHRoZSBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQorICAgICAgICBndWFyZHMsIHNpbmNl IGl0IGlzIG5lZWRlZCBmb3IgT3BlbiBTb3VyY2UgYnVpbGRzIGFzIHdlbGwuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvVXNlck1lZGlhUHJvY2Vzc01hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0 OjpVc2VyTWVkaWFQcm9jZXNzTWFuYWdlcjo6d2lsbENyZWF0ZU1lZGlhU3RyZWFtKToKKwogMjAx OC0wNS0zMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAg ICBbSlNDXSBQYXNzIFZNJiBwYXJhbWV0ZXIgYXMgbXVjaCBhcyBwb3NzaWJsZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVXNlck1lZGlhUHJvY2Vzc01hbmFnZXIuY3BwIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvVXNlck1lZGlhUHJvY2Vzc01hbmFnZXIuY3BwCmluZGV4 IGFlOTQ2ZjFhOTBjNjlhZDA4ZDk1NDliN2NjYmFlMzBmOTZhMGNjMzAuLmNkMGE1NWI4OGQ5M2Y0 YTYzM2U3N2MxM2M2NWU5NmY1OGRlODg3YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1VzZXJNZWRpYVByb2Nlc3NNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9Vc2VyTWVkaWFQcm9jZXNzTWFuYWdlci5jcHAKQEAgLTEyOCwxNSArMTI4LDE4IEBA IHZvaWQgVXNlck1lZGlhUHJvY2Vzc01hbmFnZXI6Om11dGVDYXB0dXJlTWVkaWFTdHJlYW1zRXhj ZXB0SW4oV2ViUGFnZVByb3h5JiBwYWdlCiAKIGJvb2wgVXNlck1lZGlhUHJvY2Vzc01hbmFnZXI6 OndpbGxDcmVhdGVNZWRpYVN0cmVhbShVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQ cm94eSYgcHJveHksIGJvb2wgd2l0aEF1ZGlvLCBib29sIHdpdGhWaWRlbykKIHsKLSNpZiBFTkFC TEUoU0FOREJPWF9FWFRFTlNJT05TKSAmJiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQotICAgIGF1 dG8mIHByb2Nlc3NTdGFydGluZ0NhcHR1cmUgPSBwcm94eS5wYWdlKCkucHJvY2VzcygpOwotCi0g ICAgQVNTRVJUKHN0YXRlTWFwKCkuY29udGFpbnMoJnByb2Nlc3NTdGFydGluZ0NhcHR1cmUpKTsK LQogICAgIGlmIChtX2RlbnlOZXh0UmVxdWVzdCkgewogICAgICAgICBtX2RlbnlOZXh0UmVxdWVz dCA9IGZhbHNlOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQorICAgIAorICAgIGlmIChw cm94eS5wYWdlKCkucHJlZmVyZW5jZXMoKS5tb2NrQ2FwdHVyZURldmljZXNFbmFibGVkKCkpCisg ICAgICAgIHJldHVybiB0cnVlOworICAgIAorI2lmIEVOQUJMRShTQU5EQk9YX0VYVEVOU0lPTlMp ICYmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspCisgICAgYXV0byYgcHJvY2Vzc1N0YXJ0aW5nQ2Fw dHVyZSA9IHByb3h5LnBhZ2UoKS5wcm9jZXNzKCk7CisKKyAgICBBU1NFUlQoc3RhdGVNYXAoKS5j b250YWlucygmcHJvY2Vzc1N0YXJ0aW5nQ2FwdHVyZSkpOwogCiAgICAgYXV0byYgc3RhdGUgPSBw cm9jZXNzU3RhdGUocHJvY2Vzc1N0YXJ0aW5nQ2FwdHVyZSk7CiAgICAgc2l6ZV90IGV4dGVuc2lv bkNvdW50ID0gMDsK 341673 2018-05-31 10:49:45 -0700 2018-05-31 12:13:41 -0700 Patch for landing bug-186150-20180531104944.patch text/plain 2275 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIzZGU1ZGQ3MDk5MTRlZGU0 NWJjMTUzZWU1M2RiNmVkZWYzM2YwM2MuLjlmZDc4ZTQ3NmYxNjU1ZmM0ZTEyMTAzZjJjMmVlOGMy ZGU5ZDkyYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDUtMzEgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgYXR0ZW1wdCB0byBl eHRlbmQgc2FuZGJveCB3aGVuIHJ1bm5pbmcgdGVzdHMgd2l0aCBtb2NrIG1lZGlhIGRldmljZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjE1MAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDA2OTA4NzU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg QWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAgICBBdm9pZCBhdHRlbXB0aW5nIHRvIGlzc3Vl IGEgc2FuZGJveCBleHRlbnNpb24gdG8gYWN0dWFsIG1lZGlhIGRldmljZXMgd2hlbgorICAgICAg ICBydW5uaW5nIHdpdGggTW9jayBjYXB0dXJlIGRldmljZXMuCisKKyAgICAgICAgQWxzbyBoYW5k bGUgdGhlICdkZW55TmV4dFJlcXVlc3QnIHRlc3Qgc3RhdGUgb3V0c2lkZSBvZiB0aGUgVVNFKEFQ UExFX0lOVEVSTkFMX1NESykKKyAgICAgICAgZ3VhcmRzLCBzaW5jZSBpdCBpcyBuZWVkZWQgZm9y IE9wZW4gU291cmNlIGJ1aWxkcyBhcyB3ZWxsLgorCisgICAgICAgICogVUlQcm9jZXNzL1VzZXJN ZWRpYVByb2Nlc3NNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6VXNlck1lZGlhUHJvY2Vz c01hbmFnZXI6OndpbGxDcmVhdGVNZWRpYVN0cmVhbSk6CisKIDIwMTgtMDUtMzAgIFl1c3VrZSBT dXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0pTQ10gUGFzcyBWTSYg cGFyYW1ldGVyIGFzIG11Y2ggYXMgcG9zc2libGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1VzZXJNZWRpYVByb2Nlc3NNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1VzZXJNZWRpYVByb2Nlc3NNYW5hZ2VyLmNwcAppbmRleCBhZTk0NmYxYTkwYzY5YWQw OGQ5NTQ5YjdjY2JhZTMwZjk2YTBjYzMwLi5jZDBhNTViODhkOTNmNGE2MzNlNzdjMTNjNjVlOTZm NThkZTg4N2I2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Vc2VyTWVkaWFQ cm9jZXNzTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVXNlck1lZGlh UHJvY2Vzc01hbmFnZXIuY3BwCkBAIC0xMjgsMTUgKzEyOCwxOCBAQCB2b2lkIFVzZXJNZWRpYVBy b2Nlc3NNYW5hZ2VyOjptdXRlQ2FwdHVyZU1lZGlhU3RyZWFtc0V4Y2VwdEluKFdlYlBhZ2VQcm94 eSYgcGFnZQogCiBib29sIFVzZXJNZWRpYVByb2Nlc3NNYW5hZ2VyOjp3aWxsQ3JlYXRlTWVkaWFT dHJlYW0oVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkmIHByb3h5LCBib29s IHdpdGhBdWRpbywgYm9vbCB3aXRoVmlkZW8pCiB7Ci0jaWYgRU5BQkxFKFNBTkRCT1hfRVhURU5T SU9OUykgJiYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKLSAgICBhdXRvJiBwcm9jZXNzU3RhcnRp bmdDYXB0dXJlID0gcHJveHkucGFnZSgpLnByb2Nlc3MoKTsKLQotICAgIEFTU0VSVChzdGF0ZU1h cCgpLmNvbnRhaW5zKCZwcm9jZXNzU3RhcnRpbmdDYXB0dXJlKSk7Ci0KICAgICBpZiAobV9kZW55 TmV4dFJlcXVlc3QpIHsKICAgICAgICAgbV9kZW55TmV4dFJlcXVlc3QgPSBmYWxzZTsKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgIH0KKyAgICAKKyAgICBpZiAocHJveHkucGFnZSgpLnByZWZl cmVuY2VzKCkubW9ja0NhcHR1cmVEZXZpY2VzRW5hYmxlZCgpKQorICAgICAgICByZXR1cm4gdHJ1 ZTsKKyAgICAKKyNpZiBFTkFCTEUoU0FOREJPWF9FWFRFTlNJT05TKSAmJiBVU0UoQVBQTEVfSU5U RVJOQUxfU0RLKQorICAgIGF1dG8mIHByb2Nlc3NTdGFydGluZ0NhcHR1cmUgPSBwcm94eS5wYWdl KCkucHJvY2VzcygpOworCisgICAgQVNTRVJUKHN0YXRlTWFwKCkuY29udGFpbnMoJnByb2Nlc3NT dGFydGluZ0NhcHR1cmUpKTsKIAogICAgIGF1dG8mIHN0YXRlID0gcHJvY2Vzc1N0YXRlKHByb2Nl c3NTdGFydGluZ0NhcHR1cmUpOwogICAgIHNpemVfdCBleHRlbnNpb25Db3VudCA9IDA7Cg==