<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>186133</bug_id>
          
          <creation_ts>2018-05-31 02:21:47 -0700</creation_ts>
          <short_desc>export-w3c-test-changes cannot apply patches when some w3c-import.log files are changed</short_desc>
          <delta_ts>2018-06-01 10:04:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Frédéric Wang Nélar">fred.wang</reporter>
          <assigned_to name="Frédéric Wang Nélar">fred.wang</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>lforschler</cc>
    
    <cc>rwlbuis</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1428785</commentid>
    <comment_count>0</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-05-31 02:21:47 -0700</bug_when>
    <thetext>I&apos;ve tried to export a WPT test that I have previously imported from a local web-platform-test repo. The import script has modified some w3c-import.log files in WebKit and hence these changes are included into the patch used by the export-w3c-test-changes script. Since these w3c-import.log files don&apos;t exist in the web-platform-test repo, the patch fails to apply.

I realize this is not really a standard workflow, but maybe export-w3c-test-changes should exclude these w3c-import.log files when producing the patch to apply.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1428822</commentid>
    <comment_count>1</comment_count>
      <attachid>341661</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-05-31 05:32:57 -0700</bug_when>
    <thetext>Created attachment 341661
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1429247</commentid>
    <comment_count>2</comment_count>
      <attachid>341661</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-06-01 09:36:06 -0700</bug_when>
    <thetext>Comment on attachment 341661
Patch

Clearing flags on attachment: 341661

Committed r232398: &lt;https://trac.webkit.org/changeset/232398&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1429248</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-06-01 09:36:08 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1429260</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-06-01 10:04:33 -0700</bug_when>
    <thetext>&lt;rdar://problem/40724859&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>341661</attachid>
            <date>2018-05-31 05:32:57 -0700</date>
            <delta_ts>2018-06-01 09:36:06 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-186133-20180531143256.patch</filename>
            <type>text/plain</type>
            <size>3092</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTBlOWNmYmU1MmM0MDFjOWU0YjI2YzgwODE3ZDRiZTc1
YjdkYWM2MS4uNjVkMWEwMWE4ZWFmOGQxNGE1NmE4MGFlNjJlNGFjMzVkNTAyMzVkMiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz
IEBACisyMDE4LTA1LTMxICBGcmVkZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAg
ICAgICBleHBvcnQtdzNjLXRlc3QtY2hhbmdlcyBjYW5ub3QgYXBwbHkgcGF0Y2hlcyB3aGVuIHNv
bWUgdzNjLWltcG9ydC5sb2cgZmlsZXMgYXJlIGNoYW5nZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjEzMworCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9l
eHBvcnRlci5weTogRXhjbHVkZSB3M2MtaW1wb3J0LmxvZyBmcm9tIHRoZSBkaWZmLgorICAgICAg
ICAqIFNjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfZXhwb3J0ZXJfdW5pdHRlc3QucHk6IEFkZCB1
bml0IHRlc3QuCisKIDIwMTgtMDUtMjkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t
PgogCiAgICAgICAgIEFkZCBhIGNvbnNpc3RlbmN5IGNoZWNrIGJldHdlZW4gVVJMIGFuZCBDRlVS
TApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9leHBvcnRlci5w
eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfZXhwb3J0ZXIucHkKaW5kZXggZjc2
MmRlNDY0N2M0NzJmYmU2MGNmZTc0NzRjZjY4NTY5ZmZiNzFjNC4uN2Y5YjBlOGVhYWZmODJiZTRh
Mjg1NTkyM2Y2N2EyN2M4YTExMzdlNiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw
eS93M2MvdGVzdF9leHBvcnRlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90
ZXN0X2V4cG9ydGVyLnB5CkBAIC00Niw3ICs0Niw3IEBAIFdFQktJVF9XUFRfRElSID0gJ0xheW91
dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMnCiBXUFRfUFJfVVJMID0gImh0
dHBzOi8vZ2l0aHViLmNvbS8lcy93ZWItcGxhdGZvcm0tdGVzdHMvcHVsbC8iICUgV1BUX0dIX09S
RwogV0VCS0lUX0VYUE9SVF9QUl9MQUJFTCA9ICd3ZWJraXQtZXhwb3J0JwogCi1FWENMVURFRF9G
SUxFX1NVRkZJWEVTID0gWyctZXhwZWN0ZWQudHh0JywgJy53b3JrZXIuaHRtbCcsICcuYW55Lmh0
bWwnLCAnLmFueS53b3JrZXIuaHRtbCddCitFWENMVURFRF9GSUxFX1NVRkZJWEVTID0gWyctZXhw
ZWN0ZWQudHh0JywgJy53b3JrZXIuaHRtbCcsICcuYW55Lmh0bWwnLCAnLmFueS53b3JrZXIuaHRt
bCcsICd3M2MtaW1wb3J0LmxvZyddCiAKIAogY2xhc3MgV2ViUGxhdGZvcm1UZXN0RXhwb3J0ZXIo
b2JqZWN0KToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfZXhw
b3J0ZXJfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2V4cG9y
dGVyX3VuaXR0ZXN0LnB5CmluZGV4IGE2YWQ4ZmNhMTU4YWJhOGYwMGU1OTkxMGU5NjYxYWI1YWRi
N2JmMzguLmVkZTZiNDJhMzdmZDFmZmVjNDc1OGVhMTMzMDk2YmI0YjM3YTI2MTcgMTAwNjQ0Ci0t
LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfZXhwb3J0ZXJfdW5pdHRlc3QucHkK
KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9leHBvcnRlcl91bml0dGVzdC5w
eQpAQCAtMjE5LDYgKzIxOSwxOCBAQCBTdWJ2ZXJzaW9uIFJldmlzaW9uOiAyMzE5MjAKIGRpZmYg
LS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNo
L2FwaS9oZWFkZXJzL2hlYWRlci12YWx1ZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1w
b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvaGVhZGVycy9oZWFkZXItdmFs
dWVzLWV4cGVjdGVkLnR4dAogCiArY2hhbmdlIHRvIGV4cGVjdGVkCisiIiIKKyAgICAgICAgb3B0
aW9ucyA9IHBhcnNlX2FyZ3MoWyd0ZXN0X2V4cG9ydGVyLnB5JywgJy1nJywgJ0hFQUQnLCAnLWIn
LCAnMTIzNCcsICctYycsICctbicsICdVU0VSJywgJy10JywgJ1RPS0VOJ10pCisgICAgICAgIGV4
cG9ydGVyID0gV2ViUGxhdGZvcm1UZXN0RXhwb3J0ZXIoaG9zdCwgb3B0aW9ucywgVGVzdEV4cG9y
dGVyVGVzdC5Nb2NrR2l0LCBUZXN0RXhwb3J0ZXJUZXN0Lk1vY2tCdWd6aWxsYSwgTW9ja1dQVEdp
dEh1YiwgVGVzdEV4cG9ydGVyVGVzdC5Nb2NrV1BUTGludGVyKQorICAgICAgICBzZWxmLmFzc2Vy
dEZhbHNlKGV4cG9ydGVyLmhhc193cHRfY2hhbmdlcygpKQorCisgICAgZGVmIHRlc3RfaWdub3Jl
X2NoYW5nZXNfdG9fdzNjX2ltcG9ydF9sb2coc2VsZik6CisgICAgICAgIGhvc3QgPSBUZXN0RXhw
b3J0ZXJUZXN0Lk15TW9ja0hvc3QoKQorICAgICAgICBob3N0Ll9tb2NrU0NNLm1vY2tfZm9ybWF0
X3BhdGNoX3Jlc3VsdCA9ICIiIgorU3VidmVyc2lvbiBSZXZpc2lvbjogMjMxOTIwCitkaWZmIC0t
Z2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9h
cGkvaGVhZGVycy93M2MtaW1wb3J0LmxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWIt
cGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2hlYWRlcnMvdzNjLWltcG9ydC5sb2cKKworK2NoYW5n
ZSB0byB3M2MgaW1wb3J0CiAiIiIKICAgICAgICAgb3B0aW9ucyA9IHBhcnNlX2FyZ3MoWyd0ZXN0
X2V4cG9ydGVyLnB5JywgJy1nJywgJ0hFQUQnLCAnLWInLCAnMTIzNCcsICctYycsICctbicsICdV
U0VSJywgJy10JywgJ1RPS0VOJ10pCiAgICAgICAgIGV4cG9ydGVyID0gV2ViUGxhdGZvcm1UZXN0
RXhwb3J0ZXIoaG9zdCwgb3B0aW9ucywgVGVzdEV4cG9ydGVyVGVzdC5Nb2NrR2l0LCBUZXN0RXhw
b3J0ZXJUZXN0Lk1vY2tCdWd6aWxsYSwgTW9ja1dQVEdpdEh1YiwgVGVzdEV4cG9ydGVyVGVzdC5N
b2NrV1BUTGludGVyKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>