<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>186129</bug_id>
          
          <creation_ts>2018-05-31 01:15:37 -0700</creation_ts>
          <short_desc>REGRESSION (r232186): Hardware-accelerated CSS animations using steps() timing function no longer work</short_desc>
          <delta_ts>2018-07-03 08:02:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Animations</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>170784</blocked>
    
    <blocked>186127</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Frédéric Wang Nélar">fred.wang</reporter>
          <assigned_to name="Frédéric Wang Nélar">fred.wang</assigned_to>
          <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>graouts</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1428771</commentid>
    <comment_count>0</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-05-31 01:15:37 -0700</bug_when>
    <thetext>See the attached testcase. Top square uses Bézier timing function (linear) while bottom square uses steps.

On the GTK port, the two squares are animated. On the iOS/macOS ports on trunk with the latest Xcode update (9.4) the bottom square does not move at all. It used to work a few days ago, so probably it&apos;s a recent regression in trunk or in XCode 9.4.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1428772</commentid>
    <comment_count>1</comment_count>
      <attachid>341648</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-05-31 01:15:54 -0700</bug_when>
    <thetext>Created attachment 341648
Testcase</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1428915</commentid>
    <comment_count>2</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2018-05-31 11:15:27 -0700</bug_when>
    <thetext>Started with https://trac.webkit.org/r232186. Perhaps an intentional change?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1428940</commentid>
    <comment_count>3</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2018-05-31 11:52:47 -0700</bug_when>
    <thetext>r232186 should not affect WebKit unless you have DEFAULT_EXPERIMENTAL_FEATURES_ENABLED set to TRUE. Also, the timing function code is not affected by the Web Animations flags.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1428941</commentid>
    <comment_count>4</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2018-05-31 11:54:10 -0700</bug_when>
    <thetext>Looks like a bug with the new CSS Animations implementation on top of Web Animations. This does not reproduce with the Web Animations CSS Integration flag off.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1428946</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-05-31 12:00:56 -0700</bug_when>
    <thetext>&lt;rdar://problem/40694333&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1429066</commentid>
    <comment_count>6</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2018-05-31 17:03:04 -0700</bug_when>
    <thetext>To be clear, I positively bisected this regression to r232186. That&apos;s not a guess.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1429169</commentid>
    <comment_count>7</comment_count>
      <attachid>341744</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-06-01 01:02:17 -0700</bug_when>
    <thetext>Created attachment 341744
Testcase

This is an extended testcase that logs the getComputedStyle() of the square, showing that the transform is correctly updated in both cases.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1429172</commentid>
    <comment_count>8</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2018-06-01 01:51:23 -0700</bug_when>
    <thetext>Animating margin-left instead of transform behaves as expected. This is an issue with hardware-accelerated animations only.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1429173</commentid>
    <comment_count>9</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-06-01 02:09:19 -0700</bug_when>
    <thetext>(In reply to Antoine Quint from comment #8)
&gt; Animating margin-left instead of transform behaves as expected. This is an
&gt; issue with hardware-accelerated animations only.

Also, note that GraphicsLayerCA::animationCanBeAccelerated returns false for the steps() timing function (which is the case failing in the attached testcase). So maybe the implementation with webAnimationCSSIntegration enabled does not handle transform for non-accelerated animations?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1434024</commentid>
    <comment_count>10</comment_count>
      <attachid>342943</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-06-18 09:09:26 -0700</bug_when>
    <thetext>Created attachment 342943
Testcase

Testcase, including a CSS propertie that cannot be accelerated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1434046</commentid>
    <comment_count>11</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-06-18 10:25:02 -0700</bug_when>
    <thetext>(In reply to Frédéric Wang (:fredw) from comment #9)
&gt; (In reply to Antoine Quint from comment #8)
&gt; &gt; Animating margin-left instead of transform behaves as expected. This is an
&gt; &gt; issue with hardware-accelerated animations only.
&gt; 
&gt; Also, note that GraphicsLayerCA::animationCanBeAccelerated returns false for
&gt; the steps() timing function (which is the case failing in the attached
&gt; testcase). So maybe the implementation with webAnimationCSSIntegration
&gt; enabled does not handle transform for non-accelerated animations?

Comparing the stack traces, webAnimationCSSIntegration disabled gives:

WebCore::GraphicsLayerCA::animationCanBeAccelerated
WebCore::GraphicsLayerCA::addAnimation
WebCore::RenderLayerBacking::startAnimation
WebCore::RenderBoxModelObject::startAnimation
WebCore::KeyframeAnimation::startAnimation
WebCore::AnimationBase::updateStateMachine
...

while webAnimationCSSIntegration enabled gives:

WebCore::GraphicsLayerCA::animationCanBeAccelerated
WebCore::GraphicsLayerCA::addAnimation
WebCore::RenderLayerBacking::startAnimation
WebCore::RenderBoxModelObject::startAnimation
WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions
WebCore::WebAnimation::applyPendingAcceleratedActions
...

Note that in the former case, the AnimationBase becomes non-accelerated when startAnimation returns false (e.g. when animationCanBeAccelerated returns false) but in the latter case, the WebAnimation just ignores the boolean returned by startAnimation. It looks like it should somewhat fallback to non-accelerated mode too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438807</commentid>
    <comment_count>12</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-07-03 03:16:46 -0700</bug_when>
    <thetext>(In reply to Frédéric Wang (:fredw) from comment #11)
&gt; Note that in the former case, the AnimationBase becomes non-accelerated when
&gt; startAnimation returns false (e.g. when animationCanBeAccelerated returns
&gt; false) but in the latter case, the WebAnimation just ignores the boolean
&gt; returned by startAnimation. It looks like it should somewhat fallback to
&gt; non-accelerated mode too.

OK, just checked again this morning and indeed this seems to be enough:

--- a/Source/WebCore/animation/KeyframeEffectReadOnly.cpp
+++ b/Source/WebCore/animation/KeyframeEffectReadOnly.cpp
@@ -1256,3 +1256,6 @@ void KeyframeEffectReadOnly::applyPendingAcceleratedActions()
         case AcceleratedAction::Play:
-            compositedRenderer-&gt;startAnimation(timeOffset, backingAnimationForCompositedRenderer().ptr(), m_blendingKeyframes);
+            if (!compositedRenderer-&gt;startAnimation(timeOffset, backingAnimationForCompositedRenderer().ptr(), m_blendingKeyframes)) {
+                m_shouldRunAccelerated = false;
+                m_lastRecordedAcceleratedAction = AcceleratedAction::Stop;
+            }
             break;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438819</commentid>
    <comment_count>13</comment_count>
      <attachid>344178</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-07-03 05:49:23 -0700</bug_when>
    <thetext>Created attachment 344178
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438834</commentid>
    <comment_count>14</comment_count>
      <attachid>344178</attachid>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2018-07-03 07:09:32 -0700</bug_when>
    <thetext>Comment on attachment 344178
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344178&amp;action=review

&gt; Source/WebCore/animation/KeyframeEffectReadOnly.cpp:1259
&gt; +                m_lastRecordedAcceleratedAction = AcceleratedAction::Stop;

I think we should clear the list of pending accelerated actions and return here since we already know we can&apos;t actually run accelerated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438836</commentid>
    <comment_count>15</comment_count>
      <attachid>344178</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-07-03 07:15:06 -0700</bug_when>
    <thetext>Comment on attachment 344178
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344178&amp;action=review

&gt;&gt; Source/WebCore/animation/KeyframeEffectReadOnly.cpp:1259
&gt;&gt; +                m_lastRecordedAcceleratedAction = AcceleratedAction::Stop;
&gt; 
&gt; I think we should clear the list of pending accelerated actions and return here since we already know we can&apos;t actually run accelerated.

Right, we can just return immediately. m_pendingAcceleratedActions.clear(); is already called at the beginning of the function.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438841</commentid>
    <comment_count>16</comment_count>
      <attachid>344186</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-07-03 07:22:08 -0700</bug_when>
    <thetext>Created attachment 344186
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438847</commentid>
    <comment_count>17</comment_count>
      <attachid>344186</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-07-03 08:02:01 -0700</bug_when>
    <thetext>Comment on attachment 344186
Patch for landing

Clearing flags on attachment: 344186

Committed r233462: &lt;https://trac.webkit.org/changeset/233462&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1438848</commentid>
    <comment_count>18</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-07-03 08:02:03 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>341648</attachid>
            <date>2018-05-31 01:15:54 -0700</date>
            <delta_ts>2018-06-01 01:02:17 -0700</delta_ts>
            <desc>Testcase</desc>
            <filename>css-animation-steps.html</filename>
            <type>text/html</type>
            <size>920</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPG1ldGEgY2hhcnNldD0idXRmLTgi
PgogICAgPHRpdGxlPmFuaW1hdGlvbiBzdGVwcyB0aW1pbmcgZnVuY3Rpb248L3RpdGxlPgogICAg
PGxpbmsgcmVsPSJtYXRjaCIgaHJlZj0ic2V0LWFuaW1hdGlvbi1wbGF5LXN0YXRlLXRvLXBhdXNl
ZC0wMDEtcmVmLmh0bWwiPgogICAgPHN0eWxlPgogICAgICAjY29udGFpbmVyIHsKICAgICAgICBw
b3NpdGlvbjogYWJzb2x1dGU7CiAgICAgICAgbGVmdDogMDsKICAgICAgICB0b3A6IDNlbTsKICAg
ICAgfQogICAgICAjc3F1YXJlTGluZWFyLCAjc3F1YXJlU3RlcHMgIHsKICAgICAgICB3aWR0aDog
MTAwcHg7CiAgICAgICAgaGVpZ2h0OiAxMDBweDsKICAgICAgICBiYWNrZ3JvdW5kOiBibHVlOwog
ICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgICAgICBsZWZ0OiAtNTBweDsKICAgICAgfQog
ICAgICAjc3F1YXJlTGluZWFyIHsKICAgICAgICB0b3A6IDBweDsKICAgICAgICBhbmltYXRpb246
IG1vdmUgMXMgbGluZWFyIGluZmluaXRlOwogICAgICB9CiAgICAgICNzcXVhcmVTdGVwcyB7CiAg
ICAgICAgdG9wOiAxNTBweDsKICAgICAgICBhbmltYXRpb246IG1vdmUgMXMgc3RlcHMoNCkgaW5m
aW5pdGU7CiAgICAgIH0KICAgICAgQGtleWZyYW1lcyBtb3ZlCiAgICAgIHsKICAgICAgICAxMDAl
IHsKICAgICAgICAgIHRyYW5zZm9ybTogdHJhbnNsYXRlKDUwMHB4KTsKICAgICAgICB9CiAgICAg
IH0KICAgIDwvc3R5bGU+CiAgPC9oZWFkPgogIDxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KICAg
IDxkaXYgaWQ9ImNvbnRhaW5lciI+CiAgICAgIDxkaXYgaWQ9InNxdWFyZUxpbmVhciI+PC9kaXY+
CiAgICAgIDxkaXYgaWQ9InNxdWFyZVN0ZXBzIj48L2Rpdj4KICAgIDwvZGl2PgogIDwvYm9keT4K
PC9odG1sPgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>341744</attachid>
            <date>2018-06-01 01:02:17 -0700</date>
            <delta_ts>2018-06-18 09:09:26 -0700</delta_ts>
            <desc>Testcase</desc>
            <filename>186129.html</filename>
            <type>text/html</type>
            <size>1591</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPG1ldGEgY2hhcnNldD0idXRmLTgi
PgogICAgPHRpdGxlPmFuaW1hdGlvbiBzdGVwcyB0aW1pbmcgZnVuY3Rpb248L3RpdGxlPgogICAg
PHN0eWxlPgogICAgICAjY29udGFpbmVyIHsKICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAg
ICAgICAgbGVmdDogMDsKICAgICAgICB0b3A6IDNlbTsKICAgICAgfQogICAgICAjc3F1YXJlTGlu
ZWFyLCAjc3F1YXJlU3RlcHMgIHsKICAgICAgICB3aWR0aDogMTAwcHg7CiAgICAgICAgaGVpZ2h0
OiAxMDBweDsKICAgICAgICBiYWNrZ3JvdW5kOiBibHVlOwogICAgICAgIHBvc2l0aW9uOiBhYnNv
bHV0ZTsKICAgICAgICBsZWZ0OiAtNTBweDsKICAgICAgfQogICAgICAjc3F1YXJlTGluZWFyIHsK
ICAgICAgICB0b3A6IDBweDsKICAgICAgICBhbmltYXRpb246IG1vdmUgMnMgbGluZWFyIGluZmlu
aXRlOwogICAgICB9CiAgICAgICNzcXVhcmVTdGVwcyB7CiAgICAgICAgdG9wOiAxNTBweDsKICAg
ICAgICBhbmltYXRpb246IG1vdmUgMnMgc3RlcHMoNCkgaW5maW5pdGU7CiAgICAgIH0KICAgICAg
QGtleWZyYW1lcyBtb3ZlCiAgICAgIHsKICAgICAgICAxMDAlIHsKICAgICAgICAgIHRyYW5zZm9y
bTogdHJhbnNsYXRlKDUwMHB4KTsKICAgICAgICB9CiAgICAgIH0KICAgICAgPC9zdHlsZT4KICAg
ICAgPHNjcmlwdD4KCXZhciBzdGFydCA9IG51bGwsIGluZGV4OwogICAgICAgIHZhciBhbmltYXRp
b25EdXJhdGlvbiA9IDIwMDA7Cgl2YXIgc3RlcENvdW50ID0gNDsKCWZ1bmN0aW9uIGxvZ1RyYW5z
Zm9ybU1hdHJpeChpZCkgewogICAgICAgICAgY29uc29sZS5sb2coYCR7aWR9OmAsIHdpbmRvdy5n
ZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKGlkKSkuZ2V0UHJvcGVydHlW
YWx1ZSgidHJhbnNmb3JtIikpOwogICAgICAgIH0KICAgICAgICBmdW5jdGlvbiBzdGVwKHRpbWVz
dGFtcCkgewoJICBpZiAoIXN0YXJ0KSB7CgkgICAgc3RhcnQgPSB0aW1lc3RhbXA7CgkgICAgaW5k
ZXggPSAxOwoJICB9CiAgICAgICAgICB2YXIgcHJvZ3Jlc3MgPSB0aW1lc3RhbXAgLSBzdGFydDsK
CSAgaWYgKHByb2dyZXNzID4gYW5pbWF0aW9uRHVyYXRpb24gKiBpbmRleCAvIHN0ZXBDb3VudCkg
ewoJICAgIGNvbnNvbGUubG9nKGBwcm9ncmVzczogJHtwcm9ncmVzc31gKTsKICAgICAgICAgICAg
bG9nVHJhbnNmb3JtTWF0cml4KCJzcXVhcmVMaW5lYXIiKTsKICAgICAgICAgICAgbG9nVHJhbnNm
b3JtTWF0cml4KCJzcXVhcmVTdGVwcyIpOwoJICAgIGluZGV4Kys7CgkgIH0KICAgICAgICAgIHdp
bmRvdy5yZXF1ZXN0QW5pbWF0aW9uRnJhbWUoc3RlcCk7Cgl9CglmdW5jdGlvbiBydW5UZXN0KCkg
ewoJICB3aW5kb3cucmVxdWVzdEFuaW1hdGlvbkZyYW1lKHN0ZXApOwoJfQogICAgICA8L3Njcmlw
dD4KICA8L2hlYWQ+CiAgPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgogICAgPGRpdiBpZD0iY29u
dGFpbmVyIj4KICAgICAgPGRpdiBpZD0ic3F1YXJlTGluZWFyIj48L2Rpdj4KICAgICAgPGRpdiBp
ZD0ic3F1YXJlU3RlcHMiPjwvZGl2PgogICAgPC9kaXY+CiAgPC9ib2R5Pgo8L2h0bWw+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>342943</attachid>
            <date>2018-06-18 09:09:26 -0700</date>
            <delta_ts>2018-06-18 09:09:26 -0700</delta_ts>
            <desc>Testcase</desc>
            <filename>186129.html</filename>
            <type>text/html</type>
            <size>1232</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPG1ldGEgY2hhcnNldD0idXRmLTgi
PgogICAgPHRpdGxlPkJ1ZyAxODYxMjk8L3RpdGxlPgogICAgPHN0eWxlPgogICAgICAjY29udGFp
bmVyIHsKICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAgICAgbGVmdDogMDsKICAgICAg
ICB0b3A6IDNlbTsKICAgICAgfQogICAgICAjc3F1YXJlTGluZWFyLCAjc3F1YXJlU3RlcHMsICNz
cXVhcmVOb25BY2NlbGVyYXRlZCAgewogICAgICAgIHdpZHRoOiAxMDBweDsKICAgICAgICBoZWln
aHQ6IDEwMHB4OwogICAgICAgIGJhY2tncm91bmQ6IGxpZ2h0Ymx1ZTsKICAgICAgICBwb3NpdGlv
bjogYWJzb2x1dGU7CiAgICAgICAgbGVmdDogLTUwcHg7CiAgICAgIH0KICAgICAgI3NxdWFyZUxp
bmVhciB7CiAgICAgICAgdG9wOiAwcHg7CiAgICAgICAgYW5pbWF0aW9uOiBtb3ZlQnlUcmFuc2Zv
cm0gMnMgbGluZWFyIGluZmluaXRlOwogICAgICB9CiAgICAgICNzcXVhcmVTdGVwcyB7CiAgICAg
ICAgdG9wOiAxNTBweDsKICAgICAgICBhbmltYXRpb246IG1vdmVCeVRyYW5zZm9ybSAycyBzdGVw
cyg0KSBpbmZpbml0ZTsKICAgICAgfQogICAgICAjc3F1YXJlTm9uQWNjZWxlcmF0ZWQgIHsKICAg
ICAgICB0b3A6IDMwMHB4OwogICAgICAgIGFuaW1hdGlvbjogbW92ZUJ5TGVmdCAycyBzdGVwcyg0
KSBpbmZpbml0ZTsKICAgICAgfQogICAgICBAa2V5ZnJhbWVzIG1vdmVCeVRyYW5zZm9ybQogICAg
ICB7CiAgICAgICAgMTAwJSB7CiAgICAgICAgICB0cmFuc2Zvcm06IHRyYW5zbGF0ZSg1MDBweCk7
CiAgICAgICAgfQogICAgICB9CiAgICAgIEBrZXlmcmFtZXMgbW92ZUJ5TGVmdAogICAgICB7CiAg
ICAgICAgMCUgewogICAgICAgICAgbGVmdDogLTUwcHg7CiAgICAgICAgfQogICAgICAgIDEwMCUg
ewogICAgICAgICAgbGVmdDogNDUwcHg7CiAgICAgICAgfQogICAgICB9CiAgICAgIDwvc3R5bGU+
CiAgPC9oZWFkPgogIDxib2R5PgogICAgPGRpdiBpZD0iY29udGFpbmVyIj4KICAgICAgPGRpdiBp
ZD0ic3F1YXJlTGluZWFyIj48dHQ+dHJhbnNmb3JtPC90dD4gKGxpbmVhcik8L2Rpdj4KICAgICAg
PGRpdiBpZD0ic3F1YXJlU3RlcHMiPjx0dD50cmFuc2Zvcm08L3R0PiAoc3RlcHMpPC9kaXY+CiAg
ICAgIDxkaXYgaWQ9InNxdWFyZU5vbkFjY2VsZXJhdGVkIj48dHQ+bGVmdDwvdHQ+IChzdGVwcyk8
L2Rpdj4KICAgIDwvZGl2PgogIDwvYm9keT4KPC9odG1sPgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>344178</attachid>
            <date>2018-07-03 05:49:23 -0700</date>
            <delta_ts>2018-07-03 07:22:04 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-186129-20180703144922.patch</filename>
            <type>text/plain</type>
            <size>7236</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRhZWYwYzhjN2FkYzQ4
ZDNiMzlhMDA4Nzc1OGI3ZDg5N2M4MDhkYS4uYjUxODM0OTljODNiYWE2ODU3YmE4ZTc5NDM1NjQy
YmVhOWYwOTVjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTA3LTAzICBGcmVk
ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjMy
MTg2KTogSGFyZHdhcmUtYWNjZWxlcmF0ZWQgQ1NTIGFuaW1hdGlvbnMgdXNpbmcgc3RlcHMoKSB0
aW1pbmcgZnVuY3Rpb24gbm8gbG9uZ2VyIHdvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjEyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdGhlIFdlYkFuaW1hdGlvbnNDU1NJbnRlZ3JhdGlv
biBmbGFnIGlzIGVuYWJsZWQsIGFuaW1hdGluZyB0aGUgdHJhbnNmb3JtIHByb3BlcnR5IHdpdGgK
KyAgICAgICAgYSBzdGVwcygpIHRpbWluZyBmdW5jdGlvbiBubyBsb25nZXIgd29ya3MuIFRoaXMg
aXMgYmVjYXVzZSB0aGUgV2ViQW5pbWF0aW9uIGNvZGUgd3JvbmdseQorICAgICAgICBhc3N1bWVz
IHRoYXQgdGhlIHRyYW5zZm9ybSBwcm9wZXJ0eSBjYW4gYWx3YXlzIGJlIGFjY2VsZXJhdGVkIChm
b3IgY291bnRlcmV4YW1wbGVzLCBzZWUKKyAgICAgICAgR3JhcGhpY3NMYXllckNBOjphbmltYXRp
b25DYW5CZUFjY2VsZXJhdGVkKS4gRm9yIGNvbnNpc3RlbmN5IHdpdGggQW5pbWF0aW9uQmFzZSwg
d2UgbWFrZQorICAgICAgICBXZWJBbmltYXRpb24gZmFsbGJhY2sgdG8gbm9uLWFjY2VsZXJhdGVk
IG1vZGUgd2hlbiBSZW5kZXJCb3hNb2RlbE9iamVjdDo6c3RhcnRBbmltYXRpb24KKyAgICAgICAg
ZmFpbHMuIFRoaXMgYWRkcmVzc2VzIHRoZSByZWdyZXNzaW9uIHByZXZpb3VzbHkgbWVudGlvbmVk
LgorCisgICAgICAgIFRlc3Q6IGh0dHAvd3B0L2Nzcy9jc3MtYW5pbWF0aW9ucy9zdGFydC1hbmlt
YXRpb24tMDAxLmh0bWwKKworICAgICAgICAqIGFuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdFJlYWRP
bmx5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OktleWZyYW1lRWZmZWN0UmVhZE9ubHk6OmFwcGx5
UGVuZGluZ0FjY2VsZXJhdGVkQWN0aW9ucyk6IEZhbGxiYWNrIHRvCisgICAgICAgIG5vbi1hY2Nl
bGVyYXRlZCBtb2RlIGlmIHN0YXJ0QW5pbWF0aW9uIGZhaWxlZC4KKwogMjAxOC0wNy0wMyAgRGF2
aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEFkZCBhc3Nl
cnQgdG8gY2F0Y2ggaW1wcm9wZXIgdXNlIG9mIFdlYkNvcmU6OlRpbWVyIGluIFVJIFByb2Nlc3MK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdFJlYWRP
bmx5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdFJlYWRPbmx5
LmNwcAppbmRleCA5ZTQyMWRmOWUxMzk5OGIwMmViMWMwZWQwNmEyOTUxYjFhNjQ4NjNhLi45ZGI0
NDZhMzk5NTBiM2Q0M2I3NjJhOWI0MDcyYThlMGViZmNjNDQ0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3RSZWFkT25seS5jcHAKKysrIGIvU291cmNl
L1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0UmVhZE9ubHkuY3BwCkBAIC0xMjU0LDcg
KzEyNTQsMTAgQEAgdm9pZCBLZXlmcmFtZUVmZmVjdFJlYWRPbmx5OjphcHBseVBlbmRpbmdBY2Nl
bGVyYXRlZEFjdGlvbnMoKQogICAgIGZvciAoY29uc3QgYXV0byYgYWN0aW9uIDogcGVuZGluZ0Fj
Y2VsZXJhdGlvbkFjdGlvbnMpIHsKICAgICAgICAgc3dpdGNoIChhY3Rpb24pIHsKICAgICAgICAg
Y2FzZSBBY2NlbGVyYXRlZEFjdGlvbjo6UGxheToKLSAgICAgICAgICAgIGNvbXBvc2l0ZWRSZW5k
ZXJlci0+c3RhcnRBbmltYXRpb24odGltZU9mZnNldCwgYmFja2luZ0FuaW1hdGlvbkZvckNvbXBv
c2l0ZWRSZW5kZXJlcigpLnB0cigpLCBtX2JsZW5kaW5nS2V5ZnJhbWVzKTsKKyAgICAgICAgICAg
IGlmICghY29tcG9zaXRlZFJlbmRlcmVyLT5zdGFydEFuaW1hdGlvbih0aW1lT2Zmc2V0LCBiYWNr
aW5nQW5pbWF0aW9uRm9yQ29tcG9zaXRlZFJlbmRlcmVyKCkucHRyKCksIG1fYmxlbmRpbmdLZXlm
cmFtZXMpKSB7CisgICAgICAgICAgICAgICAgbV9zaG91bGRSdW5BY2NlbGVyYXRlZCA9IGZhbHNl
OworICAgICAgICAgICAgICAgIG1fbGFzdFJlY29yZGVkQWNjZWxlcmF0ZWRBY3Rpb24gPSBBY2Nl
bGVyYXRlZEFjdGlvbjo6U3RvcDsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIGJyZWFrOwog
ICAgICAgICBjYXNlIEFjY2VsZXJhdGVkQWN0aW9uOjpQYXVzZToKICAgICAgICAgICAgIGNvbXBv
c2l0ZWRSZW5kZXJlci0+YW5pbWF0aW9uUGF1c2VkKHRpbWVPZmZzZXQsIG1fYmxlbmRpbmdLZXlm
cmFtZXMuYW5pbWF0aW9uTmFtZSgpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv
ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiMTI3YTA5YjBkM2NmN2IxYzk5ZjcwODQy
MzcwN2UxYjFmOTQ5MjUxLi4yZTMxNDgzMzk2MGYwMDQ0ZmM0NTQ5ZDEzOGY1MzRjNTgxZTI3MWI2
IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDctMDMgIEZyZWRlcmljIFdhbmcgIDxmd2Fu
Z0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMzIxODYpOiBIYXJkd2FyZS1h
Y2NlbGVyYXRlZCBDU1MgYW5pbWF0aW9ucyB1c2luZyBzdGVwcygpIHRpbWluZyBmdW5jdGlvbiBu
byBsb25nZXIgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTg2MTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgQWRkIGEgdGVzdCB0byBlbnN1cmUgdGhhdCBhY2NlbGVyYXRlZCBhbmQgbm9uLWFjY2Vs
ZXJhdGVkIGFuaW1hdGlvbnMgYXJlIHByb3Blcmx5IHN0YXJ0ZWQKKyAgICAgICAgd2hlbiBXZWJB
bmltYXRpb25zQ1NTSW50ZWdyYXRpb24gaXMgZW5hYmxlZC4gSW4gcGFydGljdWxhciwgY29uc2lk
ZXIgdGhlIGNhc2Ugb2YgYW5pbWF0ZWQKKyAgICAgICAgdHJhbnNmb3JtIHVzaW5nIHN0ZXBzKCkg
dGltaW5nIGZ1bmN0aW9uLgorCisgICAgICAgICogaHR0cC93cHQvY3NzL2Nzcy1hbmltYXRpb25z
L3N0YXJ0LWFuaW1hdGlvbi0wMDEtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogaHR0
cC93cHQvY3NzL2Nzcy1hbmltYXRpb25zL3N0YXJ0LWFuaW1hdGlvbi0wMDEuaHRtbDogQWRkZWQu
CisKIDIwMTgtMDctMDMgIEZyZWRlcmljIFdhbmcgIDxmcmVkLndhbmdAZnJlZS5mcj4KIAogICAg
ICAgICBbaU9TXSBBbmltYXRpb25zIHdpdGggQsOpemllciB0aW1pbmcgZnVuY3Rpb24gbm90IHN1
c3BlbmRlZCBvbiBVSSBwcm9jZXNzIHdoZW4gYW5pbWF0aW9uLXBsYXktc3RhdGUgaXMgc2V0IHRv
ICJwYXVzZWQiCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3dwdC9jc3MvY3NzLWFuaW1h
dGlvbnMvc3RhcnQtYW5pbWF0aW9uLTAwMS1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvaHR0
cC93cHQvY3NzL2Nzcy1hbmltYXRpb25zL3N0YXJ0LWFuaW1hdGlvbi0wMDEtZXhwZWN0ZWQuaHRt
bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwLi4yZWRhYzhmYzI3YjIxZDkxMzhkMTRjODliMjNlZTMxMzQxOGE4NjMxCi0t
LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvY3NzL2Nzcy1hbmltYXRpb25z
L3N0YXJ0LWFuaW1hdGlvbi0wMDEtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDI4IEBACis8IURP
Q1RZUEUgaHRtbD4KKzxodG1sPgorICA8aGVhZD4KKyAgICA8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+
CisgICAgPHRpdGxlPlZlcmlmeSB0aGF0IGFuaW1hdGlvbnMgcHJvcGVybHkgc3RhcnQgKHJlZmVy
ZW5jZSk8L3RpdGxlPgorICAgIDxzdHlsZT4KKyAgICAgICNjb250YWluZXIgeworICAgICAgICBw
b3NpdGlvbjogYWJzb2x1dGU7CisgICAgICAgIGxlZnQ6IDA7CisgICAgICAgIHRvcDogM2VtOwor
ICAgICAgfQorICAgICAgI2NvdmVyaW5nUmVjdCB7CisgICAgICAgIGJhY2tncm91bmQ6IGJsdWU7
CisgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgdG9wOiAtMTBweDsKKyAgICAg
ICAgbGVmdDogOTBweDsKKyAgICAgICAgd2lkdGg6IDUwMDBweDsKKyAgICAgICAgaGVpZ2h0OiA1
MDBweDsKKyAgICAgIH0KKyAgICA8L3N0eWxlPgorICA8L2hlYWQ+CisgIDxib2R5PgorICAgIDxw
PlRoaXMgdGVzdCBwYXNzZXMgaWYgZ3JlZW4gc3F1YXJlcyBhcmUgbW92ZWQgYmVoaW5kIHRoZSBi
bHVlIHJlY3RhbmdsZS48L3A+CisgICAgPGRpdiBpZD0iY29udGFpbmVyIj4KKyAgICAgIDxkaXYg
aWQ9ImNvdmVyaW5nUmVjdCI+PC9kaXY+CisgICAgPC9kaXY+CisgIDwvYm9keT4KKzwvaHRtbD4K
ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvd3B0L2Nzcy9jc3MtYW5pbWF0aW9ucy9zdGFy
dC1hbmltYXRpb24tMDAxLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9jc3MvY3NzLWFuaW1h
dGlvbnMvc3RhcnQtYW5pbWF0aW9uLTAwMS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4
IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjE0ZjE5ZmU4NTYwZTA4
YzM5ZTlmYmI3ZWU5ZDY4OGI1Y2Q4ZWUwM2EKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0
cy9odHRwL3dwdC9jc3MvY3NzLWFuaW1hdGlvbnMvc3RhcnQtYW5pbWF0aW9uLTAwMS5odG1sCkBA
IC0wLDAgKzEsNzYgQEAKKzwhRE9DVFlQRSBodG1sPjwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsg
ZW5hYmxlV2ViQW5pbWF0aW9uc0NTU0ludGVncmF0aW9uPXRydWUgXSAtLT4KKzxodG1sPgorICA8
aGVhZD4KKyAgICA8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+CisgICAgPHRpdGxlPlZlcmlmeSB0aGF0
IGFuaW1hdGlvbnMgcHJvcGVybHkgc3RhcnQ8L3RpdGxlPgorICAgIDxzdHlsZT4KKyAgICAgICNj
b250YWluZXIgeworICAgICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CisgICAgICAgIGxlZnQ6IDA7
CisgICAgICAgIHRvcDogM2VtOworICAgICAgfQorICAgICAgI3NxdWFyZUxpbmVhciwgI3NxdWFy
ZVN0ZXBzLCAjc3F1YXJlTm9uQWNjZWxlcmF0ZWQgIHsKKyAgICAgICAgd2lkdGg6IDEwMHB4Owor
ICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgICBiYWNrZ3JvdW5kOiBsaWdodGJsdWU7Cisg
ICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgIH0KKyAgICAgIC8qIEF2b2lkIGFuaW1h
dGlvbi1maWxsLW1vZGUsIHRvIG1ha2Ugc3VyZSB0aGF0IHRoZSBtb3ZlIGlzIGRvbmUgYnkgdGhl
IGFuaW1hdGlvbiBjb2RlLiAqLworICAgICAgI3NxdWFyZUxpbmVhciB7CisgICAgICAgIHRvcDog
MHB4OworICAgICAgICBhbmltYXRpb246IG1vdmVCeVRyYW5zZm9ybSAxMHMgbGluZWFyOworICAg
ICAgfQorICAgICAgI3NxdWFyZVN0ZXBzIHsKKyAgICAgICAgdG9wOiAxNTBweDsKKyAgICAgICAg
YW5pbWF0aW9uOiBtb3ZlQnlUcmFuc2Zvcm0gMTBzIHN0ZXBzKDEwMDApOworICAgICAgfQorICAg
ICAgI3NxdWFyZU5vbkFjY2VsZXJhdGVkICB7CisgICAgICAgIHRvcDogMzAwcHg7CisgICAgICAg
IGFuaW1hdGlvbjogbW92ZUJ5TGVmdCAxMHMgc3RlcHMoMTAwKTsKKyAgICAgIH0KKyAgICAgIEBr
ZXlmcmFtZXMgbW92ZUJ5VHJhbnNmb3JtCisgICAgICB7CisgICAgICAgIDEwMCUgeworICAgICAg
ICAgIHRyYW5zZm9ybTogdHJhbnNsYXRlKDUwMDBweCk7CisgICAgICAgIH0KKyAgICAgIH0KKyAg
ICAgIEBrZXlmcmFtZXMgbW92ZUJ5TGVmdAorICAgICAgeworICAgICAgICAwJSB7CisgICAgICAg
ICAgbGVmdDogMHB4OworICAgICAgICB9CisgICAgICAgIDEwMCUgeworICAgICAgICAgIGxlZnQ6
IDUwMDBweDsKKyAgICAgICAgfQorICAgICAgfQorICAgICAgI2NvdmVyaW5nUmVjdCB7CisgICAg
ICAgIGJhY2tncm91bmQ6IGJsdWU7CisgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAg
ICAgdG9wOiAtMTBweDsKKyAgICAgICAgbGVmdDogOTBweDsKKyAgICAgICAgd2lkdGg6IDUwMDBw
eDsKKyAgICAgICAgaGVpZ2h0OiA1MDBweDsKKyAgICAgIH0KKyAgICA8L3N0eWxlPgorICAgIDxz
Y3JpcHQ+CisgICAgICBmdW5jdGlvbiBydW5UZXN0KCkgeworICAgICAgICBpZiAoIXdpbmRvdy50
ZXN0UnVubmVyKQorICAgICAgICAgIHJldHVybjsKKyAgICAgICAgLy8gV2Ugd2FpdCBhIGJpdCBh
ZnRlciB0aGUgc3F1YXJlcyBhcmUgbW92ZWQgYmVoaW5kIHRoZSBibHVlIHJlY3RhbmdsZS4gRm9y
IGRpc2NvbnRpbnVvdXMKKyAgICAgICAgLy8gdHJhbnNmb3JtcyB3ZSBoYXZlIDUwMDBweCAvIDEw
MCBzdGVwcyA9IDVweC9zdGVwLiBIZW5jZSB0aGlzIGhhcHBlbnMgYWZ0ZXIgMjAgc3RlcHMgaS5l
LgorICAgICAgICAvLyAyMC8xMDAqMTBzID0gMjAwbXMuCisgICAgICAgIHRlc3RSdW5uZXIud2Fp
dFVudGlsRG9uZSgpOworICAgICAgICBzZXRUaW1lb3V0KCgpID0+IHsgdGVzdFJ1bm5lci5ub3Rp
ZnlEb25lKCk7IH0sIDMwMCk7CisgICAgICB9CisgICAgPC9zY3JpcHQ+CisgIDwvaGVhZD4KKyAg
PGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorICAgIDxwPlRoaXMgdGVzdCBwYXNzZXMgaWYgZ3Jl
ZW4gc3F1YXJlcyBhcmUgbW92ZWQgYmVoaW5kIHRoZSBibHVlIHJlY3RhbmdsZS48L3A+CisgICAg
PGRpdiBpZD0iY29udGFpbmVyIj4KKyAgICAgIDxkaXYgaWQ9InNxdWFyZUxpbmVhciI+PHR0PnRy
YW5zZm9ybTwvdHQ+IChsaW5lYXIpPC9kaXY+CisgICAgICA8ZGl2IGlkPSJzcXVhcmVTdGVwcyI+
PHR0PnRyYW5zZm9ybTwvdHQ+IChzdGVwcyk8L2Rpdj4KKyAgICAgIDxkaXYgaWQ9InNxdWFyZU5v
bkFjY2VsZXJhdGVkIj48dHQ+bGVmdDwvdHQ+IChzdGVwcyk8L2Rpdj4KKyAgICAgIDxkaXYgaWQ9
ImNvdmVyaW5nUmVjdCI+PC9kaXY+CisgICAgPC9kaXY+CisgIDwvYm9keT4KKzwvaHRtbD4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>344186</attachid>
            <date>2018-07-03 07:22:08 -0700</date>
            <delta_ts>2018-07-03 08:02:01 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-186129-20180703162207.patch</filename>
            <type>text/plain</type>
            <size>7259</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzNDYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDRhZWYwYzhjN2FkYzQ4
ZDNiMzlhMDA4Nzc1OGI3ZDg5N2M4MDhkYS4uYjlhMjQzNTNhNWJmMmVhNWNlZmNkNjI3MTg2MWFj
YjdiNjI1MjllNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTA3LTAzICBGcmVk
ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjMy
MTg2KTogSGFyZHdhcmUtYWNjZWxlcmF0ZWQgQ1NTIGFuaW1hdGlvbnMgdXNpbmcgc3RlcHMoKSB0
aW1pbmcgZnVuY3Rpb24gbm8gbG9uZ2VyIHdvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjEyOQorCisgICAgICAgIFJldmlld2VkIGJ5IEFudG9p
bmUgUXVpbnQuCisKKyAgICAgICAgV2hlbiB0aGUgV2ViQW5pbWF0aW9uc0NTU0ludGVncmF0aW9u
IGZsYWcgaXMgZW5hYmxlZCwgYW5pbWF0aW5nIHRoZSB0cmFuc2Zvcm0gcHJvcGVydHkgd2l0aAor
ICAgICAgICBhIHN0ZXBzKCkgdGltaW5nIGZ1bmN0aW9uIG5vIGxvbmdlciB3b3Jrcy4gVGhpcyBp
cyBiZWNhdXNlIHRoZSBXZWJBbmltYXRpb24gY29kZSB3cm9uZ2x5CisgICAgICAgIGFzc3VtZXMg
dGhhdCB0aGUgdHJhbnNmb3JtIHByb3BlcnR5IGNhbiBhbHdheXMgYmUgYWNjZWxlcmF0ZWQgKGZv
ciBjb3VudGVyZXhhbXBsZXMsIHNlZQorICAgICAgICBHcmFwaGljc0xheWVyQ0E6OmFuaW1hdGlv
bkNhbkJlQWNjZWxlcmF0ZWQpLiBGb3IgY29uc2lzdGVuY3kgd2l0aCBBbmltYXRpb25CYXNlLCB3
ZSBtYWtlCisgICAgICAgIFdlYkFuaW1hdGlvbiBmYWxsYmFjayB0byBub24tYWNjZWxlcmF0ZWQg
bW9kZSB3aGVuIFJlbmRlckJveE1vZGVsT2JqZWN0OjpzdGFydEFuaW1hdGlvbgorICAgICAgICBm
YWlscy4gVGhpcyBhZGRyZXNzZXMgdGhlIHJlZ3Jlc3Npb24gcHJldmlvdXNseSBtZW50aW9uZWQu
CisKKyAgICAgICAgVGVzdDogaHR0cC93cHQvY3NzL2Nzcy1hbmltYXRpb25zL3N0YXJ0LWFuaW1h
dGlvbi0wMDEuaHRtbAorCisgICAgICAgICogYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0UmVhZE9u
bHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6S2V5ZnJhbWVFZmZlY3RSZWFkT25seTo6YXBwbHlQ
ZW5kaW5nQWNjZWxlcmF0ZWRBY3Rpb25zKTogRmFsbGJhY2sgdG8KKyAgICAgICAgbm9uLWFjY2Vs
ZXJhdGVkIG1vZGUgaWYgc3RhcnRBbmltYXRpb24gZmFpbGVkLgorCiAyMDE4LTA3LTAzICBEYXZp
ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gQWRkIGFzc2Vy
dCB0byBjYXRjaCBpbXByb3BlciB1c2Ugb2YgV2ViQ29yZTo6VGltZXIgaW4gVUkgUHJvY2Vzcwpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0UmVhZE9u
bHkuY3BwIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0UmVhZE9ubHku
Y3BwCmluZGV4IDllNDIxZGY5ZTEzOTk4YjAyZWIxYzBlZDA2YTI5NTFiMWE2NDg2M2EuLjU5MGI0
MDJkYjM2ZGY1OGZjZWI1ZTc5NDBmOWNmNmQ5NDQxMjI4YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJDb3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdFJlYWRPbmx5LmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3RSZWFkT25seS5jcHAKQEAgLTEyNTQsNyAr
MTI1NCwxMSBAQCB2b2lkIEtleWZyYW1lRWZmZWN0UmVhZE9ubHk6OmFwcGx5UGVuZGluZ0FjY2Vs
ZXJhdGVkQWN0aW9ucygpCiAgICAgZm9yIChjb25zdCBhdXRvJiBhY3Rpb24gOiBwZW5kaW5nQWNj
ZWxlcmF0aW9uQWN0aW9ucykgewogICAgICAgICBzd2l0Y2ggKGFjdGlvbikgewogICAgICAgICBj
YXNlIEFjY2VsZXJhdGVkQWN0aW9uOjpQbGF5OgotICAgICAgICAgICAgY29tcG9zaXRlZFJlbmRl
cmVyLT5zdGFydEFuaW1hdGlvbih0aW1lT2Zmc2V0LCBiYWNraW5nQW5pbWF0aW9uRm9yQ29tcG9z
aXRlZFJlbmRlcmVyKCkucHRyKCksIG1fYmxlbmRpbmdLZXlmcmFtZXMpOworICAgICAgICAgICAg
aWYgKCFjb21wb3NpdGVkUmVuZGVyZXItPnN0YXJ0QW5pbWF0aW9uKHRpbWVPZmZzZXQsIGJhY2tp
bmdBbmltYXRpb25Gb3JDb21wb3NpdGVkUmVuZGVyZXIoKS5wdHIoKSwgbV9ibGVuZGluZ0tleWZy
YW1lcykpIHsKKyAgICAgICAgICAgICAgICBtX3Nob3VsZFJ1bkFjY2VsZXJhdGVkID0gZmFsc2U7
CisgICAgICAgICAgICAgICAgbV9sYXN0UmVjb3JkZWRBY2NlbGVyYXRlZEFjdGlvbiA9IEFjY2Vs
ZXJhdGVkQWN0aW9uOjpTdG9wOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAg
IH0KICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEFjY2VsZXJhdGVkQWN0aW9uOjpQ
YXVzZToKICAgICAgICAgICAgIGNvbXBvc2l0ZWRSZW5kZXJlci0+YW5pbWF0aW9uUGF1c2VkKHRp
bWVPZmZzZXQsIG1fYmxlbmRpbmdLZXlmcmFtZXMuYW5pbWF0aW9uTmFtZSgpKTsKZGlmZiAtLWdp
dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBi
MTI3YTA5YjBkM2NmN2IxYzk5ZjcwODQyMzcwN2UxYjFmOTQ5MjUxLi4zOGI0MWU5NDQ2ZjVhNWNi
YzFkOGE0NmZhOGU3NjQ1NGFlMjNkYjJhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDct
MDMgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJ
T04gKHIyMzIxODYpOiBIYXJkd2FyZS1hY2NlbGVyYXRlZCBDU1MgYW5pbWF0aW9ucyB1c2luZyBz
dGVwcygpIHRpbWluZyBmdW5jdGlvbiBubyBsb25nZXIgd29yaworICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2MTI5CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgQW50b2luZSBRdWludC4KKworICAgICAgICBBZGQgYSB0ZXN0IHRvIGVuc3VyZSB0aGF0IGFj
Y2VsZXJhdGVkIGFuZCBub24tYWNjZWxlcmF0ZWQgYW5pbWF0aW9ucyBhcmUgcHJvcGVybHkgc3Rh
cnRlZAorICAgICAgICB3aGVuIFdlYkFuaW1hdGlvbnNDU1NJbnRlZ3JhdGlvbiBpcyBlbmFibGVk
LiBJbiBwYXJ0aWN1bGFyLCBjb25zaWRlciB0aGUgY2FzZSBvZiBhbmltYXRlZAorICAgICAgICB0
cmFuc2Zvcm0gdXNpbmcgc3RlcHMoKSB0aW1pbmcgZnVuY3Rpb24uCisKKyAgICAgICAgKiBodHRw
L3dwdC9jc3MvY3NzLWFuaW1hdGlvbnMvc3RhcnQtYW5pbWF0aW9uLTAwMS1leHBlY3RlZC5odG1s
OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3dwdC9jc3MvY3NzLWFuaW1hdGlvbnMvc3RhcnQtYW5p
bWF0aW9uLTAwMS5odG1sOiBBZGRlZC4KKwogMjAxOC0wNy0wMyAgRnJlZGVyaWMgV2FuZyAgPGZy
ZWQud2FuZ0BmcmVlLmZyPgogCiAgICAgICAgIFtpT1NdIEFuaW1hdGlvbnMgd2l0aCBCw6l6aWVy
IHRpbWluZyBmdW5jdGlvbiBub3Qgc3VzcGVuZGVkIG9uIFVJIHByb2Nlc3Mgd2hlbiBhbmltYXRp
b24tcGxheS1zdGF0ZSBpcyBzZXQgdG8gInBhdXNlZCIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz
L2h0dHAvd3B0L2Nzcy9jc3MtYW5pbWF0aW9ucy9zdGFydC1hbmltYXRpb24tMDAxLWV4cGVjdGVk
Lmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9jc3MvY3NzLWFuaW1hdGlvbnMvc3RhcnQtYW5p
bWF0aW9uLTAwMS1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJlZGFjOGZjMjdiMjFkOTEzOGQx
NGM4OWIyM2VlMzEzNDE4YTg2MzEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRw
L3dwdC9jc3MvY3NzLWFuaW1hdGlvbnMvc3RhcnQtYW5pbWF0aW9uLTAwMS1leHBlY3RlZC5odG1s
CkBAIC0wLDAgKzEsMjggQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+CisgIDxoZWFkPgorICAg
IDxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KKyAgICA8dGl0bGU+VmVyaWZ5IHRoYXQgYW5pbWF0aW9u
cyBwcm9wZXJseSBzdGFydCAocmVmZXJlbmNlKTwvdGl0bGU+CisgICAgPHN0eWxlPgorICAgICAg
I2NvbnRhaW5lciB7CisgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgbGVmdDog
MDsKKyAgICAgICAgdG9wOiAzZW07CisgICAgICB9CisgICAgICAjY292ZXJpbmdSZWN0IHsKKyAg
ICAgICAgYmFja2dyb3VuZDogYmx1ZTsKKyAgICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAg
ICAgICB0b3A6IC0xMHB4OworICAgICAgICBsZWZ0OiA5MHB4OworICAgICAgICB3aWR0aDogNTAw
MHB4OworICAgICAgICBoZWlnaHQ6IDUwMHB4OworICAgICAgfQorICAgIDwvc3R5bGU+CisgIDwv
aGVhZD4KKyAgPGJvZHk+CisgICAgPHA+VGhpcyB0ZXN0IHBhc3NlcyBpZiBncmVlbiBzcXVhcmVz
IGFyZSBtb3ZlZCBiZWhpbmQgdGhlIGJsdWUgcmVjdGFuZ2xlLjwvcD4KKyAgICA8ZGl2IGlkPSJj
b250YWluZXIiPgorICAgICAgPGRpdiBpZD0iY292ZXJpbmdSZWN0Ij48L2Rpdj4KKyAgICA8L2Rp
dj4KKyAgPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC93cHQv
Y3NzL2Nzcy1hbmltYXRpb25zL3N0YXJ0LWFuaW1hdGlvbi0wMDEuaHRtbCBiL0xheW91dFRlc3Rz
L2h0dHAvd3B0L2Nzcy9jc3MtYW5pbWF0aW9ucy9zdGFydC1hbmltYXRpb24tMDAxLmh0bWwKbmV3
IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMC4uMTRmMTlmZTg1NjBlMDhjMzllOWZiYjdlZTlkNjg4YjVjZDhlZTAzYQotLS0gL2Rl
di9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvd3B0L2Nzcy9jc3MtYW5pbWF0aW9ucy9zdGFy
dC1hbmltYXRpb24tMDAxLmh0bWwKQEAgLTAsMCArMSw3NiBAQAorPCFET0NUWVBFIGh0bWw+PCEt
LSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBlbmFibGVXZWJBbmltYXRpb25zQ1NTSW50ZWdyYXRpb249
dHJ1ZSBdIC0tPgorPGh0bWw+CisgIDxoZWFkPgorICAgIDxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4K
KyAgICA8dGl0bGU+VmVyaWZ5IHRoYXQgYW5pbWF0aW9ucyBwcm9wZXJseSBzdGFydDwvdGl0bGU+
CisgICAgPHN0eWxlPgorICAgICAgI2NvbnRhaW5lciB7CisgICAgICAgIHBvc2l0aW9uOiBhYnNv
bHV0ZTsKKyAgICAgICAgbGVmdDogMDsKKyAgICAgICAgdG9wOiAzZW07CisgICAgICB9CisgICAg
ICAjc3F1YXJlTGluZWFyLCAjc3F1YXJlU3RlcHMsICNzcXVhcmVOb25BY2NlbGVyYXRlZCAgewor
ICAgICAgICB3aWR0aDogMTAwcHg7CisgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgIGJh
Y2tncm91bmQ6IGxpZ2h0Ymx1ZTsKKyAgICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAg
fQorICAgICAgLyogQXZvaWQgYW5pbWF0aW9uLWZpbGwtbW9kZSwgdG8gbWFrZSBzdXJlIHRoYXQg
dGhlIG1vdmUgaXMgZG9uZSBieSB0aGUgYW5pbWF0aW9uIGNvZGUuICovCisgICAgICAjc3F1YXJl
TGluZWFyIHsKKyAgICAgICAgdG9wOiAwcHg7CisgICAgICAgIGFuaW1hdGlvbjogbW92ZUJ5VHJh
bnNmb3JtIDEwcyBsaW5lYXI7CisgICAgICB9CisgICAgICAjc3F1YXJlU3RlcHMgeworICAgICAg
ICB0b3A6IDE1MHB4OworICAgICAgICBhbmltYXRpb246IG1vdmVCeVRyYW5zZm9ybSAxMHMgc3Rl
cHMoMTAwMCk7CisgICAgICB9CisgICAgICAjc3F1YXJlTm9uQWNjZWxlcmF0ZWQgIHsKKyAgICAg
ICAgdG9wOiAzMDBweDsKKyAgICAgICAgYW5pbWF0aW9uOiBtb3ZlQnlMZWZ0IDEwcyBzdGVwcygx
MDApOworICAgICAgfQorICAgICAgQGtleWZyYW1lcyBtb3ZlQnlUcmFuc2Zvcm0KKyAgICAgIHsK
KyAgICAgICAgMTAwJSB7CisgICAgICAgICAgdHJhbnNmb3JtOiB0cmFuc2xhdGUoNTAwMHB4KTsK
KyAgICAgICAgfQorICAgICAgfQorICAgICAgQGtleWZyYW1lcyBtb3ZlQnlMZWZ0CisgICAgICB7
CisgICAgICAgIDAlIHsKKyAgICAgICAgICBsZWZ0OiAwcHg7CisgICAgICAgIH0KKyAgICAgICAg
MTAwJSB7CisgICAgICAgICAgbGVmdDogNTAwMHB4OworICAgICAgICB9CisgICAgICB9CisgICAg
ICAjY292ZXJpbmdSZWN0IHsKKyAgICAgICAgYmFja2dyb3VuZDogYmx1ZTsKKyAgICAgICAgcG9z
aXRpb246IGFic29sdXRlOworICAgICAgICB0b3A6IC0xMHB4OworICAgICAgICBsZWZ0OiA5MHB4
OworICAgICAgICB3aWR0aDogNTAwMHB4OworICAgICAgICBoZWlnaHQ6IDUwMHB4OworICAgICAg
fQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlwdD4KKyAgICAgIGZ1bmN0aW9uIHJ1blRlc3QoKSB7
CisgICAgICAgIGlmICghd2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgICAgcmV0dXJuOworICAg
ICAgICAvLyBXZSB3YWl0IGEgYml0IGFmdGVyIHRoZSBzcXVhcmVzIGFyZSBtb3ZlZCBiZWhpbmQg
dGhlIGJsdWUgcmVjdGFuZ2xlLiBGb3IgZGlzY29udGludW91cworICAgICAgICAvLyB0cmFuc2Zv
cm1zIHdlIGhhdmUgNTAwMHB4IC8gMTAwIHN0ZXBzID0gNXB4L3N0ZXAuIEhlbmNlIHRoaXMgaGFw
cGVucyBhZnRlciAyMCBzdGVwcyBpLmUuCisgICAgICAgIC8vIDIwLzEwMCoxMHMgPSAyMDBtcy4K
KyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgICAgIHNldFRpbWVvdXQo
KCkgPT4geyB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsgfSwgMzAwKTsKKyAgICAgIH0KKyAgICA8
L3NjcmlwdD4KKyAgPC9oZWFkPgorICA8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+CisgICAgPHA+
VGhpcyB0ZXN0IHBhc3NlcyBpZiBncmVlbiBzcXVhcmVzIGFyZSBtb3ZlZCBiZWhpbmQgdGhlIGJs
dWUgcmVjdGFuZ2xlLjwvcD4KKyAgICA8ZGl2IGlkPSJjb250YWluZXIiPgorICAgICAgPGRpdiBp
ZD0ic3F1YXJlTGluZWFyIj48dHQ+dHJhbnNmb3JtPC90dD4gKGxpbmVhcik8L2Rpdj4KKyAgICAg
IDxkaXYgaWQ9InNxdWFyZVN0ZXBzIj48dHQ+dHJhbnNmb3JtPC90dD4gKHN0ZXBzKTwvZGl2Pgor
ICAgICAgPGRpdiBpZD0ic3F1YXJlTm9uQWNjZWxlcmF0ZWQiPjx0dD5sZWZ0PC90dD4gKHN0ZXBz
KTwvZGl2PgorICAgICAgPGRpdiBpZD0iY292ZXJpbmdSZWN0Ij48L2Rpdj4KKyAgICA8L2Rpdj4K
KyAgPC9ib2R5PgorPC9odG1sPgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>