186119 2018-05-30 16:44:25 -0700 Update expected results for BuildStepsConstructorTest 2018-05-31 12:54:21 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad ryanhaddad aakash_jain achristensen commit-queue don.olmstead lforschler ross.kirsling webkit-bug-importer oldest_to_newest 1428673 0 ryanhaddad 2018-05-30 16:44:25 -0700 Update expected results for BuildStepsConstructorTest, as these tests fail when run locally: ./steps_unittest.py import sets as _sets ..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................FFFFFFF................................... ====================================================================== FAIL: test_builder WinCairo 64-bit JSC Debug (Tests) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 586, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: WinCairo 64-bit JSC Debug (Tests) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'jscore-test'] ====================================================================== FAIL: test_builder WinCairo 64-bit JSC Release (Tests) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 586, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: WinCairo 64-bit JSC Release (Tests) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'jscore-test'] ====================================================================== FAIL: test_builder WinCairo 64-bit WKL Debug (Build) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 586, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: WinCairo 64-bit WKL Debug (Build) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger'] ====================================================================== FAIL: test_builder WinCairo 64-bit WKL Debug (Tests) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 586, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: WinCairo 64-bit WKL Debug (Tests) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'wincairo-requirements', 'layout-test', 'run-api-tests', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'archive-test-results', 'upload', 'MasterShellCommand'] ====================================================================== FAIL: test_builder WinCairo 64-bit WKL Release (Build) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 586, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: WinCairo 64-bit WKL Release (Build) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger'] ====================================================================== FAIL: test_builder WinCairo 64-bit WKL Release (Tests) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 586, in doTest self.assertTrue(builder['name'] in expected_build_steps, "Missing expected result for builder: %s\n Actual result is %s" % (builder['name'], buildSteps)) AssertionError: Missing expected result for builder: WinCairo 64-bit WKL Release (Tests) Actual result is ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'wincairo-requirements', 'layout-test', 'run-api-tests', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'archive-test-results', 'upload', 'MasterShellCommand'] ====================================================================== FAIL: test_unnecessary_expected_results (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 597, in test_unnecessary_expected_results self.assertTrue(builder in builders, "Builder %s doesn't exist, but has unnecessary expected results" % builder) AssertionError: Builder WinCairo 64-Bit Release doesn't exist, but has unnecessary expected results ---------------------------------------------------------------------- Ran 764 tests in 0.025s FAILED (failures=7) 1428692 1 341626 ryanhaddad 2018-05-30 17:20:21 -0700 Created attachment 341626 Patch 1428875 2 ross.kirsling 2018-05-31 09:47:56 -0700 Oops, I didn't realize there were unit tests to verify each bot's steps -- thank you for doing this! 1428967 3 341626 commit-queue 2018-05-31 12:36:26 -0700 Comment on attachment 341626 Patch Clearing flags on attachment: 341626 Committed r232363: <https://trac.webkit.org/changeset/232363> 1428968 4 commit-queue 2018-05-31 12:36:27 -0700 All reviewed patches have been landed. Closing bug. 1428974 5 webkit-bug-importer 2018-05-31 12:54:21 -0700 <rdar://problem/40696190> 341626 2018-05-30 17:20:21 -0700 2018-05-31 12:36:26 -0700 Patch bug-186119-20180530172021.patch text/plain 4179 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGQwYjhkOTRmZjQ2ZTk3OGJlYzE0NjBiYmQ4ZTMyYjBj OWYzNGZhYy4uZjRiMTU4Nzk0NzJjMGNjZWE5M2E1OGZmOTIxZDQzNTQzNTdjNmQxOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE4LTA1LTMwICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIFVwZGF0ZSBleHBlY3RlZCByZXN1bHRzIGZvciBCdWlsZFN0ZXBzQ29uc3RydWN0b3JU ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODYx MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3N0ZXBzX3VuaXR0ZXN0LnB5 OiBBZGQgbWlzc2luZyBlbnRyaWVzIGZvciAnV2luQ2Fpcm8gNjQtYml0JyBib3RzLgorCiAyMDE4 LTA1LTMwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5h bWUgQ3Jvc3NPcmlnaW5SZXNvdXJjZVBvbGljeSBzYW1lIHRvIHNhbWUtb3JpZ2luCmRpZmYgLS1n aXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9zdGVw c191bml0dGVzdC5weSBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL3N0ZXBzX3VuaXR0ZXN0LnB5CmluZGV4IDY1YmQxMTI4MDM5NDAzZmJjNTZhMTBjZmJm ZmYxNzk2NWY1YmI0Y2EuLjg3OTc1MGJkMDAwMTUwZGEwMDJkYmRkN2MyMmQ5ZWIwY2ViZWI0M2Ug MTAwNzU1Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3N0ZXBzX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL3N0ZXBzX3VuaXR0ZXN0LnB5CkBAIC01NjEsNyArNTYxLDEyIEBA IGV4cGVjdGVkX2J1aWxkX3N0ZXBzID0gewogICAgICdHVEsgTGludXggNjQtYml0IFJlbGVhc2Ug RGViaWFuIFN0YWJsZSAoQnVpbGQpJzogWydjb25maWd1cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwg b2xkIHByb2Nlc3NlcycsICdkZWxldGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBz dGFsZSBidWlsZCBmaWxlcycsICdjb21waWxlLXdlYmtpdCddLAogICAgICdHVEsgTGludXggQVJN IFJlbGVhc2UnOiBbJ2NvbmZpZ3VyZSBidWlsZCcsICdzdm4nLCAna2lsbCBvbGQgcHJvY2Vzc2Vz JywgJ2RlbGV0ZSBXZWJLaXRCdWlsZCBkaXJlY3RvcnknLCAnZGVsZXRlIHN0YWxlIGJ1aWxkIGZp bGVzJywgJ2poYnVpbGQnLCAnY29tcGlsZS13ZWJraXQnLCAnanNjb3JlLXRlc3QnLCAnd2Via2l0 cHktdGVzdCcsICd3ZWJraXRwZXJsLXRlc3QnLCAnYmluZGluZ3MtZ2VuZXJhdGlvbi10ZXN0cycs ICdidWlsdGlucy1nZW5lcmF0b3ItdGVzdHMnLCAnZGFzaGJvYXJkLXRlc3RzJywgJ0FQSSB0ZXN0 cycsICd3ZWJkcml2ZXItdGVzdCddLAogCi0gICAgJ1dpbkNhaXJvIDY0LUJpdCBSZWxlYXNlJzog Wydjb25maWd1cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwgb2xkIHByb2Nlc3NlcycsICdkZWxldGUg V2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBzdGFsZSBidWlsZCBmaWxlcycsICdjb21w aWxlLXdlYmtpdCddLAorICAgICdXaW5DYWlybyA2NC1iaXQgSlNDIERlYnVnIChUZXN0cyknOiBb J2NvbmZpZ3VyZSBidWlsZCcsICdzdm4nLCAna2lsbCBvbGQgcHJvY2Vzc2VzJywgJ2RlbGV0ZSBX ZWJLaXRCdWlsZCBkaXJlY3RvcnknLCAnZGVsZXRlIHN0YWxlIGJ1aWxkIGZpbGVzJywgJ2Rvd25s b2FkLWJ1aWx0LXByb2R1Y3QnLCAnZXh0cmFjdC1idWlsdC1wcm9kdWN0JywgJ2pzY29yZS10ZXN0 J10sCisgICAgJ1dpbkNhaXJvIDY0LWJpdCBKU0MgUmVsZWFzZSAoVGVzdHMpJzogWydjb25maWd1 cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwgb2xkIHByb2Nlc3NlcycsICdkZWxldGUgV2ViS2l0QnVp bGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBzdGFsZSBidWlsZCBmaWxlcycsICdkb3dubG9hZC1idWls dC1wcm9kdWN0JywgJ2V4dHJhY3QtYnVpbHQtcHJvZHVjdCcsICdqc2NvcmUtdGVzdCddLAorICAg ICdXaW5DYWlybyA2NC1iaXQgV0tMIERlYnVnIChCdWlsZCknOiBbJ2NvbmZpZ3VyZSBidWlsZCcs ICdzdm4nLCAna2lsbCBvbGQgcHJvY2Vzc2VzJywgJ2RlbGV0ZSBXZWJLaXRCdWlsZCBkaXJlY3Rv cnknLCAnZGVsZXRlIHN0YWxlIGJ1aWxkIGZpbGVzJywgJ2NvbXBpbGUtd2Via2l0JywgJ2FyY2hp dmUtYnVpbHQtcHJvZHVjdCcsICd1cGxvYWQnLCAndHJhbnNmZXItdG8tczMnLCAndHJpZ2dlcidd LAorICAgICdXaW5DYWlybyA2NC1iaXQgV0tMIERlYnVnIChUZXN0cyknOiBbJ2NvbmZpZ3VyZSBi dWlsZCcsICdzdm4nLCAna2lsbCBvbGQgcHJvY2Vzc2VzJywgJ2RlbGV0ZSBXZWJLaXRCdWlsZCBk aXJlY3RvcnknLCAnZGVsZXRlIHN0YWxlIGJ1aWxkIGZpbGVzJywgJ2Rvd25sb2FkLWJ1aWx0LXBy b2R1Y3QnLCAnZXh0cmFjdC1idWlsdC1wcm9kdWN0JywgJ3dpbmNhaXJvLXJlcXVpcmVtZW50cycs ICdsYXlvdXQtdGVzdCcsICdydW4tYXBpLXRlc3RzJywgJ3dlYmtpdHB5LXRlc3QnLCAnd2Via2l0 cGVybC10ZXN0JywgJ2JpbmRpbmdzLWdlbmVyYXRpb24tdGVzdHMnLCAnYnVpbHRpbnMtZ2VuZXJh dG9yLXRlc3RzJywgJ2FyY2hpdmUtdGVzdC1yZXN1bHRzJywgJ3VwbG9hZCcsICdNYXN0ZXJTaGVs bENvbW1hbmQnXSwKKyAgICAnV2luQ2Fpcm8gNjQtYml0IFdLTCBSZWxlYXNlIChCdWlsZCknOiBb J2NvbmZpZ3VyZSBidWlsZCcsICdzdm4nLCAna2lsbCBvbGQgcHJvY2Vzc2VzJywgJ2RlbGV0ZSBX ZWJLaXRCdWlsZCBkaXJlY3RvcnknLCAnZGVsZXRlIHN0YWxlIGJ1aWxkIGZpbGVzJywgJ2NvbXBp bGUtd2Via2l0JywgJ2FyY2hpdmUtYnVpbHQtcHJvZHVjdCcsICd1cGxvYWQnLCAndHJhbnNmZXIt dG8tczMnLCAndHJpZ2dlciddLAorICAgICdXaW5DYWlybyA2NC1iaXQgV0tMIFJlbGVhc2UgKFRl c3RzKSc6IFsnY29uZmlndXJlIGJ1aWxkJywgJ3N2bicsICdraWxsIG9sZCBwcm9jZXNzZXMnLCAn ZGVsZXRlIFdlYktpdEJ1aWxkIGRpcmVjdG9yeScsICdkZWxldGUgc3RhbGUgYnVpbGQgZmlsZXMn LCAnZG93bmxvYWQtYnVpbHQtcHJvZHVjdCcsICdleHRyYWN0LWJ1aWx0LXByb2R1Y3QnLCAnd2lu Y2Fpcm8tcmVxdWlyZW1lbnRzJywgJ2xheW91dC10ZXN0JywgJ3J1bi1hcGktdGVzdHMnLCAnd2Vi a2l0cHktdGVzdCcsICd3ZWJraXRwZXJsLXRlc3QnLCAnYmluZGluZ3MtZ2VuZXJhdGlvbi10ZXN0 cycsICdidWlsdGlucy1nZW5lcmF0b3ItdGVzdHMnLCAnYXJjaGl2ZS10ZXN0LXJlc3VsdHMnLCAn dXBsb2FkJywgJ01hc3RlclNoZWxsQ29tbWFuZCddLAogCiAgICAgJ1dQRSBMaW51eCA2NC1iaXQg UmVsZWFzZSAoQnVpbGQpJzogWydjb25maWd1cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwgb2xkIHBy b2Nlc3NlcycsICdkZWxldGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBzdGFsZSBi dWlsZCBmaWxlcycsICdqaGJ1aWxkJywgJ2NvbXBpbGUtd2Via2l0JywgJ2FyY2hpdmUtYnVpbHQt cHJvZHVjdCcsICd1cGxvYWQnLCAndHJhbnNmZXItdG8tczMnLCAndHJpZ2dlciddLAogICAgICdX UEUgTGludXggNjQtYml0IFJlbGVhc2UgKFRlc3RzKSc6IFsnY29uZmlndXJlIGJ1aWxkJywgJ3N2 bicsICdraWxsIG9sZCBwcm9jZXNzZXMnLCAnZGVsZXRlIFdlYktpdEJ1aWxkIGRpcmVjdG9yeScs ICdkZWxldGUgc3RhbGUgYnVpbGQgZmlsZXMnLCAnamhidWlsZCcsICdkb3dubG9hZC1idWlsdC1w cm9kdWN0JywgJ2V4dHJhY3QtYnVpbHQtcHJvZHVjdCcsICdqc2NvcmUtdGVzdCcsICdsYXlvdXQt dGVzdCcsICd3ZWJraXRweS10ZXN0JywgJ3dlYmtpdHBlcmwtdGVzdCcsICdiaW5kaW5ncy1nZW5l cmF0aW9uLXRlc3RzJywgJ2J1aWx0aW5zLWdlbmVyYXRvci10ZXN0cycsICdkYXNoYm9hcmQtdGVz dHMnLCAnYXJjaGl2ZS10ZXN0LXJlc3VsdHMnLCAndXBsb2FkJywgJ01hc3RlclNoZWxsQ29tbWFu ZCcsICdBUEkgdGVzdHMnXSwK