186114 2018-05-30 16:17:08 -0700 Fix leak of a CVPixelBufferRef due to an early return in -[RTCVideoEncoderH264 encode:codecSpecificInfo:frameTypes:] 2018-05-31 11:15:19 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.chromium.org/p/webrtc/issues/detail?id=9347 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue ddkilzer eric.carlson webkit-bug-importer youennf oldest_to_newest 1428645 0 ddkilzer 2018-05-30 16:17:08 -0700 Fix leak of a CFPixelBuffer due to early rerturn in -[RTCVideoEncoderH264 encode:codecSpecificInfo:frameTypes:]. 1428653 1 341615 ddkilzer 2018-05-30 16:27:28 -0700 Created attachment 341615 Patch v1 1428655 2 webkit-bug-importer 2018-05-30 16:29:10 -0700 <rdar://problem/40668097> 1428656 3 webkit-bug-importer 2018-05-30 16:29:11 -0700 <rdar://problem/40668098> 1428661 4 ddkilzer 2018-05-30 16:33:15 -0700 <rdar://problem/40668097> 1428662 5 341618 ddkilzer 2018-05-30 16:34:15 -0700 Created attachment 341618 Patch v2 1428690 6 341618 commit-queue 2018-05-30 17:18:52 -0700 Comment on attachment 341618 Patch v2 Clearing flags on attachment: 341618 Committed r232322: <https://trac.webkit.org/changeset/232322> 1428691 7 commit-queue 2018-05-30 17:18:53 -0700 All reviewed patches have been landed. Closing bug. 341615 2018-05-30 16:27:28 -0700 2018-05-30 16:34:13 -0700 Patch v1 bug-186114-20180530162727.patch text/plain 3109 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBkMThhODY1MGFkZTc5YzA1M2RmMTMyNDllNTc1ZTRjMDZkMGRkNzFiLi4yMjUy MTc2MTkxOTgzOTMxNWI5ZjVhNDI3NTM5ZWYwMGFjMmE4MWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0wNS0zMCAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBsZWFrIG9mIGEgQ1ZQaXhl bEJ1ZmZlclJlZiBkdWUgdG8gZWFybHkgcmVydHVybiBpbiAtW1JUQ1ZpZGVvRW5jb2RlckgyNjQg ZW5jb2RlOmNvZGVjU3BlY2lmaWNJbmZvOmZyYW1lVHlwZXM6XQorICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMTg2MTE0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9GcmFtZXdvcmsvQ2xhc3Nlcy9W aWRlb1Rvb2xib3gvUlRDVmlkZW9FbmNvZGVySDI2NC5tbToKKyAgICAgICAgKC1bUlRDVmlkZW9F bmNvZGVySDI2NCBlbmNvZGU6Y29kZWNTcGVjaWZpY0luZm86ZnJhbWVUeXBlczpdKToKKyAgICAg ICAgQ2FsbCBDVkJ1ZmZlclJlbGVhc2UocGl4ZWxCdWZmZXIpIGJlZm9yZSBlYXJseSByZXR1cm4g dG8gZnJlZQorICAgICAgICBpdC4KKyAgICAgICAgKiBXZWJLaXQvMDAxMC1GaXgtUlRDVmlkZW9F bmNvZGVySDI2NC1DVlBpeGVsQnVmZmVyLWxlYWsucGF0Y2g6IEFkZC4KKwogMjAxOC0wNS0yNyAg RGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEZpeCB3 YXJuaW5ncyBhYm91dCBsZWFrcyBmb3VuZCBieSBjbGFuZyBzdGF0aWMgYW5hbHl6ZXIKZGlmZiAt LWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpj L0ZyYW1ld29yay9DbGFzc2VzL1ZpZGVvVG9vbGJveC9SVENWaWRlb0VuY29kZXJIMjY0Lm1tIGIv U291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvRnJhbWV3 b3JrL0NsYXNzZXMvVmlkZW9Ub29sYm94L1JUQ1ZpZGVvRW5jb2RlckgyNjQubW0KaW5kZXggNDJm OTQwNDI2YWU2YjYwNTEwMmU5ZTFmODE5OGEyNWM2OTNlYjBlNy4uMTZhODQxZDk0NTgwNTMzYzc3 MTM1MGI0ODc1Y2JkNjk2YTY5ZTlmOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvbGli d2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0NsYXNzZXMvVmlkZW9Ub29s Ym94L1JUQ1ZpZGVvRW5jb2RlckgyNjQubW0KKysrIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2Vi cnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0NsYXNzZXMvVmlkZW9Ub29sYm94 L1JUQ1ZpZGVvRW5jb2RlckgyNjQubW0KQEAgLTQyOSw2ICs0MjksNyBAQCAtIChOU0ludGVnZXIp ZW5jb2RlOihSVENWaWRlb0ZyYW1lICopZnJhbWUKICAgICAgIH0KICAgICAgIF9mcmFtZVNjYWxl QnVmZmVyLnNocmlua190b19maXQoKTsKICAgICAgIGlmICghW3J0Y1BpeGVsQnVmZmVyIGNyb3BB bmRTY2FsZVRvOnBpeGVsQnVmZmVyIHdpdGhUZW1wQnVmZmVyOl9mcmFtZVNjYWxlQnVmZmVyLmRh dGEoKV0pIHsKKyAgICAgICAgQ1ZCdWZmZXJSZWxlYXNlKHBpeGVsQnVmZmVyKTsKICAgICAgICAg cmV0dXJuIFdFQlJUQ19WSURFT19DT0RFQ19FUlJPUjsKICAgICAgIH0KICAgICB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvV2ViS2l0LzAwMTAtRml4LVJUQ1ZpZGVv RW5jb2RlckgyNjQtQ1ZQaXhlbEJ1ZmZlci1sZWFrLnBhdGNoIGIvU291cmNlL1RoaXJkUGFydHkv bGlid2VicnRjL1dlYktpdC8wMDEwLUZpeC1SVENWaWRlb0VuY29kZXJIMjY0LUNWUGl4ZWxCdWZm ZXItbGVhay5wYXRjaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44MzA5OGMzNDljNjkwNzkzMmE3MjZjMWQ1NDUxYmMw NWU3M2VmNDYzCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L1dlYktpdC8wMDEwLUZpeC1SVENWaWRlb0VuY29kZXJIMjY0LUNWUGl4ZWxCdWZmZXItbGVhay5w YXRjaApAQCAtMCwwICsxLDEyIEBACitkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGli d2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0NsYXNzZXMvVmlkZW9Ub29s Ym94L1JUQ1ZpZGVvRW5jb2RlckgyNjQubW0gYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMv U291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9GcmFtZXdvcmsvQ2xhc3Nlcy9WaWRlb1Rvb2xib3gvUlRD VmlkZW9FbmNvZGVySDI2NC5tbQoraW5kZXggNDJmOTQwNDI2YWUuLjE2YTg0MWQ5NDU4IDEwMDY0 NAorLS0tIGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29i amMvRnJhbWV3b3JrL0NsYXNzZXMvVmlkZW9Ub29sYm94L1JUQ1ZpZGVvRW5jb2RlckgyNjQubW0K KysrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpj L0ZyYW1ld29yay9DbGFzc2VzL1ZpZGVvVG9vbGJveC9SVENWaWRlb0VuY29kZXJIMjY0Lm1tCitA QCAtNDI5LDYgKzQyOSw3IEBAIC0gKE5TSW50ZWdlcillbmNvZGU6KFJUQ1ZpZGVvRnJhbWUgKilm cmFtZQorICAgICAgIH0KKyAgICAgICBfZnJhbWVTY2FsZUJ1ZmZlci5zaHJpbmtfdG9fZml0KCk7 CisgICAgICAgaWYgKCFbcnRjUGl4ZWxCdWZmZXIgY3JvcEFuZFNjYWxlVG86cGl4ZWxCdWZmZXIg d2l0aFRlbXBCdWZmZXI6X2ZyYW1lU2NhbGVCdWZmZXIuZGF0YSgpXSkgeworKyAgICAgICAgQ1ZC dWZmZXJSZWxlYXNlKHBpeGVsQnVmZmVyKTsKKyAgICAgICAgIHJldHVybiBXRUJSVENfVklERU9f Q09ERUNfRVJST1I7CisgICAgICAgfQorICAgICB9Cg== 341618 2018-05-30 16:34:15 -0700 2018-05-30 17:18:52 -0700 Patch v2 bug-186114-20180530163413.patch text/plain 3144 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBkMThhODY1MGFkZTc5YzA1M2RmMTMyNDllNTc1ZTRjMDZkMGRkNzFiLi4yNmM3 ZjVkYjc0NWZiOGI4YWQwNzFiZWY5MzA2NjdjZTRjMjk4ODdjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOC0wNS0zMCAgRGF2aWQgS2ls emVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBsZWFrIG9mIGEgQ1ZQaXhl bEJ1ZmZlclJlZiBkdWUgdG8gZWFybHkgcmVydHVybiBpbiAtW1JUQ1ZpZGVvRW5jb2RlckgyNjQg ZW5jb2RlOmNvZGVjU3BlY2lmaWNJbmZvOmZyYW1lVHlwZXM6XQorICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMTg2MTE0PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDA2NjgwOTc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2Uv d2VicnRjL3Nkay9vYmpjL0ZyYW1ld29yay9DbGFzc2VzL1ZpZGVvVG9vbGJveC9SVENWaWRlb0Vu Y29kZXJIMjY0Lm1tOgorICAgICAgICAoLVtSVENWaWRlb0VuY29kZXJIMjY0IGVuY29kZTpjb2Rl Y1NwZWNpZmljSW5mbzpmcmFtZVR5cGVzOl0pOgorICAgICAgICBDYWxsIENWQnVmZmVyUmVsZWFz ZShwaXhlbEJ1ZmZlcikgYmVmb3JlIGVhcmx5IHJldHVybiB0byBmcmVlCisgICAgICAgIGl0Lgor ICAgICAgICAqIFdlYktpdC8wMDEwLUZpeC1SVENWaWRlb0VuY29kZXJIMjY0LUNWUGl4ZWxCdWZm ZXItbGVhay5wYXRjaDogQWRkLgorCiAyMDE4LTA1LTI3ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHpl ckBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gRml4IHdhcm5pbmdzIGFib3V0IGxlYWtzIGZv dW5kIGJ5IGNsYW5nIHN0YXRpYyBhbmFseXplcgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFy dHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0NsYXNzZXMvVmlk ZW9Ub29sYm94L1JUQ1ZpZGVvRW5jb2RlckgyNjQubW0gYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3 ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9GcmFtZXdvcmsvQ2xhc3Nlcy9WaWRlb1Rvb2xi b3gvUlRDVmlkZW9FbmNvZGVySDI2NC5tbQppbmRleCA0MmY5NDA0MjZhZTZiNjA1MTAyZTllMWY4 MTk4YTI1YzY5M2ViMGU3Li4xNmE4NDFkOTQ1ODA1MzNjNzcxMzUwYjQ4NzVjYmQ2OTZhNjllOWY4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9z ZGsvb2JqYy9GcmFtZXdvcmsvQ2xhc3Nlcy9WaWRlb1Rvb2xib3gvUlRDVmlkZW9FbmNvZGVySDI2 NC5tbQorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsv b2JqYy9GcmFtZXdvcmsvQ2xhc3Nlcy9WaWRlb1Rvb2xib3gvUlRDVmlkZW9FbmNvZGVySDI2NC5t bQpAQCAtNDI5LDYgKzQyOSw3IEBAIC0gKE5TSW50ZWdlcillbmNvZGU6KFJUQ1ZpZGVvRnJhbWUg KilmcmFtZQogICAgICAgfQogICAgICAgX2ZyYW1lU2NhbGVCdWZmZXIuc2hyaW5rX3RvX2ZpdCgp OwogICAgICAgaWYgKCFbcnRjUGl4ZWxCdWZmZXIgY3JvcEFuZFNjYWxlVG86cGl4ZWxCdWZmZXIg d2l0aFRlbXBCdWZmZXI6X2ZyYW1lU2NhbGVCdWZmZXIuZGF0YSgpXSkgeworICAgICAgICBDVkJ1 ZmZlclJlbGVhc2UocGl4ZWxCdWZmZXIpOwogICAgICAgICByZXR1cm4gV0VCUlRDX1ZJREVPX0NP REVDX0VSUk9SOwogICAgICAgfQogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5 L2xpYndlYnJ0Yy9XZWJLaXQvMDAxMC1GaXgtUlRDVmlkZW9FbmNvZGVySDI2NC1DVlBpeGVsQnVm ZmVyLWxlYWsucGF0Y2ggYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvV2ViS2l0LzAwMTAt Rml4LVJUQ1ZpZGVvRW5jb2RlckgyNjQtQ1ZQaXhlbEJ1ZmZlci1sZWFrLnBhdGNoCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjgzMDk4YzM0OWM2OTA3OTMyYTcyNmMxZDU0NTFiYzA1ZTczZWY0NjMKLS0tIC9kZXYvbnVs bAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvV2ViS2l0LzAwMTAtRml4LVJUQ1Zp ZGVvRW5jb2RlckgyNjQtQ1ZQaXhlbEJ1ZmZlci1sZWFrLnBhdGNoCkBAIC0wLDAgKzEsMTIgQEAK K2RpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9z ZGsvb2JqYy9GcmFtZXdvcmsvQ2xhc3Nlcy9WaWRlb1Rvb2xib3gvUlRDVmlkZW9FbmNvZGVySDI2 NC5tbSBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL3Nkay9vYmpj L0ZyYW1ld29yay9DbGFzc2VzL1ZpZGVvVG9vbGJveC9SVENWaWRlb0VuY29kZXJIMjY0Lm1tCitp bmRleCA0MmY5NDA0MjZhZS4uMTZhODQxZDk0NTggMTAwNjQ0CistLS0gYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9zZGsvb2JqYy9GcmFtZXdvcmsvQ2xhc3Nlcy9W aWRlb1Rvb2xib3gvUlRDVmlkZW9FbmNvZGVySDI2NC5tbQorKysrIGIvU291cmNlL1RoaXJkUGFy dHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvc2RrL29iamMvRnJhbWV3b3JrL0NsYXNzZXMvVmlk ZW9Ub29sYm94L1JUQ1ZpZGVvRW5jb2RlckgyNjQubW0KK0BAIC00MjksNiArNDI5LDcgQEAgLSAo TlNJbnRlZ2VyKWVuY29kZTooUlRDVmlkZW9GcmFtZSAqKWZyYW1lCisgICAgICAgfQorICAgICAg IF9mcmFtZVNjYWxlQnVmZmVyLnNocmlua190b19maXQoKTsKKyAgICAgICBpZiAoIVtydGNQaXhl bEJ1ZmZlciBjcm9wQW5kU2NhbGVUbzpwaXhlbEJ1ZmZlciB3aXRoVGVtcEJ1ZmZlcjpfZnJhbWVT Y2FsZUJ1ZmZlci5kYXRhKCldKSB7CisrICAgICAgICBDVkJ1ZmZlclJlbGVhc2UocGl4ZWxCdWZm ZXIpOworICAgICAgICAgcmV0dXJuIFdFQlJUQ19WSURFT19DT0RFQ19FUlJPUjsKKyAgICAgICB9 CisgICAgIH0K