186103 2018-05-30 11:02:58 -0700 [iOS] -[WKFullScreenViewController viewWillAppear:] should call [super viewWillAppear:] 2018-05-30 13:41:14 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 186067 1 ddkilzer ddkilzer commit-queue eric.carlson jeremyj-wk jer.noble jonlee webkit-bug-importer oldest_to_newest 1428510 0 ddkilzer 2018-05-30 11:02:58 -0700 Fix static analyzer warnings in WKFullScreenViewController.mm: Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:70:13: warning: Called C++ object pointer is null interface->playbackSessionModel()->removeClient(*this); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:306:1: warning: The 'viewWillAppear:' instance method in UIViewController subclass 'WKFullScreenViewController' is missing a [super viewWillAppear:] call } ^ 2 warnings generated. 1428511 1 webkit-bug-importer 2018-05-30 11:03:26 -0700 <rdar://problem/40655695> 1428513 2 341584 ddkilzer 2018-05-30 11:10:27 -0700 Created attachment 341584 Patch v1 1428515 3 ddkilzer 2018-05-30 11:18:33 -0700 Jer fixed the first issue in: Bug 186067: Fix a few issues in WKFullScreenViewController <https://bugs.webkit.org/show_bug.cgi?id=186067> <https://trac.webkit.org/changeset/232299> Updating this just to fix the -viewWillAppear: issue. 1428516 4 341585 ddkilzer 2018-05-30 11:21:28 -0700 Created attachment 341585 Patch v2 1428577 5 341585 commit-queue 2018-05-30 13:41:12 -0700 Comment on attachment 341585 Patch v2 Clearing flags on attachment: 341585 Committed r232308: <https://trac.webkit.org/changeset/232308> 1428578 6 commit-queue 2018-05-30 13:41:14 -0700 All reviewed patches have been landed. Closing bug. 341584 2018-05-30 11:10:27 -0700 2018-05-30 11:21:27 -0700 Patch v1 bug-186103-20180530111026.patch text/plain 2309 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY0MTg4Y2MzNDY4YzBmNzZk MzhjZDFjZDFiODk3YWFjOGQ1YmVlMDQuLjEwZDJiZGJkOTY2MDMwODNhMDMwMDdhNTVhNGIxMzY1 YjU5NmY3ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDUtMzAgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggc3RhdGljIGFuYWx5emVy IHdhcm5pbmdzIGluIFdLRnVsbFNjcmVlblZpZXdDb250cm9sbGVyLm1tCisgICAgICAgIDxodHRw czovL3dlYmtpdC5vcmcvYi8xODYxMDM+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDY1NTY5 NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxTY3JlZW5WaWV3Q29udHJvbGxlci5tbToKKyAg ICAgICAgKFdLRnVsbFNjcmVlblZpZXdDb250cm9sbGVyUGxheWJhY2tTZXNzaW9uTW9kZWxDbGll bnQ6OnNldEludGVyZmFjZSk6CisgICAgICAgIFByZXZlbnQgbnVsbHB0ciBkZXJlZmVyZW5jZSBj cmFzaCB3aGVuIGNhbGxpbmcgc2V0SW50ZXJmYWNlKG51bGxwdHIpCisgICAgICAgIGZyb20gLVtX S0Z1bGxTY3JlZW5WaWV3Q29udHJvbGxlciBkZWFsbG9jXS4gIEZvciBjb25zaXN0ZW5jeSwgd2UK KyAgICAgICAgYWx3YXlzIHVzZSB0aGUgc2FtZSB2YXJpYWJsZSBpbiB0aGUgYm9keSBvZiB0aGUg YGlmYCBzdGF0ZW1lbnQKKyAgICAgICAgdGhhdCB3YXMgdXNlZCBpbiB0aGUgY29uZGl0aW9uLgor ICAgICAgICAoLVtXS0Z1bGxTY3JlZW5WaWV3Q29udHJvbGxlciB2aWV3V2lsbEFwcGVhcjpdKTog Q2FsbAorICAgICAgICBbc3VwZXIgdmlld1dpbGxBcHBlZWFyOl0gdG8gZnVsZmlsbCBBUEkgY29u dHJhY3QuCisKIDIwMTgtMDUtMjkgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TXSBBZGQgYXNzZXJ0IHRvIGNhdGNoIGltcHJvcGVyIHVzZSBvZiBXZWJD b3JlOjpUaW1lciBpbiBVSSBQcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxTY3JlZW5WaWV3Q29udHJvbGxlci5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlblZpZXdDb250cm9s bGVyLm1tCmluZGV4IDY3MTBhZTA2MmI1YjEyOWRlOTA1NmNiZmQ5MjE3NzQ2YTg2ZmU3MDcuLmRk NGJmYWEzM2QwY2JkMzhhNDliNmMzYjhhYzRmZjMwYzJiZTkwMTcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlblZpZXdDb250cm9s bGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVs bFNjcmVlblZpZXdDb250cm9sbGVyLm1tCkBAIC02NywxMCArNjcsMTAgQEAgcHVibGljOgogICAg ICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGlmIChtX2ludGVyZmFjZSAmJiBtX2ludGVyZmFj ZS0+cGxheWJhY2tTZXNzaW9uTW9kZWwoKSkKLSAgICAgICAgICAgIGludGVyZmFjZS0+cGxheWJh Y2tTZXNzaW9uTW9kZWwoKS0+cmVtb3ZlQ2xpZW50KCp0aGlzKTsKKyAgICAgICAgICAgIG1faW50 ZXJmYWNlLT5wbGF5YmFja1Nlc3Npb25Nb2RlbCgpLT5yZW1vdmVDbGllbnQoKnRoaXMpOwogICAg ICAgICBtX2ludGVyZmFjZSA9IGludGVyZmFjZTsKICAgICAgICAgaWYgKG1faW50ZXJmYWNlICYm IG1faW50ZXJmYWNlLT5wbGF5YmFja1Nlc3Npb25Nb2RlbCgpKQotICAgICAgICAgICAgaW50ZXJm YWNlLT5wbGF5YmFja1Nlc3Npb25Nb2RlbCgpLT5hZGRDbGllbnQoKnRoaXMpOworICAgICAgICAg ICAgbV9pbnRlcmZhY2UtPnBsYXliYWNrU2Vzc2lvbk1vZGVsKCktPmFkZENsaWVudCgqdGhpcyk7 CiAgICAgfQogCiBwcml2YXRlOgpAQCAtMzAzLDYgKzMwMyw4IEBAIC0gKHZvaWQpdmlld1dpbGxB cHBlYXI6KEJPT0wpYW5pbWF0ZWQKIAogICAgIGlmIChhdXRvKiBtYW5hZ2VyID0gc2VsZi5fbWFu YWdlcikKICAgICAgICAgbWFuYWdlci0+c2V0RnVsbHNjcmVlbkF1dG9IaWRlRGVsYXkoYXV0b0hp ZGVEZWxheSk7CisKKyAgICBbc3VwZXIgdmlld1dpbGxBcHBlYXI6YW5pbWF0ZWRdOwogfQogCiAt ICh2b2lkKXZpZXdEaWRMYXlvdXRTdWJ2aWV3cwo= 341585 2018-05-30 11:21:28 -0700 2018-05-30 13:41:12 -0700 Patch v2 bug-186103-20180530112127.patch text/plain 2045 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVhYmUyZDI4OTE1NDA4ZDA4 OTNmZWExMjExZTMxZGQxZmY5ZTU0ZDAuLjFiZGQxY2Q4MGE4ZWEwMDE5ZDEwM2MzODhhNTdlNWIy ODZjZmNmMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDUtMzAgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSAtW1dLRnVsbFNjcmVl blZpZXdDb250cm9sbGVyIHZpZXdXaWxsQXBwZWFyOl0gc2hvdWxkIGNhbGwgW3N1cGVyIHZpZXdX aWxsQXBwZWVhcjpdCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xODYxMDM+CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS80MDY1NTY5NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxT Y3JlZW5WaWV3Q29udHJvbGxlci5tbToKKyAgICAgICAgKFdLRnVsbFNjcmVlblZpZXdDb250cm9s bGVyUGxheWJhY2tTZXNzaW9uTW9kZWxDbGllbnQ6OnNldEludGVyZmFjZSk6CisgICAgICAgIERy aXZlLWJ5IGNsZWFuIHVwLiAgRm9yIGNvbnNpc3RlbmN5LCB3ZSBhbHdheXMgdXNlIHRoZSBzYW1l CisgICAgICAgIHZhcmlhYmxlIGluIHRoZSBib2R5IG9mIHRoZSBgaWZgIHN0YXRlbWVudCB0aGF0 IHdhcyB1c2VkIGluIHRoZQorICAgICAgICBjb25kaXRpb24uCisgICAgICAgICgtW1dLRnVsbFNj cmVlblZpZXdDb250cm9sbGVyIHZpZXdXaWxsQXBwZWFyOl0pOiBDYWxsCisgICAgICAgIFtzdXBl ciB2aWV3V2lsbEFwcGVlYXI6XSB0byBmdWxmaWxsIEFQSSBjb250cmFjdC4KKwogMjAxOC0wNS0z MCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBBdXRvLXBpcCBz aG91bGQgdXNlIG1haW4gY29udGVudCBoZXVyaXN0aWMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxTY3JlZW5WaWV3Q29udHJvbGxlci5t bSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlblZp ZXdDb250cm9sbGVyLm1tCmluZGV4IDZiYzQ1MmRiM2E2Y2JjNTFiNDNmZDM3OWVmZGNkZWFmOTk1 ZWEwYmUuLjA2YzA4M2VkNTg1NmVhZGE4NDFjYmVmYTA1OWUyNjc2ZDhlMWZhOTQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlblZp ZXdDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2Ny ZWVuL1dLRnVsbFNjcmVlblZpZXdDb250cm9sbGVyLm1tCkBAIC03MCw3ICs3MCw3IEBAIHB1Ymxp YzoKICAgICAgICAgICAgIG1faW50ZXJmYWNlLT5wbGF5YmFja1Nlc3Npb25Nb2RlbCgpLT5yZW1v dmVDbGllbnQoKnRoaXMpOwogICAgICAgICBtX2ludGVyZmFjZSA9IGludGVyZmFjZTsKICAgICAg ICAgaWYgKG1faW50ZXJmYWNlICYmIG1faW50ZXJmYWNlLT5wbGF5YmFja1Nlc3Npb25Nb2RlbCgp KQotICAgICAgICAgICAgaW50ZXJmYWNlLT5wbGF5YmFja1Nlc3Npb25Nb2RlbCgpLT5hZGRDbGll bnQoKnRoaXMpOworICAgICAgICAgICAgbV9pbnRlcmZhY2UtPnBsYXliYWNrU2Vzc2lvbk1vZGVs KCktPmFkZENsaWVudCgqdGhpcyk7CiAgICAgfQogCiBwcml2YXRlOgpAQCAtMzAzLDYgKzMwMyw4 IEBAIC0gKHZvaWQpdmlld1dpbGxBcHBlYXI6KEJPT0wpYW5pbWF0ZWQKIAogICAgIGlmIChhdXRv KiBtYW5hZ2VyID0gc2VsZi5fbWFuYWdlcikKICAgICAgICAgbWFuYWdlci0+c2V0RnVsbHNjcmVl bkF1dG9IaWRlRGVsYXkoYXV0b0hpZGVEZWxheSk7CisKKyAgICBbc3VwZXIgdmlld1dpbGxBcHBl YXI6YW5pbWF0ZWRdOwogfQogCiAtICh2b2lkKXZpZXdEaWRMYXlvdXRTdWJ2aWV3cwo=