186097 2018-05-30 08:47:14 -0700 Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate() 2018-06-01 06:40:16 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue dulowiskotic1234 ggaren mitz thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1428449 0 cdumez 2018-05-30 08:47:14 -0700 Take a background process assertion in WebPageProxy::callAfterNextPresentationUpdate() otherwise, apps may get stuck on _doAfterNextPresentationUpdate because the WebProcess got suspended. 1428451 1 webkit-bug-importer 2018-05-30 08:47:42 -0700 <rdar://problem/40651225> 1428453 2 341575 cdumez 2018-05-30 08:48:42 -0700 Created attachment 341575 Patch 1428493 3 341575 commit-queue 2018-05-30 10:42:56 -0700 Comment on attachment 341575 Patch Clearing flags on attachment: 341575 Committed r232298: <https://trac.webkit.org/changeset/232298> 1428494 4 commit-queue 2018-05-30 10:42:58 -0700 All reviewed patches have been landed. Closing bug. 1428514 5 thorton 2018-05-30 11:15:24 -0700 Dan points out that callbackMap.put takes a BackgroundActivityToken parameter, which RemoteLayerTreeDrawingAreaProxy currently passes nullptr to: m_webPageProxy.process().send(Messages::DrawingArea::AddTransactionCallbackID(m_callbacks.put(WTFMove(callbackFunction), nullptr)), m_webPageProxy.pageID()); So this fix probably should have just made that non-null instead of capturing a BackgroundActivityToken elsewhere. 1428526 6 cdumez 2018-05-30 11:53:26 -0700 Reopening to apply comments. 1428543 7 341594 cdumez 2018-05-30 12:28:45 -0700 Created attachment 341594 Patch 1428557 8 341594 mitz 2018-05-30 13:04:11 -0700 Comment on attachment 341594 Patch Even better! 1428573 9 341594 commit-queue 2018-05-30 13:37:56 -0700 Comment on attachment 341594 Patch Clearing flags on attachment: 341594 Committed r232307: <https://trac.webkit.org/changeset/232307> 1428574 10 commit-queue 2018-05-30 13:37:58 -0700 All reviewed patches have been landed. Closing bug. 341575 2018-05-30 08:48:42 -0700 2018-05-30 12:28:44 -0700 Patch bug-186097-20180530084844.patch text/plain 1732 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFjMTJkN2MwOWI1MjFmMjcy N2Q2OTkyMzhmOTM0YTJlZDYxMTJjN2YuLmYzODg3NzY2NTE1ZmE5MmJjN2U2YjlhYTRiZThhZWYy MGRiMzQxZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDUtMzAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBUYWtlIGEgYmFja2dyb3VuZCBwcm9j ZXNzIGFzc2VydGlvbiBpbiBXZWJQYWdlUHJveHk6OmNhbGxBZnRlck5leHRQcmVzZW50YXRpb25V cGRhdGUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTg2MDk3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDY1MTIyNT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUYWtlIGEgYmFja2dyb3VuZCBwcm9j ZXNzIGFzc2VydGlvbiBpbiBXZWJQYWdlUHJveHk6OmNhbGxBZnRlck5leHRQcmVzZW50YXRpb25V cGRhdGUoKS4gT3RoZXJ3aXNlLAorICAgICAgICBhcHBzIG1heSBnZXQgc3R1Y2sgb24gX2RvQWZ0 ZXJOZXh0UHJlc2VudGF0aW9uVXBkYXRlIGJlY2F1c2UgdGhlIFdlYlByb2Nlc3MgZ290IHN1c3Bl bmRlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUHJveHk6OmNhbGxBZnRlck5leHRQcmVzZW50YXRpb25VcGRhdGUpOgor CiAyMDE4LTA1LTI4ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW9k ZXJuaXplIFNWR1JlbmRlclN0eWxlRGVmcy5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5LmNwcAppbmRleCBlYTQzNjI5NTAxYzU5ZjJiMzRmNGZiYjBiZTZiNzQwMTIwYzA4OTkx Li4wZGJkMDFmZDU1YmEzNTIyNzc3ODdhNjgyMzhkNmRkNzUzMzhlMDZhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTczNTEsNyArNzM1MSw5IEBAIHZvaWQg V2ViUGFnZVByb3h5OjpjYWxsQWZ0ZXJOZXh0UHJlc2VudGF0aW9uVXBkYXRlKFdURjo6RnVuY3Rp b248dm9pZCAoQ2FsbGJhY2tCCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBtX2RyYXdp bmdBcmVhLT5kaXNwYXRjaEFmdGVyRW5zdXJpbmdEcmF3aW5nKFdURk1vdmUoY2FsbGJhY2spKTsK KyAgICBtX2RyYXdpbmdBcmVhLT5kaXNwYXRjaEFmdGVyRW5zdXJpbmdEcmF3aW5nKFtjYWxsYmFj ayA9IFdURk1vdmUoY2FsbGJhY2spLCBiYWNrZ3JvdW5kQWN0aXZpdHkgPSBtX3Byb2Nlc3MtPnRo cm90dGxlcigpLmJhY2tncm91bmRBY3Rpdml0eVRva2VuKCldKENhbGxiYWNrQmFzZTo6RXJyb3Ig ZXJyb3IpIHsKKyAgICAgICAgY2FsbGJhY2soZXJyb3IpOworICAgIH0pOwogfQogCiB2b2lkIFdl YlBhZ2VQcm94eTo6c2V0U2hvdWxkU2NhbGVWaWV3VG9GaXREb2N1bWVudChib29sIHNob3VsZFNj YWxlVmlld1RvRml0RG9jdW1lbnQpCg== 341594 2018-05-30 12:28:45 -0700 2018-05-30 13:37:56 -0700 Patch bug-186097-20180530122844.patch text/plain 2848 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVhYmUyZDI4OTE1NDA4ZDA4 OTNmZWExMjExZTMxZGQxZmY5ZTU0ZDAuLjc2NDZiZTFkN2VmOTI1OTUzMzMyODAyMTQwZjRjMzdm M2ZhZGNkYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDUtMzAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBUYWtlIGEgYmFja2dyb3VuZCBwcm9j ZXNzIGFzc2VydGlvbiBpbiBXZWJQYWdlUHJveHk6OmNhbGxBZnRlck5leHRQcmVzZW50YXRpb25V cGRhdGUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTg2MDk3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDY1MTIyNT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWZhY3RvciBmaXggbGFuZGVkIGlu IHIyMzIyOTggc28gdGhhdCB3ZSByZWx5IG9uIHRoZSBleGlzdGluZyBDYWxsYmFjayBpbmZyYXN0 cnVjdHVyZQorICAgICAgICB0byB0YWtlIGEgYmFja2dyb3VuZCBwcm9jZXNzIGFzc2VydGlvbi4K KworICAgICAgICAqIFVJUHJvY2Vzcy9SZW1vdGVMYXllclRyZWUvUmVtb3RlTGF5ZXJUcmVlRHJh d2luZ0FyZWFQcm94eS5tbToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlRHJhd2lu Z0FyZWFQcm94eTo6ZGlzcGF0Y2hBZnRlckVuc3VyaW5nRHJhd2luZyk6CisgICAgICAgICogVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6 Y2FsbEFmdGVyTmV4dFByZXNlbnRhdGlvblVwZGF0ZSk6CisKIDIwMTgtMDUtMzAgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgQXV0by1waXAgc2hvdWxkIHVzZSBt YWluIGNvbnRlbnQgaGV1cmlzdGljLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvUmVtb3RlTGF5ZXJUcmVlL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhUHJveHkubW0gYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9SZW1vdGVMYXllclRyZWUvUmVtb3RlTGF5ZXJUcmVlRHJh d2luZ0FyZWFQcm94eS5tbQppbmRleCBjMGJkZmU1NzZiMzgyZjgyNDg1MGM3ZGQ1NThhNjE2OTFi ZGE1ZTNiLi4wODlmNzU5NGNmNWQzNjFiMjY4M2QyZDlkODE0M2JhMTAyMTZjZWFhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9SZW1vdGVMYXllclRyZWUvUmVtb3RlTGF5ZXJU cmVlRHJhd2luZ0FyZWFQcm94eS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9SZW1v dGVMYXllclRyZWUvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eS5tbQpAQCAtNDU2LDcg KzQ1Niw3IEBAIHZvaWQgUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWFQcm94eTo6ZGlzcGF0Y2hB ZnRlckVuc3VyaW5nRHJhd2luZyhXVEY6OkZ1bmN0aW9uCiAgICAgICAgIHJldHVybjsKICAgICB9 CiAKLSAgICBtX3dlYlBhZ2VQcm94eS5wcm9jZXNzKCkuc2VuZChNZXNzYWdlczo6RHJhd2luZ0Fy ZWE6OkFkZFRyYW5zYWN0aW9uQ2FsbGJhY2tJRChtX2NhbGxiYWNrcy5wdXQoV1RGTW92ZShjYWxs YmFja0Z1bmN0aW9uKSwgbnVsbHB0cikpLCBtX3dlYlBhZ2VQcm94eS5wYWdlSUQoKSk7CisgICAg bV93ZWJQYWdlUHJveHkucHJvY2VzcygpLnNlbmQoTWVzc2FnZXM6OkRyYXdpbmdBcmVhOjpBZGRU cmFuc2FjdGlvbkNhbGxiYWNrSUQobV9jYWxsYmFja3MucHV0KFdURk1vdmUoY2FsbGJhY2tGdW5j dGlvbiksIG1fd2ViUGFnZVByb3h5LnByb2Nlc3MoKS50aHJvdHRsZXIoKS5iYWNrZ3JvdW5kQWN0 aXZpdHlUb2tlbigpKSksIG1fd2ViUGFnZVByb3h5LnBhZ2VJRCgpKTsKIH0KIAogdm9pZCBSZW1v dGVMYXllclRyZWVEcmF3aW5nQXJlYVByb3h5OjpoaWRlQ29udGVudFVudGlsUGVuZGluZ1VwZGF0 ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCAwZGJkMDFm ZDU1YmEzNTIyNzc3ODdhNjgyMzhkNmRkNzUzMzhlMDZhLi5lYTQzNjI5NTAxYzU5ZjJiMzRmNGZi YjBiZTZiNzQwMTIwYzA4OTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5jcHAKQEAgLTczNTEsOSArNzM1MSw3IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpjYWxsQWZ0ZXJO ZXh0UHJlc2VudGF0aW9uVXBkYXRlKFdURjo6RnVuY3Rpb248dm9pZCAoQ2FsbGJhY2tCCiAgICAg ICAgIHJldHVybjsKICAgICB9CiAKLSAgICBtX2RyYXdpbmdBcmVhLT5kaXNwYXRjaEFmdGVyRW5z dXJpbmdEcmF3aW5nKFtjYWxsYmFjayA9IFdURk1vdmUoY2FsbGJhY2spLCBiYWNrZ3JvdW5kQWN0 aXZpdHkgPSBtX3Byb2Nlc3MtPnRocm90dGxlcigpLmJhY2tncm91bmRBY3Rpdml0eVRva2VuKCld KENhbGxiYWNrQmFzZTo6RXJyb3IgZXJyb3IpIHsKLSAgICAgICAgY2FsbGJhY2soZXJyb3IpOwot ICAgIH0pOworICAgIG1fZHJhd2luZ0FyZWEtPmRpc3BhdGNoQWZ0ZXJFbnN1cmluZ0RyYXdpbmco V1RGTW92ZShjYWxsYmFjaykpOwogfQogCiB2b2lkIFdlYlBhZ2VQcm94eTo6c2V0U2hvdWxkU2Nh bGVWaWV3VG9GaXREb2N1bWVudChib29sIHNob3VsZFNjYWxlVmlld1RvRml0RG9jdW1lbnQpCg==