186088 2018-05-30 04:25:21 -0700 Make WKWebView firstResponder after entering or exiting fullscreen. 2018-06-02 09:03:38 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue jer.noble jonlee webkit-bug-importer oldest_to_newest 1428380 0 jeremyj-wk 2018-05-30 04:25:21 -0700 Make WKWebView firstResponder after entering or exiting fullscreen. 1428382 1 jeremyj-wk 2018-05-30 04:25:46 -0700 *** Bug 186087 has been marked as a duplicate of this bug. *** 1428383 2 jeremyj-wk 2018-05-30 04:27:13 -0700 rdar://problem/40387859 1428384 3 341561 jeremyj-wk 2018-05-30 04:31:51 -0700 Created attachment 341561 Patch 1428427 4 341561 jonlee 2018-05-30 07:56:59 -0700 Comment on attachment 341561 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341561&action=review > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:538 > + [webView becomeFirstResponder]; This block inconsistently references the web view with a local variable and a member variable. Which one should it be? 1429426 5 341806 jeremyj-wk 2018-06-01 16:50:24 -0700 Created attachment 341806 Patch 1429435 6 jeremyj-wk 2018-06-01 17:02:51 -0700 (In reply to Jon Lee from comment #4) > Comment on attachment 341561 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341561&action=review > > > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:538 > > + [webView becomeFirstResponder]; > > This block inconsistently references the web view with a local variable and > a member variable. Which one should it be? Fixed. 1429565 7 341806 commit-queue 2018-06-02 09:03:36 -0700 Comment on attachment 341806 Patch Clearing flags on attachment: 341806 Committed r232438: <https://trac.webkit.org/changeset/232438> 1429566 8 commit-queue 2018-06-02 09:03:38 -0700 All reviewed patches have been landed. Closing bug. 341561 2018-05-30 04:31:51 -0700 2018-06-01 16:50:23 -0700 Patch bug-186088-20180530043151.patch text/plain 2091 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxOTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNhYmJkMTU4ODhlZTIyN2Nk MmMyNjdmZjgzOWJjM2UxZWRlZTZiZWEuLmM4OWQzYzVhZDU5NTRlMTBhNGViOGU0ZjI5OThjYzU3 ZjRhODdkYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDUtMzAgIEplcmVteSBK b25lcyAgPGplcmVteWpAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgV0tXZWJWaWV3IGZpcnN0 UmVzcG9uZGVyIGFmdGVyIGVudGVyaW5nIG9yIGV4aXRpbmcgZnVsbHNjcmVlbi4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjA4OAorICAgICAgICBy ZGFyOi8vcHJvYmxlbS80MDM4Nzg1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVwZGF0ZSBmaXJzdCByZXNwb25kZXIgd2hlbiBXS1dlYlZpZXcgbW92 ZXMgdG8gYSBuZXcgd2luZG93LCBvdGhlcndpc2UgdGhlcmUgd29uJ3QgYmUgYSBmaXJzdCByZXNw b25kZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxsU2NyZWVu V2luZG93Q29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29u dHJvbGxlciBiZWdhbkVudGVyRnVsbFNjcmVlbldpdGhJbml0aWFsRnJhbWU6ZmluYWxGcmFtZTpd KToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBfY29tcGxldGVkRXhp dEZ1bGxTY3JlZW5dKToKKwogMjAxOC0wNS0xOCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNv bT4KIAogICAgICAgICBbQ29jb2FdIEFkZCBtaXNzaW5nIG51bGxhYmlsaXR5IGFubm90YXRpb25z IHRvIF9XS0F1dG9tYXRpb25TZXNzaW9uRGVsZWdhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXJJ T1MubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxTY3Jl ZW5XaW5kb3dDb250cm9sbGVySU9TLm1tCmluZGV4IGQyZjVmMThkZGI2M2I1YWY1YjY3OTFlN2Q0 MDg1ZmQyYzc1MDQzZmYuLjNmZmUyNThiYzE3YWI3MzIxZDRhMDhkNjdlYTkyMjc0YTE3NjFhY2Ug MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVs bFNjcmVlbldpbmRvd0NvbnRyb2xsZXJJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcklPUy5tbQpAQCAt NTM1LDYgKzUzNSw3IEBAIC0gKHZvaWQpYmVnYW5FbnRlckZ1bGxTY3JlZW5XaXRoSW5pdGlhbEZy YW1lOihDR1JlY3QpaW5pdGlhbEZyYW1lIGZpbmFsRnJhbWU6KENHCiAgICAgICAgIGF1dG8qIHBh Z2UgPSBbc2VsZi5fd2ViVmlldyBfcGFnZV07CiAgICAgICAgIGF1dG8qIG1hbmFnZXIgPSBzZWxm Ll9tYW5hZ2VyOwogICAgICAgICBpZiAocGFnZSAmJiBtYW5hZ2VyKSB7CisgICAgICAgICAgICBb d2ViVmlldyBiZWNvbWVGaXJzdFJlc3BvbmRlcl07CiAgICAgICAgICAgICBtYW5hZ2VyLT5kaWRF bnRlckZ1bGxTY3JlZW4oKTsKICAgICAgICAgICAgIG1hbmFnZXItPnNldEFuaW1hdGluZ0Z1bGxT Y3JlZW4oZmFsc2UpOwogICAgICAgICAgICAgcGFnZS0+c2V0U3VwcHJlc3NWaXNpYmlsaXR5VXBk YXRlcyhmYWxzZSk7CkBAIC02MTgsNiArNjE5LDcgQEAgLSAodm9pZClfY29tcGxldGVkRXhpdEZ1 bGxTY3JlZW4KICAgICBbd2ViVmlldyBzZXRBdXRvcmVzaXppbmdNYXNrOltfd2ViVmlld1BsYWNl aG9sZGVyIGF1dG9yZXNpemluZ01hc2tdXTsKIAogICAgIFtbd2ViVmlldyB3aW5kb3ddIG1ha2VL ZXlBbmRWaXNpYmxlXTsKKyAgICBbd2ViVmlldyBiZWNvbWVGaXJzdFJlc3BvbmRlcl07CiAKICAg ICBfdmlld1N0YXRlLmFwcGx5VG8od2ViVmlldy5nZXQoKSk7CiAK 341806 2018-06-01 16:50:24 -0700 2018-06-02 09:03:36 -0700 Patch bug-186088-20180601165023.patch text/plain 2097 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxOTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNhYmJkMTU4ODhlZTIyN2Nk MmMyNjdmZjgzOWJjM2UxZWRlZTZiZWEuLmM4OWQzYzVhZDU5NTRlMTBhNGViOGU0ZjI5OThjYzU3 ZjRhODdkYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDUtMzAgIEplcmVteSBK b25lcyAgPGplcmVteWpAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgV0tXZWJWaWV3IGZpcnN0 UmVzcG9uZGVyIGFmdGVyIGVudGVyaW5nIG9yIGV4aXRpbmcgZnVsbHNjcmVlbi4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjA4OAorICAgICAgICBy ZGFyOi8vcHJvYmxlbS80MDM4Nzg1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVwZGF0ZSBmaXJzdCByZXNwb25kZXIgd2hlbiBXS1dlYlZpZXcgbW92 ZXMgdG8gYSBuZXcgd2luZG93LCBvdGhlcndpc2UgdGhlcmUgd29uJ3QgYmUgYSBmaXJzdCByZXNw b25kZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxsU2NyZWVu V2luZG93Q29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29u dHJvbGxlciBiZWdhbkVudGVyRnVsbFNjcmVlbldpdGhJbml0aWFsRnJhbWU6ZmluYWxGcmFtZTpd KToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBfY29tcGxldGVkRXhp dEZ1bGxTY3JlZW5dKToKKwogMjAxOC0wNS0xOCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNv bT4KIAogICAgICAgICBbQ29jb2FdIEFkZCBtaXNzaW5nIG51bGxhYmlsaXR5IGFubm90YXRpb25z IHRvIF9XS0F1dG9tYXRpb25TZXNzaW9uRGVsZWdhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXJJ T1MubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxTY3Jl ZW5XaW5kb3dDb250cm9sbGVySU9TLm1tCmluZGV4IGQyZjVmMThkZGI2M2I1YWY1YjY3OTFlN2Q0 MDg1ZmQyYzc1MDQzZmYuLjMwMTYxZDg5NmVkNjllMjYzMTE5N2JkNTUzNDRhNjMwMTA2ZDMwMTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVs bFNjcmVlbldpbmRvd0NvbnRyb2xsZXJJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcklPUy5tbQpAQCAt NTM1LDYgKzUzNSw3IEBAIC0gKHZvaWQpYmVnYW5FbnRlckZ1bGxTY3JlZW5XaXRoSW5pdGlhbEZy YW1lOihDR1JlY3QpaW5pdGlhbEZyYW1lIGZpbmFsRnJhbWU6KENHCiAgICAgICAgIGF1dG8qIHBh Z2UgPSBbc2VsZi5fd2ViVmlldyBfcGFnZV07CiAgICAgICAgIGF1dG8qIG1hbmFnZXIgPSBzZWxm Ll9tYW5hZ2VyOwogICAgICAgICBpZiAocGFnZSAmJiBtYW5hZ2VyKSB7CisgICAgICAgICAgICBb c2VsZi5fd2ViVmlldyBiZWNvbWVGaXJzdFJlc3BvbmRlcl07CiAgICAgICAgICAgICBtYW5hZ2Vy LT5kaWRFbnRlckZ1bGxTY3JlZW4oKTsKICAgICAgICAgICAgIG1hbmFnZXItPnNldEFuaW1hdGlu Z0Z1bGxTY3JlZW4oZmFsc2UpOwogICAgICAgICAgICAgcGFnZS0+c2V0U3VwcHJlc3NWaXNpYmls aXR5VXBkYXRlcyhmYWxzZSk7CkBAIC02MTgsNiArNjE5LDcgQEAgLSAodm9pZClfY29tcGxldGVk RXhpdEZ1bGxTY3JlZW4KICAgICBbd2ViVmlldyBzZXRBdXRvcmVzaXppbmdNYXNrOltfd2ViVmll d1BsYWNlaG9sZGVyIGF1dG9yZXNpemluZ01hc2tdXTsKIAogICAgIFtbd2ViVmlldyB3aW5kb3dd IG1ha2VLZXlBbmRWaXNpYmxlXTsKKyAgICBbd2ViVmlldyBiZWNvbWVGaXJzdFJlc3BvbmRlcl07 CiAKICAgICBfdmlld1N0YXRlLmFwcGx5VG8od2ViVmlldy5nZXQoKSk7CiAK