186077 2018-05-29 18:19:12 -0700 Update default Resource Timing buffer size from 150 to 250 2024-03-12 16:25:14 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 nic rniwa ahmad.saleem792 rniwa webkit-bug-importer oldest_to_newest 1428313 0 nic 2018-05-29 18:19:12 -0700 Per https://github.com/w3c/resource-timing/pull/155, the ResourceTiming default buffer size should be increased from 150 to 250. 2020006 1 ahmad.saleem792 2024-03-10 19:41:21 -0700 We have this function - setResourceTimingBufferSize https://searchfox.org/wubkat/rev/c67bb750f2c1083399f0dbe7d08b416cd45eee34/Source/WebCore/page/Performance.cpp#247 Although looking into WPT: https://wpt.fyi/results/resource-timing?label=master&label=experimental&aligned&q=buffer Safari seems to pass all tests, do we need to do anything here? @Ryosuke - any input or whom might be right person to comment on this? 2020354 2 rniwa 2024-03-11 20:40:29 -0700 We still have 150 hard-coded in Performance.h. We need to update it to 250 per spec: https://w3c.github.io/resource-timing/#sec-extensions-performance-interface 2020357 3 ahmad.saleem792 2024-03-11 20:45:54 -0700 (In reply to Ryosuke Niwa from comment #2) > We still have 150 hard-coded in Performance.h. We need to update it to 250 > per spec: > https://w3c.github.io/resource-timing/#sec-extensions-performance-interface Is it just to update this? https://searchfox.org/wubkat/rev/711120e7edec012527620d07bf63d85713a180fd/Source/WebCore/page/Performance.h#146 unsigned m_resourceTimingBufferSize { 150 }; Can do PR to update it to 250 with reference to web-spec, do I need to adjust any tests? 2020358 4 ahmad.saleem792 2024-03-11 20:52:03 -0700 Draft PR - https://github.com/WebKit/WebKit/pull/25757 Let's see what happens. 2020360 5 rniwa 2024-03-11 21:00:12 -0700 Pull request: https://github.com/WebKit/WebKit/pull/25758 2020591 6 ews-feeder 2024-03-12 16:24:19 -0700 Committed 276007@main (94cf8a4a86fc): <https://commits.webkit.org/276007@main> Reviewed commits have been landed. Closing PR #25758 and removing active labels. 2020592 7 webkit-bug-importer 2024-03-12 16:25:14 -0700 <rdar://problem/124487568>