186067 2018-05-29 15:20:59 -0700 Fix a few issues in WKFullScreenViewController 2018-05-30 11:18:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 186063 186103 1 jer.noble jer.noble commit-queue darin eric.carlson jeremyj-wk webkit-bug-importer oldest_to_newest 1428244 0 jer.noble 2018-05-29 15:20:59 -0700 Fix a few issues in WKFullScreenViewController 1428245 1 webkit-bug-importer 2018-05-29 15:21:35 -0700 <rdar://problem/40630944> 1428247 2 341527 jer.noble 2018-05-29 15:23:04 -0700 Created attachment 341527 Patch 1428359 3 341527 darin 2018-05-29 22:09:51 -0700 Comment on attachment 341527 Patch No test coverage for either of these mistakes? 1428482 4 jer.noble 2018-05-30 10:07:51 -0700 The "interface -> m_interface" bug was found during development of bug #186063, and this fix will be tested by the test that patch introduces. 1428497 5 341527 commit-queue 2018-05-30 10:46:55 -0700 Comment on attachment 341527 Patch Clearing flags on attachment: 341527 Committed r232299: <https://trac.webkit.org/changeset/232299> 1428498 6 commit-queue 2018-05-30 10:46:56 -0700 All reviewed patches have been landed. Closing bug. 341527 2018-05-29 15:23:04 -0700 2018-05-30 10:46:55 -0700 Patch bug-186067-20180529152303.patch text/plain 2068 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5MjM5MzBhMTQ4YTVmYmUw NjM1YzkzYjA2NTUyOGI3MGFiOGY0ZGUuLjk2YmViNTViMTZlZTBhYzk1MzljYjdiNGYwYzE3ZTU0 YjY4Zjg5Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDUtMjkgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGEgZmV3IGlzc3VlcyBpbiBX S0Z1bGxTY3JlZW5WaWV3Q29udHJvbGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg2MDY3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDYzMDk0 ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg Y2hlY2sgaW4gc2V0SW50ZXJmYWNlKCkgaXMgY2hlY2tpbmcgdGhlIHdyb25nIHBvaW50ZXI6Cisg ICAgICAgICogVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlblZpZXdDb250cm9s bGVyLm1tOgorICAgICAgICAoV0tGdWxsU2NyZWVuVmlld0NvbnRyb2xsZXJQbGF5YmFja1Nlc3Np b25Nb2RlbENsaWVudDo6c2V0SW50ZXJmYWNlKToKKworICAgICAgICBUaGUgY2hlY2sgaW4gLV9l ZmZlY3RpdmVGdWxsc2NyZWVuSW5zZXRUb3AgaXMgYmFja3dhcmRzOgorICAgICAgICAoLVtXS0Z1 bGxTY3JlZW5WaWV3Q29udHJvbGxlciBfZWZmZWN0aXZlRnVsbHNjcmVlbkluc2V0VG9wXSk6CisK IDIwMTgtMDUtMjkgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAg QXV0by1waXAgc2hvdWxkIHVzZSBtYWluIGNvbnRlbnQgaGV1cmlzdGljLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxsU2NyZWVuVmlld0Nv bnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1 bGxTY3JlZW5WaWV3Q29udHJvbGxlci5tbQppbmRleCAwYzdkNDhkYjMxNTczNzQwOTFjZGQ1OWRl ZDRmNjljYzg5MTJhOTM1Li5mNDFjZWQ2MDAzNTZmNDE1YmZmZGYwNmNkOTg4ODk3NjM1OTZhMjJi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1 bGxTY3JlZW5WaWV3Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvZnVsbHNjcmVlbi9XS0Z1bGxTY3JlZW5WaWV3Q29udHJvbGxlci5tbQpAQCAtNjcsNyArNjcs NyBAQCBwdWJsaWM6CiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgaWYgKG1faW50ZXJm YWNlICYmIG1faW50ZXJmYWNlLT5wbGF5YmFja1Nlc3Npb25Nb2RlbCgpKQotICAgICAgICAgICAg aW50ZXJmYWNlLT5wbGF5YmFja1Nlc3Npb25Nb2RlbCgpLT5yZW1vdmVDbGllbnQoKnRoaXMpOwor ICAgICAgICAgICAgbV9pbnRlcmZhY2UtPnBsYXliYWNrU2Vzc2lvbk1vZGVsKCktPnJlbW92ZUNs aWVudCgqdGhpcyk7CiAgICAgICAgIG1faW50ZXJmYWNlID0gaW50ZXJmYWNlOwogICAgICAgICBp ZiAobV9pbnRlcmZhY2UgJiYgbV9pbnRlcmZhY2UtPnBsYXliYWNrU2Vzc2lvbk1vZGVsKCkpCiAg ICAgICAgICAgICBpbnRlcmZhY2UtPnBsYXliYWNrU2Vzc2lvbk1vZGVsKCktPmFkZENsaWVudCgq dGhpcyk7CkBAIC0zNTcsNyArMzU3LDcgQEAgLSAoV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eSop X21hbmFnZXIKIEBkeW5hbWljIF9lZmZlY3RpdmVGdWxsc2NyZWVuSW5zZXRUb3A7CiAtIChDR0Zs b2F0KV9lZmZlY3RpdmVGdWxsc2NyZWVuSW5zZXRUb3AKIHsKLSAgICBpZiAoIXNlbGYucHJlZmVy c1N0YXR1c0JhckhpZGRlbikKKyAgICBpZiAoc2VsZi5wcmVmZXJzU3RhdHVzQmFySGlkZGVuKQog ICAgICAgICByZXR1cm4gMDsKIAogICAgIENHUmVjdCBjYW5jZWxGcmFtZSA9IF9jYW5jZWxCdXR0 b24uZ2V0KCkuZnJhbWU7Cg==