186066 2018-05-29 15:19:32 -0700 Printing does not apply the right styles 2018-05-29 16:41:46 -0700 1 1 1 Unclassified WebKit Printing WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bdakin commit-queue ews-watchlist joepeck megan_gardner thorton oldest_to_newest 1428242 0 timothy 2018-05-29 15:19:32 -0700 <rdar://problem/40274975> 1428246 1 341526 timothy 2018-05-29 15:22:37 -0700 Created attachment 341526 Patch 1428250 2 341526 megan_gardner 2018-05-29 15:46:22 -0700 Comment on attachment 341526 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341526&action=review R=me, except that I can't actually r+ ;) > Source/WebCore/ChangeLog:18 > + (WebCore::Page::defaultAppearance const): Deleted. Nit, "Deleted implementation" makes more sense to me. 1428275 3 341526 commit-queue 2018-05-29 16:41:45 -0700 Comment on attachment 341526 Patch Clearing flags on attachment: 341526 Committed r232278: <https://trac.webkit.org/changeset/232278> 1428276 4 commit-queue 2018-05-29 16:41:46 -0700 All reviewed patches have been landed. Closing bug. 341526 2018-05-29 15:22:37 -0700 2018-05-29 16:41:45 -0700 Patch bug-186066-20180529152236.patch text/plain 4013 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGFhM2EzZGE4ODZlMmVk MzVkNDBkOGE5ZWFlNjJlMDE1YTJmNzIyZi4uNjNlYTM3ZWVkZTM4NDRmNGJiNmJiZWRkYjQwZjA2 OWIwYmZlZjAxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA1LTI5ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBQcmludGluZyBkb2Vz IG5vdCBhcHBseSB0aGUgcmlnaHQgY29sb3JzIGluIGFsbCBjYXNlcy4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2MDY2CisgICAgICAgIHJkYXI6 Ly9wcm9ibGVtLzQwMjc0OTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBpbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclBhZ2VBZ2VudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JQYWdlQWdlbnQ6OnNldEVtdWxhdGVkTWVkaWEpOiBD YWxsIFJlbmRlclRoZW1lOjpwbGF0Zm9ybUNvbG9yc0RpZENoYW5nZQorICAgICAgICB0byBpbnZh bGlkYXRlIHRoZSBjb2xvciBjYWNoZS4KKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmFkanVzdE1lZGlhVHlwZUZvclByaW50aW5nKTog RGl0dG8uCisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6 OmRlZmF1bHRBcHBlYXJhbmNlIGNvbnN0KTogQWRkZWQuIFVzZSBkZWZhdWx0IHdoZW4gbm90IHNj cmVlbi4KKyAgICAgICAgKiBwYWdlL1BhZ2UuaDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OmRl ZmF1bHRBcHBlYXJhbmNlIGNvbnN0KTogRGVsZXRlZC4KKwogMjAxOC0wNS0yOSAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEF2b2lkIHVubmVjZXNzYXJ5IFN0cmlu ZyBhbGxvY2F0aW9uIGluIGlzUHVibGljU3VmZml4KGNvbnN0IFN0cmluZyYpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAK aW5kZXggNThiN2I2ZTQ0MTk0NmZmODQwY2JlY2I1NzkwNjFjM2UzMGJkMmRiNy4uMmUzYjc2ZDcx ZGNkMTExMTFiYTAxNTU0MDFjZTk5MWYxNjlkODdkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yUGFnZUFnZW50LmNwcApAQCAtNTUsNiAr NTUsNyBAQAogI2luY2x1ZGUgIk1lbW9yeUNhY2hlLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2lu Y2x1ZGUgIlJlbmRlck9iamVjdC5oIgorI2luY2x1ZGUgIlJlbmRlclRoZW1lLmgiCiAjaW5jbHVk ZSAiU2NyaXB0Q29udHJvbGxlci5oIgogI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAjaW5j bHVkZSAiU2V0dGluZ3MuaCIKQEAgLTc4NSw4ICs3ODYsMTAgQEAgdm9pZCBJbnNwZWN0b3JQYWdl QWdlbnQ6OnNldEVtdWxhdGVkTWVkaWEoRXJyb3JTdHJpbmcmLCBjb25zdCBTdHJpbmcmIG1lZGlh KQogICAgICAgICByZXR1cm47CiAKICAgICBtX2VtdWxhdGVkTWVkaWEgPSBtZWRpYTsKLSAgICBE b2N1bWVudCogZG9jdW1lbnQgPSBtX3BhZ2UubWFpbkZyYW1lKCkuZG9jdW1lbnQoKTsKLSAgICBp ZiAoZG9jdW1lbnQpIHsKKworICAgIFJlbmRlclRoZW1lOjpzaW5nbGV0b24oKS5wbGF0Zm9ybUNv bG9yc0RpZENoYW5nZSgpOworCisgICAgaWYgKGF1dG8gZG9jdW1lbnQgPSBtX3BhZ2UubWFpbkZy YW1lKCkuZG9jdW1lbnQoKSkgewogICAgICAgICBkb2N1bWVudC0+c3R5bGVTY29wZSgpLmRpZENo YW5nZVN0eWxlU2hlZXRFbnZpcm9ubWVudCgpOwogICAgICAgICBkb2N1bWVudC0+dXBkYXRlTGF5 b3V0KCk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDc3NGJlMjJhMmFm OTlhZDM1MGM0OGRjOTYwZjM1NTRmZjY3OGI4Y2QuLjQ4Mjc0Nzk1OGU1Yjc2ZmM5MGUxMGY4ODQ0 N2YxMGYyMWNiZDVjNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTEzNzksNiAr MTM3OSw4IEBAIHZvaWQgRnJhbWVWaWV3OjphZGp1c3RNZWRpYVR5cGVGb3JQcmludGluZyhib29s IHByaW50aW5nKQogICAgICAgICAgICAgc2V0TWVkaWFUeXBlKG1fbWVkaWFUeXBlV2hlbk5vdFBy aW50aW5nKTsKICAgICAgICAgbV9tZWRpYVR5cGVXaGVuTm90UHJpbnRpbmcgPSBTdHJpbmcoKTsK ICAgICB9CisKKyAgICBSZW5kZXJUaGVtZTo6c2luZ2xldG9uKCkucGxhdGZvcm1Db2xvcnNEaWRD aGFuZ2UoKTsKIH0KIAogYm9vbCBGcmFtZVZpZXc6OnVzZVNsb3dSZXBhaW50cyhib29sIGNvbnNp ZGVyT3ZlcmxhcCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCmluZGV4IGY3Y2VlMmRmNGQ4NTlkNmU2 YzM1NDMyZGMwNTc4OTM1MWMwNGZhYWQuLjc4MDU4MmIwNDA3M2VhOTA4YWI3NDMxNzc5NzA2YzFj Yjg5Yzc2ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcApAQCAtMjM2OCw2ICsyMzY4LDE0IEBAIHZvaWQg UGFnZTo6c2V0VW5vYnNjdXJlZFNhZmVBcmVhSW5zZXRzKGNvbnN0IEZsb2F0Qm94RXh0ZW50JiBp bnNldHMpCiAgICAgfQogfQogCitib29sIFBhZ2U6OmRlZmF1bHRBcHBlYXJhbmNlKCkgY29uc3QK K3sKKyAgICBGcmFtZVZpZXcqIHZpZXcgPSBtYWluRnJhbWUoKS52aWV3KCk7CisgICAgaWYgKCF2 aWV3IHx8ICFlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZSh2aWV3LT5tZWRpYVR5cGUoKSwg InNjcmVlbiIpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gbV9kZWZhdWx0QXBw ZWFyYW5jZTsKK30KKwogdm9pZCBQYWdlOjpzZXRGdWxsc2NyZWVuSW5zZXRUb3AoZG91YmxlIGlu c2V0KQogewogICAgIGZvciAoRnJhbWUqIGZyYW1lID0gJm1haW5GcmFtZSgpOyBmcmFtZTsgZnJh bWUgPSBmcmFtZS0+dHJlZSgpLnRyYXZlcnNlTmV4dCgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1BhZ2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oCmluZGV4IDVj YzE1ZThiZWVlYWU4ODZjOTkyZGVkYmE4NTZiZjY5ZDRjMzU0NDIuLjJiNjMyOGFhMTNmOGRjMTRl YWRjOGEzYjgwNWIxMWY0YTFiMmI0MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv UGFnZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oCkBAIC0zNDIsNyArMzQyLDcg QEAgcHVibGljOgogICAgIGJvb2wgdXNlU3lzdGVtQXBwZWFyYW5jZSgpIGNvbnN0IHsgcmV0dXJu IG1fdXNlU3lzdGVtQXBwZWFyYW5jZTsgfQogICAgIHZvaWQgc2V0VXNlU3lzdGVtQXBwZWFyYW5j ZShib29sIGEpIHsgbV91c2VTeXN0ZW1BcHBlYXJhbmNlID0gYTsgfQogICAgIAotICAgIGJvb2wg ZGVmYXVsdEFwcGVhcmFuY2UoKSBjb25zdCB7IHJldHVybiBtX2RlZmF1bHRBcHBlYXJhbmNlOyB9 CisgICAgYm9vbCBkZWZhdWx0QXBwZWFyYW5jZSgpIGNvbnN0OwogICAgIHZvaWQgc2V0RGVmYXVs dEFwcGVhcmFuY2UoYm9vbCBhKSB7IG1fZGVmYXVsdEFwcGVhcmFuY2UgPSBhOyB9CiAKICNpZiBF TkFCTEUoVEVYVF9BVVRPU0laSU5HKQo=