186061 2018-05-29 14:46:44 -0700 REGRESSION(r232212): Broke Win32 Builds 2018-06-01 16:33:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 186153 185989 1 msaboff msaboff ap commit-queue realdawei ryanhaddad webkit-bug-importer ysuzuki oldest_to_newest 1428219 0 msaboff 2018-05-29 14:46:44 -0700 Looks like the CMakefile needs to be updated as well to create LLIntAssembly.h instead of LowLevelInterpreterWin.asm. 1428225 1 341521 msaboff 2018-05-29 14:50:28 -0700 Created attachment 341521 Patch 1428460 2 341521 ysuzuki 2018-05-30 08:59:49 -0700 Comment on attachment 341521 Patch r=me 1428463 3 341521 commit-queue 2018-05-30 09:09:07 -0700 Comment on attachment 341521 Patch Clearing flags on attachment: 341521 Committed r232293: <https://trac.webkit.org/changeset/232293> 1428464 4 commit-queue 2018-05-30 09:09:09 -0700 All reviewed patches have been landed. Closing bug. 1428465 5 webkit-bug-importer 2018-05-30 09:10:30 -0700 <rdar://problem/40651765> 1428484 6 realdawei 2018-05-30 10:12:15 -0700 It's looking like even with a clean build, Windows build is still failing: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/9732/steps/compile-webkit/logs/stdio 1428488 7 ryanhaddad 2018-05-30 10:31:10 -0700 Reopening per David's comment. 1428490 8 msaboff 2018-05-30 10:35:09 -0700 (In reply to Ryan Haddad from comment #7) > Reopening per David's comment. I should have been clear that I didn't want a cq+ until the EWS bots worked. Investigating some more. 1428544 9 ap 2018-05-30 12:29:40 -0700 > I should have been clear that I didn't want a cq+ until the EWS bots worked. Yup, so I understood - but landing it didn't make things worse. 1429417 10 msaboff 2018-06-01 16:33:28 -0700 This was fixed with the rollout of r232212 tracked in <https://bugs.webkit.org/show_bug.cgi?id=186153>. 341521 2018-05-29 14:50:28 -0700 2018-05-30 09:09:07 -0700 Patch 186061.patch text/plain 1858 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMyMjc0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE4LTA1LTI5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjIzMjIxMik6IEJyb2tlIFdpbjMyIEJ1aWxkcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2MDYxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCBXaW5kb3dzIGJ1aWxk cyB3aXRoIHRoZSBKSVQgZGlzYWJsZWQgdG8gZ2VuZXJhdGUgYW5kIHVzZSBMTEludEFzc2VtYmx5 LmgKKyAgICAgICAgaW5zdGVhZCBvZiBMb3dMZXZlbEludGVycHJldGVyV2luLmFzbS4KKworICAg ICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE4LTA1LTI5ICBDYWlvIExpbWEgIDx0aWNhaW9s aW1hQGdtYWlsLmNvbT4KIAogICAgICAgICBbRVNOZXh0XVtCaWdJbnRdIEltcGxlbWVudCBzdXBw b3J0IGZvciAiPCIgYW5kICI+IiByZWxhdGlvbmFsIG9wZXJhdGlvbgpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DTWFrZUxpc3RzLnR4dAkocmV2aXNpb24gMjMyMjYzKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yNjMsNyArMjYzLDcg QEAgYWRkX2RlcGVuZGVuY2llcyhMTEludE9mZnNldHNFeHRyYWN0b3IgSgogIyBMTEludE9mZnNl dHNFeHRyYWN0b3IgbWF0Y2hlcywgbm8gb3V0cHV0IGlzIGdlbmVyYXRlZC4gVG8gbWFrZSB0aGlz IHRhcmdldCBjb25zaXN0ZW50IGFuZCBhdm9pZAogIyBydW5uaW5nIHRoaXMgY29tbWFuZCBmb3Ig ZXZlcnkgYnVpbGQsIHdlIGFydGlmaWNpYWxseSB1cGRhdGUgTExJbnRBc3NlbWJseS5oJ3MgbXRp bWUgKHVzaW5nIHRvdWNoKQogIyBhZnRlciBldmVyeSBhc20ucmIgcnVuLgotaWYgKE1TVkMpCitp ZiAoTVNWQyBBTkQgRU5BQkxFX0pJVCkKICAgICBzZXQoTExJbnRPdXRwdXQgTG93TGV2ZWxJbnRl cnByZXRlcldpbi5hc20pCiAgICAgc2V0KE9GRkxJTkVfQVNNX0FSR1MgLS1hc3NlbWJsZXI9TUFT TSkKIGVsc2UgKCkKQEAgLTI4Myw3ICsyODMsNyBAQCBhZGRfY3VzdG9tX2NvbW1hbmQoCiAjIHRo ZSAuY3BwIGZpbGVzIGJlbG93IGlzIHNpbWlsYXIgdG8gdGhlIG9uZSBpbiB0aGUgcHJldmlvdXMg Y29tbWVudC4gSG93ZXZlciwgc2luY2UgdGhlc2UgLmNwcAogIyBmaWxlcyBhcmUgdXNlZCB0byBi dWlsZCBKYXZhU2NyaXB0Q29yZSBpdHNlbGYsIHdlIGNhbiBqdXN0IGFkZCBMTEludEFzc2VtYmx5 LmggdG8gSlNDX0hFQURFUlMKICMgc2luY2UgaXQgaXMgdXNlZCBpbiB0aGUgYWRkX2xpYnJhcnko KSBjYWxsIGF0IHRoZSBlbmQgb2YgdGhpcyBmaWxlLgotaWYgKE1TVkMpCitpZiAoTVNWQyBBTkQg RU5BQkxFX0pJVCkKICAgICBlbmFibGVfbGFuZ3VhZ2UoQVNNX01BU00pCiAgICAgaWYgKENNQUtF X1NJWkVPRl9WT0lEX1AgRVFVQUwgNCkKICAgICAgICAgIyBXaW4zMiBuZWVkcyAvc2FmZXNlaCB3 aXRoIGFzc2VtYmx5LCBidXQgV2luNjQgZG9lcyBub3QuCg==