186060 2018-05-29 13:52:47 -0700 Store 0-lifetime stylesheets / scripts into the disk cache for faster history navigations 2018-06-06 12:58:37 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 cdumez cdumez cgarcia commit-queue ews-watchlist ggaren koivisto simon.fraser webkit-bug-importer oldest_to_newest 1428199 0 cdumez 2018-05-29 13:52:47 -0700 Store 0-lifetime stylesheets / scripts into the disk cache for faster history navigations. In particular, on apple.com, several of the scripts / stylesheets currently do not get stored because our current heuristic thinks they are unlikely to be reused. For e.g.: Summary URL: https://www.apple.com/ac/globalfooter/3/en_US/styles/ac-globalfooter.built.css Status: 200 OK Request No request, served from the disk cache. Response Date: Tue, 29 May 2018 20:41:41 GMT Connection: keep-alive Content-Encoding: gzip Access-Control-Allow-Origin: https://www.apple.com Expires: Tue, 29 May 2018 20:41:41 GMT Cache-Control: max-age=0 Content-Length: 5212 Vary: Accept-Encoding Content-Type: text/css Server: Apache X-Check-Cacheable: YES X-Serial: 6858 1428200 1 webkit-bug-importer 2018-05-29 13:53:23 -0700 <rdar://problem/40627270> 1428201 2 341515 cdumez 2018-05-29 13:58:22 -0700 Created attachment 341515 Patch 1428215 3 341515 ggaren 2018-05-29 14:34:46 -0700 Comment on attachment 341515 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341515&action=review r=me > Source/WebKit/ChangeLog:9 > + Tweak our storeUnconditionallyForHistoryNavigation logic to match resources' whose priority resources 1428218 4 341519 cdumez 2018-05-29 14:39:33 -0700 Created attachment 341519 Patch 1428236 5 341519 commit-queue 2018-05-29 15:14:09 -0700 Comment on attachment 341519 Patch Clearing flags on attachment: 341519 Committed r232275: <https://trac.webkit.org/changeset/232275> 1428237 6 commit-queue 2018-05-29 15:14:10 -0700 All reviewed patches have been landed. Closing bug. 1429616 7 cdumez 2018-06-02 16:34:49 -0700 Reverted r232275 for reason: May have caused a ~1% PLT regression on iOS Committed r232447: <https://trac.webkit.org/changeset/232447> 1430555 8 cdumez 2018-06-06 12:42:24 -0700 Apparently too costly. I don't have a better idea at the moment. 1430561 9 koivisto 2018-06-06 12:58:37 -0700 This seems like something the site should fix rather than something we should optimise for. 341515 2018-05-29 13:58:22 -0700 2018-05-29 14:39:32 -0700 Patch bug-186060-20180529135822.patch text/plain 2401 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIzZmZhYzdmNzk0YzU3MDcw NjhlMGUzZGUwMTllYmViNDZhMmYwNTIuLjg5NThiYTNiYTM5ZGE1MDg5ZWZlYmFhMGRjOGY0ZDg1 YjI2ZTJhYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMDUtMjkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBTdG9yZSAwLWxpZmV0aW1lIHN0eWxl c2hlZXRzIC8gc2NyaXB0cyBpbnRvIHRoZSBkaXNrIGNhY2hlIGZvciBmYXN0ZXIgaGlzdG9yeSBu YXZpZ2F0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg2MDYwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDYyNzI3MD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUd2VhayBvdXIgc3RvcmVVbmNv bmRpdGlvbmFsbHlGb3JIaXN0b3J5TmF2aWdhdGlvbiBsb2dpYyB0byBtYXRjaCByZXNvdXJjZXMn IHdob3NlIHByaW9yaXR5CisgICAgICAgIGlzIEhpZ2gsIG5vdCBqdXN0IFZlcnlIaWdoLiBQZXIg bG9naWMgaW4gQ2FjaGVkUmVzb3VyY2U6OmRlZmF1bHRQcmlvcml0eUZvclJlc291cmNlVHlwZShU eXBlKSwKKyAgICAgICAgVGhpcyBub3cgbWF0Y2hlcyBzdHlsZXNoZWV0cyBhbmQgc2NyaXB0cyBp biBhZGRpdGlvbiB0byBtYWluIHJlc291cmNlcy4KKworICAgICAgICBJIGZvdW5kIHRoYXQgaW4g Y2FzZSBvZiBhIGhpc3RvcnkgbmF2aWdhdGlvbiB0byBhcHBsZS5jb20sIGEgc2lnbmlmaWNhbnQg bnVtYmVyIG9mIHNjcmlwdHMKKyAgICAgICAgYW5kIHN0eWxlc2hlZXRzIGhhZCB0byBiZSBsb2Fk ZWQgZnJvbSB0aGUgbmV0d29yayBiZWNhdXNlIG91ciBwcmV2aW91cyBoZXVyaXN0aWMgZGVjaWRl ZAorICAgICAgICBub3QgdG8gc3RvcmUgdGhlbSAoYmVjYXVzZSB0aGVpciBwcmlvcml0eSB3YXMg bm90IFZlcnlIaWdoIGFuZCBiZWNhdXNlIHRoZWlyIG1heC1hZ2Ugd2FzCisgICAgICAgIDApLgor CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjptYWtlU3RvcmVEZWNpc2lvbik6CisKIDIwMTgtMDUt MjkgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmVk IHNvbWUgdW51c2VkIFdlYlNRTCB0cmFja2VycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCmluZGV4IDljYzRhMWUxZDhiNDU2N2M4 NGFiMDA5ZWZhNjU4ZjZkMDBiMWMxNGYuLmM1NDdlYTg2ZmNiZDVjZmM5MDM0MDNkNTFhNzc2MzNm NTZkZjM0MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUv TmV0d29ya0NhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hl L05ldHdvcmtDYWNoZS5jcHAKQEAgLTI3Niw3ICsyNzYsNyBAQCBzdGF0aWMgU3RvcmVEZWNpc2lv biBtYWtlU3RvcmVEZWNpc2lvbihjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmIG9yaWdp bmFsUgogICAgIH0KIAogICAgIGJvb2wgaXNNYWluUmVzb3VyY2UgPSBvcmlnaW5hbFJlcXVlc3Qu cmVxdWVzdGVyKCkgPT0gV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0OjpSZXF1ZXN0ZXI6Ok1haW47 Ci0gICAgYm9vbCBzdG9yZVVuY29uZGl0aW9uYWxseUZvckhpc3RvcnlOYXZpZ2F0aW9uID0gaXNN YWluUmVzb3VyY2UgfHwgb3JpZ2luYWxSZXF1ZXN0LnByaW9yaXR5KCkgPT0gV2ViQ29yZTo6UmVz b3VyY2VMb2FkUHJpb3JpdHk6OlZlcnlIaWdoOworICAgIGJvb2wgc3RvcmVVbmNvbmRpdGlvbmFs bHlGb3JIaXN0b3J5TmF2aWdhdGlvbiA9IGlzTWFpblJlc291cmNlIHx8IG9yaWdpbmFsUmVxdWVz dC5wcmlvcml0eSgpID49IFdlYkNvcmU6OlJlc291cmNlTG9hZFByaW9yaXR5OjpIaWdoOwogICAg IGlmICghc3RvcmVVbmNvbmRpdGlvbmFsbHlGb3JIaXN0b3J5TmF2aWdhdGlvbikgewogICAgICAg ICBhdXRvIG5vdyA9IFdhbGxUaW1lOjpub3coKTsKICAgICAgICAgYm9vbCBoYXNOb25aZXJvTGlm ZXRpbWUgPSAhcmVzcG9uc2UuY2FjaGVDb250cm9sQ29udGFpbnNOb0NhY2hlKCkgJiYgV2ViQ29y ZTo6Y29tcHV0ZUZyZXNobmVzc0xpZmV0aW1lRm9ySFRUUEZhbWlseShyZXNwb25zZSwgbm93KSA+ IDBfbXM7Cg== 341519 2018-05-29 14:39:33 -0700 2018-05-29 15:14:09 -0700 Patch bug-186060-20180529143933.patch text/plain 2407 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVkY2Y3MWQ1YmQ0MmYzNzNm ZDBmMmMyMDQxNjQzNGM1ZThiNjZiMjAuLjY4ZjJhNTYwN2NkNzJjMjI4NTU5N2FhZGVmOGZiOWJj OGNiY2IzY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMDUtMjkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBTdG9yZSAwLWxpZmV0aW1lIHN0eWxl c2hlZXRzIC8gc2NyaXB0cyBpbnRvIHRoZSBkaXNrIGNhY2hlIGZvciBmYXN0ZXIgaGlzdG9yeSBu YXZpZ2F0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg2MDYwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDYyNzI3MD4KKworICAgICAgICBS ZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KKworICAgICAgICBUd2VhayBvdXIgc3RvcmVVbmNv bmRpdGlvbmFsbHlGb3JIaXN0b3J5TmF2aWdhdGlvbiBsb2dpYyB0byBtYXRjaCByZXNvdXJjZXMg d2hvc2UgcHJpb3JpdHkKKyAgICAgICAgaXMgSGlnaCwgbm90IGp1c3QgVmVyeUhpZ2guIFBlciBs b2dpYyBpbiBDYWNoZWRSZXNvdXJjZTo6ZGVmYXVsdFByaW9yaXR5Rm9yUmVzb3VyY2VUeXBlKFR5 cGUpLAorICAgICAgICBUaGlzIG5vdyBtYXRjaGVzIHN0eWxlc2hlZXRzIGFuZCBzY3JpcHRzIGlu IGFkZGl0aW9uIHRvIG1haW4gcmVzb3VyY2VzLgorCisgICAgICAgIEkgZm91bmQgdGhhdCBpbiBj YXNlIG9mIGEgaGlzdG9yeSBuYXZpZ2F0aW9uIHRvIGFwcGxlLmNvbSwgYSBzaWduaWZpY2FudCBu dW1iZXIgb2Ygc2NyaXB0cworICAgICAgICBhbmQgc3R5bGVzaGVldHMgaGFkIHRvIGJlIGxvYWRl ZCBmcm9tIHRoZSBuZXR3b3JrIGJlY2F1c2Ugb3VyIHByZXZpb3VzIGhldXJpc3RpYyBkZWNpZGVk CisgICAgICAgIG5vdCB0byBzdG9yZSB0aGVtIChiZWNhdXNlIHRoZWlyIHByaW9yaXR5IHdhcyBu b3QgVmVyeUhpZ2ggYW5kIGJlY2F1c2UgdGhlaXIgbWF4LWFnZSB3YXMKKyAgICAgICAgMCkuCisK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwOgorICAgICAg ICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6Om1ha2VTdG9yZURlY2lzaW9uKToKKwogMjAxOC0wNS0y OCAgSmVmZiBNaWxsZXIgIDxqZWZmbUBhcHBsZS5jb20+CiAKICAgICAgICAgRXhwb3NlIGFkZGl0 aW9uYWwgV0tNZW51SXRlbUlkZW50aWZpZXIgc3RyaW5ncwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCmluZGV4IDljYzRhMWUxZDhi NDU2N2M4NGFiMDA5ZWZhNjU4ZjZkMDBiMWMxNGYuLmM1NDdlYTg2ZmNiZDVjZmM5MDM0MDNkNTFh Nzc2MzNmNTZkZjM0MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv Y2FjaGUvTmV0d29ya0NhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L2NhY2hlL05ldHdvcmtDYWNoZS5jcHAKQEAgLTI3Niw3ICsyNzYsNyBAQCBzdGF0aWMgU3RvcmVE ZWNpc2lvbiBtYWtlU3RvcmVEZWNpc2lvbihjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Qm IG9yaWdpbmFsUgogICAgIH0KIAogICAgIGJvb2wgaXNNYWluUmVzb3VyY2UgPSBvcmlnaW5hbFJl cXVlc3QucmVxdWVzdGVyKCkgPT0gV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0OjpSZXF1ZXN0ZXI6 Ok1haW47Ci0gICAgYm9vbCBzdG9yZVVuY29uZGl0aW9uYWxseUZvckhpc3RvcnlOYXZpZ2F0aW9u ID0gaXNNYWluUmVzb3VyY2UgfHwgb3JpZ2luYWxSZXF1ZXN0LnByaW9yaXR5KCkgPT0gV2ViQ29y ZTo6UmVzb3VyY2VMb2FkUHJpb3JpdHk6OlZlcnlIaWdoOworICAgIGJvb2wgc3RvcmVVbmNvbmRp dGlvbmFsbHlGb3JIaXN0b3J5TmF2aWdhdGlvbiA9IGlzTWFpblJlc291cmNlIHx8IG9yaWdpbmFs UmVxdWVzdC5wcmlvcml0eSgpID49IFdlYkNvcmU6OlJlc291cmNlTG9hZFByaW9yaXR5OjpIaWdo OwogICAgIGlmICghc3RvcmVVbmNvbmRpdGlvbmFsbHlGb3JIaXN0b3J5TmF2aWdhdGlvbikgewog ICAgICAgICBhdXRvIG5vdyA9IFdhbGxUaW1lOjpub3coKTsKICAgICAgICAgYm9vbCBoYXNOb25a ZXJvTGlmZXRpbWUgPSAhcmVzcG9uc2UuY2FjaGVDb250cm9sQ29udGFpbnNOb0NhY2hlKCkgJiYg V2ViQ29yZTo6Y29tcHV0ZUZyZXNobmVzc0xpZmV0aW1lRm9ySFRUUEZhbWlseShyZXNwb25zZSwg bm93KSA+IDBfbXM7Cg==