186056 2018-05-29 10:25:44 -0700 Create typedef for HashMap<PlatformDisplayID, ScreenProperties> 2018-05-29 16:28:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue webkit-bug-importer oldest_to_newest 1428107 0 pvollan 2018-05-29 10:25:44 -0700 Improve readability by creating a typedef for HashMap<WebCore::PlatformDisplayID, WebCore::ScreenProperties>. 1428113 1 341495 pvollan 2018-05-29 10:32:20 -0700 Created attachment 341495 Patch 1428115 2 webkit-bug-importer 2018-05-29 10:33:25 -0700 <rdar://problem/40619613> 1428254 3 341495 bfulgham 2018-05-29 15:57:05 -0700 Comment on attachment 341495 Patch Excellent. r=me 1428259 4 341495 pvollan 2018-05-29 16:01:50 -0700 Comment on attachment 341495 Patch Thanks for reviewing! 1428270 5 341495 commit-queue 2018-05-29 16:28:47 -0700 Comment on attachment 341495 Patch Clearing flags on attachment: 341495 Committed r232277: <https://trac.webkit.org/changeset/232277> 1428271 6 commit-queue 2018-05-29 16:28:48 -0700 All reviewed patches have been landed. Closing bug. 341495 2018-05-29 10:32:20 -0700 2018-05-29 16:28:47 -0700 Patch bug-186056-20180529103219.patch text/plain 5370 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjI2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA1LTI5ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBDcmVhdGUgdHlwZWRlZiBm b3IgSGFzaE1hcDxQbGF0Zm9ybURpc3BsYXlJRCwgU2NyZWVuUHJvcGVydGllcz4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjA1NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8g Y2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogcGxhdGZvcm0vUGxhdGZvcm1TY3JlZW4u aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvUGxhdGZvcm1TY3JlZW5NYWMubW06CisgICAgICAg IChXZWJDb3JlOjpzY3JlZW5Qcm9wZXJ0aWVzKToKKyAgICAgICAgKFdlYkNvcmU6OmdldFNjcmVl blByb3BlcnRpZXMpOgorICAgICAgICAoV2ViQ29yZTo6c2V0U2NyZWVuUHJvcGVydGllcyk6CisK IDIwMTgtMDUtMjkgIE5hbiBXYW5nICA8bl93YW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDog c2V0VmFsdWUgb24gY29udGVudGVkaXRhYmxlIHNob3VsZCBwcmVzZXJ2ZSB3aGl0ZXNwYWNlCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybVNjcmVlbi5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtU2NyZWVuLmgJKHJldmlzaW9uIDIz MjI2MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtU2NyZWVuLmgJKHdvcmtp bmcgY29weSkKQEAgLTkzLDggKzkzLDEwIEBAIFdFQkNPUkVfRVhQT1JUIE5TUmVjdCB0b0Rldmlj ZVNwYWNlKGNvbnMKIAogTlNQb2ludCBmbGlwU2NyZWVuUG9pbnQoY29uc3QgTlNQb2ludCYsIE5T U2NyZWVuICopOwogCi1XRUJDT1JFX0VYUE9SVCBzdGQ6OnBhaXI8UGxhdGZvcm1EaXNwbGF5SUQs IEhhc2hNYXA8UGxhdGZvcm1EaXNwbGF5SUQsIFNjcmVlblByb3BlcnRpZXM+PiBnZXRTY3JlZW5Q cm9wZXJ0aWVzKCk7Ci1XRUJDT1JFX0VYUE9SVCB2b2lkIHNldFNjcmVlblByb3BlcnRpZXMoUGxh dGZvcm1EaXNwbGF5SUQgcHJpbWFyeVNjcmVlbklELCBjb25zdCBIYXNoTWFwPFBsYXRmb3JtRGlz cGxheUlELCBTY3JlZW5Qcm9wZXJ0aWVzPiYpOwordHlwZWRlZiBIYXNoTWFwPFBsYXRmb3JtRGlz cGxheUlELCBTY3JlZW5Qcm9wZXJ0aWVzPiBTY3JlZW5Qcm9wZXJ0aWVzTWFwOworCitXRUJDT1JF X0VYUE9SVCBzdGQ6OnBhaXI8UGxhdGZvcm1EaXNwbGF5SUQsIFNjcmVlblByb3BlcnRpZXNNYXA+ IGdldFNjcmVlblByb3BlcnRpZXMoKTsKK1dFQkNPUkVfRVhQT1JUIHZvaWQgc2V0U2NyZWVuUHJv cGVydGllcyhQbGF0Zm9ybURpc3BsYXlJRCBwcmltYXJ5U2NyZWVuSUQsIGNvbnN0IFNjcmVlblBy b3BlcnRpZXNNYXAmKTsKIFNjcmVlblByb3BlcnRpZXMgc2NyZWVuUHJvcGVydGllcyhQbGF0Zm9y bURpc3BsYXlJRCk7CiAKICNlbmRpZgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1BsYXRmb3JtU2NyZWVuTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbQkocmV2aXNpb24gMjMyMjYxKQorKysgU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tCSh3b3JraW5nIGNvcHkp CkBAIC05Niw5ICs5Niw5IEBAIHN0YXRpYyBOU1NjcmVlbiAqc2NyZWVuKFdpZGdldCogd2lkZ2V0 KQogICAgIHJldHVybiBzY3JlZW4oZGlzcGxheUlEKHdpZGdldCkpOwogfQogCi1zdGF0aWMgSGFz aE1hcDxQbGF0Zm9ybURpc3BsYXlJRCwgU2NyZWVuUHJvcGVydGllcz4mIHNjcmVlblByb3BlcnRp ZXMoKQorc3RhdGljIFNjcmVlblByb3BlcnRpZXNNYXAmIHNjcmVlblByb3BlcnRpZXMoKQogewot ICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxIYXNoTWFwPFBsYXRmb3JtRGlzcGxheUlELCBTY3Jl ZW5Qcm9wZXJ0aWVzPj4gc2NyZWVuUHJvcGVydGllczsKKyAgICBzdGF0aWMgTmV2ZXJEZXN0cm95 ZWQ8U2NyZWVuUHJvcGVydGllc01hcD4gc2NyZWVuUHJvcGVydGllczsKICAgICByZXR1cm4gc2Ny ZWVuUHJvcGVydGllczsKIH0KIApAQCAtMTA4LDExICsxMDgsMTEgQEAgc3RhdGljIFBsYXRmb3Jt RGlzcGxheUlEJiBwcmltYXJ5U2NyZWVuRAogICAgIHJldHVybiBwcmltYXJ5U2NyZWVuRGlzcGxh eUlEOwogfQogCi1zdGQ6OnBhaXI8UGxhdGZvcm1EaXNwbGF5SUQsIEhhc2hNYXA8UGxhdGZvcm1E aXNwbGF5SUQsIFNjcmVlblByb3BlcnRpZXM+PiBnZXRTY3JlZW5Qcm9wZXJ0aWVzKCkKK3N0ZDo6 cGFpcjxQbGF0Zm9ybURpc3BsYXlJRCwgU2NyZWVuUHJvcGVydGllc01hcD4gZ2V0U2NyZWVuUHJv cGVydGllcygpCiB7CiAgICAgQVNTRVJUKGhhc1Byb2Nlc3NQcml2aWxlZ2UoUHJvY2Vzc1ByaXZp bGVnZTo6Q2FuQ29tbXVuaWNhdGVXaXRoV2luZG93U2VydmVyKSk7CiAKLSAgICBIYXNoTWFwPFBs YXRmb3JtRGlzcGxheUlELCBTY3JlZW5Qcm9wZXJ0aWVzPiBzY3JlZW5Qcm9wZXJ0aWVzOworICAg IFNjcmVlblByb3BlcnRpZXNNYXAgc2NyZWVuUHJvcGVydGllczsKICAgICBzdGQ6Om9wdGlvbmFs PFBsYXRmb3JtRGlzcGxheUlEPiBmaXJzdFNjcmVlbjsKIAogICAgIGZvciAoTlNTY3JlZW4gKnNj cmVlbiBpbiBbTlNTY3JlZW4gc2NyZWVuc10pIHsKQEAgLTEzOCw3ICsxMzgsNyBAQCBzdGQ6OnBh aXI8UGxhdGZvcm1EaXNwbGF5SUQsIEhhc2hNYXA8UGxhCiAgICAgcmV0dXJuIHsgV1RGTW92ZSgq Zmlyc3RTY3JlZW4pLCBXVEZNb3ZlKHNjcmVlblByb3BlcnRpZXMpIH07CiB9CiAKLXZvaWQgc2V0 U2NyZWVuUHJvcGVydGllcyhQbGF0Zm9ybURpc3BsYXlJRCBwcmltYXJ5U2NyZWVuSUQsIGNvbnN0 IEhhc2hNYXA8UGxhdGZvcm1EaXNwbGF5SUQsIFNjcmVlblByb3BlcnRpZXM+JiBwcm9wZXJ0aWVz KQordm9pZCBzZXRTY3JlZW5Qcm9wZXJ0aWVzKFBsYXRmb3JtRGlzcGxheUlEIHByaW1hcnlTY3Jl ZW5JRCwgY29uc3QgU2NyZWVuUHJvcGVydGllc01hcCYgcHJvcGVydGllcykKIHsKICAgICBwcmlt YXJ5U2NyZWVuRGlzcGxheUlEKCkgPSBwcmltYXJ5U2NyZWVuSUQ7CiAgICAgc2NyZWVuUHJvcGVy dGllcygpID0gcHJvcGVydGllczsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzIyNjIpCisrKyBT b3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisy MDE4LTA1LTI5ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAg ICBDcmVhdGUgdHlwZWRlZiBmb3IgSGFzaE1hcDxQbGF0Zm9ybURpc3BsYXlJRCwgU2NyZWVuUHJv cGVydGllcz4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NjA1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2hhcmVkL1dlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzOjpkZWNvZGUpOgorICAgICAgICAqIFNo YXJlZC9XZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmg6CisKIDIwMTgtMDUtMjkgIFBlciBB cm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZvbGxvdy11cCBmaXhl cyBhZnRlciByMjI4OTA3LgpJbmRleDogU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJvY2Vzc0Ny ZWF0aW9uUGFyYW1ldGVycy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9TaGFyZWQv V2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5jcHAJKHJldmlzaW9uIDIzMjI2MSkKKysrIFNv dXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC00MTAsNyArNDEwLDcgQEAgYm9vbCBXZWJQcm9jZXNzQ3JlYXRpb25QYXJh bWV0ZXJzOjpkZWNvZAogICAgIGlmICghZGVjb2Rlci5kZWNvZGUocGFyYW1ldGVycy5wcmltYXJ5 RGlzcGxheUlEKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgc3RkOjpvcHRpb25hbDxI YXNoTWFwPFdlYkNvcmU6OlBsYXRmb3JtRGlzcGxheUlELCBXZWJDb3JlOjpTY3JlZW5Qcm9wZXJ0 aWVzPj4gc2NyZWVuUHJvcGVydGllc01hcDsKKyAgICBzdGQ6Om9wdGlvbmFsPFdlYkNvcmU6OlNj cmVlblByb3BlcnRpZXNNYXA+IHNjcmVlblByb3BlcnRpZXNNYXA7CiAgICAgZGVjb2RlciA+PiBz Y3JlZW5Qcm9wZXJ0aWVzTWFwOwogICAgIGlmICghc2NyZWVuUHJvcGVydGllc01hcCkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwpJbmRleDogU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJvY2Vzc0Ny ZWF0aW9uUGFyYW1ldGVycy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvU2hhcmVkL1dl YlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaAkocmV2aXNpb24gMjMyMjYxKQorKysgU291cmNl L1dlYktpdC9TaGFyZWQvV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5oCSh3b3JraW5nIGNv cHkpCkBAIC0xOTYsNyArMTk2LDcgQEAgc3RydWN0IFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRl cnMgewogCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIFdlYkNvcmU6OlBsYXRmb3JtRGlzcGxheUlE IHByaW1hcnlEaXNwbGF5SUQgeyAwIH07Ci0gICAgSGFzaE1hcDxXZWJDb3JlOjpQbGF0Zm9ybURp c3BsYXlJRCwgV2ViQ29yZTo6U2NyZWVuUHJvcGVydGllcz4gc2NyZWVuUHJvcGVydGllc01hcDsK KyAgICBXZWJDb3JlOjpTY3JlZW5Qcm9wZXJ0aWVzTWFwIHNjcmVlblByb3BlcnRpZXNNYXA7CiAj ZW5kaWYKIH07CiAK