186054 2018-05-29 10:15:02 -0700 Avoid unnecessary String allocation in isPublicSuffix(const String&) 2018-05-29 11:33:25 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue ggaren sam webkit-bug-importer oldest_to_newest 1428100 0 cdumez 2018-05-29 10:15:02 -0700 Avoid unnecessary String allocation in isPublicSuffix(const String&): Sample Count, Samples %, CPU %, Symbol 1, 0.0%, 0.0%, WebCore::ResourceRequestBase::partitionName(WTF::String const&) (in WebCore) 1, 0.0%, 0.0%, WebCore::topPrivatelyControlledDomain(WTF::String const&) (in WebCore) 1, 0.0%, 0.0%, WebCore::isPublicSuffix(WTF::String const&) (in WebCore) 1, 0.0%, 0.0%, WTF::String::String(NSString*) (in JavaScriptCore) 1, 0.0%, 0.0%, DYLD-STUB$$objc_msgSend (in CoreFoundation) 1428104 1 341494 cdumez 2018-05-29 10:19:04 -0700 Created attachment 341494 Patch 1428123 2 341494 sam 2018-05-29 10:49:21 -0700 Comment on attachment 341494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341494&action=review > Source/WebCore/platform/mac/PublicSuffixMac.mm:39 > - NSString *host = decodeHostName(domain); > + NSString *host = decodeHostName(static_cast<NSString*>(domain)); I would add a comment explaining the cast. Also, the NSString* should be NSString * (space between NSString and *). And I think we traditionally use C-style casts for objective-c casts. 1428125 3 341499 cdumez 2018-05-29 10:52:37 -0700 Created attachment 341499 Patch 1428144 4 341499 commit-queue 2018-05-29 11:32:05 -0700 Comment on attachment 341499 Patch Clearing flags on attachment: 341499 Committed r232268: <https://trac.webkit.org/changeset/232268> 1428145 5 commit-queue 2018-05-29 11:32:07 -0700 All reviewed patches have been landed. Closing bug. 1428146 6 webkit-bug-importer 2018-05-29 11:33:25 -0700 <rdar://problem/40622283> 341494 2018-05-29 10:19:04 -0700 2018-05-29 10:52:36 -0700 Patch bug-186054-20180529101904.patch text/plain 1664 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGJmMjg4NjE1ZjQ3ZmYz NDgzYzVjMWZhYjQ3YzU2MGUwMGZhMTA4OS4uMDI5NGZiMTYyNjc0Y2ExNmIyMDkyNzEwZmY2MjQw MWE2YmRiMTQzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA1LTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgdW5uZWNlc3Nhcnkg U3RyaW5nIGFsbG9jYXRpb24gaW4gaXNQdWJsaWNTdWZmaXgoY29uc3QgU3RyaW5nJikKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjA1NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkIHVubmVjZXNz YXJ5IFN0cmluZyBhbGxvY2F0aW9uIGluIGlzUHVibGljU3VmZml4KGNvbnN0IFN0cmluZyYpIGJ5 IGNhbGxpbmcgZGlyZWN0bHkKKyAgICAgICAgdGhlIGRlY29kZUhvc3ROYW1lKCkgb3ZlcmxvYWQg dGFraW5nIGluIGEgTlNTdHJpbmcqLiBUaGlzIG92ZXJsb2FkIHJldHVybnMgYSBOU1N0cmluZyos CisgICAgICAgIHdoaWNoIGlzIHdoYXQgd2UgbmVlZC4gV2Ugd291bGQgcHJldmlvdXNseSBjYWxs IHRoZSBvdmVybG9hZGluZyB0YWtpbmcgaW4gYSBTdHJpbmcsIHdoaWNoCisgICAgICAgIHdvdWxk IHJldHVybiBhIFN0cmluZywgd2hpY2ggd2Ugd291bGQgaGF2ZSB0byBjb252ZXJ0IGJhY2sgdG8g YSBOU1N0cmluZyouCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvUHVibGljU3VmZml4TWFjLm1t OgorICAgICAgICAoV2ViQ29yZTo6aXNQdWJsaWNTdWZmaXgpOgorCiAyMDE4LTA1LTI5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ10gTWlzY2VsbGFuZW91 cyBmaXhlcyB0byBlbnN1cmUgbm8gYXNzZXJ0aW9uIGluIExheW91dENvbnRleHQ6OmxheW91dApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1B1YmxpY1N1ZmZpeE1hYy5t bSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QdWJsaWNTdWZmaXhNYWMubW0KaW5kZXgg NjczNmUyZDI5NWJiOTk4NjVlNzkwZTY3OGQ0YTZlNGRiZGNmMTM5OS4uZDU4OTFhZjI2N2Y3MDUy ODVlOWZmMGEzYWYxNDA0MzMwODJiN2U5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL1B1YmxpY1N1ZmZpeE1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tYWMvUHVibGljU3VmZml4TWFjLm1tCkBAIC0zNiw3ICszNiw3IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKIAogYm9vbCBpc1B1YmxpY1N1ZmZpeChjb25zdCBTdHJpbmcmIGRvbWFpbikKIHsKLSAg ICBOU1N0cmluZyAqaG9zdCA9IGRlY29kZUhvc3ROYW1lKGRvbWFpbik7CisgICAgTlNTdHJpbmcg Kmhvc3QgPSBkZWNvZGVIb3N0TmFtZShzdGF0aWNfY2FzdDxOU1N0cmluZyo+KGRvbWFpbikpOwog ICAgIHJldHVybiBob3N0ICYmIF9DRkhvc3RJc0RvbWFpblRvcExldmVsKChDRlN0cmluZ1JlZilo b3N0KTsKIH0KIAo= 341499 2018-05-29 10:52:37 -0700 2018-05-29 11:32:05 -0700 Patch bug-186054-20180529105236.patch text/plain 2002 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmMwZWE3NGVjYjdkYzg5 YzIxYTNjMzIwYjUxMTUwNGMxZTJmNDNkZi4uZTFiM2EwNDNlNWEwZGJmOTBhMThkMTc2ZDE2OWI4 NmQ1N2NhOWUxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA1LTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgdW5uZWNlc3Nhcnkg U3RyaW5nIGFsbG9jYXRpb24gaW4gaXNQdWJsaWNTdWZmaXgoY29uc3QgU3RyaW5nJikKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjA1NAorCisgICAg ICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCisKKyAgICAgICAgQXZvaWQgdW5uZWNlc3Nhcnkg U3RyaW5nIGFsbG9jYXRpb24gaW4gaXNQdWJsaWNTdWZmaXgoY29uc3QgU3RyaW5nJikgYnkgY2Fs bGluZyBkaXJlY3RseQorICAgICAgICB0aGUgZGVjb2RlSG9zdE5hbWUoKSBvdmVybG9hZCB0YWtp bmcgaW4gYSBOU1N0cmluZyouIFRoaXMgb3ZlcmxvYWQgcmV0dXJucyBhIE5TU3RyaW5nKiwKKyAg ICAgICAgd2hpY2ggaXMgd2hhdCB3ZSBuZWVkLiBXZSB3b3VsZCBwcmV2aW91c2x5IGNhbGwgdGhl IG92ZXJsb2FkaW5nIHRha2luZyBpbiBhIFN0cmluZywgd2hpY2gKKyAgICAgICAgd291bGQgcmV0 dXJuIGEgU3RyaW5nLCB3aGljaCB3ZSB3b3VsZCBoYXZlIHRvIGNvbnZlcnQgYmFjayB0byBhIE5T U3RyaW5nKi4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9QdWJsaWNTdWZmaXhNYWMubW06Cisg ICAgICAgIChXZWJDb3JlOjppc1B1YmxpY1N1ZmZpeCk6CisKIDIwMTgtMDUtMjkgIE5hbiBXYW5n ICA8bl93YW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogc2V0VmFsdWUgb24gY29udGVudGVk aXRhYmxlIHNob3VsZCBwcmVzZXJ2ZSB3aGl0ZXNwYWNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tYWMvUHVibGljU3VmZml4TWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL1B1YmxpY1N1ZmZpeE1hYy5tbQppbmRleCA2NzM2ZTJkMjk1YmI5OTg2NWU3OTBl Njc4ZDRhNmU0ZGJkY2YxMzk5Li5iMzg4OWZiNjU1NjA2NjUxYmRmZmMxOTE2MWU4ZWQzZWRiMDhh MjMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUHVibGljU3VmZml4 TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QdWJsaWNTdWZmaXhNYWMu bW0KQEAgLTM2LDcgKzM2LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBib29sIGlzUHVibGlj U3VmZml4KGNvbnN0IFN0cmluZyYgZG9tYWluKQogewotICAgIE5TU3RyaW5nICpob3N0ID0gZGVj b2RlSG9zdE5hbWUoZG9tYWluKTsKKyAgICAvLyBFeHBsaWNpdGx5IGNhc3QgdGhlIGRvbWFpbiB0 byBhIE5TU3RyaW5nIGJlZm9yZSBjYWxsaW5nIGRlY29kZUhvc3ROYW1lKCkgc28gd2UgZ2V0IGEg TlNTdHJpbmcgYmFjayBpbnN0ZWFkIG9mIGEgU3RyaW5nLgorICAgIE5TU3RyaW5nICpob3N0ID0g ZGVjb2RlSG9zdE5hbWUoKE5TU3RyaW5nICopZG9tYWluKTsKICAgICByZXR1cm4gaG9zdCAmJiBf Q0ZIb3N0SXNEb21haW5Ub3BMZXZlbCgoQ0ZTdHJpbmdSZWYpaG9zdCk7CiB9CiAKQEAgLTYyLDcg KzYzLDcgQEAgU3RyaW5nIHRvcFByaXZhdGVseUNvbnRyb2xsZWREb21haW4oY29uc3QgU3RyaW5n JiBkb21haW4pCiAKIFN0cmluZyBkZWNvZGVIb3N0TmFtZShjb25zdCBTdHJpbmcmIGRvbWFpbikK IHsKLSAgICByZXR1cm4gZGVjb2RlSG9zdE5hbWUoc3RhdGljX2Nhc3Q8TlNTdHJpbmcqPihkb21h aW4pKTsKKyAgICByZXR1cm4gZGVjb2RlSG9zdE5hbWUoKE5TU3RyaW5nICopKGRvbWFpbikpOwog fQogCiB9Cg==