186031 2018-05-28 02:27:52 -0700 [Web Animations] Test webanimations/css-animations.html is crashing 2018-05-28 03:16:52 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned commit-queue dino graouts jonlee webkit-bug-importer oldest_to_newest 1427901 0 cgarcia 2018-05-28 02:27:52 -0700 I don't know since when this is crashing because it's not happening in the bots. This is another case of std::optional value being used while it's nullopt. I guess different compiler have different behaviors for that, see also bug #185819 for another example. So, I guess this started to fail when we stopped using the WTF implementation of std::optional. This is very easy to reproduce with the 404 page of github, by moving the focus outside the web view. The problem is that we try to get the current iteration of a declarative animation when the active time is unresolved. Program terminated with signal SIGABRT, Aborted. #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 51 ../sysdeps/unix/sysv/linux/raise.c: No existe el fichero o el directorio. [Current thread is 1 (Thread 0x7f52348bd9c0 (LWP 16058))] (gdb) bt #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 #1 0x00007f52259d5231 in __GI_abort () at abort.c:79 #2 0x00007f52338d80cc in WebCore::DeclarativeAnimation::invalidateDOMEvents(WTF::Seconds) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007f52338da5e4 in WebCore::DeclarativeAnimation::cancel() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #4 0x00007f52338da618 in WebCore::AnimationTimeline::cancelOrRemoveDeclarativeAnimation(WTF::RefPtr<WebCore::DeclarativeAnimation, WTF::DumbPtrTraits<WebCore::DeclarativeAnimation> >) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #5 0x00007f52338dba3d in WebCore::AnimationTimeline::updateCSSAnimationsForElement(WebCore::Element&, WebCore::RenderStyle const&, WebCore::RenderStyle const*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #6 0x00007f52335e1e19 in WebCore::Style::TreeResolver::createAnimatedElementUpdate(std::unique_ptr<WebCore::RenderStyle, std::default_delete<WebCore::RenderStyle> >, WebCore::Element&, WebCore::Style::Change) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #7 0x00007f52335e5f0b in WebCore::Style::TreeResolver::resolveElement(WebCore::Element&) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #8 0x00007f52335e858e in WebCore::Style::TreeResolver::resolveComposedTree() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #9 0x00007f52335e920e in WebCore::Style::TreeResolver::resolve() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #10 0x00007f5232ca453e in WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #11 0x00007f5232ca4ba2 in WebCore::Document::updateStyleIfNeeded() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #12 0x00007f5232cd7acb in WebCore::Element::getAnimations() () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #13 0x00007f5232562da9 in WebCore::jsElementPrototypeFunctionGetAnimations(JSC::ExecState*) () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #14 0x00007f51dcc33177 in ?? () #15 0x00007ffd452ae210 in ?? () #16 0x00007f522fb326c5 in llint_entry () from /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 Backtrace stopped: frame did not save the PC 1427902 1 341450 cgarcia 2018-05-28 02:31:10 -0700 Created attachment 341450 Patch 1427903 2 341450 commit-queue 2018-05-28 03:15:51 -0700 Comment on attachment 341450 Patch Clearing flags on attachment: 341450 Committed r232241: <https://trac.webkit.org/changeset/232241> 1427904 3 commit-queue 2018-05-28 03:15:52 -0700 All reviewed patches have been landed. Closing bug. 1427905 4 webkit-bug-importer 2018-05-28 03:16:52 -0700 <rdar://problem/40595767> 341450 2018-05-28 02:31:10 -0700 2018-05-28 03:15:51 -0700 Patch wcore-anim-crash.diff text/plain 1870 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNGE1OTNkMmQ0NS4uODIyZDhlYTMxYTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0wNS0yOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25zXSBUZXN0IHdlYmFuaW1hdGlvbnMv Y3NzLWFuaW1hdGlvbnMuaHRtbCBpcyBjcmFzaGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg2MDMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBhbm90aGVyIGNhc2Ugb2Ygc3RkOjpvcHRp b25hbCB2YWx1ZSBiZWluZyB1c2VkIHdoaWxlIGl0J3MgbnVsbG9wdCwgSSBndWVzcyB0aGlzIHN0 YXJ0ZWQgdG8gZmFpbCB3aGVuIHdlCisgICAgICAgIHN0b3BwZWQgdXNpbmcgdGhlIFdURiBpbXBs ZW1lbnRhdGlvbiBvZiBzdGQ6Om9wdGlvbmFsLiBUaGUgcHJvYmxlbSBpcyB0aGF0IHdlIHRyeSB0 byBnZXQgdGhlIGN1cnJlbnQgaXRlcmF0aW9uCisgICAgICAgIG9mIGEgZGVjbGFyYXRpdmUgYW5p bWF0aW9uIHdoZW4gdGhlIGFjdGl2ZSB0aW1lIGlzIHVucmVzb2x2ZWQuCisKKyAgICAgICAgKiBh bmltYXRpb24vRGVjbGFyYXRpdmVBbmltYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGVj bGFyYXRpdmVBbmltYXRpb246OmludmFsaWRhdGVET01FdmVudHMpOiBVc2UgdmFsdWVfb3IoMCkg aW5zdGVhZCBvZiB2YWx1ZSgpIHRvIGdldCB0aGUgY3VycmVudAorICAgICAgICBpdGVyYXRpb24g b2YgdGhlIGVmZmVjdC4KKwogMjAxOC0wNS0yOCAgVGhpYmF1bHQgU2F1bmllciAgPHRzYXVuaWVy QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gSGFuZGxlIGNoYW5nZXMgaW4gdGhl ICJkcm0tcHJlZmVycmVkLWRlY3J5cHRpb24tc3lzdGVtLWlkIiBORUVEX0NPTlRFWFQgbWVzc2Fn ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9EZWNsYXJhdGl2ZUFuaW1h dGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vRGVjbGFyYXRpdmVBbmltYXRpb24u Y3BwCmluZGV4IGY5ZTNhOWRjMWYwLi42NDA0YWEzNDNlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYW5pbWF0aW9uL0RlY2xhcmF0aXZlQW5pbWF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9hbmltYXRpb24vRGVjbGFyYXRpdmVBbmltYXRpb24uY3BwCkBAIC0xMjMsNyArMTIzLDcg QEAgdm9pZCBEZWNsYXJhdGl2ZUFuaW1hdGlvbjo6aW52YWxpZGF0ZURPTUV2ZW50cyhTZWNvbmRz IGVsYXBzZWRUaW1lKQogICAgIGF1dG8qIGFuaW1hdGlvbkVmZmVjdCA9IGVmZmVjdCgpOwogCiAg ICAgYXV0byBpc1BlbmRpbmcgPSBwZW5kaW5nKCk7Ci0gICAgYXV0byBpdGVyYXRpb24gPSBhbmlt YXRpb25FZmZlY3QgPyBhbmltYXRpb25FZmZlY3QtPmN1cnJlbnRJdGVyYXRpb24oKS52YWx1ZSgp IDogMDsKKyAgICBhdXRvIGl0ZXJhdGlvbiA9IGFuaW1hdGlvbkVmZmVjdCA/IGFuaW1hdGlvbkVm ZmVjdC0+Y3VycmVudEl0ZXJhdGlvbigpLnZhbHVlX29yKDApIDogMDsKICAgICBhdXRvIGN1cnJl bnRQaGFzZSA9IGFuaW1hdGlvbkVmZmVjdCA/IGFuaW1hdGlvbkVmZmVjdC0+cGhhc2UoKSA6IHBo YXNlV2l0aG91dEVmZmVjdCgpOwogCiAgICAgYm9vbCB3YXNBY3RpdmUgPSBtX3ByZXZpb3VzUGhh c2UgPT0gQW5pbWF0aW9uRWZmZWN0UmVhZE9ubHk6OlBoYXNlOjpBY3RpdmU7Cg==