186017 2018-05-27 06:57:24 -0700 [WTF] RandomDevice should be initialized inside std::call_once 2018-07-01 21:25:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 186014 1 ysuzuki ysuzuki benjamin cdumez cmarcelo darin dbates don.olmstead ews-watchlist fpizlo webkit-bug-importer oldest_to_newest 1427809 0 ysuzuki 2018-05-27 06:57:24 -0700 [WTF] RandomDevice should be initialized inside std::call_once 1427810 1 341420 ysuzuki 2018-05-27 06:58:19 -0700 Created attachment 341420 Patch 1428936 2 341420 ap 2018-05-31 11:46:39 -0700 Comment on attachment 341420 Patch Marking r- to get out of review queue, as EWS is all red. 1436797 3 343674 ysuzuki 2018-06-26 19:04:46 -0700 Created attachment 343674 Patch 1437480 4 343674 don.olmstead 2018-06-28 12:33:03 -0700 Comment on attachment 343674 Patch Informal review is that LGTM. Guessing this is something you're going to be doing across the codebase? 1437556 5 darin 2018-06-28 14:40:28 -0700 (In reply to Don Olmstead from comment #4) > Guessing this is something you're going to be doing across the codebase? I think only in code that is supposed to be safe for use from multiple threads, which is a small faction of all WebKit code. 1437557 6 343674 darin 2018-06-28 14:41:33 -0700 Comment on attachment 343674 Patch Since I expect this to come up repeatedly I wonder if there is a cleaner idiom for this. If some way we find we can afford to pay the locking cost on Apple’s platforms it would be nice to be able to quickly remove all of this code. 1437567 7 darin 2018-06-28 14:53:46 -0700 Maybe the elegant way to do it is to define a different NeverDestroyed variant that automatically includes the once_flag and the laziness and does this all. Then that can be used only on platforms where we turn off the compiler’s built-in locking. On other platforms it can possibly even be a typedef for the plain old NeverDestroyed. 1438382 8 ysuzuki 2018-07-01 21:17:07 -0700 (In reply to Darin Adler from comment #7) > Maybe the elegant way to do it is to define a different NeverDestroyed > variant that automatically includes the once_flag and the laziness and does > this all. Then that can be used only on platforms where we turn off the > compiler’s built-in locking. On other platforms it can possibly even be a > typedef for the plain old NeverDestroyed. Yeah, that sounds fancy. 1438383 9 ysuzuki 2018-07-01 21:24:38 -0700 Committed r233415: <https://trac.webkit.org/changeset/233415> 1438384 10 webkit-bug-importer 2018-07-01 21:25:18 -0700 <rdar://problem/41709074> 341420 2018-05-27 06:58:19 -0700 2018-06-26 19:04:44 -0700 Patch bug-186017-20180527225818.patch text/plain 1611 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDIyOWYzMDMxNmM1ODE3YjE4MTVhODU3 OTlhNzdhOGE2NGMwZDk5YjguLmFmYjU0OTczNmU1MjBhMTY3Y2FjODRiNThmM2I4NDAzNmViZGRk MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDUtMjcgIFl1c3VrZSBTdXp1a2kgIDx1dGF0 YW5lLnRlYUBnbWFpbC5jb20+CisKKyAgICAgICAgW1dURl0gUmFuZG9tRGV2aWNlIHNob3VsZCBi ZSBpbml0aWFsaXplZCBpbnNpZGUgc3RkOjpjYWxsX29uY2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjAxNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIExpbnV4IHBvcnRzIHVzZXMgbXV0ZXgt Z3VhcmRlZCBzdGF0aWMgdmFyaWFibGVzLCBNYWMgcG9ydHMgZG8gbm90LgorICAgICAgICBTbyB3 ZSBzaG91bGQgZ3VhcmQgc3RhdGljIHZhcmlhYmxlcycgaW5pdGlhbGl6YXRpb24gYnkgdXNpbmcg c3RkOjpjYWxsX29uY2UuCisgICAgICAgIFRoaXMgcGF0Y2ggZG9lcyBpdCBmb3IgUmFuZG9tRGV2 aWNlLgorCisgICAgICAgICogd3RmL09TUmFuZG9tU291cmNlLmNwcDoKKyAgICAgICAgKFdURjo6 Y3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21WYWx1ZXNGcm9tT1MpOgorCiAyMDE4LTA1LTI2ICBGaWxp cCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgdGVzdGFpciBzb21ldGltZXMg Y3Jhc2hlcyBkdWUgdG8gcmFjZXMgaW4gaW5pdGlhbGl6YXRpb24gb2YgQVJDNFJhbmRvbU51bWJl ckdlbmVyYXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvT1NSYW5kb21Tb3VyY2UuY3Bw IGIvU291cmNlL1dURi93dGYvT1NSYW5kb21Tb3VyY2UuY3BwCmluZGV4IGMzZDA4OTU3ODYxZTQ2 OWMwZjVjOGFiYjVhY2I3YWJmMTIwNGU5NDkuLjgxMzM5NDNiZWMzOWQzYjc3NzM4NWViY2U2NTVh YWE1MzcyYzhlNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL09TUmFuZG9tU291cmNlLmNw cAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9PU1JhbmRvbVNvdXJjZS5jcHAKQEAgLTMzLDcgKzMzLDEz IEBAIG5hbWVzcGFjZSBXVEYgewogCiB2b2lkIGNyeXB0b2dyYXBoaWNhbGx5UmFuZG9tVmFsdWVz RnJvbU9TKHVuc2lnbmVkIGNoYXIqIGJ1ZmZlciwgc2l6ZV90IGxlbmd0aCkKIHsKLSAgICBzdGF0 aWMgTmV2ZXJEZXN0cm95ZWQ8UmFuZG9tRGV2aWNlPiBkZXZpY2U7CisgICAgc3RhdGljIExhenlO ZXZlckRlc3Ryb3llZDxSYW5kb21EZXZpY2U+IGRldmljZTsKKyAgICBzdGF0aWMgc3RkOjpvbmNl X2ZsYWcgb25jZUZsYWc7CisgICAgc3RkOjpjYWxsX29uY2UoCisgICAgICAgIG9uY2VGbGFnLAor ICAgICAgICBbXSB7CisgICAgICAgICAgICBkZXZpY2UuY29uc3RydWN0KCk7CisgICAgICAgIH0p OwogICAgIGRldmljZS5nZXQoKS5jcnlwdG9ncmFwaGljYWxseVJhbmRvbVZhbHVlcyhidWZmZXIs IGxlbmd0aCk7CiB9CiAK 343674 2018-06-26 19:04:46 -0700 2018-06-28 14:41:33 -0700 Patch bug-186017-20180627110446.patch text/plain 1719 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI0YTc0MmM2NDQ0NWU5NjE5ODQ0ZjZk OTU5NTUwNDk1MzRhMjk3M2QuLjBmZDc4ZjczYTYwZDNiMTUwY2YwY2Y2ODYxMTA4NzEzZGMyZWU4 ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDYtMjYgIFl1c3VrZSBTdXp1a2kgIDx1dGF0 YW5lLnRlYUBnbWFpbC5jb20+CisKKyAgICAgICAgW1dURl0gUmFuZG9tRGV2aWNlIHNob3VsZCBi ZSBpbml0aWFsaXplZCBpbnNpZGUgc3RkOjpjYWxsX29uY2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NjAxNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIExpbnV4IHBvcnRzIHVzZXMgbXV0ZXgt Z3VhcmRlZCBzdGF0aWMgdmFyaWFibGVzLCBNYWMgcG9ydHMgZG8gbm90LgorICAgICAgICBTbyB3 ZSBzaG91bGQgZ3VhcmQgc3RhdGljIHZhcmlhYmxlcycgaW5pdGlhbGl6YXRpb24gYnkgdXNpbmcg c3RkOjpjYWxsX29uY2UuCisgICAgICAgIFRoaXMgcGF0Y2ggZG9lcyBpdCBmb3IgUmFuZG9tRGV2 aWNlLgorCisgICAgICAgICogd3RmL09TUmFuZG9tU291cmNlLmNwcDoKKyAgICAgICAgKFdURjo6 Y3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21WYWx1ZXNGcm9tT1MpOgorCiAyMDE4LTA2LTI1ICBEYXZp ZCBGZW50b24gIDxkYXZpZF9mZW50b25AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHIyMzMxMjAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9PU1JhbmRv bVNvdXJjZS5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9PU1JhbmRvbVNvdXJjZS5jcHAKaW5kZXggYzNk MDg5NTc4NjFlNDY5YzBmNWM4YWJiNWFjYjdhYmYxMjA0ZTk0OS4uMDE2Y2MxYmUzOGE1YzdkYzg4 NzdmMTk5NTYxMGZhZDIwZDZhYzc3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvT1NSYW5k b21Tb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL09TUmFuZG9tU291cmNlLmNwcApAQCAt MjYsNiArMjYsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIk9TUmFuZG9tU291 cmNlLmgiCiAKKyNpbmNsdWRlIDxtdXRleD4KICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQu aD4KICNpbmNsdWRlIDx3dGYvUmFuZG9tRGV2aWNlLmg+CiAKQEAgLTMzLDcgKzM0LDEzIEBAIG5h bWVzcGFjZSBXVEYgewogCiB2b2lkIGNyeXB0b2dyYXBoaWNhbGx5UmFuZG9tVmFsdWVzRnJvbU9T KHVuc2lnbmVkIGNoYXIqIGJ1ZmZlciwgc2l6ZV90IGxlbmd0aCkKIHsKLSAgICBzdGF0aWMgTmV2 ZXJEZXN0cm95ZWQ8UmFuZG9tRGV2aWNlPiBkZXZpY2U7CisgICAgc3RhdGljIExhenlOZXZlckRl c3Ryb3llZDxSYW5kb21EZXZpY2U+IGRldmljZTsKKyAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcg b25jZUZsYWc7CisgICAgc3RkOjpjYWxsX29uY2UoCisgICAgICAgIG9uY2VGbGFnLAorICAgICAg ICBbXSB7CisgICAgICAgICAgICBkZXZpY2UuY29uc3RydWN0KCk7CisgICAgICAgIH0pOwogICAg IGRldmljZS5nZXQoKS5jcnlwdG9ncmFwaGljYWxseVJhbmRvbVZhbHVlcyhidWZmZXIsIGxlbmd0 aCk7CiB9CiAK