186011 2018-05-26 00:17:22 -0700 iOS WK1: Occasional crash in sanitizedMarkupForFragmentInDocument 2018-05-29 13:30:25 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ap cdumez commit-queue ddkilzer koivisto wenson_hsieh oldest_to_newest 1427703 0 rniwa 2018-05-26 00:17:22 -0700 We're seeing an occasional crash inside appendChild in sanitizedMarkupForFragmentInDocument. 1427704 1 341392 rniwa 2018-05-26 01:55:39 -0700 Created attachment 341392 Fixes the bug 1427705 2 rniwa 2018-05-26 01:57:29 -0700 <rdar://problem/36256359> 1427747 3 ap 2018-05-26 12:12:09 -0700 Interesting! When what the yielding added? It would seem that it may be required for responsiveness. Perhaps we don’t care about WK1 responsiveness any more though. 1428174 4 rniwa 2018-05-29 12:53:14 -0700 (In reply to Alexey Proskuryakov from comment #3) > Interesting! > > When what the yielding added? It would seem that it may be required for > responsiveness. Perhaps we don’t care about WK1 responsiveness any more > though. Well, we're creating an empty document here, and we're in the middle of trying to paste a content, which is a sync API so we can't really yield. 1428176 5 341392 ddkilzer 2018-05-29 12:54:58 -0700 Comment on attachment 341392 Fixes the bug r=me 1428184 6 341392 commit-queue 2018-05-29 13:30:23 -0700 Comment on attachment 341392 Fixes the bug Clearing flags on attachment: 341392 Committed r232272: <https://trac.webkit.org/changeset/232272> 1428185 7 commit-queue 2018-05-29 13:30:25 -0700 All reviewed patches have been landed. Closing bug. 341392 2018-05-26 01:55:39 -0700 2018-05-29 13:30:23 -0700 Fixes the bug bug-186011-20180526015539.patch text/plain 5535 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFhMjRlZjg3Y2VmM2Iz ZGI4ZDRhNWQ5MDM1MmNiNDYxNzQyYmEzNC4uMTE2M2FhMDlhNTU2Y2ZmYWE4MTIzODMzOTI3MDJl Mzk4ZDIzZmRmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE4LTA1LTI2ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGlPUyBXSzE6IE9jY2FzaW9u YWwgY3Jhc2ggaW4gc2FuaXRpemVkTWFya3VwRm9yRnJhZ21lbnRJbkRvY3VtZW50CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODYwMTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY3Jhc2ggd2FzIGNh dXNlZCBieSB0aGUgSFRNTCBwYXJzZXIgaW4gc2FuaXRpemVkTWFya3VwRm9yRnJhZ21lbnRJbkRv Y3VtZW50IHlpZWxkaW5nIGluIHRoZSB3ZWIgdGhyZWFkCisgICAgICAgIHdoZW4gX1dlYlRocmVh ZExvY2soKSBzZXRzIHdlYlRocmVhZFNob3VsZFlpZWxkIHRvIHRydWUgaW4gdGhlIG1haW4gdGhy ZWFkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBpcyBvY2Nhc2lvbmFsbHkgY2F1Z2h0 IGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogZWRpdGluZy9tYXJrdXAuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Y3JlYXRlUGFnZUZvclNhbml0aXppbmdXZWJDb250ZW50KTogRml4ZWQg dGhlIGJ1ZyBieSBtYWtpbmcgdGhlIEhUTUwgcGFyc2VyIG5ldmVyIHlpZWxkLgorICAgICAgICBB bHNvIHJlbGVhc2UtYXNzZXJ0IHRoYXQgdGhlIGJvZHkgaXMgbmV2ZXIgbnVsbCBoZXJlLgorICAg ICAgICAoV2ViQ29yZTo6c2FuaXRpemVkTWFya3VwRm9yRnJhZ21lbnRJbkRvY3VtZW50KTogUmVt b3ZlZCBzdXBlcmZsb3VzIGNhbGwgdG8gV1RGTW92ZSBzaW5jZSBhcHBlbmRDaGlsZAorICAgICAg ICB0YWtlcyBhIHJlZmVyZW5jZSwgbm90IGEgUmVmLgorICAgICAgICAqIGluc3BlY3Rvci9JbnNw ZWN0b3JPdmVybGF5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rvck92ZXJsYXk6Om92 ZXJsYXlQYWdlKTogRGVwbG95ZWQgdGhlIHNhbWUgZml4LgorICAgICAgICAqIGxvYWRlci9Eb2N1 bWVudFdyaXRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudFdyaXRlcjo6aW5zZXJ0 RGF0YVN5bmNocm9ub3VzbHkpOiBBZGRlZC4KKyAgICAgICAgKiBsb2FkZXIvRG9jdW1lbnRXcml0 ZXIuaDoKKwogMjAxOC0wNS0yMiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUu Y29tPgogCiAgICAgICAgIFRleHQgY2FuIHdyYXAgYmV0d2VlbiBoeXBoZW5zIGFuZCBjb21tYXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvbWFya3VwLmNwcAppbmRleCA1NTUxZWVjZjkyMjNkMzY5YTBhZjc0ZDI0 OTQ3NDM3ZTBiZWJiZjczLi4zMTVmYjE1ZTQzMjlhNTM0NDFhZTNkYTRhNDAwNGNjZjNkNzhlYWQy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJrdXAuY3BwCkBAIC0xODksMTAgKzE4OSwxMiBAQCBzdGQ6 OnVuaXF1ZV9wdHI8UGFnZT4gY3JlYXRlUGFnZUZvclNhbml0aXppbmdXZWJDb250ZW50KCkKICAg ICBGcmFtZUxvYWRlciYgbG9hZGVyID0gZnJhbWUubG9hZGVyKCk7CiAgICAgc3RhdGljIGNoYXIg bWFya3VwW10gPSAiPCFET0NUWVBFIGh0bWw+PGh0bWw+PGJvZHk+PC9ib2R5PjwvaHRtbD4iOwog ICAgIEFTU0VSVChsb2FkZXIuYWN0aXZlRG9jdW1lbnRMb2FkZXIoKSk7Ci0gICAgbG9hZGVyLmFj dGl2ZURvY3VtZW50TG9hZGVyKCktPndyaXRlcigpLnNldE1JTUVUeXBlKCJ0ZXh0L2h0bWwiKTsK LSAgICBsb2FkZXIuYWN0aXZlRG9jdW1lbnRMb2FkZXIoKS0+d3JpdGVyKCkuYmVnaW4oKTsKLSAg ICBsb2FkZXIuYWN0aXZlRG9jdW1lbnRMb2FkZXIoKS0+d3JpdGVyKCkuYWRkRGF0YShtYXJrdXAs IHNpemVvZihtYXJrdXApKTsKLSAgICBsb2FkZXIuYWN0aXZlRG9jdW1lbnRMb2FkZXIoKS0+d3Jp dGVyKCkuZW5kKCk7CisgICAgYXV0byYgd3JpdGVyID0gbG9hZGVyLmFjdGl2ZURvY3VtZW50TG9h ZGVyKCktPndyaXRlcigpOworICAgIHdyaXRlci5zZXRNSU1FVHlwZSgidGV4dC9odG1sIik7Cisg ICAgd3JpdGVyLmJlZ2luKCk7CisgICAgd3JpdGVyLmluc2VydERhdGFTeW5jaHJvbm91c2x5KFN0 cmluZyhtYXJrdXApKTsKKyAgICB3cml0ZXIuZW5kKCk7CisgICAgUkVMRUFTRV9BU1NFUlQocGFn ZS0+bWFpbkZyYW1lKCkuZG9jdW1lbnQoKS0+Ym9keSgpKTsKIAogICAgIHJldHVybiBwYWdlOwog fQpAQCAtODU5LDcgKzg2MSw3IEBAIFN0cmluZyBzYW5pdGl6ZWRNYXJrdXBGb3JGcmFnbWVudElu RG9jdW1lbnQoUmVmPERvY3VtZW50RnJhZ21lbnQ+JiYgZnJhZ21lbnQsIERvCiAKICAgICBhdXRv IGJvZHlFbGVtZW50ID0gbWFrZVJlZlB0cihkb2N1bWVudC5ib2R5KCkpOwogICAgIEFTU0VSVChi b2R5RWxlbWVudCk7Ci0gICAgYm9keUVsZW1lbnQtPmFwcGVuZENoaWxkKFdURk1vdmUoZnJhZ21l bnQpKTsKKyAgICBib2R5RWxlbWVudC0+YXBwZW5kQ2hpbGQoZnJhZ21lbnQuZ2V0KCkpOwogCiAg ICAgYXV0byByYW5nZSA9IFJhbmdlOjpjcmVhdGUoZG9jdW1lbnQpOwogICAgIHJhbmdlLT5zZWxl Y3ROb2RlQ29udGVudHMoKmJvZHlFbGVtZW50KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JPdmVybGF5LmNwcAppbmRleCBlNWM4OTAyMTRjOWM0OTAzNWQwMTMzMTQ2M2I2 ZGYxZDAwM2ViYTkxLi42ZTcwYTEwOThkY2IwYzJhOWVjZjMwYTdiZTlmNjIxOWQ0MjgyNmM3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwCkBAIC03 MjksMTAgKzcyOSwxMSBAQCBQYWdlKiBJbnNwZWN0b3JPdmVybGF5OjpvdmVybGF5UGFnZSgpCiAg ICAgZnJhbWUudmlldygpLT5zZXRDYW5IYXZlU2Nyb2xsYmFycyhmYWxzZSk7CiAgICAgZnJhbWUu dmlldygpLT5zZXRUcmFuc3BhcmVudCh0cnVlKTsKICAgICBBU1NFUlQobG9hZGVyLmFjdGl2ZURv Y3VtZW50TG9hZGVyKCkpOwotICAgIGxvYWRlci5hY3RpdmVEb2N1bWVudExvYWRlcigpLT53cml0 ZXIoKS5zZXRNSU1FVHlwZSgidGV4dC9odG1sIik7Ci0gICAgbG9hZGVyLmFjdGl2ZURvY3VtZW50 TG9hZGVyKCktPndyaXRlcigpLmJlZ2luKCk7Ci0gICAgbG9hZGVyLmFjdGl2ZURvY3VtZW50TG9h ZGVyKCktPndyaXRlcigpLmFkZERhdGEocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4oSW5z cGVjdG9yT3ZlcmxheVBhZ2VfaHRtbCksIHNpemVvZihJbnNwZWN0b3JPdmVybGF5UGFnZV9odG1s KSk7Ci0gICAgbG9hZGVyLmFjdGl2ZURvY3VtZW50TG9hZGVyKCktPndyaXRlcigpLmVuZCgpOwor ICAgIGF1dG8mIHdyaXRlciA9IGxvYWRlci5hY3RpdmVEb2N1bWVudExvYWRlcigpLT53cml0ZXIo KTsKKyAgICB3cml0ZXIuc2V0TUlNRVR5cGUoInRleHQvaHRtbCIpOworICAgIHdyaXRlci5iZWdp bigpOworICAgIHdyaXRlci5pbnNlcnREYXRhU3luY2hyb25vdXNseShTdHJpbmcocmVpbnRlcnBy ZXRfY2FzdDxjb25zdCBjaGFyKj4oSW5zcGVjdG9yT3ZlcmxheVBhZ2VfaHRtbCksIHNpemVvZihJ bnNwZWN0b3JPdmVybGF5UGFnZV9odG1sKSkpOworICAgIHdyaXRlci5lbmQoKTsKIAogI2lmIE9T KFdJTkRPV1MpCiAgICAgZXZhbHVhdGVJbk92ZXJsYXkoInNldFBsYXRmb3JtIiwgIndpbmRvd3Mi KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudFdyaXRlci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRXcml0ZXIuY3BwCmluZGV4IGQ5NDM3YTAx Njk5YTFhNmJhMGFlZDgwY2MwYTJlNmRkOGRlMTNmMTcuLjI1NDUxZWMwMGQ5OGMyMjI1ODFmZTg1 Yjg5YmY5MmI1N2M2MjUxOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1 bWVudFdyaXRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50V3JpdGVy LmNwcApAQCAtMjUzLDYgKzI1MywxNCBAQCB2b2lkIERvY3VtZW50V3JpdGVyOjphZGREYXRhKGNv bnN0IGNoYXIqIGJ5dGVzLCBzaXplX3QgbGVuZ3RoKQogICAgIG1fcGFyc2VyLT5hcHBlbmRCeXRl cygqdGhpcywgYnl0ZXMsIGxlbmd0aCk7CiB9CiAKK3ZvaWQgRG9jdW1lbnRXcml0ZXI6Omluc2Vy dERhdGFTeW5jaHJvbm91c2x5KGNvbnN0IFN0cmluZyYgbWFya3VwKQoreworICAgIEFTU0VSVCht X3N0YXRlICE9IE5vdFN0YXJ0ZWRXcml0aW5nU3RhdGUpOworICAgIEFTU0VSVChtX3N0YXRlICE9 IEZpbmlzaGVkV3JpdGluZ1N0YXRlKTsKKyAgICBBU1NFUlQobV9wYXJzZXIpOworICAgIG1fcGFy c2VyLT5pbnNlcnQobWFya3VwKTsKK30KKwogdm9pZCBEb2N1bWVudFdyaXRlcjo6ZW5kKCkKIHsK ICAgICBBU1NFUlQobV9mcmFtZS0+cGFnZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9Eb2N1bWVudFdyaXRlci5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50 V3JpdGVyLmgKaW5kZXggOWYwMzY5MWEzOGQ3N2E1MGJjMGU0MjllMTU5ZmMwYWYzOGY1MmVlMC4u Mzg1ZmI2NDA3YmE0MTliYmI4NjY3Y2JjNTA5OTdjMWIwZDRiZjIxNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50V3JpdGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL0RvY3VtZW50V3JpdGVyLmgKQEAgLTUxLDggKzUxLDkgQEAgcHVibGljOgogICAgIGJv b2wgYmVnaW4oKTsKICAgICBib29sIGJlZ2luKGNvbnN0IFVSTCYsIGJvb2wgZGlzcGF0Y2hXaW5k b3dPYmplY3RBdmFpbGFibGUgPSB0cnVlLCBEb2N1bWVudCogb3duZXJEb2N1bWVudCA9IG51bGxw dHIpOwogICAgIHZvaWQgYWRkRGF0YShjb25zdCBjaGFyKiBieXRlcywgc2l6ZV90IGxlbmd0aCk7 CisgICAgdm9pZCBpbnNlcnREYXRhU3luY2hyb25vdXNseShjb25zdCBTdHJpbmcmKTsgLy8gRm9y IGFuIGludGVybmFsIHVzZSBvbmx5IHRvIHByZXZlbnQgdGhlIHBhcnNlciBmcm9tIHlpZWxkaW5n LgogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgZW5kKCk7Ci0gICAgCisKICAgICB2b2lkIHNldEZy YW1lKEZyYW1lKiBmcmFtZSkgeyBtX2ZyYW1lID0gZnJhbWU7IH0KIAogICAgIFdFQkNPUkVfRVhQ T1JUIHZvaWQgc2V0RW5jb2RpbmcoY29uc3QgU3RyaW5nJiBlbmNvZGluZywgYm9vbCB1c2VyQ2hv c2VuKTsK