186006 2018-05-25 17:18:19 -0700 [ESNext][BigInt] Skip BigInt div tests breaking on iOS build 2018-05-27 11:09:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=186022 P2 Normal --- 1 ticaiolima ticaiolima fpizlo jfbastien keith_miller mark.lam msaboff rmorisset saam ysuzuki oldest_to_newest 1427605 0 ticaiolima 2018-05-25 17:18:19 -0700 Some tests are breaking on IOS build and we should skip such tests. 1427628 1 341373 ticaiolima 2018-05-25 18:33:18 -0700 Created attachment 341373 Patch 1427726 2 341373 ysuzuki 2018-05-26 09:14:40 -0700 Comment on attachment 341373 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341373&action=review > JSTests/ChangeLog:10 > + > + Skippping big-int-div tests on iOS build because they are broken in > + this architecture. > + I think we should fix this issue rather than disabling this only for iOS platforms. 1427735 3 341373 ticaiolima 2018-05-26 09:29:44 -0700 Comment on attachment 341373 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341373&action=review >> JSTests/ChangeLog:10 >> + > > I think we should fix this issue rather than disabling this only for iOS platforms. I agree. The problem is that it seems to be a internal build and I don't have access to the error trace. I can't find these tests failing into build.webkit.org. Could anyone help me get the error trace, if possible? 1427740 4 341373 ysuzuki 2018-05-26 10:25:15 -0700 Comment on attachment 341373 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341373&action=review >>> JSTests/ChangeLog:10 >>> + >> >> I think we should fix this issue rather than disabling this only for iOS platforms. > > I agree. The problem is that it seems to be a internal build and I don't have access to the error trace. I can't find these tests failing into build.webkit.org. Could anyone help me get the error trace, if possible? It seems that digitDiv's generic path is broken. I commented out X86 / X86_64 asm part, and even x86_64 Linux shows failures. 1427749 5 ticaiolima 2018-05-26 12:32:04 -0700 (In reply to Yusuke Suzuki from comment #4) > Comment on attachment 341373 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341373&action=review > > >>> JSTests/ChangeLog:10 > >>> + > >> > >> I think we should fix this issue rather than disabling this only for iOS platforms. > > > > I agree. The problem is that it seems to be a internal build and I don't have access to the error trace. I can't find these tests failing into build.webkit.org. Could anyone help me get the error trace, if possible? > > It seems that digitDiv's generic path is broken. I commented out X86 / > X86_64 asm part, and even x86_64 Linux shows failures. Thx! This way, I think we should Rollback https://trac.webkit.org/changeset/231886. The problem is that I'm unable to do that until tomorrow night. I will do that ASAP. 1427784 6 ap 2018-05-26 18:48:51 -0700 cf. rdar://problem/40331121 341373 2018-05-25 18:33:18 -0700 2018-05-26 09:14:40 -0700 Patch bug-186006-20180525223317.patch text/plain 3989 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMTg0CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDY0NTc5MzQ3OGEyNzExYWRkZGI3OTE0ZjVhNGEz N2I2MzRjNGVjMGYuLjcwNTkwMTA2MjNkOTY4MDk0NWQyMDUyZmJkYzIwNTk4ZWNkZGQ0NDcgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjAgQEAKKzIwMTgtMDUtMjUgIENhaW8gTGltYSAgPHRpY2Fpb2xpbWFAZ21haWwuY29t PgorCisgICAgICAgIFtFU05leHRdW0JpZ0ludF0gU2tpcCBCaWdJbnQgZGl2IHRlc3RzIGJyZWFr aW5nIG9uIGlPUyBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg2MDA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgU2tpcHBwaW5nIGJpZy1pbnQtZGl2IHRlc3RzIG9uIGlPUyBidWlsZCBiZWNhdXNl IHRoZXkgYXJlIGJyb2tlbiBpbgorICAgICAgICB0aGlzIGFyY2hpdGVjdHVyZS4KKworICAgICAg ICAqIHN0cmVzcy9iaWctaW50LWRpdi1qaXQuanM6CisgICAgICAgICogc3RyZXNzL2JpZy1pbnQt ZGl2LW1lbW9yeS1zdHJlc3MuanM6CisgICAgICAgICogc3RyZXNzL2JpZy1pbnQtZGl2LXRvLXBy aW1pdGl2ZS5qczoKKyAgICAgICAgKiBzdHJlc3MvYmlnLWludC1kaXYtdHlwZS1lcnJvci5qczoK KyAgICAgICAgKiBzdHJlc3MvYmlnLWludC1kaXYtd3JhcHBlZC12YWx1ZS5qczoKKyAgICAgICAg KiBzdHJlc3MvYmlnLWludC1kaXZpc2lvbi5qczoKKwogMjAxOC0wNS0yMyAgS2VpdGggTWlsbGVy ICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBEZWZpbmUgbGVuZ3RoIG9uIENv VyBhcnJheSBzaG91bGQgcHJvcGVybHkgY29udmVydCB0byB3cml0YWJsZQpkaWZmIC0tZ2l0IGEv SlNUZXN0cy9zdHJlc3MvYmlnLWludC1kaXYtaml0LmpzIGIvSlNUZXN0cy9zdHJlc3MvYmlnLWlu dC1kaXYtaml0LmpzCmluZGV4IDBlMjE3ZTgzMDdlMzlkNGY0MGMxNWEyYWQwNzA4NDQ4MjY2YTkw NGYuLjI2ZTU4ZjhhM2VkYzRmMTEyNmEyOGZkZmVhYzhiMWFmOGMyMGYwMzEgMTAwNjQ0Ci0tLSBh L0pTVGVzdHMvc3RyZXNzL2JpZy1pbnQtZGl2LWppdC5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9i aWctaW50LWRpdi1qaXQuanMKQEAgLTEsNCArMSw0IEBACi0vL0AgcnVuQmlnSW50RW5hYmxlZAor Ly9AIGlmICRob3N0T1MgPT0gImRhcndpbiIgYW5kICRhcmNoaXRlY3R1cmUgIT0gIng4Ni02NCIg YW5kICRhcmNoaXRlY3R1cmUgIT0gIng4NiIgdGhlbiBza2lwIGVsc2UgcnVuQmlnSW50RW5hYmxl ZCBlbmQKIAogbGV0IGFzc2VydCA9IHsKICAgICBzYW1lVmFsdWU6IGZ1bmN0aW9uKGksIGUsIG0p IHsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2JpZy1pbnQtZGl2LW1lbW9yeS1zdHJlc3Mu anMgYi9KU1Rlc3RzL3N0cmVzcy9iaWctaW50LWRpdi1tZW1vcnktc3RyZXNzLmpzCmluZGV4IDBj ZjBiOWI2ZmFmM2VmODVjNWY1OWQzYmE5YmY0YTk3NGY3M2Y2ZjQuLmQ1MjEwMzMzZWU0MDE3MDc4 NzQ3NDU4N2U4MmI5MTIwYjJkMjU4NTMgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL2JpZy1p bnQtZGl2LW1lbW9yeS1zdHJlc3MuanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvYmlnLWludC1kaXYt bWVtb3J5LXN0cmVzcy5qcwpAQCAtMSw0ICsxLDQgQEAKLS8vQCBydW5CaWdJbnRFbmFibGVkCisv L0AgaWYgJGhvc3RPUyA9PSAiZGFyd2luIiBhbmQgJGFyY2hpdGVjdHVyZSAhPSAieDg2LTY0IiBh bmQgJGFyY2hpdGVjdHVyZSAhPSAieDg2IiB0aGVuIHNraXAgZWxzZSBydW5CaWdJbnRFbmFibGVk IGVuZAogCiBmdW5jdGlvbiBhc3NlcnQoYSkgewogICAgIGlmICghYSkKZGlmZiAtLWdpdCBhL0pT VGVzdHMvc3RyZXNzL2JpZy1pbnQtZGl2LXRvLXByaW1pdGl2ZS5qcyBiL0pTVGVzdHMvc3RyZXNz L2JpZy1pbnQtZGl2LXRvLXByaW1pdGl2ZS5qcwppbmRleCBhMjk3MzQ0N2VhNDI1ODI2MjI1MmVh ZmRhYWUwZDYyZWYxODIxYzg4Li4yZDk1NjMyZWMxNmQ4Y2RiYjE0MGYwZWEzNzVmYTg1M2ZkYWY1 YTJhIDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9iaWctaW50LWRpdi10by1wcmltaXRpdmUu anMKKysrIGIvSlNUZXN0cy9zdHJlc3MvYmlnLWludC1kaXYtdG8tcHJpbWl0aXZlLmpzCkBAIC0x LDQgKzEsNCBAQAotLy9AIHJ1bkJpZ0ludEVuYWJsZWQKKy8vQCBpZiAkaG9zdE9TID09ICJkYXJ3 aW4iIGFuZCAkYXJjaGl0ZWN0dXJlICE9ICJ4ODYtNjQiIGFuZCAkYXJjaGl0ZWN0dXJlICE9ICJ4 ODYiIHRoZW4gc2tpcCBlbHNlIHJ1bkJpZ0ludEVuYWJsZWQgZW5kCiAKIGZ1bmN0aW9uIGFzc2Vy dChhKSB7CiAgICAgaWYgKCFhKQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvYmlnLWludC1k aXYtdHlwZS1lcnJvci5qcyBiL0pTVGVzdHMvc3RyZXNzL2JpZy1pbnQtZGl2LXR5cGUtZXJyb3Iu anMKaW5kZXggMjc5ODJjZDc4ZTAzMDE1MGVhZmFhNGY5MzQ2ZTRmNjY3ZDVlNjYxYi4uMDRlZGEx NjUxNzYyZmNmNTljNDI1YWE0OTAwMGRhYzBhYTdhYmEyNiAxMDA2NDQKLS0tIGEvSlNUZXN0cy9z dHJlc3MvYmlnLWludC1kaXYtdHlwZS1lcnJvci5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9iaWct aW50LWRpdi10eXBlLWVycm9yLmpzCkBAIC0xLDQgKzEsNCBAQAotLy9AIHJ1bkJpZ0ludEVuYWJs ZWQKKy8vQCBpZiAkaG9zdE9TID09ICJkYXJ3aW4iIGFuZCAkYXJjaGl0ZWN0dXJlICE9ICJ4ODYt NjQiIGFuZCAkYXJjaGl0ZWN0dXJlICE9ICJ4ODYiIHRoZW4gc2tpcCBlbHNlIHJ1bkJpZ0ludEVu YWJsZWQgZW5kCiAKIGZ1bmN0aW9uIGFzc2VydChhLCBtZXNzYWdlKSB7CiAgICAgaWYgKCFhKQpk aWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvYmlnLWludC1kaXYtd3JhcHBlZC12YWx1ZS5qcyBi L0pTVGVzdHMvc3RyZXNzL2JpZy1pbnQtZGl2LXdyYXBwZWQtdmFsdWUuanMKaW5kZXggOWJiOWFl ZTk4M2FmMGMwZTA5NzU4ZTc3MjM4NGY1ZWIzYzQ2ZGM5MC4uMTEyMGY4MTAzZDhiZDQ1NjJhNjg0 OWFiN2Y1YzQyNmM0Nzc2Yzk3NCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3MvYmlnLWludC1k aXYtd3JhcHBlZC12YWx1ZS5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9iaWctaW50LWRpdi13cmFw cGVkLXZhbHVlLmpzCkBAIC0xLDQgKzEsNCBAQAotLy9AIHJ1bkJpZ0ludEVuYWJsZWQKKy8vQCBp ZiAkaG9zdE9TID09ICJkYXJ3aW4iIGFuZCAkYXJjaGl0ZWN0dXJlICE9ICJ4ODYtNjQiIGFuZCAk YXJjaGl0ZWN0dXJlICE9ICJ4ODYiIHRoZW4gc2tpcCBlbHNlIHJ1bkJpZ0ludEVuYWJsZWQgZW5k CiAKIGFzc2VydCA9IHsKICAgICBzYW1lVmFsdWU6IGZ1bmN0aW9uIChpbnB1dCwgZXhwZWN0ZWQs IG1lc3NhZ2UpIHsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2JpZy1pbnQtZGl2aXNpb24u anMgYi9KU1Rlc3RzL3N0cmVzcy9iaWctaW50LWRpdmlzaW9uLmpzCmluZGV4IDQwMTg5MGFkNjMx NmNlY2U3YTliMmNhZDAyMGFhYjBmNWRiMjk5MWEuLmUwYTZhOTQ3OGE4NGNmYmZjNmRkOTZmZGE5 Y2U3OTZjYjZiZWI0YWEgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL2JpZy1pbnQtZGl2aXNp b24uanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvYmlnLWludC1kaXZpc2lvbi5qcwpAQCAtMSw0ICsx LDQgQEAKLS8vQCBydW5CaWdJbnRFbmFibGVkCisvL0AgaWYgJGhvc3RPUyA9PSAiZGFyd2luIiBh bmQgJGFyY2hpdGVjdHVyZSAhPSAieDg2LTY0IiBhbmQgJGFyY2hpdGVjdHVyZSAhPSAieDg2IiB0 aGVuIHNraXAgZWxzZSBydW5CaWdJbnRFbmFibGVkIGVuZAogCiAvLyBDb3B5cmlnaHQgKEMpIDIw MTcgUm9iaW4gVGVtcGxldG9uLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogLy8gVGhpcyBjb2RlIGlz IGdvdmVybmVkIGJ5IHRoZSBCU0QgbGljZW5zZSBmb3VuZCBpbiB0aGUgTElDRU5TRSBmaWxlLgo=