186003 2018-05-25 16:16:24 -0700 Do even fewer allocations in URL host operations 2018-05-29 21:50:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez commit-queue darin dbates ews-watchlist ggaren japhet webkit-bug-importer oldest_to_newest 1427530 0 achristensen 2018-05-25 16:16:24 -0700 Do even fewer allocations in URL host operations 1427537 1 341348 achristensen 2018-05-25 16:19:15 -0700 Created attachment 341348 Patch 1427538 2 341348 ggaren 2018-05-25 16:19:52 -0700 Comment on attachment 341348 Patch r=me 1428139 3 341348 commit-queue 2018-05-29 11:24:58 -0700 Comment on attachment 341348 Patch Clearing flags on attachment: 341348 Committed r232267: <https://trac.webkit.org/changeset/232267> 1428140 4 commit-queue 2018-05-29 11:25:00 -0700 All reviewed patches have been landed. Closing bug. 1428141 5 webkit-bug-importer 2018-05-29 11:25:30 -0700 <rdar://problem/40621951> 1428356 6 341348 darin 2018-05-29 21:50:27 -0700 Comment on attachment 341348 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341348&action=review > Source/WebCore/loader/ResourceLoadStatistics.cpp:341 > if (host.isNull() || host.isEmpty()) The isNull check here is redundant. 341348 2018-05-25 16:19:15 -0700 2018-05-29 11:24:58 -0700 Patch bug-186003-20180525161914.patch text/plain 4960 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMjIxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA1LTI1ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRG8gZXZlbiBm ZXdlciBhbGxvY2F0aW9ucyBpbiBVUkwgaG9zdCBvcGVyYXRpb25zCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODYwMDMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxvYWRlci9SZXNvdXJjZUxvYWRTdGF0 aXN0aWNzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlTG9hZFN0YXRpc3RpY3M6OnBy aW1hcnlEb21haW4pOgorICAgICAgICAqIGxvYWRlci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzLmg6 CisgICAgICAgICogcGxhdGZvcm0vVVJMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlVSTDo6aG9z dElzSVBBZGRyZXNzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9VUkwuaDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9tYWMvVVJMTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6VVJMOjpob3N0SXNJUEFkZHJl c3MpOgorICAgICAgICAqIHBsYXRmb3JtL3NvdXAvVVJMU291cC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpVUkw6Omhvc3RJc0lQQWRkcmVzcyk6CisKIDIwMTgtMDUtMjUgIEplcmVteSBKb25lcyAg PGplcmVteWpAYXBwbGUuY29tPgogCiAgICAgICAgIEZ1bGxzY3JlZW4gZWxlbWVudCBjYW4gYmUg Y2xpcHBlZCBieSBhbmNlc3Rvci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJj ZUxvYWRTdGF0aXN0aWNzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIv UmVzb3VyY2VMb2FkU3RhdGlzdGljcy5jcHAJKHJldmlzaW9uIDIzMjE5OCkKKysrIFNvdXJjZS9X ZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzMzLDIyICszMzMsMjMgQEAgdm9pZCBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzOjptZXJnZShj b25zdAogCiBTdHJpbmcgUmVzb3VyY2VMb2FkU3RhdGlzdGljczo6cHJpbWFyeURvbWFpbihjb25z dCBVUkwmIHVybCkKIHsKLSAgICByZXR1cm4gcHJpbWFyeURvbWFpbih1cmwuaG9zdCgpLnRvU3Ry aW5nKCkpOworICAgIHJldHVybiBwcmltYXJ5RG9tYWluKHVybC5ob3N0KCkpOwogfQogCi1TdHJp bmcgUmVzb3VyY2VMb2FkU3RhdGlzdGljczo6cHJpbWFyeURvbWFpbihjb25zdCBTdHJpbmcmIGhv c3QpCitTdHJpbmcgUmVzb3VyY2VMb2FkU3RhdGlzdGljczo6cHJpbWFyeURvbWFpbihTdHJpbmdW aWV3IGhvc3QpCiB7CiAgICAgaWYgKGhvc3QuaXNOdWxsKCkgfHwgaG9zdC5pc0VtcHR5KCkpCiAg ICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIm51bGxPcmlnaW4iKTsKIAorICAgIFN0cmluZyBo b3N0U3RyaW5nID0gaG9zdC50b1N0cmluZygpOwogI2lmIEVOQUJMRShQVUJMSUNfU1VGRklYX0xJ U1QpCi0gICAgU3RyaW5nIHByaW1hcnlEb21haW4gPSB0b3BQcml2YXRlbHlDb250cm9sbGVkRG9t YWluKGhvc3QpOworICAgIFN0cmluZyBwcmltYXJ5RG9tYWluID0gdG9wUHJpdmF0ZWx5Q29udHJv bGxlZERvbWFpbihob3N0U3RyaW5nKTsKICAgICAvLyBXZSB3aWxsIGhhdmUgYW4gZW1wdHkgc3Ry aW5nIGhlcmUgaWYgdGhlcmUgaXMgbm8gVExELiBVc2UgdGhlIGhvc3QgYXMgYSBmYWxsYmFjay4K ICAgICBpZiAoIXByaW1hcnlEb21haW4uaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gcHJpbWFy eURvbWFpbjsKICNlbmRpZgogCi0gICAgcmV0dXJuIGhvc3Q7CisgICAgcmV0dXJuIGhvc3RTdHJp bmc7CiB9CiAKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRTdGF0 aXN0aWNzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9h ZFN0YXRpc3RpY3MuaAkocmV2aXNpb24gMjMyMTk3KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVy L1Jlc291cmNlTG9hZFN0YXRpc3RpY3MuaAkod29ya2luZyBjb3B5KQpAQCAtNTEsNyArNTEsNyBA QCBzdHJ1Y3QgUmVzb3VyY2VMb2FkU3RhdGlzdGljcyB7CiAgICAgUmVzb3VyY2VMb2FkU3RhdGlz dGljcyYgb3BlcmF0b3I9KFJlc291cmNlTG9hZFN0YXRpc3RpY3MmJikgPSBkZWZhdWx0OwogCiAg ICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIFN0cmluZyBwcmltYXJ5RG9tYWluKGNvbnN0IFVSTCYp OwotICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBTdHJpbmcgcHJpbWFyeURvbWFpbihjb25zdCBT dHJpbmcmIGhvc3QpOworICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBTdHJpbmcgcHJpbWFyeURv bWFpbihTdHJpbmdWaWV3IGhvc3QpOwogCiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBlbmNvZGUo S2V5ZWRFbmNvZGVyJikgY29uc3Q7CiAgICAgV0VCQ09SRV9FWFBPUlQgYm9vbCBkZWNvZGUoS2V5 ZWREZWNvZGVyJiwgdW5zaWduZWQgbW9kZWxWZXJzaW9uKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL1VSTC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v VVJMLmNwcAkocmV2aXNpb24gMjMyMTk4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJM LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA2MCw3ICsxMDYwLDcgQEAgVGV4dFN0cmVhbSYgb3Bl cmF0b3I8PChUZXh0U3RyZWFtJiB0cywgYwogfQogCiAjaWYgIVBMQVRGT1JNKENPQ09BKSAmJiAh VVNFKFNPVVApCi1ib29sIFVSTDo6aG9zdElzSVBBZGRyZXNzKGNvbnN0IFN0cmluZyYgaG9zdCkK K2Jvb2wgVVJMOjpob3N0SXNJUEFkZHJlc3MoU3RyaW5nVmlldyBob3N0KQogewogICAgIC8vIEFz c3VtZSB0aGF0IGFueSBob3N0IHRoYXQgZW5kcyB3aXRoIGEgZGlnaXQgaXMgdHJ5aW5nIHRvIGJl IGFuIElQIGFkZHJlc3MuCiAgICAgcmV0dXJuICFob3N0LmlzRW1wdHkoKSAmJiBpc0FTQ0lJRGln aXQoaG9zdFtob3N0Lmxlbmd0aCgpIC0gMV0pOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vVVJMLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMLmgJKHJl dmlzaW9uIDIzMjE5OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTC5oCSh3b3JraW5n IGNvcHkpCkBAIC0xNzYsNyArMTc2LDcgQEAgcHVibGljOgogICAgIHVuc2lnbmVkIGhvc3RTdGFy dCgpIGNvbnN0OwogICAgIHVuc2lnbmVkIGhvc3RFbmQoKSBjb25zdDsKIAotICAgIFdFQkNPUkVf RVhQT1JUIHN0YXRpYyBib29sIGhvc3RJc0lQQWRkcmVzcyhjb25zdCBTdHJpbmcmKTsKKyAgICBX RUJDT1JFX0VYUE9SVCBzdGF0aWMgYm9vbCBob3N0SXNJUEFkZHJlc3MoU3RyaW5nVmlldyk7CiAK ICAgICB1bnNpZ25lZCBwYXRoU3RhcnQoKSBjb25zdDsKICAgICB1bnNpZ25lZCBwYXRoRW5kKCkg Y29uc3Q7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVVJMTWFjLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9VUkxNYWMubW0JKHJldmlzaW9u IDIzMjE5NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9VUkxNYWMubW0JKHdvcmtp bmcgY29weSkKQEAgLTc5LDkgKzc5LDkgQEAgUmV0YWluUHRyPENGVVJMUmVmPiBVUkw6OmNyZWF0 ZUNGVVJMKCkgYwogICAgIHJldHVybiBjcmVhdGVDRlVSTEZyb21CdWZmZXIoYnVmZmVyLmRhdGEo KSwgYnVmZmVyLnNpemUoKSk7CiB9CiAKLWJvb2wgVVJMOjpob3N0SXNJUEFkZHJlc3MoY29uc3Qg U3RyaW5nJiBob3N0KQorYm9vbCBVUkw6Omhvc3RJc0lQQWRkcmVzcyhTdHJpbmdWaWV3IGhvc3Qp CiB7Ci0gICAgcmV0dXJuIFtob3N0IF93ZWJfbG9va3NMaWtlSVBBZGRyZXNzXTsKKyAgICByZXR1 cm4gW2hvc3QuY3JlYXRlTlNTdHJpbmdXaXRob3V0Q29weWluZygpLmdldCgpIF93ZWJfbG9va3NM aWtlSVBBZGRyZXNzXTsKIH0KIAogfQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc291 cC9VUkxTb3VwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zb3Vw L1VSTFNvdXAuY3BwCShyZXZpc2lvbiAyMzIxOTcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9zb3VwL1VSTFNvdXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Niw3ICs2Niw3IEBAIEdVbmlx dWVQdHI8U291cFVSST4gVVJMOjpjcmVhdGVTb3VwVVJJKCkKICAgICByZXR1cm4gR1VuaXF1ZVB0 cjxTb3VwVVJJPihzb3VwX3VyaV9uZXcoc3RyaW5nKCkudXRmOCgpLmRhdGEoKSkpOwogfQogCi1i b29sIFVSTDo6aG9zdElzSVBBZGRyZXNzKGNvbnN0IFN0cmluZyYgaG9zdCkKK2Jvb2wgVVJMOjpo b3N0SXNJUEFkZHJlc3MoU3RyaW5nVmlldyBob3N0KQogewogICAgIHJldHVybiAhaG9zdC5pc0Vt cHR5KCkgJiYgZ19ob3N0bmFtZV9pc19pcF9hZGRyZXNzKGhvc3QudXRmOCgpLmRhdGEoKSk7CiB9 Cg==