185992 2018-05-25 13:23:54 -0700 WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback() unexpectedly constructs a process pool 2018-05-25 14:38:08 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson bfulgham commit-queue ggaren webkit-bug-importer wilander oldest_to_newest 1427428 0 cdumez 2018-05-25 13:23:54 -0700 WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback() unexpectedly constructs a process pool: Sample Count, Samples %, CPU %, Symbol 14, 0.1%, 0.1%, WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled(bool) (in WebKit) 14, 0.1%, 0.1%, WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback(WTF::Function<void (WTF::String const&)>&&) (in WebKit) 14, 0.1%, 0.1%, WebKit::WebsiteDataStore::processPools(unsigned long, bool) const (in WebKit) 12, 0.1%, 0.1%, WebKit::WebProcessPool::create(API::ProcessPoolConfiguration&) (in WebKit) 1427430 1 341318 cdumez 2018-05-25 13:27:25 -0700 Created attachment 341318 Patch 1427437 2 wilander 2018-05-25 13:49:44 -0700 Did you test so that this doesn't turn off the feature in the cases where we expect it to be turned on? 1427443 3 cdumez 2018-05-25 13:58:30 -0700 (In reply to John Wilander from comment #2) > Did you test so that this doesn't turn off the feature in the cases where we > expect it to be turned on? If I add logging in the WebProcess and launch Safari I see: WebProcess::setResourceLoadStatisticsEnabled(1) So the feature still gets enabled. 1427457 4 341318 ggaren 2018-05-25 14:19:35 -0700 Comment on attachment 341318 Patch r=me 1427464 5 341318 commit-queue 2018-05-25 14:35:35 -0700 Comment on attachment 341318 Patch Clearing flags on attachment: 341318 Committed r232203: <https://trac.webkit.org/changeset/232203> 1427465 6 commit-queue 2018-05-25 14:35:36 -0700 All reviewed patches have been landed. Closing bug. 1427468 7 webkit-bug-importer 2018-05-25 14:38:08 -0700 <rdar://problem/40566386> 341318 2018-05-25 13:27:25 -0700 2018-05-25 14:35:35 -0700 Patch bug-185992-20180525132724.patch text/plain 4185 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAzMGUyZTNiNTQ0MDYwNGUy MGU4ZDNiY2M5MmJiMGI3NWEwNzk0MTYuLmYyNWUxNGViZmMxODE1Nzc1OGNmNjk0NWUzMmY5ZTdk MTczNDE3OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDUtMjUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBXZWJzaXRlRGF0YVN0b3JlOjplbmFi bGVSZXNvdXJjZUxvYWRTdGF0aXN0aWNzQW5kU2V0VGVzdGluZ0NhbGxiYWNrKCkgdW5leHBlY3Rl ZGx5IGNvbnN0cnVjdHMgYSBwcm9jZXNzIHBvb2wKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTk5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBlbmFibGVSZXNvdXJjZUxvYWRTdGF0aXN0aWNz QW5kU2V0VGVzdGluZ0NhbGxiYWNrKCkgdG8gcGFzcyB0aGUgcmlnaHQgcGFyYW1ldGVyIHRvIHBy b2Nlc3NQb29scygpCisgICAgICAgIHRvIGF2b2lkIGNvbnN0cnVjdGluZyBhIHByb2Nlc3MgcG9v bCB3aGVuIG5vbmUgZXhpc3QuIEFsc28gZHJvcCB0aGUgJ3Jlc291cmNlTG9hZFN0YXRpc3RpY3NF bmFibGVkJworICAgICAgICBmbGFnIG9uIHRoZSBXZWJQcm9jZXNzUG9vbCBhbmQgaGF2ZSBpdCBx dWVyeSBpdHMgZGF0YSBzdG9yZSBpbnN0ZWFkIHRvIGtub3cgaWYgdGhlIGZlYXR1cmUgaXMgZW5h YmxlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjppbml0aWFsaXplTmV3V2ViUHJvY2Vzcyk6CisgICAg ICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpzZXRSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRW5h YmxlZCk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmg6CisgICAgICAgICog VUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJzaXRlRGF0YVN0b3JlOjplbmFibGVSZXNvdXJjZUxvYWRTdGF0aXN0aWNzQW5kU2V0 VGVzdGluZ0NhbGxiYWNrKToKKwogMjAxOC0wNS0yNSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIERyb3Agc3VwcG9ydCBmb3IgTlNVUkxDYWNoZSBpbiBXZWJLaXQy CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKaW5kZXggYmYzYmM5 OGU0NjI4ZDY5ZDU1MTk4MjZiZTg4NGYzYzU1MmIzYmUzNC4uMDY3YTViNTA3YTRiN2Q2YTIyMDkw MGE3OTEyOGY2ZGJkYjc5NGVhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUHJvY2Vzc1Bvb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nl c3NQb29sLmNwcApAQCAtOTQyLDcgKzk0Miw3IEBAIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OmluaXRp YWxpemVOZXdXZWJQcm9jZXNzKFdlYlByb2Nlc3NQcm94eSYgcHJvY2VzcywgV2Vic2l0ZURhCiAg ICAgICAgIHBhcmFtZXRlcnMud2F5bGFuZENvbXBvc2l0b3JEaXNwbGF5TmFtZSA9IFdheWxhbmRD b21wb3NpdG9yOjpzaW5nbGV0b24oKS5kaXNwbGF5TmFtZSgpOwogI2VuZGlmCiAKLSAgICBwYXJh bWV0ZXJzLnJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkID0gcmVzb3VyY2VMb2FkU3RhdGlz dGljc0VuYWJsZWQoKTsKKyAgICBwYXJhbWV0ZXJzLnJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFi bGVkID0gd2Vic2l0ZURhdGFTdG9yZS5yZXNvdXJjZUxvYWRTdGF0aXN0aWNzRW5hYmxlZCgpOwog I2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCiAgICAgcGFyYW1ldGVycy5zaG91bGRDYXB0dXJlQXVk aW9JblVJUHJvY2VzcyA9IG1fY29uZmlndXJhdGlvbi0+c2hvdWxkQ2FwdHVyZUF1ZGlvSW5VSVBy b2Nlc3MoKTsKICNlbmRpZgpAQCAtMTM2OCw3ICsxMzY4LDYgQEAgdm9pZCBXZWJQcm9jZXNzUG9v bDo6c2V0U2hvdWxkVXNlRm9udFNtb290aGluZyhib29sIHVzZUZvbnRTbW9vdGhpbmcpCiAKIHZv aWQgV2ViUHJvY2Vzc1Bvb2w6OnNldFJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKGJvb2wg ZW5hYmxlZCkKIHsKLSAgICBtX3Jlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkID0gZW5hYmxl ZDsKICAgICBzZW5kVG9BbGxQcm9jZXNzZXMoTWVzc2FnZXM6OldlYlByb2Nlc3M6OlNldFJlc291 cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKGVuYWJsZWQpKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuaCBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYlByb2Nlc3NQb29sLmgKaW5kZXggMTkyZmMzOWYwMGY4NTk0OGM3M2ZhNTNjOTJh ZmFhZDU1MDdhMTViZi4uYWViMTkxMGE2MGU0NWFmMDI1NWMwNWU3ZWRjY2JiZGIxNjkzYjhmMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5oCkBAIC00MTQsNyArNDE0 LDYgQEAgcHVibGljOgogICAgIHN0YXRpYyBTdHJpbmcgbGVnYWN5UGxhdGZvcm1EZWZhdWx0TmV0 d29ya0NhY2hlRGlyZWN0b3J5KCk7CiAgICAgc3RhdGljIFN0cmluZyBsZWdhY3lQbGF0Zm9ybURl ZmF1bHRKYXZhU2NyaXB0Q29uZmlndXJhdGlvbkRpcmVjdG9yeSgpOwogCi0gICAgYm9vbCByZXNv dXJjZUxvYWRTdGF0aXN0aWNzRW5hYmxlZCgpIHsgcmV0dXJuIG1fcmVzb3VyY2VMb2FkU3RhdGlz dGljc0VuYWJsZWQ7IH0KICAgICB2b2lkIHNldFJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVk KGJvb2wpOwogICAgIHZvaWQgY2xlYXJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzKCk7CiAKQEAgLTYz MSw3ICs2MzAsNiBAQCBwcml2YXRlOgogI2VuZGlmCiAKICAgICBib29sIG1fbWVtb3J5Q2FjaGVE aXNhYmxlZCB7IGZhbHNlIH07Ci0gICAgYm9vbCBtX3Jlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFi bGVkIHsgZmFsc2UgfTsKICAgICBib29sIG1famF2YVNjcmlwdENvbmZpZ3VyYXRpb25GaWxlRW5h YmxlZCB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2Fsd2F5c1J1bnNBdEJhY2tncm91bmRQcmlvcml0 eTsKICAgICBib29sIG1fc2hvdWxkVGFrZVVJQmFja2dyb3VuZEFzc2VydGlvbjsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUu Y3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9y ZS5jcHAKaW5kZXggYTlmMjY4Y2ZmMWJhZjRmMGE4OWM4Nzg1Y2M5OWM3MDU1NmY4MmI1Ny4uNTQ4 NzYxYTNmYzQ5M2M5MWZjNzMzYWNmMWI5ODNjNTBkOWQwZTQ0ZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAK QEAgLTE0NzcsNyArMTQ3Nyw3IEBAIHZvaWQgV2Vic2l0ZURhdGFTdG9yZTo6ZW5hYmxlUmVzb3Vy Y2VMb2FkU3RhdGlzdGljc0FuZFNldFRlc3RpbmdDYWxsYmFjayhGdW5jdGlvCiAgICAgbV9yZXNv dXJjZUxvYWRTdGF0aXN0aWNzID0gV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpjcmVh dGUobV9jb25maWd1cmF0aW9uLnJlc291cmNlTG9hZFN0YXRpc3RpY3NEaXJlY3RvcnksIFdURk1v dmUoY2FsbGJhY2spLCBtX3Nlc3Npb25JRC5pc0VwaGVtZXJhbCgpKTsKICNlbmRpZgogCi0gICAg Zm9yIChhdXRvJiBwcm9jZXNzUG9vbCA6IHByb2Nlc3NQb29scygpKQorICAgIGZvciAoYXV0byYg cHJvY2Vzc1Bvb2wgOiBwcm9jZXNzUG9vbHMoc3RkOjpudW1lcmljX2xpbWl0czxzaXplX3Q+Ojpt YXgoKSwgZmFsc2UpKQogICAgICAgICBwcm9jZXNzUG9vbC0+c2V0UmVzb3VyY2VMb2FkU3RhdGlz dGljc0VuYWJsZWQodHJ1ZSk7CiB9CiAK