185985 2018-05-25 09:46:41 -0700 Avoid triggering network cache speculative revalidation for loads allowing expired content 2018-05-25 10:24:55 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez beidson cgarcia commit-queue ews-watchlist ggaren koivisto webkit-bug-importer oldest_to_newest 1427326 0 cdumez 2018-05-25 09:46:41 -0700 Avoid triggering network cache speculative revalidation for loads allowing expired content (e.g. history loads). This causes us to do unnecessary revalidations. 1427329 1 341296 cdumez 2018-05-25 09:49:18 -0700 Created attachment 341296 Patch 1427334 2 ggaren 2018-05-25 09:58:23 -0700 If we skip speculative revalidation, does that mean that we'll also skip the optimization that brings all the resources for a given URL into memory? 1427338 3 341296 commit-queue 2018-05-25 10:23:19 -0700 Comment on attachment 341296 Patch Clearing flags on attachment: 341296 Committed r232190: <https://trac.webkit.org/changeset/232190> 1427339 4 commit-queue 2018-05-25 10:23:21 -0700 All reviewed patches have been landed. Closing bug. 1427340 5 webkit-bug-importer 2018-05-25 10:24:55 -0700 <rdar://problem/40557978> 341296 2018-05-25 09:49:18 -0700 2018-05-25 10:23:19 -0700 Patch bug-185985-20180525094917.patch text/plain 1918 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRjNzMzMWIyNmRjNzc2NTNi NDFhMWFhODM0MjM3NDJkY2I0ZWQ1NjMuLmE1Zjc2N2NlN2NjOWZlODU4OTVhMWYzZTNlMzIyNTQx OGY3YzE5YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDUtMjUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCB0cmlnZ2VyaW5nIG5ldHdv cmsgY2FjaGUgc3BlY3VsYXRpdmUgcmV2YWxpZGF0aW9uIGZvciBsb2FkcyBhbGxvd2luZyBleHBp cmVkIGNvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NTk4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEF2b2lkIHRyaWdnZXJpbmcgbmV0d29yayBjYWNoZSBzcGVjdWxhdGl2ZSByZXZhbGlkYXRp b24gZm9yIGxvYWRzIGFsbG93aW5nIGV4cGlyZWQgY29udGVudAorICAgICAgICAoZS5nLiBoaXN0 b3J5IGxvYWRzLCByZXN0b3JpbmcgcGFnZXMgYWZ0ZXIgY3Jhc2ggb3Igc2FmYXJpIHJlbGF1bmNo KS4gVGhpcyBjYXVzZXMgdXMgdG8gZG8KKyAgICAgICAgdW5uZWNlc3NhcnkgcmV2YWxpZGF0aW9u cywgaXQgaXMgYm90aCB3YXN0ZWZ1bCBhbmQgYmFkIGZvciBwZXJmb3JtYW5jZS4KKworICAgICAg ICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHA6CisgICAgICAgIChXZWJL aXQ6Ok5ldHdvcmtDYWNoZTo6Q2FjaGU6OnJldHJpZXZlKToKKwogMjAxOC0wNS0yNSAgRGF2aWQg S2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBpc3N1ZXMgd2l0aCAt ZGVhbGxvYyBtZXRob2RzIGZvdW5kIGJ5IGNsYW5nIHN0YXRpYyBhbmFseXplcgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCmluZGV4 IGU5YTk2MThlNDFlMGM5NjJiYjQ3MTc0ZDFhNDhjNDdjYTBkYWRmNTEuLjljYzRhMWUxZDhiNDU2 N2M4NGFiMDA5ZWZhNjU4ZjZkMDBiMWMxNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHAKQEAgLTMyMSw3ICszMjEsNyBAQCB2 b2lkIENhY2hlOjpyZXRyaWV2ZShjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmIHJlcXVl c3QsIGNvbnN0IEdsb2JhbEZyYW1lSQogICAgIEtleSBzdG9yYWdlS2V5ID0gbWFrZUNhY2hlS2V5 KHJlcXVlc3QpOwogCiAjaWYgRU5BQkxFKE5FVFdPUktfQ0FDSEVfU1BFQ1VMQVRJVkVfUkVWQUxJ REFUSU9OKQotICAgIGJvb2wgY2FuVXNlU3BlY3VsYXRpdmVSZXZhbGlkYXRpb24gPSBtX3NwZWN1 bGF0aXZlTG9hZE1hbmFnZXIgJiYgIXJlcXVlc3QuaXNDb25kaXRpb25hbCgpOworICAgIGJvb2wg Y2FuVXNlU3BlY3VsYXRpdmVSZXZhbGlkYXRpb24gPSBtX3NwZWN1bGF0aXZlTG9hZE1hbmFnZXIg JiYgIXJlcXVlc3QuaXNDb25kaXRpb25hbCgpICYmICFjYWNoZVBvbGljeUFsbG93c0V4cGlyZWQo cmVxdWVzdC5jYWNoZVBvbGljeSgpKTsKICAgICBpZiAoY2FuVXNlU3BlY3VsYXRpdmVSZXZhbGlk YXRpb24pCiAgICAgICAgIG1fc3BlY3VsYXRpdmVMb2FkTWFuYWdlci0+cmVnaXN0ZXJMb2FkKGZy YW1lSUQsIHJlcXVlc3QsIHN0b3JhZ2VLZXkpOwogI2VuZGlmCg==