185982 2018-05-25 09:01:08 -0700 iOS: setting 'defaultValue' of input type=date from script does not cause UI update 2018-05-30 06:36:20 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build iPhone / iPad iOS 9.3 RESOLVED FIXED InRadar P2 Normal --- 1 smcgruer webkit-unassigned ajuma cdumez commit-queue darin jonlee simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1427311 0 smcgruer 2018-05-25 09:01:08 -0700 What steps will reproduce the problem? (1) Create an input type=date (2) From script, set the 'defaultValue' to a value (3) Observe the input element's rendered UI What is the expected result? The UI should update to show the default value (since there was no previous selection). This happens on desktop Chrome. What happens instead? The UI doesn't update; the date picker is blank. However if you select it, the date picker widget appears and shows that the default value is set. See test case http://output.jsbin.com/vocunov Note that this comes from a React bug that they found and worked around, sadly without informing browser vendors at the time :( - https://github.com/facebook/react/issues/7233 We recently fixed this in Chromium Android (http://crbug.com/838898), and I have a similar patch (to be uploaded shortly) which fixes it in WebKit iOS. 1427351 1 341301 smcgruer 2018-05-25 10:49:21 -0700 Created attachment 341301 Patch 1427352 2 smcgruer 2018-05-25 10:50:03 -0700 First version of the patch has been added to this bug. I am not sure how to mark a LayoutTest as needing to be run on iOS - is that automatic in WebKit? 1427354 3 cdumez 2018-05-25 10:53:13 -0700 (In reply to Stephen McGruer from comment #2) > First version of the patch has been added to this bug. I am not sure how to > mark a LayoutTest as needing to be run on iOS - is that automatic in WebKit? if the iOS-sim bubble becomes green, then your new test is passing on iOS. 1427996 4 341301 darin 2018-05-28 20:27:02 -0700 Comment on attachment 341301 Patch Nice to fix this. Patch looks OK but not ideal. There’s already a general purpose InputType::attributeChanged function, so there is no need to add the valueAttributeChanged function. I fact, we should probably consider removing the other InputType xxxAttributeChanged functions for the various specific attributes. They are redundant, bloat the HTMLInputElement::parseAttribute function and the InputType base class unnecessarily, and cause additional unneeded work for other input types. Note that the same issue comes up with plain text input fields; for those, TextFieldInputType::attributeChanged handles it. It’s a bit untidy to do almost the same thing for the same reason for the date/time fields, but write the code differently and separately. I assume this comes about because the programmers doing the date/time code weren’t aware of the already-existing text field code. The updateAppearance function has the same purpose as the updateInnerTextValue function, but uses a different name. From code inspection, I notice a similar but distinct problem if the lang attribute of the element is changed, or the lang attribute of an ancestor element if it’s the ancestor that happens to determine the computed language (nearest ancestor with a lang attribute). BaseDateAndTimeInputType::localizeValue will format the value based on the locale, which depends on the computed language value, and nothing will cause BaseChooserOnlyDateAndTimeInputType::updateAppearance to be called when the locale changes. Another similar but distinct problem can occur if the document’s content language is changed by adding a <meta> element to the document with an "http-equiv" attribute in it and there are no "lang" attributes. Would be nice if we handled all these cases properly. 1428101 5 smcgruer 2018-05-29 10:15:53 -0700 Thank you for the quick and thorough review Darin. Before I respond to the majority of your review, can I check - you marked the patch as 'review+', are you happy for this version of the patch to be landed and your comments left as future work (probably for others working in this area, not myself)? Or would you prefer if we attempted to resolve your comments in this same patch? 1428352 6 darin 2018-05-29 21:40:23 -0700 (In reply to Stephen McGruer from comment #5) > Thank you for the quick and thorough review Darin. Before I respond to the > majority of your review, can I check - you marked the patch as 'review+', > are you happy for this version of the patch to be landed and your comments > left as future work (probably for others working in this area, not myself)? > Or would you prefer if we attempted to resolve your comments in this same > patch? Either way is OK with me. That’s why I said review+. 1428353 7 darin 2018-05-29 21:41:52 -0700 I think the issues with language are going to be both challenging to fix efficiently and also challenging to test in a platform-independent way. 1428395 8 341301 commit-queue 2018-05-30 06:35:55 -0700 Comment on attachment 341301 Patch Clearing flags on attachment: 341301 Committed r232289: <https://trac.webkit.org/changeset/232289> 1428396 9 commit-queue 2018-05-30 06:35:56 -0700 All reviewed patches have been landed. Closing bug. 1428397 10 webkit-bug-importer 2018-05-30 06:36:20 -0700 <rdar://problem/40648857> 341301 2018-05-25 10:49:21 -0700 2018-05-30 06:35:55 -0700 Patch bug-185982-20180525134921.patch text/plain 6003 smcgruer U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGYxOTZjYjdmMGIxNmVh YWVlZGQ5Mjg4YWRjMjViODY4Y2RjYjIwNS4uZDQ0Nzk4NmE0ZDdlOWQ3MjViZGZmZDk0ZmYwMGE2 YmQyYmU4ZmQ5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA1LTI1ICBTdGVw aGVuIE1jR3J1ZXIgIDxzbWNncnVlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgaU9TOiBzZXR0 aW5nICdkZWZhdWx0VmFsdWUnIG9mIGlucHV0IHR5cGU9ZGF0ZSBmcm9tIHNjcmlwdCBzaG91bGQg Y2F1c2UgYSBVSSB1cGRhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NTk4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvZGF0ZS9kYXRlLWFwcGVhcmFuY2UtZGVmYXVsdFZh bHVlLmh0bWwKKworICAgICAgICAqIGh0bWwvQmFzZUNob29zZXJPbmx5RGF0ZUFuZFRpbWVJbnB1 dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QmFzZUNob29zZXJPbmx5RGF0ZUFuZFRpbWVJ bnB1dFR5cGU6OnZhbHVlQXR0cmlidXRlQ2hhbmdlZCk6CisgICAgICAgICogaHRtbC9CYXNlQ2hv b3Nlck9ubHlEYXRlQW5kVGltZUlucHV0VHlwZS5oOgorICAgICAgICAqIGh0bWwvSFRNTElucHV0 RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpwYXJzZUF0 dHJpYnV0ZSk6CisgICAgICAgICogaHRtbC9JbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SW5wdXRUeXBlOjp2YWx1ZUF0dHJpYnV0ZUNoYW5nZWQpOgorICAgICAgICAqIGh0bWwvSW5w dXRUeXBlLmg6CisKIDIwMTgtMDUtMjMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIE5ldHdvcmtMb2FkQ2hlY2tlciBzaG91bGQgY2hlY2sgY2FjaGVkIHJlZGly ZWN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9CYXNlQ2hvb3Nlck9ubHlE YXRlQW5kVGltZUlucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VDaG9vc2Vy T25seURhdGVBbmRUaW1lSW5wdXRUeXBlLmNwcAppbmRleCBkNDM0ZWI0MzFlM2IxMmY4ZTY1YWZi MTQyZWQ1MTA1YzUxNmVmNjkwLi43MmQ2YjE0NmQ3NGFjM2Y0ZTQ0NTNmYTI0NTcwYjg2YTFlNzYy Y2NjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VDaG9vc2VyT25seURhdGVB bmRUaW1lSW5wdXRUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VDaG9vc2Vy T25seURhdGVBbmRUaW1lSW5wdXRUeXBlLmNwcApAQCAtMTM0LDUgKzEzNCwxMSBAQCBib29sIEJh c2VDaG9vc2VyT25seURhdGVBbmRUaW1lSW5wdXRUeXBlOjppc01vdXNlRm9jdXNhYmxlKCkgY29u c3QKICAgICByZXR1cm4gZWxlbWVudCgpLmlzVGV4dEZvcm1Db250cm9sRm9jdXNhYmxlKCk7CiB9 CiAKK3ZvaWQgQmFzZUNob29zZXJPbmx5RGF0ZUFuZFRpbWVJbnB1dFR5cGU6OnZhbHVlQXR0cmli dXRlQ2hhbmdlZCgpCit7CisgICAgaWYgKCFlbGVtZW50KCkuaGFzRGlydHlWYWx1ZSgpKQorICAg ICAgICB1cGRhdGVBcHBlYXJhbmNlKCk7Cit9CisKIH0KICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9CYXNlQ2hvb3Nlck9ubHlEYXRlQW5kVGltZUlucHV0VHlwZS5oIGIv U291cmNlL1dlYkNvcmUvaHRtbC9CYXNlQ2hvb3Nlck9ubHlEYXRlQW5kVGltZUlucHV0VHlwZS5o CmluZGV4IDZkNTRlYmYyZmM4MzU0ZjQ5NzkzNGUyNDRjODBhZjRmYmMzNmIzYzIuLjNjYmZkZGZj N2M5NWMxZDdiY2M5OGE5MzViNDYzMTBiMmE0MDZkZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvQmFzZUNob29zZXJPbmx5RGF0ZUFuZFRpbWVJbnB1dFR5cGUuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0Jhc2VDaG9vc2VyT25seURhdGVBbmRUaW1lSW5wdXRUeXBlLmgKQEAg LTUzLDYgKzUzLDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGhhbmRsZUtleXVwRXZlbnQoS2V5Ym9h cmRFdmVudCYpIG92ZXJyaWRlOwogICAgIHZvaWQgYWNjZXNzS2V5QWN0aW9uKGJvb2wgc2VuZE1v dXNlRXZlbnRzKSBvdmVycmlkZTsKICAgICBib29sIGlzTW91c2VGb2N1c2FibGUoKSBjb25zdCBv dmVycmlkZTsKKyAgICB2b2lkIHZhbHVlQXR0cmlidXRlQ2hhbmdlZCgpIG92ZXJyaWRlOwogCiAg ICAgLy8gRGF0ZVRpbWVDaG9vc2VyQ2xpZW50IGZ1bmN0aW9uczoKICAgICB2b2lkIGRpZENob29z ZVZhbHVlKGNvbnN0IFN0cmluZyYpIG92ZXJyaWRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElu cHV0RWxlbWVudC5jcHAKaW5kZXggODQ4ZWRhNWYwMDY1MzA5OGE1OGQ5ZjM0YzYyOTMyNDNmNzdj Njg0MS4uODhjNmMyYTlmZTg4ZjIwZDBlYjFlMWNjM2VkNWM3YjUzMTkxYTEzZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC03MjgsNiArNzI4LDcgQEAgdm9p ZCBIVE1MSW5wdXRFbGVtZW50OjpwYXJzZUF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiBu YW1lLCBjb25zdCBBdG9taWNTdHIKICAgICAgICAgc2V0Rm9ybUNvbnRyb2xWYWx1ZU1hdGNoZXNS ZW5kZXJlcihmYWxzZSk7CiAgICAgICAgIHVwZGF0ZVZhbGlkaXR5KCk7CiAgICAgICAgIG1fdmFs dWVBdHRyaWJ1dGVXYXNVcGRhdGVkQWZ0ZXJQYXJzaW5nID0gIW1fcGFyc2luZ0luUHJvZ3Jlc3M7 CisgICAgICAgIG1faW5wdXRUeXBlLT52YWx1ZUF0dHJpYnV0ZUNoYW5nZWQoKTsKICAgICB9IGVs c2UgaWYgKG5hbWUgPT0gY2hlY2tlZEF0dHIpIHsKICAgICAgICAgaWYgKG1faW5wdXRUeXBlLT5p c0NoZWNrYWJsZSgpKQogICAgICAgICAgICAgaW52YWxpZGF0ZVN0eWxlRm9yU3VidHJlZSgpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9JbnB1dFR5cGUuY3BwCmluZGV4IDhiZWMzYTZmNDAwOTc0YWFkYzRiZWFiMzQ5 YmUwNmY4ZDRjYjdhNTcuLmNhNmY1YmFiN2FjYWQxODQ4YTE1M2I1YmRmYjg4ZTlkYjRkNDE4Mjcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5jcHAKQEAgLTkzNiw2ICs5MzYsMTAgQEAgYm9vbCBJ bnB1dFR5cGU6Omhhc1RvdWNoRXZlbnRIYW5kbGVyKCkgY29uc3QKIH0KICNlbmRpZgogCit2b2lk IElucHV0VHlwZTo6dmFsdWVBdHRyaWJ1dGVDaGFuZ2VkKCkKK3sKK30KKwogU3RyaW5nIElucHV0 VHlwZTo6ZGVmYXVsdFRvb2xUaXAoKSBjb25zdAogewogICAgIHJldHVybiBTdHJpbmcoKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0lucHV0VHlwZS5oCmluZGV4IGQwYjg2YjU4YTAzNWJiYzAxNTQ2YmEzYzQ3MTJmYTQw NjYxNDEzYjAuLjBiMGIwMGEyMDQwZDAyYTk1NDU4ODY4Y2Y1ZDJiNmY5MzkwNjE3YzkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmgKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9JbnB1dFR5cGUuaApAQCAtMjY1LDYgKzI2NSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0 dWFsIHZvaWQgY2Fwc0xvY2tTdGF0ZU1heUhhdmVDaGFuZ2VkKCk7CiAgICAgdmlydHVhbCB2b2lk IHVwZGF0ZUF1dG9GaWxsQnV0dG9uKCk7CiAgICAgdmlydHVhbCBTdHJpbmcgZGVmYXVsdFRvb2xU aXAoKSBjb25zdDsKKyAgICB2aXJ0dWFsIHZvaWQgdmFsdWVBdHRyaWJ1dGVDaGFuZ2VkKCk7CiAg ICAgdmlydHVhbCBib29sIG1hdGNoZXNJbmRldGVybWluYXRlUHNldWRvQ2xhc3MoKSBjb25zdDsK ICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkQXBwZWFySW5kZXRlcm1pbmF0ZSgpIGNvbnN0OwogICAg IHZpcnR1YWwgYm9vbCBzdXBwb3J0c1NlbGVjdGlvbkFQSSgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDY1MDkx MjkwYjY0YzFlNDM1NzJkMjYyMTBjNjM5ZTkwYjdkNzkxMjEuLmEyOTU1ZWE2NTRjNGVkMjdjODYz ZjFhMjJiM2NkMjViMDU5MWYyYjkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOC0wNS0yNSAg U3RlcGhlbiBNY0dydWVyICA8c21jZ3J1ZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGlPUzog c2V0dGluZyAnZGVmYXVsdFZhbHVlJyBvZiBpbnB1dCB0eXBlPWRhdGUgZnJvbSBzY3JpcHQgc2hv dWxkIGNhdXNlIGEgVUkgdXBkYXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODU5ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGZhc3QvZm9ybXMvZGF0ZS9kYXRlLWFwcGVhcmFuY2UtZGVmYXVsdFZh bHVlLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvZGF0ZS9kYXRl LWFwcGVhcmFuY2UtZGVmYXVsdFZhbHVlLmh0bWw6IEFkZGVkLgorCiAyMDE4LTA1LTIzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBOZXR3b3JrTG9hZENoZWNr ZXIgc2hvdWxkIGNoZWNrIGNhY2hlZCByZWRpcmVjdGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvZm9ybXMvZGF0ZS9kYXRlLWFwcGVhcmFuY2UtZGVmYXVsdFZhbHVlLWV4cGVjdGVk Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2RhdGUvZGF0ZS1hcHBlYXJhbmNlLWRlZmF1 bHRWYWx1ZS1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmFlNzM2ZDA5MDZjZDMzNTA5ZmFlNWEw MGQ2YjA0ZDA3NWMwYjdiYzEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL2RhdGUvZGF0ZS1hcHBlYXJhbmNlLWRlZmF1bHRWYWx1ZS1leHBlY3RlZC5odG1sCkBAIC0w LDAgKzEsNSBAQAorPGh0bWw+Cis8Ym9keT4KKzxpbnB1dCB0eXBlPSJkYXRlIiB2YWx1ZT0iMjAw NS0wNi0wNyI+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL2RhdGUvZGF0ZS1hcHBlYXJhbmNlLWRlZmF1bHRWYWx1ZS5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy9kYXRlL2RhdGUtYXBwZWFyYW5jZS1kZWZhdWx0VmFsdWUuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi5jYjE4MGE3YmQxNmM1ZmIxNjVhNjNhM2QwNTI1M2ZmMDllNjZkNzBmCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kYXRlL2RhdGUtYXBwZWFyYW5jZS1k ZWZhdWx0VmFsdWUuaHRtbApAQCAtMCwwICsxLDkgQEAKKzwhLS0gVGhpcyB0ZXN0cyB0aGF0IHNl dHRpbmcgZGVmYXVsdFZhbHVlIHZpYSBzY3JpcHQgaXMgcmVmbGVjdGVkIGluIHRoZSBVSS4gU2Vl IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU5ODIgLS0+Cis8aHRt bD4KKzxib2R5PgorPGlucHV0IHR5cGU9ImRhdGUiPgorPHNjcmlwdD4KK2RvY3VtZW50LnF1ZXJ5 U2VsZWN0b3IoJ2lucHV0JykuZGVmYXVsdFZhbHVlID0gJzIwMDUtMDYtMDcnCis8L3NjcmlwdD4K KzwvYm9keT4KKzwvaHRtbD4K