185973 2018-05-24 22:01:36 -0700 ProcessLauncherMac.mm contains a couple of meaningless #ifndef directives 2018-05-25 21:26:28 -0700 1 1 1 Unclassified WebKit WebKit2 Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz andersca darin thorton webkit-bug-importer oldest_to_newest 1427183 0 mitz 2018-05-24 22:01:36 -0700 #ifndef _NDEBUG is always true because no configuration ever defines _NDEBUG. Patch forthcoming. 1427187 1 341252 mitz 2018-05-24 22:03:43 -0700 Created attachment 341252 Use #if !ASSERT_DISABLED instead 1427188 2 mitz 2018-05-24 22:09:47 -0700 Fixed in <https://trac.webkit.org/r232184>. 1427189 3 webkit-bug-importer 2018-05-24 22:10:18 -0700 <rdar://problem/40546223> 1427668 4 darin 2018-05-25 21:26:28 -0700 Glad you took care of this. I was planning to ask how _NDEBUG was getting set after spotting it in a patch. 341252 2018-05-24 22:03:43 -0700 2018-05-24 22:07:41 -0700 Use #if !ASSERT_DISABLED instead bug-185973-20180524220342.patch text/plain 1956 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzIxODMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA1LTI0ICBEYW4gQmVybnN0 ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUHJvY2Vzc0xhdW5jaGVyTWFjLm1tIGNv bnRhaW5zIGEgY291cGxlIG9mIG1lYW5pbmdsZXNzICNpZm5kZWYgZGlyZWN0aXZlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1OTczCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1 bmNoZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vz c0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKTogVXNlICNpZiAhQVNTRVJUX0RJU0FCTEVEIHRvIGd1 YXJkIHN0YXRlbWVudHMgdGhhdAorICAgICAgICAgIGFyZSBvbmx5IG5lZWRlZCBmb3IgYW4gYXNz ZXJ0aW9uLCBpbnN0ZWFkIG9mICNpZm5kZWYgX05ERUJVRywgd2hpY2ggaXMgYWx3YXlzIHRydWUu CisKIDIwMTgtMDUtMjQgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBNZW1vcnkgcHJlc3N1cmUgbW9uaXRvciBkb2Vz bid0IHJlbGlhYmxlIG5vdGlmeSBhbGwgdGhlIHN1YnByb2Nlc3NlcwpJbmRleDogU291cmNlL1dl YktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5j aGVyTWFjLm1tCShyZXZpc2lvbiAyMzIxODEpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9M YXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMTIs NyArMjEyLDcgQEAgdm9pZCBQcm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MoKQogICAgICAg ICBpZiAoIXByb2Nlc3NMYXVuY2hlci0+aXNMYXVuY2hpbmcoKSkKICAgICAgICAgICAgIHJldHVy bjsKIAotI2lmbmRlZiBfTkRFQlVHCisjaWYgIUFTU0VSVF9ESVNBQkxFRAogICAgICAgICBtYWNo X3BvcnRfdXJlZnNfdCBzZW5kUmlnaHRDb3VudCA9IDA7CiAgICAgICAgIG1hY2hfcG9ydF9nZXRf cmVmcyhtYWNoX3Rhc2tfc2VsZigpLCBsaXN0ZW5pbmdQb3J0LCBNQUNIX1BPUlRfUklHSFRfU0VO RCwgJnNlbmRSaWdodENvdW50KTsKICAgICAgICAgQVNTRVJUKHNlbmRSaWdodENvdW50ID49IDEp OwpAQCAtMjQ5LDcgKzI0OSw3IEBAIHZvaWQgUHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNz KCkKICAgICAgICAgICAgIEFTU0VSVCh4cGNfZ2V0X3R5cGUocmVwbHkpID09IFhQQ19UWVBFX0RJ Q1RJT05BUlkpOwogICAgICAgICAgICAgQVNTRVJUKCFzdHJjbXAoeHBjX2RpY3Rpb25hcnlfZ2V0 X3N0cmluZyhyZXBseSwgIm1lc3NhZ2UtbmFtZSIpLCAicHJvY2Vzcy1maW5pc2hlZC1sYXVuY2hp bmciKSk7CiAKLSNpZm5kZWYgX05ERUJVRworI2lmICFBU1NFUlRfRElTQUJMRUQKICAgICAgICAg ICAgIG1hY2hfcG9ydF91cmVmc190IHNlbmRSaWdodENvdW50ID0gMDsKICAgICAgICAgICAgIG1h Y2hfcG9ydF9nZXRfcmVmcyhtYWNoX3Rhc2tfc2VsZigpLCBsaXN0ZW5pbmdQb3J0LCBNQUNIX1BP UlRfUklHSFRfU0VORCwgJnNlbmRSaWdodENvdW50KTsKICAgICAgICAgICAgIEFTU0VSVChzZW5k UmlnaHRDb3VudCA+PSAxKTsK