185966 2018-05-24 16:42:37 -0700 [iOS] Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text 2018-05-24 18:59:21 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez beidson commit-queue dbates ews-watchlist ggaren japhet koivisto rniwa webkit-bug-importer youennf oldest_to_newest 1427096 0 cdumez 2018-05-24 16:42:37 -0700 Avoid dlopening QuickLooks in the common case where the main resource is HTML or plain text: Sample Count, Samples %, CPU %, Symbol 33, 0.3%, 0.2%, void IPC::handleMessage<Messages::WebResourceLoader::DidReceiveResponse, WebKit::WebResourceLoader, void (WebKit::WebResourceLoader::*)(WebCore::ResourceResponse const&, bool)>(IPC::Decoder&, WebKit::WebResourceLoader*, void (WebKit::WebResourceLoader::*)(WebCore::ResourceResponse const&, bool)) (in WebKit) 33, 0.3%, 0.2%, WebKit::WebResourceLoader::didReceiveResponse(WebCore::ResourceResponse const&, bool) (in WebKit) 32, 0.3%, 0.2%, WebCore::SubresourceLoader::didReceiveResponse(WebCore::ResourceResponse const&, WTF::CompletionHandler<void ()>&&) (in WebCore) 26, 0.2%, 0.1%, WebCore::PreviewLoader::shouldCreateForMIMEType(WTF::String const&) (in WebCore) 26, 0.2%, 0.1%, std::__1::__call_once(unsigned long volatile&, void*, void (*)(void*)) (in libc++.1.dylib) 26, 0.2%, 0.1%, void std::__1::__call_once_proxy<std::__1::tuple<WebCore::PreviewLoader::shouldCreateForMIMEType(WTF::String const&)::$_2&&> >(void*) (in WebCore) 26, 0.2%, 0.1%, WebCore::QLPreviewGetSupportedMIMETypesSet() (in WebCore) 26, 0.2%, 0.1%, WebCore::initQuickLookQLPreviewGetSupportedMIMETypes() (in WebCore) 26, 0.2%, 0.1%, dispatch_once_f$VARIANT$mp (in libdispatch.dylib) 26, 0.2%, 0.1%, _dispatch_client_callout (in libdispatch.dylib) 26, 0.2%, 0.1%, invocation function for block in WebCore::initQuickLookQLPreviewGetSupportedMIMETypes() (in WebCore) 26, 0.2%, 0.1%, dispatch_once_f$VARIANT$mp (in libdispatch.dylib) 26, 0.2%, 0.1%, _dispatch_client_callout (in libdispatch.dylib) 26, 0.2%, 0.1%, invocation function for block in WebCore::QuickLookLibrary(bool) (in WebCore) 26, 0.2%, 0.1%, dlopen (in libdyld.dylib) 26, 0.2%, 0.1%, dlopen_internal (in dyld) 1427101 1 341233 cdumez 2018-05-24 16:44:56 -0700 Created attachment 341233 Patch 1427120 2 341233 ggaren 2018-05-24 17:18:06 -0700 Comment on attachment 341233 Patch r=me 1427143 3 341233 commit-queue 2018-05-24 18:58:20 -0700 Comment on attachment 341233 Patch Clearing flags on attachment: 341233 Committed r232179: <https://trac.webkit.org/changeset/232179> 1427144 4 commit-queue 2018-05-24 18:58:22 -0700 All reviewed patches have been landed. Closing bug. 1427147 5 webkit-bug-importer 2018-05-24 18:59:21 -0700 <rdar://problem/40542935> 341233 2018-05-24 16:44:56 -0700 2018-05-24 18:58:20 -0700 Patch bug-185966-20180524164455.patch text/plain 1613 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTNkYjFhMWZkOGJlNjIw YmY0YzNhOTliOTE4ODBmZGRmOTc2MjYwMS4uMTNkZTA3YTlkMjgwMmEyNWRiZGZkY2ViN2MyYWU4 YzI5YTllOGU4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA1LTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQXZvaWQgZGxvcGVu aW5nIFF1aWNrTG9va3MgaW4gdGhlIGNvbW1vbiBjYXNlIHdoZXJlIHRoZSBtYWluIHJlc291cmNl IGlzIEhUTUwgb3IgcGxhaW4gdGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg1OTY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQXZvaWQgZGxvcGVuaW5nIFF1aWNrTG9va3MgaW4gdGhlIGNvbW1vbiBj YXNlIHdoZXJlIHRoZSBtYWluIHJlc291cmNlIGlzIEhUTUwgb3IgcGxhaW4gdGV4dAorICAgICAg ICBmb3IgcGVyZm9ybWFuY2UgcmVhc29ucy4KKworICAgICAgICAqIGxvYWRlci9pb3MvUHJldmll d0xvYWRlci5tbToKKyAgICAgICAgKFdlYkNvcmU6OlByZXZpZXdMb2FkZXI6OnNob3VsZENyZWF0 ZUZvck1JTUVUeXBlKToKKwogMjAxOC0wNS0yNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgogCiAgICAgICAgIFJlZHVjZSBjb3B5aW5nIG9mIEZvbnRDYXNjYWRlRGVzY3JpcHRpb24g b2JqZWN0cyBieSBtb3ZpbmcgdGhlbSBhcm91bmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9pb3MvUHJldmlld0xvYWRlci5tbSBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pb3Mv UHJldmlld0xvYWRlci5tbQppbmRleCA5NTMzNGNjMmVlMDFlMTAxNWE0YjIwY2U4NDg3NDBmYzE3 MzVkZjRhLi42NmMwYzllMzY2YjIxNDExMGIwYjY3MjFiYTNlYmU0MDk4NDUxNTE2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvaW9zL1ByZXZpZXdMb2FkZXIubW0KKysrIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL2lvcy9QcmV2aWV3TG9hZGVyLm1tCkBAIC0yNDMsNiArMjQzLDkg QEAgUHJldmlld0xvYWRlcjo6flByZXZpZXdMb2FkZXIoKQogCiBib29sIFByZXZpZXdMb2FkZXI6 OnNob3VsZENyZWF0ZUZvck1JTUVUeXBlKGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCiB7CisgICAg aWYgKGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKG1pbWVUeXBlLCAidGV4dC9odG1sIikg fHwgZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UobWltZVR5cGUsICJ0ZXh0L3BsYWluIikp CisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxhZyBvbmNl RmxhZzsKICAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8SGFzaFNldDxTdHJpbmcsIEFTQ0lJQ2Fz ZUluc2Vuc2l0aXZlSGFzaD4+IHN1cHBvcnRlZE1JTUVUeXBlczsKICAgICBzdGQ6OmNhbGxfb25j ZShvbmNlRmxhZywgW10gewo=