185955 2018-05-24 12:46:54 -0700 REGRESSION(r224908): [macOS] Media playback not honoring custom caption styles 2018-05-24 13:33:24 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 179747 1 bfulgham bfulgham commit-queue eric.carlson oldest_to_newest 1427025 0 bfulgham 2018-05-24 12:46:54 -0700 In Bug 179747 I removed access to the MediaAccessibility mach port, as well as read/write access to various preferences associated with that process, as it was no longer needed by modern WebKit media routines. Detailed testing reveals that read access is still needed to these preferences to properly handle custom caption styles. This patch re-enables access to the media accessibility preferences. 1427027 1 bfulgham 2018-05-24 12:48:17 -0700 <rdar://problem/40339278> 1427028 2 341217 bfulgham 2018-05-24 12:52:09 -0700 Created attachment 341217 Patch 1427042 3 341217 commit-queue 2018-05-24 13:33:23 -0700 Comment on attachment 341217 Patch Clearing flags on attachment: 341217 Committed r232162: <https://trac.webkit.org/changeset/232162> 1427043 4 commit-queue 2018-05-24 13:33:24 -0700 All reviewed patches have been landed. Closing bug. 341217 2018-05-24 12:52:09 -0700 2018-05-24 13:33:23 -0700 Patch bug-185955-20180524125209.patch text/plain 1829 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI4ZWRjMTIxZmIxNWE4ZjBl YjJkNTVhNjliY2RiZDVkMGNjMzYwZTMuLmE2YTIzMGMzNjZkNjY1ZmI0YzUyOTMyNWM4MDQwNzc3 ZDRjZTcwMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDUtMjQgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjI0OTA4 KTogW21hY09TXSBNZWRpYSBwbGF5YmFjayBub3QgaG9ub3JpbmcgY3VzdG9tIGNhcHRpb24gc3R5 bGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU5 NTUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQwMzM5Mjc4PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIyMjQ5MDggSSByZW1vdmVkIGFjY2Vz cyB0byB0aGUgTWVkaWFBY2Nlc3NpYmlsaXR5IG1hY2ggcG9ydCwgYXMgd2VsbCBhcworICAgICAg ICByZWFkL3dyaXRlIGFjY2VzcyB0byB2YXJpb3VzIHByZWZlcmVuY2VzIGFzc29jaWF0ZWQgd2l0 aCB0aGF0IHByb2Nlc3MsIGFzIGl0CisgICAgICAgIHdhcyBubyBsb25nZXIgbmVlZGVkIGJ5IG1v ZGVybiBXZWJLaXQgbWVkaWEgcm91dGluZXMuCisKKyAgICAgICAgRGV0YWlsZWQgdGVzdGluZyBy ZXZlYWxzIHRoYXQgcmVhZCBhY2Nlc3MgaXMgc3RpbGwgbmVlZGVkIHRvIHRoZXNlIHByZWZlcmVu Y2VzCisgICAgICAgIHRvIHByb3Blcmx5IGhhbmRsZSBjdXN0b20gY2FwdGlvbiBzdHlsZXMuCisK KyAgICAgICAgVGhpcyBwYXRjaCByZS1lbmFibGVzIGFjY2VzcyB0byB0aGUgbWVkaWEgYWNjZXNz aWJpbGl0eSBwcmVmZXJlbmNlcy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvY29tLmFwcGxlLldl YlByb2Nlc3Muc2IuaW46CisKIDIwMTgtMDUtMjMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgogCiAgICAgICAgIE5ldHdvcmtMb2FkQ2hlY2tlciBzaG91bGQgY2hlY2sgY2FjaGVk IHJlZGlyZWN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5h cHBsZS5XZWJQcm9jZXNzLnNiLmluIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBs ZS5XZWJQcm9jZXNzLnNiLmluCmluZGV4IDgzM2I1MThmM2NmNzRiOTIxMjA5M2QzNTMzMWI3MTI3 ZjI2NWRiN2IuLjI0YzNhZWM5M2Y4YmFhNmExOTUzNmM4MWE5MThlZTI1NjgzMWExYTcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5p bgorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2Iu aW4KQEAgLTQ3Nyw2ICs0NzcsNyBAQAogICAgICAgICAiY29tLmFwcGxlLmRyaXZlci5BcHBsZUJs dWV0b290aE11bHRpdG91Y2gudHJhY2twYWQiCiAgICAgICAgICJjb20uYXBwbGUuZHJpdmVyLkFw cGxlSElETW91c2UiCiAgICAgICAgICJjb20uYXBwbGUubG9va3VwLnNoYXJlZCIKKyAgICAgICAg ImNvbS5hcHBsZS5tZWRpYWFjY2Vzc2liaWxpdHkiIDs7IE5lZWRlZCBmb3IgY3VzdG9tIGNhcHRp b24gc3R5bGVzCiAgICAgICAgICJjb20uYXBwbGUubmV0d29ya0Nvbm5lY3QiCiAgICAgICAgICJj b20uYXBwbGUuc3BlZWNoLnZvaWNlLnByZWZzIgogICAgICAgICAiY29tLmFwcGxlLnN5c3RlbXNv dW5kIgo=