185954 2018-05-24 12:35:02 -0700 [negative result] speed up resolveRopeSlowCase8 by inlining the worklist 2018-05-24 12:35:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED WONTFIX P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 1427021 0 fpizlo 2018-05-24 12:35:02 -0700 ... 1427022 1 341216 fpizlo 2018-05-24 12:35:24 -0700 Created attachment 341216 the patch 1427023 2 fpizlo 2018-05-24 12:35:34 -0700 This wasn't a speed-up. 341216 2018-05-24 12:35:24 -0700 2018-05-24 12:35:24 -0700 the patch blah.patch text/plain 7196 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5jcHAJKHJldmlz aW9uIDIzMjEzMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMSw3ICsxLDcgQEAKIC8qCiAgKiAgQ29weXJpZ2h0IChDKSAx OTk5LTIwMDIgSGFycmkgUG9ydGVuIChwb3J0ZW5Aa2RlLm9yZykKICAqICBDb3B5cmlnaHQgKEMp IDIwMDEgUGV0ZXIgS2VsbHkgKHBta0Bwb3N0LmNvbSkKLSAqICBDb3B5cmlnaHQgKEMpIDIwMDQt MjAxNyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiAgQ29weXJpZ2h0IChDKSAy MDA0LTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqICBUaGlzIGxp YnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAg KiAgbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQ dWJsaWMKQEAgLTI4NiwzNSArMjg2LDkyIEBAIHZvaWQgSlNSb3BlU3RyaW5nOjpyZXNvbHZlUm9w ZShFeGVjU3RhdGUKICAgICBBU1NFUlQoIWlzUm9wZSgpKTsKIH0KIAotLy8gT3ZlcnZpZXc6IFRo ZXNlIGZ1bmN0aW9ucyBjb252ZXJ0IGEgSlNTdHJpbmcgZnJvbSBob2xkaW5nIGEgc3RyaW5nIGlu IHJvcGUgZm9ybQotLy8gZG93biB0byBhIHNpbXBsZSBTdHJpbmcgcmVwcmVzZW50YXRpb24uIEl0 IGRvZXMgc28gYnkgYnVpbGRpbmcgdXAgdGhlIHN0cmluZwotLy8gYmFja3dhcmRzLCBzaW5jZSB3 ZSB3YW50IHRvIGF2b2lkIHJlY3Vyc2lvbiwgd2UgZXhwZWN0IHRoYXQgdGhlIHRyZWUgc3RydWN0 dXJlCi0vLyByZXByZXNlbnRpbmcgdGhlIHJvcGUgaXMgbGlrZWx5IGltYmFsYW5jZWQgd2l0aCBt b3JlIG5vZGVzIGRvd24gdGhlIGxlZnQgc2lkZQotLy8gKHNpbmNlIGFwcGVuZGluZyB0byB0aGUg c3RyaW5nIGlzIGxpa2VseSBtb3JlIGNvbW1vbikgLSBhbmQgYXMgc3VjaCByZXNvbHZpbmcKLS8v IGluIHRoaXMgZmFzaGlvbiBzaG91bGQgbWluaW1pemUgd29yayBxdWV1ZSBzaXplLiAgKElmIHdl IGJ1aWx0IHRoZSBxdWV1ZSBmb3J3YXJkcwotLy8gd2Ugd291bGQgbGlrZWx5IGhhdmUgdG8gcGxh Y2UgYWxsIG9mIHRoZSBjb25zdGl0dWVudCBTdHJpbmdJbXBscyBpbnRvIHRoZQotLy8gVmVjdG9y IGJlZm9yZSBwZXJmb3JtaW5nIGFueSBjb25jYXRlbmF0aW9uLCBidXQgYnkgd29ya2luZyBiYWNr d2FyZHMgd2UgbGlrZWx5Ci0vLyBvbmx5IGZpbGwgdGhlIHF1ZXVlIHdpdGggdGhlIG51bWJlciBv ZiBzdWJzdHJpbmdzIGF0IGFueSBnaXZlbiBsZXZlbCBpbiBhCi0vLyByb3BlLW9mLXJvcGVzLikK LXZvaWQgSlNSb3BlU3RyaW5nOjpyZXNvbHZlUm9wZVNsb3dDYXNlOChMQ2hhciogYnVmZmVyKSBj b25zdAotewotICAgIExDaGFyKiBwb3NpdGlvbiA9IGJ1ZmZlciArIGxlbmd0aCgpOyAvLyBXZSB3 aWxsIGJlIHdvcmtpbmcgYmFja3dhcmRzIG92ZXIgdGhlIHJvcGUuCi0gICAgVmVjdG9yPEpTU3Ry aW5nKiwgMzIsIFVuc2FmZVZlY3Rvck92ZXJmbG93PiB3b3JrUXVldWU7IC8vIFB1dHRpbmcgc3Ry aW5ncyBpbnRvIGEgVmVjdG9yIGlzIG9ubHkgT0sgYmVjYXVzZSB0aGVyZSBhcmUgbm8gR0MgcG9p bnRzIGluIHRoaXMgbWV0aG9kLgorY2xhc3MgSlNSb3BlU3RyaW5nOjpGYXN0UmVzb2x2aW5nV29y a2xpc3QgeworcHVibGljOgorICAgIHN0YXRpYyBjb25zdGV4cHIgdW5zaWduZWQgY2FwYWNpdHkg PSAzMjsKICAgICAKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHNfbWF4SW50ZXJuYWxSb3Bl TGVuZ3RoICYmIGZpYmVyKGkpOyArK2kpCi0gICAgICAgIHdvcmtRdWV1ZS5hcHBlbmQoZmliZXIo aSkuZ2V0KCkpOworICAgIEFMV0FZU19JTkxJTkUgRmFzdFJlc29sdmluZ1dvcmtsaXN0KCkKKyAg ICB7CisgICAgfQorICAgIAorICAgIEFMV0FZU19JTkxJTkUgdm9pZCBwdXNoVW5jaGVja2VkKEpT U3RyaW5nKiBzdHJpbmcpCisgICAgeworICAgICAgICBBU1NFUlQobV9zaXplIDwgY2FwYWNpdHkp OworICAgICAgICBtX3N0cmluZ3NbbV9zaXplKytdID0gc3RyaW5nOworICAgIH0KKyAgICAKKyAg ICBBTFdBWVNfSU5MSU5FIGJvb2wgcHVzaChKU1N0cmluZyogc3RyaW5nKQorICAgIHsKKyAgICAg ICAgaWYgKG1fc2l6ZSA9PSBjYXBhY2l0eSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICAgICAgbV9zdHJpbmdzW21fc2l6ZSsrXSA9IHN0cmluZzsKKyAgICAgICAgcmV0dXJuIHRydWU7 CisgICAgfQorICAgIAorICAgIEFMV0FZU19JTkxJTkUgSlNTdHJpbmcqIHBvcCgpCisgICAgewor ICAgICAgICBpZiAoIW1fc2l6ZSkKKyAgICAgICAgICAgIHJldHVybiBudWxscHRyOworICAgICAg ICByZXR1cm4gbV9zdHJpbmdzWy0tbV9zaXplXTsKKyAgICB9CisgICAgCisgICAgQUxXQVlTX0lO TElORSB1bnNpZ25lZCBzaXplKCkgY29uc3QgeyByZXR1cm4gbV9zaXplOyB9CisgICAgCisgICAg QUxXQVlTX0lOTElORSBKU1N0cmluZyogb3BlcmF0b3JbXSh1bnNpZ25lZCBpKSBjb25zdCB7IHJl dHVybiBtX3N0cmluZ3NbaV07IH0KKyAgICAKK3ByaXZhdGU6CisgICAgSlNTdHJpbmcqIG1fc3Ry aW5nc1tjYXBhY2l0eV07CisgICAgdW5zaWduZWQgbV9zaXplIHsgMCB9OworfTsKIAotICAgIHdo aWxlICghd29ya1F1ZXVlLmlzRW1wdHkoKSkgewotICAgICAgICBKU1N0cmluZyogY3VycmVudEZp YmVyID0gd29ya1F1ZXVlLmxhc3QoKTsKLSAgICAgICAgd29ya1F1ZXVlLnJlbW92ZUxhc3QoKTsK K2NsYXNzIEpTUm9wZVN0cmluZzo6U2xvd1Jlc29sdmluZ1dvcmtsaXN0IHsKK3B1YmxpYzoKKyAg ICBBTFdBWVNfSU5MSU5FIFNsb3dSZXNvbHZpbmdXb3JrbGlzdChjb25zdCBGYXN0UmVzb2x2aW5n V29ya2xpc3QmIG90aGVyV29ya2xpc3QsIEpTU3RyaW5nKiBhbm90aGVyU3RyaW5nKQorICAgIHsK KyAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG90aGVyV29ya2xpc3Quc2l6ZSgpOyAr K2kpCisgICAgICAgICAgICBtX3ZlY3Rvci5hcHBlbmQob3RoZXJXb3JrbGlzdFtpXSk7CisgICAg ICAgIG1fdmVjdG9yLmFwcGVuZChhbm90aGVyU3RyaW5nKTsKKyAgICB9CisgICAgCisgICAgU2xv d1Jlc29sdmluZ1dvcmtsaXN0KGNvbnN0IFNsb3dSZXNvbHZpbmdXb3JrbGlzdCYsIEpTU3RyaW5n KikKKyAgICB7CisgICAgICAgIFVOUkVBQ0hBQkxFX0ZPUl9QTEFURk9STSgpOworICAgIH0KKyAg ICAKKyAgICBBTFdBWVNfSU5MSU5FIGJvb2wgcHVzaChKU1N0cmluZyogc3RyaW5nKQorICAgIHsK KyAgICAgICAgbV92ZWN0b3IuYXBwZW5kKHN0cmluZyk7CisgICAgICAgIHJldHVybiB0cnVlOwor ICAgIH0KKyAgICAKKyAgICBBTFdBWVNfSU5MSU5FIEpTU3RyaW5nKiBwb3AoKQorICAgIHsKKyAg ICAgICAgaWYgKG1fdmVjdG9yLmlzRW1wdHkoKSkKKyAgICAgICAgICAgIHJldHVybiBudWxscHRy OworICAgICAgICByZXR1cm4gbV92ZWN0b3IudGFrZUxhc3QoKTsKKyAgICB9CisKK3ByaXZhdGU6 CisgICAgVmVjdG9yPEpTU3RyaW5nKiwgRmFzdFJlc29sdmluZ1dvcmtsaXN0OjpjYXBhY2l0eSAq IDIsIFVuc2FmZVZlY3Rvck92ZXJmbG93PiBtX3ZlY3RvcjsgLy8gUHV0dGluZyBzdHJpbmdzIGlu dG8gYSBWZWN0b3IgaXMgb25seSBPSyBiZWNhdXNlIHRoZXJlIGFyZSBubyBHQyBwb2ludHMgaW4g dGhpcyBtZXRob2QuCit9OwogCit0ZW1wbGF0ZTx0eXBlbmFtZSBXb3JrbGlzdFR5cGU+CitBTFdB WVNfSU5MSU5FIHZvaWQgSlNSb3BlU3RyaW5nOjpyZXNvbHZlUm9wZVNsb3dDYXNlOEdlbmVyaWMo TENoYXIqJiBwb3NpdGlvbiwgV29ya2xpc3RUeXBlJiB3b3JrbGlzdCkgY29uc3QKK3sKKyAgICB3 aGlsZSAoSlNTdHJpbmcqIGN1cnJlbnRGaWJlciA9IHdvcmtsaXN0LnBvcCgpKSB7CiAgICAgICAg IGNvbnN0IExDaGFyKiBjaGFyYWN0ZXJzOwogICAgICAgICAKICAgICAgICAgaWYgKGN1cnJlbnRG aWJlci0+aXNSb3BlKCkpIHsKICAgICAgICAgICAgIEpTUm9wZVN0cmluZyogY3VycmVudEZpYmVy QXNSb3BlID0gc3RhdGljX2Nhc3Q8SlNSb3BlU3RyaW5nKj4oY3VycmVudEZpYmVyKTsKICAgICAg ICAgICAgIGlmICghY3VycmVudEZpYmVyQXNSb3BlLT5pc1N1YnN0cmluZygpKSB7Ci0gICAgICAg ICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzX21heEludGVybmFsUm9wZUxlbmd0aCAm JiBjdXJyZW50RmliZXJBc1JvcGUtPmZpYmVyKGkpOyArK2kpCi0gICAgICAgICAgICAgICAgICAg IHdvcmtRdWV1ZS5hcHBlbmQoY3VycmVudEZpYmVyQXNSb3BlLT5maWJlcihpKS5nZXQoKSk7Cisg ICAgICAgICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzX21heEludGVybmFsUm9wZUxl bmd0aCAmJiBjdXJyZW50RmliZXJBc1JvcGUtPmZpYmVyKGkpOyArK2kpIHsKKyAgICAgICAgICAg ICAgICAgICAgSlNTdHJpbmcqIGFub3RoZXJTdHJpbmcgPSBjdXJyZW50RmliZXJBc1JvcGUtPmZp YmVyKGkpLmdldCgpOworICAgICAgICAgICAgICAgICAgICBpZiAoVU5MSUtFTFkoIXdvcmtsaXN0 LnB1c2goYW5vdGhlclN0cmluZykpKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBTbG93UmVz b2x2aW5nV29ya2xpc3Qgc2xvd1dvcmtsaXN0KHdvcmtsaXN0LCBhbm90aGVyU3RyaW5nKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgIHJlc29sdmVSb3BlU2xvd0Nhc2U4R2VuZXJpYyhwb3NpdGlv biwgc2xvd1dvcmtsaXN0KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAg ICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBjb250 aW51ZTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIEFTU0VSVCghY3VycmVudEZpYmVyQXNS b3BlLT5zdWJzdHJpbmdCYXNlKCktPmlzUm9wZSgpKTsKQEAgLTMyOCw3ICszODUsMjggQEAgdm9p ZCBKU1JvcGVTdHJpbmc6OnJlc29sdmVSb3BlU2xvd0Nhc2U4KAogICAgICAgICBwb3NpdGlvbiAt PSBsZW5ndGg7CiAgICAgICAgIFN0cmluZ0ltcGw6OmNvcHlDaGFyYWN0ZXJzKHBvc2l0aW9uLCBj aGFyYWN0ZXJzLCBsZW5ndGgpOwogICAgIH0KK30KKworLy8gT3ZlcnZpZXc6IFRoZXNlIGZ1bmN0 aW9ucyBjb252ZXJ0IGEgSlNTdHJpbmcgZnJvbSBob2xkaW5nIGEgc3RyaW5nIGluIHJvcGUgZm9y bQorLy8gZG93biB0byBhIHNpbXBsZSBTdHJpbmcgcmVwcmVzZW50YXRpb24uIEl0IGRvZXMgc28g YnkgYnVpbGRpbmcgdXAgdGhlIHN0cmluZworLy8gYmFja3dhcmRzLCBzaW5jZSB3ZSB3YW50IHRv IGF2b2lkIHJlY3Vyc2lvbiwgd2UgZXhwZWN0IHRoYXQgdGhlIHRyZWUgc3RydWN0dXJlCisvLyBy ZXByZXNlbnRpbmcgdGhlIHJvcGUgaXMgbGlrZWx5IGltYmFsYW5jZWQgd2l0aCBtb3JlIG5vZGVz IGRvd24gdGhlIGxlZnQgc2lkZQorLy8gKHNpbmNlIGFwcGVuZGluZyB0byB0aGUgc3RyaW5nIGlz IGxpa2VseSBtb3JlIGNvbW1vbikgLSBhbmQgYXMgc3VjaCByZXNvbHZpbmcKKy8vIGluIHRoaXMg ZmFzaGlvbiBzaG91bGQgbWluaW1pemUgd29yayBxdWV1ZSBzaXplLiAgKElmIHdlIGJ1aWx0IHRo ZSBxdWV1ZSBmb3J3YXJkcworLy8gd2Ugd291bGQgbGlrZWx5IGhhdmUgdG8gcGxhY2UgYWxsIG9m IHRoZSBjb25zdGl0dWVudCBTdHJpbmdJbXBscyBpbnRvIHRoZQorLy8gVmVjdG9yIGJlZm9yZSBw ZXJmb3JtaW5nIGFueSBjb25jYXRlbmF0aW9uLCBidXQgYnkgd29ya2luZyBiYWNrd2FyZHMgd2Ug bGlrZWx5CisvLyBvbmx5IGZpbGwgdGhlIHF1ZXVlIHdpdGggdGhlIG51bWJlciBvZiBzdWJzdHJp bmdzIGF0IGFueSBnaXZlbiBsZXZlbCBpbiBhCisvLyByb3BlLW9mLXJvcGVzLikKK3ZvaWQgSlNS b3BlU3RyaW5nOjpyZXNvbHZlUm9wZVNsb3dDYXNlOChMQ2hhciogYnVmZmVyKSBjb25zdAorewor ICAgIExDaGFyKiBwb3NpdGlvbiA9IGJ1ZmZlciArIGxlbmd0aCgpOyAvLyBXZSB3aWxsIGJlIHdv cmtpbmcgYmFja3dhcmRzIG92ZXIgdGhlIHJvcGUuCisgICAgRmFzdFJlc29sdmluZ1dvcmtsaXN0 IHdvcmtsaXN0OwogCisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzX21heEludGVybmFsUm9w ZUxlbmd0aCAmJiBmaWJlcihpKTsgKytpKQorICAgICAgICB3b3JrbGlzdC5wdXNoVW5jaGVja2Vk KGZpYmVyKGkpLmdldCgpKTsKKworICAgIHJlc29sdmVSb3BlU2xvd0Nhc2U4R2VuZXJpYyhwb3Np dGlvbiwgd29ya2xpc3QpOworICAgIAogICAgIEFTU0VSVChidWZmZXIgPT0gcG9zaXRpb24pOwog fQogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmgJKHJldmlz aW9uIDIzMjEzMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmgJ KHdvcmtpbmcgY29weSkKQEAgLTQyMSw2ICs0MjEsMTAgQEAgcHJpdmF0ZToKICAgICBKU19FWFBP UlRfUFJJVkFURSB2b2lkIHJlc29sdmVSb3BlKEV4ZWNTdGF0ZSopIGNvbnN0OwogICAgIEpTX0VY UE9SVF9QUklWQVRFIHZvaWQgcmVzb2x2ZVJvcGVUb0F0b21pY1N0cmluZyhFeGVjU3RhdGUqKSBj b25zdDsKICAgICBKU19FWFBPUlRfUFJJVkFURSBSZWZQdHI8QXRvbWljU3RyaW5nSW1wbD4gcmVz b2x2ZVJvcGVUb0V4aXN0aW5nQXRvbWljU3RyaW5nKEV4ZWNTdGF0ZSopIGNvbnN0OworICAgIHRl bXBsYXRlPHR5cGVuYW1lIFdvcmtsaXN0VHlwZT4KKyAgICB2b2lkIHJlc29sdmVSb3BlU2xvd0Nh c2U4R2VuZXJpYyhMQ2hhciomLCBXb3JrbGlzdFR5cGUmKSBjb25zdDsKKyAgICBjbGFzcyBGYXN0 UmVzb2x2aW5nV29ya2xpc3Q7CisgICAgY2xhc3MgU2xvd1Jlc29sdmluZ1dvcmtsaXN0OwogICAg IHZvaWQgcmVzb2x2ZVJvcGVTbG93Q2FzZTgoTENoYXIqKSBjb25zdDsKICAgICB2b2lkIHJlc29s dmVSb3BlU2xvd0Nhc2UoVUNoYXIqKSBjb25zdDsKICAgICB2b2lkIG91dE9mTWVtb3J5KEV4ZWNT dGF0ZSopIGNvbnN0Owo=