<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>185952</bug_id>
          
          <creation_ts>2018-05-24 10:43:10 -0700</creation_ts>
          <short_desc>Cache navigator.userAgent for performance</short_desc>
          <delta_ts>2018-07-25 10:58:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>188009</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1426979</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-05-24 10:43:10 -0700</bug_when>
    <thetext>Cache navigator.userAgent for performance. We currently ask the client 5 times while loading apple.com.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1426985</commentid>
    <comment_count>1</comment_count>
      <attachid>341207</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-05-24 10:51:43 -0700</bug_when>
    <thetext>Created attachment 341207
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1427005</commentid>
    <comment_count>2</comment_count>
      <attachid>341207</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2018-05-24 11:40:27 -0700</bug_when>
    <thetext>Comment on attachment 341207
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1427013</commentid>
    <comment_count>3</comment_count>
      <attachid>341207</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-05-24 12:23:19 -0700</bug_when>
    <thetext>Comment on attachment 341207
Patch

Clearing flags on attachment: 341207

Committed r232159: &lt;https://trac.webkit.org/changeset/232159&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1427014</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-05-24 12:23:21 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1427016</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-05-24 12:24:24 -0700</bug_when>
    <thetext>&lt;rdar://problem/40530246&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>341207</attachid>
            <date>2018-05-24 10:51:43 -0700</date>
            <delta_ts>2018-05-24 12:23:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-185952-20180524105143.patch</filename>
            <type>text/plain</type>
            <size>5167</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODk0YWU3MDBhZjlkNjEw
ZGE3NDdlYzc1NjA5MzZlMjQ0YjdlNGM3NS4uM2JjOGEwMzYwODkxN2U0MWI1YjZmZTgxNjdlZWRm
NWVlOThjOTkxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA1LTI0ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FjaGUgbmF2aWdhdG9yLnVz
ZXJBZ2VudCBmb3IgcGVyZm9ybWFuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTE4NTk1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIENhY2hlIG5hdmlnYXRvci51c2VyQWdlbnQgZm9yIHBlcmZvcm1hbmNl
LiBQcmV2aW91c2x5LCB3ZSB3b3VsZCBhc2sgdGhlIGNsaWVudCA1IHRpbWVzCisgICAgICAgIHdo
aWxlIGxvYWRpbmcgYXBwbGUuY29tLgorCisgICAgICAgICogcGFnZS9OYXZpZ2F0b3IuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6TmF2aWdhdG9yOjp1c2VyQWdlbnQgY29uc3QpOgorICAgICAgICAq
IHBhZ2UvTmF2aWdhdG9yLmg6CisgICAgICAgICogcGFnZS9OYXZpZ2F0b3JCYXNlLmg6CisgICAg
ICAgICogcGFnZS9OYXZpZ2F0b3JJRC5pZGw6CisgICAgICAgICogcGFnZS9Xb3JrZXJOYXZpZ2F0
b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyTmF2aWdhdG9yOjp1c2VyQWdlbnQgY29u
c3QpOgorICAgICAgICAqIHBhZ2UvV29ya2VyTmF2aWdhdG9yLmg6CisKIDIwMTgtMDUtMjMgIENo
cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5kZXJMYXllcjo6c2Ny
b2xsUmVjdFRvVmlzaWJsZSgpIHNob3VsZCBub3QgcHJvcGFnYXRlIGEgc3ViZnJhbWUncyBzY3Jv
bGwgdG8gaXRzIGNyb3NzLW9yaWdpbiBwYXJlbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L3BhZ2UvTmF2aWdhdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmNwcApp
bmRleCAzMGU0MGVjYTYxZTExNTNiMWExYTQ1ZmUwZjRiOTcwOTE1ZWJkNWNiLi45YThkMjY4Yzg4
MTdiMzViNDAzNjlkYzJhYzZlMDM5NDA4YWJmMzBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9wYWdlL05hdmlnYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0b3Iu
Y3BwCkBAIC03NywxNyArNzcsMTEgQEAgU3RyaW5nIE5hdmlnYXRvcjo6YXBwVmVyc2lvbigpIGNv
bnN0CiAgICAgcmV0dXJuIGFwcFZlcnNpb247CiB9CiAKLVN0cmluZyBOYXZpZ2F0b3I6OnVzZXJB
Z2VudCgpIGNvbnN0Citjb25zdCBTdHJpbmcmIE5hdmlnYXRvcjo6dXNlckFnZW50KCkgY29uc3QK
IHsKLSAgICBpZiAoIW1fZnJhbWUpCi0gICAgICAgIHJldHVybiBTdHJpbmcoKTsKLQotICAgIC8v
IElmIHRoZSBmcmFtZSBpcyBhbHJlYWR5IGRldGFjaGVkLCBGcmFtZUxvYWRlcjo6dXNlckFnZW50
IG1heSBtYWxmdW5jdGlvbiwgYmVjYXVzZSBpdCBjYWxscyBhIGNsaWVudCBtZXRob2QKLSAgICAv
LyB0aGF0IHVzZXMgZnJhbWUncyBXZWJWaWV3IChhdCBsZWFzdCwgaW4gTWFjIFdlYktpdCkuCi0g
ICAgaWYgKCFtX2ZyYW1lLT5wYWdlKCkpCi0gICAgICAgIHJldHVybiBTdHJpbmcoKTsKLQotICAg
IHJldHVybiBtX2ZyYW1lLT5sb2FkZXIoKS51c2VyQWdlbnQobV9mcmFtZS0+ZG9jdW1lbnQoKS0+
dXJsKCkpOworICAgIGlmIChtX3VzZXJBZ2VudC5pc051bGwoKSAmJiBtX2ZyYW1lICYmIG1fZnJh
bWUtPnBhZ2UoKSkKKyAgICAgICAgbV91c2VyQWdlbnQgPSBtX2ZyYW1lLT5sb2FkZXIoKS51c2Vy
QWdlbnQobV9mcmFtZS0+ZG9jdW1lbnQoKS0+dXJsKCkpOworICAgIHJldHVybiBtX3VzZXJBZ2Vu
dDsKIH0KIAogYm9vbCBOYXZpZ2F0b3I6Om9uTGluZSgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0
b3IuaAppbmRleCA4MDhiZDY3NDgwYjljZDVkZGY3ZjliOGQwMjc1OThiOWYyN2QxMDIzLi4xODE2
ZTNhNTZkMWQ3YzIxMTAyY2VhMjZiN2ViNjY1ODEyMzk5N2NhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9wYWdlL05hdmlnYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdh
dG9yLmgKQEAgLTM5LDcgKzM5LDcgQEAgcHVibGljOgogICAgIERPTU1pbWVUeXBlQXJyYXkmIG1p
bWVUeXBlcygpOwogICAgIGJvb2wgY29va2llRW5hYmxlZCgpIGNvbnN0OwogICAgIGJvb2wgamF2
YUVuYWJsZWQoKSBjb25zdDsKLSAgICBTdHJpbmcgdXNlckFnZW50KCkgY29uc3QgZmluYWw7Cisg
ICAgY29uc3QgU3RyaW5nJiB1c2VyQWdlbnQoKSBjb25zdCBmaW5hbDsKICAgICBib29sIG9uTGlu
ZSgpIGNvbnN0IGZpbmFsOwogICAgIAogI2lmIFBMQVRGT1JNKElPUykKQEAgLTUzLDYgKzUzLDcg
QEAgcHJpdmF0ZToKIAogICAgIG11dGFibGUgUmVmUHRyPERPTVBsdWdpbkFycmF5PiBtX3BsdWdp
bnM7CiAgICAgbXV0YWJsZSBSZWZQdHI8RE9NTWltZVR5cGVBcnJheT4gbV9taW1lVHlwZXM7Cisg
ICAgbXV0YWJsZSBTdHJpbmcgbV91c2VyQWdlbnQ7CiB9OwogCiB9CmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvckJhc2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2
aWdhdG9yQmFzZS5oCmluZGV4IDgzOGQyMDAyZTc3ZmMzNjg5NTEwZWEyMTIyYTNkYmQwMzVkYTVh
MGEuLjcwMTVjMzg1N2E1ZjJiOWNkY2U1NzlhMDYzNTllMmVkZjkwNTI3ZmUgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yQmFzZS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L3BhZ2UvTmF2aWdhdG9yQmFzZS5oCkBAIC00Miw3ICs0Miw3IEBAIHB1YmxpYzoKIAogICAgIHN0
YXRpYyBTdHJpbmcgYXBwTmFtZSgpOwogICAgIFN0cmluZyBhcHBWZXJzaW9uKCkgY29uc3Q7Ci0g
ICAgdmlydHVhbCBTdHJpbmcgdXNlckFnZW50KCkgY29uc3QgPSAwOworICAgIHZpcnR1YWwgY29u
c3QgU3RyaW5nJiB1c2VyQWdlbnQoKSBjb25zdCA9IDA7CiAgICAgc3RhdGljIFN0cmluZyBwbGF0
Zm9ybSgpOwogCiAgICAgc3RhdGljIFN0cmluZyBhcHBDb2RlTmFtZSgpOwpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0b3JJRC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl
L05hdmlnYXRvcklELmlkbAppbmRleCA1Nzk2N2NlNWMxODNiNjZkMzE4OTE5YzI2OWNjMzUzOWMw
ZDU3M2UxLi5mNmIxNGZhZWZjMzNiYzVkMDA1MDIwODQwMmM3NWVlY2M3YTY0MzgzIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvcklELmlkbAorKysgYi9Tb3VyY2UvV2Vi
Q29yZS9wYWdlL05hdmlnYXRvcklELmlkbApAQCAtMzUsNyArMzUsNyBAQAogICAgIHJlYWRvbmx5
IGF0dHJpYnV0ZSBET01TdHJpbmcgcGxhdGZvcm07CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIERP
TVN0cmluZyBwcm9kdWN0OwogICAgIFtFeHBvc2VkPVdpbmRvd10gcmVhZG9ubHkgYXR0cmlidXRl
IERPTVN0cmluZyBwcm9kdWN0U3ViOwotICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcg
dXNlckFnZW50OworICAgIFtDYWNoZWRBdHRyaWJ1dGVdIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01T
dHJpbmcgdXNlckFnZW50OwogICAgIFtFeHBvc2VkPVdpbmRvd10gcmVhZG9ubHkgYXR0cmlidXRl
IERPTVN0cmluZyB2ZW5kb3I7CiAgICAgW0V4cG9zZWQ9V2luZG93XSByZWFkb25seSBhdHRyaWJ1
dGUgRE9NU3RyaW5nIHZlbmRvclN1YjsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w
YWdlL1dvcmtlck5hdmlnYXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1dvcmtlck5hdmln
YXRvci5jcHAKaW5kZXggMWEzNjhmNjhiMGM3ZTgxYTM0ODQ4NDEwOTQxYWVkOGJhZDk5NGE2OS4u
YjQ5NjRjNTExYmFhZDFkMWRkNjYwMzU3YTQ3NzdhYzkwNzBhMDRjMiAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvcGFnZS9Xb3JrZXJOYXZpZ2F0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L3BhZ2UvV29ya2VyTmF2aWdhdG9yLmNwcApAQCAtMzYsNyArMzYsNyBAQCBXb3JrZXJOYXZpZ2F0
b3I6Oldvcmtlck5hdmlnYXRvcihTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0LCBjb25z
dCBTdHJpbmcmCiB7CiB9CiAKLVN0cmluZyBXb3JrZXJOYXZpZ2F0b3I6OnVzZXJBZ2VudCgpIGNv
bnN0Citjb25zdCBTdHJpbmcmIFdvcmtlck5hdmlnYXRvcjo6dXNlckFnZW50KCkgY29uc3QKIHsK
ICAgICByZXR1cm4gbV91c2VyQWdlbnQ7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w
YWdlL1dvcmtlck5hdmlnYXRvci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Xb3JrZXJOYXZpZ2F0
b3IuaAppbmRleCA5YmVkNWY3YjM5YTkwNGFkNGJhMjNhY2VjYmJhMDRkZjVkMWNhMmI1Li40NWVj
ZjY2YzdkMjBjODJiZDUyY2Y1NWQxZmI5NGE4YzMyYjRiNDUwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9wYWdlL1dvcmtlck5hdmlnYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv
V29ya2VyTmF2aWdhdG9yLmgKQEAgLTM1LDcgKzM1LDcgQEAgY2xhc3MgV29ya2VyTmF2aWdhdG9y
IGZpbmFsIDogcHVibGljIE5hdmlnYXRvckJhc2UsIHB1YmxpYyBTdXBwbGVtZW50YWJsZTxXb3Jr
ZXIKIHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPFdvcmtlck5hdmlnYXRvcj4gY3JlYXRlKFNjcmlw
dEV4ZWN1dGlvbkNvbnRleHQmIGNvbnRleHQsIGNvbnN0IFN0cmluZyYgdXNlckFnZW50LCBib29s
IGlzT25saW5lKSB7IHJldHVybiBhZG9wdFJlZigqbmV3IFdvcmtlck5hdmlnYXRvcihjb250ZXh0
LCB1c2VyQWdlbnQsIGlzT25saW5lKSk7IH0KIAotICAgIFN0cmluZyB1c2VyQWdlbnQoKSBjb25z
dCBmaW5hbDsKKyAgICBjb25zdCBTdHJpbmcmIHVzZXJBZ2VudCgpIGNvbnN0IGZpbmFsOwogICAg
IGJvb2wgb25MaW5lKCkgY29uc3QgZmluYWw7CiAgICAgdm9pZCBzZXRJc09ubGluZShib29sIGlz
T25saW5lKSB7IG1faXNPbmxpbmUgPSBpc09ubGluZTsgfQogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>