185944 2018-05-24 06:10:21 -0700 [MIPS] Fix build on MIPS32r1 2018-05-30 07:14:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dominik.infuehr webkit-unassigned achristensen benjamin cdumez cmarcelo commit-queue dbates ews-watchlist fpizlo ggaren jiewen_tan keith_miller loic.yhuel mark.lam msaboff olivier.blin saam webkit-bug-importer ysuzuki oldest_to_newest 1426910 0 dominik.infuehr 2018-05-24 06:10:21 -0700 [MIPS] Fix build on MIPS32r1 1426912 1 341185 dominik.infuehr 2018-05-24 06:15:24 -0700 Created attachment 341185 Patch 1426934 2 loic.yhuel 2018-05-24 08:40:06 -0700 This looks ok, and builds fine. Here are the different cases I can think of : - -march=mips32 -mfp32 : mtc1/mfc1, OK - -march=mips32 -mfpxx (so __mips_isa_rev == 1, __mips_fpr == 0) : "as" would fail with "Error: float register should be even, was xx" (the only way would be to an intermediate memory transfer). Nothing changes here, so I think no one uses this configuration so it's fine if WebKit doesn't support it. - -march=mips32r2 -mfp32 : mfhc1 and mthc1 are used even if not necessary, but this isn't an issue - -march=mips32r2 -mfpxx : mfhc1 and mthc1, OK - -mfp64 : gcc already ensures mfhc1 and mthc1 are available 1427279 3 olivier.blin 2018-05-25 07:41:57 -0700 I confirm it builds fine on a MIPS32r1 target, and jsc runs correctly too. 1428398 4 341185 ysuzuki 2018-05-30 06:46:31 -0700 Comment on attachment 341185 Patch r=me 1428402 5 341185 commit-queue 2018-05-30 07:13:27 -0700 Comment on attachment 341185 Patch Clearing flags on attachment: 341185 Committed r232290: <https://trac.webkit.org/changeset/232290> 1428403 6 commit-queue 2018-05-30 07:13:29 -0700 All reviewed patches have been landed. Closing bug. 1428405 7 webkit-bug-importer 2018-05-30 07:14:24 -0700 <rdar://problem/40649432> 341185 2018-05-24 06:15:24 -0700 2018-05-30 07:13:27 -0700 Patch bug-185944-20180524151523.patch text/plain 3503 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NDI4NTBiMTI0Yjk1ZjA2YmVkMjhhZTQ5NGM2YzZkMmQ4OWI5ZmM3Li45OTVmNWJiNDgwNTIzODYx ZGFkMTA0MTRlYjUxYzBjZDJmMjUyZmIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wNS0yNCAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlh LmNvbT4KKworICAgICAgICBbTUlQU10gRml4IGJ1aWxkIG9uIE1JUFMzMnIxCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU5NDQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IHVzZSBpbnN0cnVjdGlv bnMgb24gTUlQUzMycjIgb3IgbGF0ZXIuIG10aGMxIGFuZCBtZmhjMSBhcmUgbm90IHN1cHBvcnRl ZAorICAgICAgICBvbiBNSVBTMzJyMS4KKworICAgICAgICAqIG9mZmxpbmVhc20vbWlwcy5yYjoK KwogMjAxOC0wNS0yMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAog ICAgICAgICBbSlNDXSBDbGVhbiB1cCBzdHJpbmdHZXRCeVZhbFN0dWJHZW5lcmF0b3IKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXgg MWM2NjdkMGE0Y2U5OTY0YTQwZDE1ZWVkZGI3MWQxYjEzMjRhNTQ5OC4uYTdiNzEzOTY0MmExYTE2 MTg4MjhhNjc1ZmVlZTJiNTg2ZWEzMDljMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0wNS0y NCAgRG9taW5payBJbmZ1ZWhyICA8ZGluZnVlaHJAaWdhbGlhLmNvbT4KKworICAgICAgICBbTUlQ U10gRml4IGJ1aWxkIG9uIE1JUFMzMnIxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODU5NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGRlZCBXVEZfTUlQU19JU0FfUkVWX0FUX0xFQVNUIHRvIHRlc3Qg Zm9yIGNlcnRhaW4gcmVsZWFzZSBvciBsYXRlci4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5o OgorCiAyMDE4LTA1LTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBTdHJpbmdJbXBsIHV0ZjggY29udmVyc2lvbiBzaG91bGQgbm90IGZhaWwgc2lsZW50bHkuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJiIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYgppbmRleCAzMmVlYTVhZDFhN2Q2 MGM4MDIwYTEwMTRlMTdmMjBlMWI3NjczY2MyLi5kZjE5YzZiYTAzZTE1OWZjYjkzMzlkZjFlZjgy MDRiYWEyMTAyYTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFz bS9taXBzLnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIK QEAgLTEwMTQsMTAgKzEwMTQsMTggQEAgY2xhc3MgSW5zdHJ1Y3Rpb24KICAgICAgICAgICAgICRh c20ucHV0cyAic3cgI3tvcGVyYW5kc1sxXS5taXBzT3BlcmFuZH0sICN7b3BlcmFuZHNbMF0udmFs dWUgKiA0fSgkc3ApIgogICAgICAgICB3aGVuICJmaWkyZCIKICAgICAgICAgICAgICRhc20ucHV0 cyAibXRjMSAje29wZXJhbmRzWzBdLm1pcHNPcGVyYW5kfSwgI3tvcGVyYW5kc1syXS5taXBzU2lu Z2xlTG99IgorICAgICAgICAgICAgJGFzbS5wdXRTdHIoIiNpZiBXVEZfTUlQU19JU0FfUkVWX0FU X0xFQVNUKDIpIikKICAgICAgICAgICAgICRhc20ucHV0cyAibXRoYzEgI3tvcGVyYW5kc1sxXS5t aXBzT3BlcmFuZH0sICN7b3BlcmFuZHNbMl0ubWlwc1NpbmdsZUxvfSIKKyAgICAgICAgICAgICRh c20ucHV0U3RyKCIjZWxzZSIpCisgICAgICAgICAgICAkYXNtLnB1dHMgIm10YzEgI3tvcGVyYW5k c1sxXS5taXBzT3BlcmFuZH0sICN7b3BlcmFuZHNbMl0ubWlwc1NpbmdsZUhpfSIKKyAgICAgICAg ICAgICRhc20ucHV0U3RyKCIjZW5kaWYiKQogICAgICAgICB3aGVuICJmZDJpaSIKICAgICAgICAg ICAgICRhc20ucHV0cyAibWZjMSAje29wZXJhbmRzWzFdLm1pcHNPcGVyYW5kfSwgI3tvcGVyYW5k c1swXS5taXBzU2luZ2xlTG99IgorICAgICAgICAgICAgJGFzbS5wdXRTdHIoIiNpZiBXVEZfTUlQ U19JU0FfUkVWX0FUX0xFQVNUKDIpIikKICAgICAgICAgICAgICRhc20ucHV0cyAibWZoYzEgI3tv cGVyYW5kc1syXS5taXBzT3BlcmFuZH0sICN7b3BlcmFuZHNbMF0ubWlwc1NpbmdsZUxvfSIKKyAg ICAgICAgICAgICRhc20ucHV0U3RyKCIjZWxzZSIpCisgICAgICAgICAgICAkYXNtLnB1dHMgIm1m YzEgI3tvcGVyYW5kc1syXS5taXBzT3BlcmFuZH0sICN7b3BlcmFuZHNbMF0ubWlwc1NpbmdsZUhp fSIKKyAgICAgICAgICAgICRhc20ucHV0U3RyKCIjZW5kaWYiKQogICAgICAgICB3aGVuIC9eYm8v CiAgICAgICAgICAgICAkYXNtLnB1dHMgImJndCAje29wZXJhbmRzWzBdLm1pcHNPcGVyYW5kfSwg I3tvcGVyYW5kc1sxXS5taXBzT3BlcmFuZH0sICN7b3BlcmFuZHNbMl0uYXNtTGFiZWx9IgogICAg ICAgICB3aGVuIC9eYnMvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIv U291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCBjN2QwY2EwMGZiZjAxNmY1ODJjMjNjMWFl N2RlMGUyOGM5ZWM4NzhjLi5lOTE5Njg1YjY5ZmNhNzkzYWY0NTI0MzA3OTFkYzRiNDNhYmM2ZGRj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYv d3RmL1BsYXRmb3JtLmgKQEAgLTc0LDYgKzc0LDcgQEAKICNkZWZpbmUgV1RGX01JUFNfSVNBX0FU X0xFQVNUKHYpIChkZWZpbmVkIFdURl9NSVBTX0FSQ0ggJiYgV1RGX01JUFNfQVJDSCA+PSB2KQog I2RlZmluZSBXVEZfTUlQU19BUkNIX1JFViBfX21pcHNfaXNhX3JldgogI2RlZmluZSBXVEZfTUlQ U19JU0FfUkVWKHYpIChkZWZpbmVkIFdURl9NSVBTX0FSQ0hfUkVWICYmIFdURl9NSVBTX0FSQ0hf UkVWID09IHYpCisjZGVmaW5lIFdURl9NSVBTX0lTQV9SRVZfQVRfTEVBU1QodikgKGRlZmluZWQg V1RGX01JUFNfQVJDSF9SRVYgJiYgV1RGX01JUFNfQVJDSF9SRVYgPj0gdikKICNkZWZpbmUgV1RG X01JUFNfRE9VQkxFX0ZMT0FUIChkZWZpbmVkIF9fbWlwc19oYXJkX2Zsb2F0ICYmICFkZWZpbmVk IF9fbWlwc19zaW5nbGVfZmxvYXQpCiAjZGVmaW5lIFdURl9NSVBTX0ZQNjQgKGRlZmluZWQgX19t aXBzX2ZwciAmJiBfX21pcHNfZnByID09IDY0KQogLyogTUlQUyByZXF1aXJlcyBhbGxvY2F0b3Jz IHRvIHVzZSBhbGlnbmVkIG1lbW9yeSAqLwo=