185896 2018-05-22 17:49:02 -0700 BytecodeGeneratorification shouldn't add a ValueProfile if the JIT is disabled. 2018-05-22 20:12:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset saam webkit-bug-importer oldest_to_newest 1426428 0 mark.lam 2018-05-22 17:49:02 -0700 Patch coming. 1426429 1 webkit-bug-importer 2018-05-22 17:49:29 -0700 <rdar://problem/40471403> 1426430 2 341052 mark.lam 2018-05-22 17:54:11 -0700 Created attachment 341052 proposed patch. 1426466 3 mark.lam 2018-05-22 20:12:18 -0700 Thanks for the review. Landed in r232100: <http://trac.webkit.org/r232100>. 341052 2018-05-22 17:54:11 -0700 2018-05-22 18:03:39 -0700 proposed patch. bug-185896.patch text/plain 2734 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzIwOTMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA1LTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBCeXRlY29kZUdlbmVyYXRvcmlmaWNhdGlvbiBzaG91bGRuJ3QgYWRkIGEg VmFsdWVQcm9maWxlIGlmIHRoZSBKSVQgaXMgZGlzYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU4OTYKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzQwNDcxNDAzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogc3RyZXNzL3JlZ3Jlc3MtMTg1ODk2LmpzOiBBZGRlZC4KKwogMjAxOC0wNS0yMiAg WXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbSlNDXSBG aXggQ2FjaGVkQ2FsbCdzIGFyZ3VtZW50IGNvdW50IGlmIFJlZ0V4cCBoYXMgbmFtZWQgY2FwdHVy ZXMKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg1ODk2LmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg1ODk2LmpzCShub25leGlzdGVudCkKKysrIEpTVGVz dHMvc3RyZXNzL3JlZ3Jlc3MtMTg1ODk2LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTQg QEAKK3ZhciBleGNlcHRpb247CitmdW5jdGlvbiogaXRlbXMoKSB7CisgICAgeWllbGQgeyB9Owor ICAgIHlpZWxkKiA0MjsKK30KKwordHJ5IHsKKyAgICBmb3IgKGxldCBpIG9mIGl0ZW1zKCkpIHsg fQorfSBjYXRjaCAoZSkgeworICAgIGV4Y2VwdGlvbiA9IGU7Cit9CisKK2lmIChleGNlcHRpb24g IT0gIlR5cGVFcnJvcjogdW5kZWZpbmVkIGlzIG5vdCBhIGZ1bmN0aW9uIChuZWFyICcuLi55aWVs ZCogNDIuLi4nKSIpCisgICAgdGhyb3cgRkFJTEVEOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbiAyMzIwODkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDUtMjIgIE1hcmsgTGFtICA8 bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIEJ5dGVjb2RlR2VuZXJhdG9yaWZpY2F0aW9u IHNob3VsZG4ndCBhZGQgYSBWYWx1ZVByb2ZpbGUgaWYgdGhlIEpJVCBpcyBkaXNhYmxlZC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTg5NgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNDA0NzE0MDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBieXRlY29kZS9CeXRlY29kZUdlbmVyYXRvcmlmaWNh dGlvbi5jcHA6CisgICAgICAgIChKU0M6OkJ5dGVjb2RlR2VuZXJhdG9yaWZpY2F0aW9uOjpydW4p OgorCiAyMDE4LTA1LTIyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBTdHJpbmdJbXBsIHV0ZjggY29udmVyc2lvbiBzaG91bGQgbm90IGZhaWwgc2lsZW50bHkuCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQnl0ZWNvZGVHZW5lcmF0b3JpZmlj YXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9C eXRlY29kZUdlbmVyYXRvcmlmaWNhdGlvbi5jcHAJKHJldmlzaW9uIDIzMjA4NykKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9CeXRlY29kZUdlbmVyYXRvcmlmaWNhdGlvbi5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTIyOSw3ICsyMjksOSBAQCB2b2lkIEJ5dGVjb2RlR2VuZXJhdG9y aWZpY2F0aW9uOjpydW4oKQogICAgICAgICAgICAgICAgIFZpcnR1YWxSZWdpc3RlciBvcGVyYW5k ID0gdmlydHVhbFJlZ2lzdGVyRm9yTG9jYWwoaW5kZXgpOwogICAgICAgICAgICAgICAgIFN0b3Jh Z2Ugc3RvcmFnZSA9IHN0b3JhZ2VGb3JHZW5lcmF0b3JMb2NhbChpbmRleCk7CiAKLSAgICAgICAg ICAgICAgICBVbmxpbmtlZFZhbHVlUHJvZmlsZSBwcm9maWxlID0gbV9jb2RlQmxvY2stPmFkZFZh bHVlUHJvZmlsZSgpOworICAgICAgICAgICAgICAgIFVubGlua2VkVmFsdWVQcm9maWxlIHByb2Zp bGUgPSBtX2NvZGVCbG9jay0+dm0oKS0+Y2FuVXNlSklUKCkKKyAgICAgICAgICAgICAgICAgICAg PyBtX2NvZGVCbG9jay0+YWRkVmFsdWVQcm9maWxlKCkKKyAgICAgICAgICAgICAgICAgICAgOiBz dGF0aWNfY2FzdDxVbmxpbmtlZFZhbHVlUHJvZmlsZT4oLTEpOwogICAgICAgICAgICAgICAgIGZy YWdtZW50LmFwcGVuZEluc3RydWN0aW9uKAogICAgICAgICAgICAgICAgICAgICBvcF9nZXRfZnJv bV9zY29wZSwKICAgICAgICAgICAgICAgICAgICAgb3BlcmFuZC5vZmZzZXQoKSwgLy8gZHN0Cg==