185867 2018-05-22 06:25:37 -0700 [GTK] WebDriver: Network process crash when running imported/w3c/webdriver/tests/delete_cookie/delete.py::test_unknown_cookie 2018-05-22 08:10:09 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=185866 Gtk P2 Normal --- 1 cgarcia webkit-unassigned bburg berto bugs-noreply ews-watchlist gustavo mcatanzaro oldest_to_newest 1426128 0 cgarcia 2018-05-22 06:25:37 -0700 webkitpy.webdriver_tests.webdriver_w3c_executor: [DEBUG] (WebKitWebDriver:21620): (process:21647): libsoup-CRITICAL **: 15:18:04.117: soup_cookie_jar_get_cookie_list: assertion 'uri != NULL' failed webkitpy.webdriver_tests.webdriver_w3c_executor: [DEBUG] (WebKitWebDriver:21620): RemoteInspectorServer failed to send DBus message: The connection is closed We need to null check the value returned by URL::createSoupURI() before passing it to soup. 1426130 1 340979 cgarcia 2018-05-22 06:28:00 -0700 Created attachment 340979 Patch 1426159 2 cgarcia 2018-05-22 08:10:09 -0700 Committed r232066: <https://trac.webkit.org/changeset/232066> 340979 2018-05-22 06:28:00 -0700 2018-05-22 07:41:05 -0700 Patch wd-network-process-crash.diff text/plain 4129 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNWY2ZjhmZmUxNC4uZjdiMTJlMDg4NzQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0wNS0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gV2ViRHJpdmVyOiBOZXR3b3JrIHByb2Nlc3MgY3Jh c2ggd2hlbiBydW5uaW5nIGltcG9ydGVkL3czYy93ZWJkcml2ZXIvdGVzdHMvZGVsZXRlX2Nvb2tp ZS9kZWxldGUucHk6OnRlc3RfdW5rbm93bl9jb29raWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTg2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIG5lZWQgdG8gbnVsbCBjaGVjayB0aGUgdmFsdWUg cmV0dXJuZWQgYnkgVVJMOjpjcmVhdGVTb3VwVVJJKCkgYmVmb3JlIHBhc3NpbmcgaXQgdG8gc291 cC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OnNldENvb2tpZXNGcm9tRE9NKToKKyAgICAgICAgKFdlYkNvcmU6 OmNvb2tpZXNGb3JTZXNzaW9uKToKKyAgICAgICAgKFdlYkNvcmU6OmdldFJhd0Nvb2tpZXMpOgor ICAgICAgICAoV2ViQ29yZTo6ZGVsZXRlQ29va2llKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvTmV0d29ya1N0b3JhZ2VTZXNzaW9uU291cC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpOZXR3b3JrU3RvcmFnZVNlc3Npb246OmdldENvb2tpZXMpOgorCiAyMDE4LTA1LTIxICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFVzZSBtb3JlIEMr KzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29v a2llSmFyU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29v a2llSmFyU291cC5jcHAKaW5kZXggOWMwOTEyZTZiNDkuLmY0OTQwOWE3ZjNiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL0Nvb2tpZUphclNvdXAu Y3BwCkBAIC01NSwxMiArNTUsMTYgQEAgdm9pZCBzZXRDb29raWVzRnJvbURPTShjb25zdCBOZXR3 b3JrU3RvcmFnZVNlc3Npb24mIHNlc3Npb24sIGNvbnN0IFVSTCYgZmlyc3RQYXIKIHsKICAgICBV TlVTRURfUEFSQU0oZnJhbWVJRCk7CiAgICAgVU5VU0VEX1BBUkFNKHBhZ2VJRCk7Ci0gICAgU291 cENvb2tpZUphciogamFyID0gc2Vzc2lvbi5jb29raWVTdG9yYWdlKCk7Ci0KICAgICBHVW5pcXVl UHRyPFNvdXBVUkk+IG9yaWdpbiA9IHVybC5jcmVhdGVTb3VwVVJJKCk7CisgICAgaWYgKCFvcmln aW4pCisgICAgICAgIHJldHVybjsKKwogICAgIEdVbmlxdWVQdHI8U291cFVSST4gZmlyc3RQYXJ0 eVVSSSA9IGZpcnN0UGFydHkuY3JlYXRlU291cFVSSSgpOworICAgIGlmICghZmlyc3RQYXJ0eVVS SSkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gR2V0IGV4aXN0aW5nIGNvb2tpZXMgZm9yIHRo aXMgb3JpZ2luLgorICAgIFNvdXBDb29raWVKYXIqIGphciA9IHNlc3Npb24uY29va2llU3RvcmFn ZSgpOwogICAgIEdTTGlzdCogZXhpc3RpbmdDb29raWVzID0gc291cF9jb29raWVfamFyX2dldF9j b29raWVfbGlzdChqYXIsIG9yaWdpbi5nZXQoKSwgVFJVRSk7CiAKICAgICBWZWN0b3I8U3RyaW5n PiBjb29raWVzOwpAQCAtODgsNiArOTIsOSBAQCB2b2lkIHNldENvb2tpZXNGcm9tRE9NKGNvbnN0 IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYgc2Vzc2lvbiwgY29uc3QgVVJMJiBmaXJzdFBhcgogc3Rh dGljIHN0ZDo6cGFpcjxTdHJpbmcsIGJvb2w+IGNvb2tpZXNGb3JTZXNzaW9uKGNvbnN0IE5ldHdv cmtTdG9yYWdlU2Vzc2lvbiYgc2Vzc2lvbiwgY29uc3QgVVJMJiB1cmwsIGJvb2wgZm9ySFRUUEhl YWRlciwgSW5jbHVkZVNlY3VyZUNvb2tpZXMgaW5jbHVkZVNlY3VyZUNvb2tpZXMpCiB7CiAgICAg R1VuaXF1ZVB0cjxTb3VwVVJJPiB1cmkgPSB1cmwuY3JlYXRlU291cFVSSSgpOworICAgIGlmICgh dXJpKQorICAgICAgICByZXR1cm4geyB7IH0sIGZhbHNlIH07CisKICAgICBHU0xpc3QqIGNvb2tp ZXMgPSBzb3VwX2Nvb2tpZV9qYXJfZ2V0X2Nvb2tpZV9saXN0KHNlc3Npb24uY29va2llU3RvcmFn ZSgpLCB1cmkuZ2V0KCksIGZvckhUVFBIZWFkZXIpOwogICAgIGJvb2wgZGlkQWNjZXNzU2VjdXJl Q29va2llcyA9IGZhbHNlOwogCkBAIC0xNTQsNiArMTYxLDkgQEAgYm9vbCBnZXRSYXdDb29raWVz KGNvbnN0IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYgc2Vzc2lvbiwgY29uc3QgVVJMJiBmaXJzdFBh cnR5LAogICAgIFVOVVNFRF9QQVJBTShwYWdlSUQpOwogICAgIHJhd0Nvb2tpZXMuY2xlYXIoKTsK ICAgICBHVW5pcXVlUHRyPFNvdXBVUkk+IHVyaSA9IHVybC5jcmVhdGVTb3VwVVJJKCk7CisgICAg aWYgKCF1cmkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIEdVbmlxdWVQdHI8R1NMaXN0 PiBjb29raWVzKHNvdXBfY29va2llX2phcl9nZXRfY29va2llX2xpc3Qoc2Vzc2lvbi5jb29raWVT dG9yYWdlKCksIHVyaS5nZXQoKSwgVFJVRSkpOwogICAgIGlmICghY29va2llcykKICAgICAgICAg cmV0dXJuIGZhbHNlOwpAQCAtMTc5LDkgKzE4OSwxMSBAQCBib29sIGdldFJhd0Nvb2tpZXMoY29u c3QgTmV0d29ya1N0b3JhZ2VTZXNzaW9uJiBzZXNzaW9uLCBjb25zdCBVUkwmIGZpcnN0UGFydHks CiAKIHZvaWQgZGVsZXRlQ29va2llKGNvbnN0IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYgc2Vzc2lv biwgY29uc3QgVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgbmFtZSkKIHsKLSAgICBTb3VwQ29va2ll SmFyKiBqYXIgPSBzZXNzaW9uLmNvb2tpZVN0b3JhZ2UoKTsKLQogICAgIEdVbmlxdWVQdHI8U291 cFVSST4gdXJpID0gdXJsLmNyZWF0ZVNvdXBVUkkoKTsKKyAgICBpZiAoIXVyaSkKKyAgICAgICAg cmV0dXJuOworCisgICAgU291cENvb2tpZUphciogamFyID0gc2Vzc2lvbi5jb29raWVTdG9yYWdl KCk7CiAgICAgR1VuaXF1ZVB0cjxHU0xpc3Q+IGNvb2tpZXMoc291cF9jb29raWVfamFyX2dldF9j b29raWVfbGlzdChqYXIsIHVyaS5nZXQoKSwgVFJVRSkpOwogICAgIGlmICghY29va2llcykKICAg ICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9zb3VwL05ldHdvcmtTdG9yYWdlU2Vzc2lvblNvdXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9zb3VwL05ldHdvcmtTdG9yYWdlU2Vzc2lvblNvdXAuY3BwCmluZGV4IDQx MWI5Y2Q0YTZiLi4zNDFmYWZlY2FkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9zb3VwL05ldHdvcmtTdG9yYWdlU2Vzc2lvblNvdXAuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9OZXR3b3JrU3RvcmFnZVNlc3Npb25Tb3Vw LmNwcApAQCAtMzE4LDYgKzMxOCw5IEBAIFZlY3RvcjxDb29raWU+IE5ldHdvcmtTdG9yYWdlU2Vz c2lvbjo6Z2V0Q29va2llcyhjb25zdCBVUkwmIHVybCkKIHsKICAgICBWZWN0b3I8Q29va2llPiBj b29raWVzOwogICAgIEdVbmlxdWVQdHI8U291cFVSST4gdXJpID0gdXJsLmNyZWF0ZVNvdXBVUkko KTsKKyAgICBpZiAoIXVyaSkKKyAgICAgICAgcmV0dXJuIGNvb2tpZXM7CisKICAgICBHVW5pcXVl UHRyPEdTTGlzdD4gY29va2llc0xpc3Qoc291cF9jb29raWVfamFyX2dldF9jb29raWVfbGlzdChj b29raWVTdG9yYWdlKCksIHVyaS5nZXQoKSwgVFJVRSkpOwogICAgIGZvciAoR1NMaXN0KiBpdGVt ID0gY29va2llc0xpc3QuZ2V0KCk7IGl0ZW07IGl0ZW0gPSBnX3NsaXN0X25leHQoaXRlbSkpIHsK ICAgICAgICAgR1VuaXF1ZVB0cjxTb3VwQ29va2llPiBzb3VwQ29va2llKHN0YXRpY19jYXN0PFNv dXBDb29raWUqPihpdGVtLT5kYXRhKSk7Cg==