185865 2018-05-22 05:42:24 -0700 Fix build without MathML 2018-05-22 07:47:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 olivier.blin webkit-unassigned commit-queue fpizlo fred.wang koivisto mcatanzaro simon.fraser webkit-bug-importer zalan zan oldest_to_newest 1426116 0 olivier.blin 2018-05-22 05:42:24 -0700 Build without ENABLE(MATHML) fails. Regression(r226654): [RenderTreeBuilder] Move MathML addChild logic to RenderTreeBuilder https://bugs.webkit.org/show_bug.cgi?id=181443 Regression(r229694): Put the DOM in IsoHeaps https://bugs.webkit.org/show_bug.cgi?id=183546 1426118 1 340976 olivier.blin 2018-05-22 05:43:53 -0700 Created attachment 340976 Patch 1426122 2 olivier.blin 2018-05-22 05:54:22 -0700 You may want to know if it is still worth maintaining this MathML build flag. On an ARMv7 platform, disabling MathML allows to save 242,148 bytes over a library of 27,063,644 bytes, that's about 1% of the size. 1426140 3 340976 mcatanzaro 2018-05-22 07:19:45 -0700 Comment on attachment 340976 Patch Sigh, I think it's OK even without exposing the MATHML build flag for WPE, because none of the code is platform-specific. 1426141 4 mcatanzaro 2018-05-22 07:20:41 -0700 (In reply to Olivier Blin from comment #2) > You may want to know if it is still worth maintaining this MathML build flag. > > On an ARMv7 platform, disabling MathML allows to save 242,148 bytes over a > library of 27,063,644 bytes, that's about 1% of the size. And yes, if you didn't have this analysis to prove it's significant, we would have probably started to talk about that. 1426148 5 340976 commit-queue 2018-05-22 07:46:47 -0700 Comment on attachment 340976 Patch Clearing flags on attachment: 340976 Committed r232064: <https://trac.webkit.org/changeset/232064> 1426149 6 commit-queue 2018-05-22 07:46:49 -0700 All reviewed patches have been landed. Closing bug. 1426150 7 webkit-bug-importer 2018-05-22 07:47:15 -0700 <rdar://problem/40450626> 340976 2018-05-22 05:43:53 -0700 2018-05-22 07:46:47 -0700 Patch bug-185865-20180522144352.patch text/plain 6291 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTVmNmY4ZmZlMTQwYzA0 MGZhMDAxNzc0ZTQyZTdiYjRhZTBlMWZmNy4uYzdmZDA1OGVmOTYwNjRjMzc1MTgwNTM0MWRmZWIw OGY2NWMxOWUxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE4LTA1LTIyICBPbGl2 aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgRml4IGJ1 aWxkIHdpdGhvdXQgTWF0aE1MCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODU4NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZWdyZXNzaW9uKHIyMjY2NTQpOiBbUmVuZGVyVHJlZUJ1aWxkZXJdIE1vdmUg TWF0aE1MIGFkZENoaWxkIGxvZ2ljIHRvIFJlbmRlclRyZWVCdWlsZGVyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODE0NDMKKworICAgICAgICBSZWdy ZXNzaW9uKHIyMjk2OTQpOiBQdXQgdGhlIERPTSBpbiBJc29IZWFwcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNTQ2CisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCBidWlsZCBmaXguCisKKyAgICAgICAgKiBtYXRobWwvTWF0aE1MVW5rbm93bkVsZW1l bnQuY3BwOgorICAgICAgICAqIG1hdGhtbC9NYXRoTUxVbmtub3duRWxlbWVudC5oOgorICAgICAg ICAqIHJlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJUcmVlQnVpbGRlcjo6UmVuZGVyVHJlZUJ1aWxkZXIpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyVHJlZUJ1aWxkZXI6OmF0dGFjaCk6CisgICAgICAgICogcmVuZGVyaW5n L3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmg6CisgICAgICAgICogcmVuZGVyaW5nL3VwZGF0 aW5nL1JlbmRlclRyZWVCdWlsZGVyTWF0aE1MLmNwcDoKKyAgICAgICAgKiByZW5kZXJpbmcvdXBk YXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXJNYXRoTUwuaDoKKwogMjAxOC0wNS0yMSAgWXVzdWtlIFN1 enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBVc2UgbW9yZSBDKysxNwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbWF0aG1sL01hdGhNTFVua25vd25FbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxVbmtub3duRWxlbWVudC5jcHAKaW5kZXgg YmRmYjUxYjBlNTVhZjRmNTEwNGIyYzIxMWQxZWM1Zjc0NTU5MzQ5NC4uNDc5OWZiZWI5NDU4NDRh OTZjYWE5ODhhODA5NTZmMmE4NzAxN2Y1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbWF0 aG1sL01hdGhNTFVua25vd25FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9tYXRobWwv TWF0aE1MVW5rbm93bkVsZW1lbnQuY3BwCkBAIC0yNiw2ICsyNiw4IEBACiAjaW5jbHVkZSAiY29u ZmlnLmgiCiAjaW5jbHVkZSAiTWF0aE1MVW5rbm93bkVsZW1lbnQuaCIKIAorI2lmIEVOQUJMRShN QVRITUwpCisKICNpbmNsdWRlIDx3dGYvSXNvTWFsbG9jSW5saW5lcy5oPgogCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CkBAIC0zNCwzICszNiw0IEBAIFdURl9NQUtFX0lTT19BTExPQ0FURURfSU1QTChN YXRoTUxVbmtub3duRWxlbWVudCk7CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAorI2VuZGlm IC8vIEVOQUJMRShNQVRITUwpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0 aE1MVW5rbm93bkVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxVbmtub3du RWxlbWVudC5oCmluZGV4IDZmNjg3MzUzMzgzN2FhMWEwZTM4OTYyNjBmOTNkMGZjMzRhZWNhZTMu LmNmZDNlYTdhNmVkODc4OGY2OWVkZDg3NGM5YjI4ZWZiYzk5ZmY0YmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxVbmtub3duRWxlbWVudC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL21hdGhtbC9NYXRoTUxVbmtub3duRWxlbWVudC5oCkBAIC0yNSw2ICsyNSw4IEBACiAK ICNwcmFnbWEgb25jZQogCisjaWYgRU5BQkxFKE1BVEhNTCkKKwogI2luY2x1ZGUgIk1hdGhNTEVs ZW1lbnQuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNDcsMyArNDksNSBAQCBwcml2YXRl OgogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQorCisjZW5kaWYgLy8gRU5BQkxFKE1BVEhN TCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJU cmVlQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVy VHJlZUJ1aWxkZXIuY3BwCmluZGV4IDk5NDdkMDk4NzlkYmJmZGE2ZjE4YTkyZDY2ODdiNGUyZmI3 OGU4ZmYuLmExZjM2NGQyM2IxOGRmMThjNTA3NWZlMmM4OTZjMzViMmM5MWFlODYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWls ZGVyLmNwcApAQCAtMTMxLDcgKzEzMSw5IEBAIFJlbmRlclRyZWVCdWlsZGVyOjpSZW5kZXJUcmVl QnVpbGRlcihSZW5kZXJWaWV3JiB2aWV3KQogICAgICwgbV9ibG9ja0Zsb3dCdWlsZGVyKHN0ZDo6 bWFrZV91bmlxdWU8QmxvY2tGbG93PigqdGhpcykpCiAgICAgLCBtX2lubGluZUJ1aWxkZXIoc3Rk OjptYWtlX3VuaXF1ZTxJbmxpbmU+KCp0aGlzKSkKICAgICAsIG1fc3ZnQnVpbGRlcihzdGQ6Om1h a2VfdW5pcXVlPFNWRz4oKnRoaXMpKQorI2lmIEVOQUJMRShNQVRITUwpCiAgICAgLCBtX21hdGhN TEJ1aWxkZXIoc3RkOjptYWtlX3VuaXF1ZTxNYXRoTUw+KCp0aGlzKSkKKyNlbmRpZgogICAgICwg bV9jb250aW51YXRpb25CdWlsZGVyKHN0ZDo6bWFrZV91bmlxdWU8Q29udGludWF0aW9uPigqdGhp cykpCiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQogICAgICwgbV9mdWxsU2NyZWVuQnVpbGRl cihzdGQ6Om1ha2VfdW5pcXVlPEZ1bGxTY3JlZW4+KCp0aGlzKSkKQEAgLTI3MCwxMCArMjcyLDEy IEBAIHZvaWQgUmVuZGVyVHJlZUJ1aWxkZXI6OmF0dGFjaChSZW5kZXJFbGVtZW50JiBwYXJlbnQs IFJlbmRlclB0cjxSZW5kZXJPYmplY3Q+IGNoCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKKyNp ZiBFTkFCTEUoTUFUSE1MKQogICAgIGlmIChpczxSZW5kZXJNYXRoTUxGZW5jZWQ+KHBhcmVudCkp IHsKICAgICAgICAgbWF0aE1MQnVpbGRlcigpLmF0dGFjaChkb3duY2FzdDxSZW5kZXJNYXRoTUxG ZW5jZWQ+KHBhcmVudCksIFdURk1vdmUoY2hpbGQpLCBiZWZvcmVDaGlsZCk7CiAgICAgICAgIHJl dHVybjsKICAgICB9CisjZW5kaWYKIAogICAgIGlmIChpczxSZW5kZXJHcmlkPihwYXJlbnQpKSB7 CiAgICAgICAgIGF0dGFjaFRvUmVuZGVyR3JpZChkb3duY2FzdDxSZW5kZXJHcmlkPihwYXJlbnQp LCBXVEZNb3ZlKGNoaWxkKSwgYmVmb3JlQ2hpbGQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmggYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuaAppbmRleCA1NTlkYTk0MGIz NmU2NGRkM2E4YmM5YTVhY2FmZGVjZTJmZmQ4ZjI4Li43ZTkzNjkyMDAwODlmNzkxY2E1ZWU2OWM1 MDczNDlhNDZhNjFmMDE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBk YXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv dXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuaApAQCAtOTQsNyArOTQsOSBAQCBwcml2YXRlOgog ICAgIGNsYXNzIEJsb2NrRmxvdzsKICAgICBjbGFzcyBJbmxpbmU7CiAgICAgY2xhc3MgU1ZHOwor I2lmIEVOQUJMRShNQVRITUwpCiAgICAgY2xhc3MgTWF0aE1MOworI2VuZGlmCiAgICAgY2xhc3Mg Q29udGludWF0aW9uOwogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICBjbGFzcyBGdWxs U2NyZWVuOwpAQCAtMTEwLDcgKzExMiw5IEBAIHByaXZhdGU6CiAgICAgQmxvY2tGbG93JiBibG9j a0Zsb3dCdWlsZGVyKCkgeyByZXR1cm4gKm1fYmxvY2tGbG93QnVpbGRlcjsgfQogICAgIElubGlu ZSYgaW5saW5lQnVpbGRlcigpIHsgcmV0dXJuICptX2lubGluZUJ1aWxkZXI7IH0KICAgICBTVkcm IHN2Z0J1aWxkZXIoKSB7IHJldHVybiAqbV9zdmdCdWlsZGVyOyB9CisjaWYgRU5BQkxFKE1BVEhN TCkKICAgICBNYXRoTUwmIG1hdGhNTEJ1aWxkZXIoKSB7IHJldHVybiAqbV9tYXRoTUxCdWlsZGVy OyB9CisjZW5kaWYKICAgICBDb250aW51YXRpb24mIGNvbnRpbnVhdGlvbkJ1aWxkZXIoKSB7IHJl dHVybiAqbV9jb250aW51YXRpb25CdWlsZGVyOyB9CiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJ KQogICAgIEZ1bGxTY3JlZW4mIGZ1bGxTY3JlZW5CdWlsZGVyKCkgeyByZXR1cm4gKm1fZnVsbFNj cmVlbkJ1aWxkZXI7IH0KQEAgLTEzMCw3ICsxMzQsOSBAQCBwcml2YXRlOgogICAgIHN0ZDo6dW5p cXVlX3B0cjxCbG9ja0Zsb3c+IG1fYmxvY2tGbG93QnVpbGRlcjsKICAgICBzdGQ6OnVuaXF1ZV9w dHI8SW5saW5lPiBtX2lubGluZUJ1aWxkZXI7CiAgICAgc3RkOjp1bmlxdWVfcHRyPFNWRz4gbV9z dmdCdWlsZGVyOworI2lmIEVOQUJMRShNQVRITUwpCiAgICAgc3RkOjp1bmlxdWVfcHRyPE1hdGhN TD4gbV9tYXRoTUxCdWlsZGVyOworI2VuZGlmCiAgICAgc3RkOjp1bmlxdWVfcHRyPENvbnRpbnVh dGlvbj4gbV9jb250aW51YXRpb25CdWlsZGVyOwogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkK ICAgICBzdGQ6OnVuaXF1ZV9wdHI8RnVsbFNjcmVlbj4gbV9mdWxsU2NyZWVuQnVpbGRlcjsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVp bGRlck1hdGhNTC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVy VHJlZUJ1aWxkZXJNYXRoTUwuY3BwCmluZGV4IDVjYjQ3OGIzMTdhOTg2OTk2OGQ5NTVkZjNhYWYx NDBjZjM5OWJmZjcuLmE3YjYwNjBjYmUwNDhkYTViOWJjZjk3M2Q4YzcxMDk0ZTJiY2M5MDIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVp bGRlck1hdGhNTC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1Jl bmRlclRyZWVCdWlsZGVyTWF0aE1MLmNwcApAQCAtMjYsNiArMjYsOCBAQAogI2luY2x1ZGUgImNv bmZpZy5oIgogI2luY2x1ZGUgIlJlbmRlclRyZWVCdWlsZGVyTWF0aE1MLmgiCiAKKyNpZiBFTkFC TEUoTUFUSE1MKQorCiAjaW5jbHVkZSAiUmVuZGVyTWF0aE1MRmVuY2VkLmgiCiAjaW5jbHVkZSAi UmVuZGVyTWF0aE1MRmVuY2VkT3BlcmF0b3IuaCIKICNpbmNsdWRlICJSZW5kZXJUcmVlQnVpbGRl ckJsb2NrLmgiCkBAIC0xMDgsMyArMTEwLDUgQEAgdm9pZCBSZW5kZXJUcmVlQnVpbGRlcjo6TWF0 aE1MOjphdHRhY2goUmVuZGVyTWF0aE1MRmVuY2VkJiBwYXJlbnQsIFJlbmRlclB0cjxSZW4KIH0K IAogfQorCisjZW5kaWYgLy8gRU5BQkxFKE1BVEhNTCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlck1hdGhNTC5oIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyTWF0aE1MLmgKaW5k ZXggMWNjZDdjZWMzOWNlMzUzZmRkMzU5OTIzM2IzZmI1NzdkMmZhNmRhYi4uMDU2NWI1MTg0ODM3 MjJiNjczMTIwYTRhZTk0NWQ2NzMwNmJkY2E4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyTWF0aE1MLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyTWF0aE1MLmgKQEAg LTI1LDYgKzI1LDggQEAKIAogI3ByYWdtYSBvbmNlCiAKKyNpZiBFTkFCTEUoTUFUSE1MKQorCiAj aW5jbHVkZSAiTWF0aE1MT3BlcmF0b3JEaWN0aW9uYXJ5LmgiCiAjaW5jbHVkZSAiUmVuZGVyVHJl ZUJ1aWxkZXIuaCIKIApAQCAtNDgsMyArNTAsNSBAQCBwcml2YXRlOgogfTsKIAogfQorCisjZW5k aWYgLy8gRU5BQkxFKE1BVEhNTCkK